Commit graph

42900 commits

Author SHA1 Message Date
Jannat Patel
49a9f53d24
feat: text editor and mentions for discussions (#21886) 2023-08-07 20:23:53 +05:30
Ankush Menat
f6326b6145
fix: check before deleting prepared report (#21950) 2023-08-07 14:00:34 +05:30
Sagar Vora
b385fae2dc test: use unique IP to prevent future conflict with other tests 2023-08-07 13:49:52 +05:30
Sagar Vora
e877d926eb
test: set request_ip when testing reset_password (#21937)
* test: set `request_ip` when testing `reset_password`

* test: increase rate limit temporarily while testing `reset_password`
2023-08-07 11:37:23 +05:30
RitvikSardana
3f971f37c1
feat: Added Re-run in Console Button in Console Log Doctype (#21825)
* feat: Added Reload in Console Button in Console Log Doctype

* refactor: simpler doc mapping

* fix: added type of script

* fix: renamed button name

* fix: new solution for Re-run in console

* refactor: use set_route

[skip ci]

---------

Co-authored-by: Ritvik Sardana <ritviksardana@Ritviks-MacBook-Air.local>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-08-07 11:33:41 +05:30
Ankush Menat
dbc61cc137 fix: workflow help
closes https://github.com/frappe/frappe/issues/21923
2023-08-07 10:22:59 +05:30
Ankush Menat
a2b2998684
fix(DX): Wrap print format errors (#21944)
[skip ci]
2023-08-06 18:55:16 +05:30
Raffael Meyer
5fce1a57c0
fix: validate fieldname in get_group_by_count (#21932)
* fix: validate fieldname in get_group_by_count

* test: call get_group_by_count with invalid field

* test: is_default_field
2023-08-06 17:33:34 +05:30
Raffael Meyer
4fae798ad1
fix: check file permission before zipping (#21934) 2023-08-06 17:21:22 +05:30
Sagar Vora
e588f2d70b
Merge pull request #21928 from resilient-tech/fix-rate-limiter 2023-08-05 17:38:08 +00:00
Sagar Vora
2b96324c31
fix: rate limit for all HTTP methods (#21929) 2023-08-05 22:32:55 +05:30
Michelle Alva
fd2efdb0e1
chore: whitelisted typo (#21930) 2023-08-05 20:15:55 +05:30
Sagar Vora
7aed89ae4d test: set request before verifying 2023-08-05 14:43:45 +05:30
Sagar Vora
773cefea69 test: specify args or kwargs instead of frappe.form_dict 2023-08-05 14:14:03 +05:30
Sagar Vora
3f3821befb fix: dont use form_dict & frappe.call 2023-08-05 13:02:50 +05:30
Sagar Vora
4931c7379c fix: only rate limit if frappe.request is set 2023-08-05 12:54:34 +05:30
Sagar Vora
0cced74766 fix: add rate limiting and type hints for add_feedback 2023-08-05 12:46:31 +05:30
Sagar Vora
1f5480bf0f chore: move permission check earlier 2023-08-05 12:37:34 +05:30
Ankush Menat
cc85d39b50 fix: only allow system manager to start backups 2023-08-05 11:22:49 +05:30
Ankush Menat
201be85d88 chore: remove dead code
https://sourcegraph.com/search?q=context:global+get_badge_info+repo:%5Egithub%5C.com/frappe/.*&patternType=standard&sm=0&groupBy=repo
2023-08-05 11:20:27 +05:30
Ankush Menat
2ed85ca9f2 refactor: check license names before sending text
File might not exist.
2023-08-05 11:15:58 +05:30
Raffael Meyer
011d21b4a3
refactor: docshare get_users (#21924) 2023-08-05 09:41:22 +05:30
Ankush Menat
8817c228a2 fix: filter schema name on mariadb 2023-08-04 14:33:17 +05:30
Ankush Menat
fd15ab5329 fix: revert pg incompatible change 2023-08-04 14:13:36 +05:30
Ankush Menat
c4230f8760
fix: autoincr status per doctype (#21918)
* fix: autoincr status per doctype

closes https://github.com/frappe/frappe/issues/21386

* chore: Check autoincremented on the database currently being used.

* refactor: Styling and space fix

---------

Co-authored-by: Athul Cyriac Ajay <athul8720@gmail.com>
2023-08-04 13:59:39 +05:30
Raffael Meyer
dc0a8c5ccb
fix: keep privacy setting of attachments on amend (#21911) 2023-08-03 15:33:39 +05:30
Raffael Meyer
fa73d5ea03
perf(dx): let developers know that they need to enable index on links (#21745)
* perf: enable indexing for dashboard links

* style: format with black

* fix: nudge index, don't enable

Many edge cases which can't be checked on-the-fly. Best to just notify
developer that they should enable indexing.

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-08-03 11:39:59 +05:30
Ankush Menat
d1c3877044
fix: debounce form refresh from realtime events (#21905)
refer https://github.com/frappe/hrms/issues/755
2023-08-02 21:02:25 +05:30
Raffael Meyer
0b509b8e57
fix: add invalid filters for fieldtype "Float" (#21904) 2023-08-02 19:56:03 +05:30
Suraj Shetty
975c4845cd
Merge pull request #21892 from barredterra/center-upload-notes 2023-08-02 14:35:50 +05:30
Suraj Shetty
0b5a24b2ec
Merge pull request #21899 from surajshetty3416/fix-image-compression 2023-08-02 11:20:29 +05:30
Suraj Shetty
67a32bd054 fix: Set minimum resolution of image 2023-08-02 10:54:36 +05:30
Suraj Shetty
672835d7a9 fix: Show "View File" in the sidebar of file doc 2023-08-02 10:20:25 +05:30
Suraj Shetty
a7be8ccff2 Merge remote-tracking branch 'upstream' into fix-image-compression 2023-08-02 10:13:52 +05:30
Suraj Shetty
5ebe28b454 feat: Add formatter for "File Size" 2023-08-02 10:13:27 +05:30
Suraj Shetty
3621daf699 fix: Compress bit more agressively 2023-08-02 09:25:48 +05:30
Ankush Menat
8bf8950c2b
fix: include server script in recorder stack trace (#21891)
[skip ci]
2023-08-01 20:59:46 +05:30
barredterra
b3e319363c fix: center notes text in FileUploader 2023-08-01 15:32:03 +02:00
Corentin Flr
2c92043998
fix(doctype): Allow cached_property decorator in controllers (#21881) 2023-07-31 21:40:53 +05:30
Ankush Menat
ada2e20af3 fix: has_permission check on int pk 2023-07-31 16:42:31 +05:30
Ankush Menat
b41d4905c0 fix: onboarding widget contrast 2023-07-31 15:00:15 +05:30
Ankush Menat
ff6439af3d fix: underlined onboarding steps 2023-07-31 14:44:52 +05:30
David Arnold
fddd3b24f7
test: skip tests on RO app paths which require write access (#21878) 2023-07-31 12:46:23 +05:30
David Arnold
3471685eaa
feat(ops): add environment variable to set bench root / workdir (#21872) 2023-07-31 11:50:09 +05:30
Sagar Vora
97eefdaa44
perf: dont reload doc when already saving (#21869) 2023-07-31 11:48:54 +05:30
niraj gautam
d08ee0284d
fix: Delete module folder on Module Def deletion (#21857)
* fix: Delete module folder on Module Def deletion

* fix: Check if folder exists before removal

* fix: Make use of frappe function to delete folder

* fix: Indentation

* fix: Update linting
2023-07-31 11:39:04 +05:30
mergify[bot]
74899f510a
Merge pull request #21378 from dvdl16/feature/force-web-capture-setting
feat: setting for force web capture mode for camera uploads
2023-07-31 05:41:48 +00:00
Dirk van der Laarse
6645589cdf chore: linting fixes 2023-07-30 15:48:03 +00:00
Dirk van der Laarse
c66d744824 fix: field order and change label to title case 2023-07-30 15:36:55 +00:00
Ankush Menat
84188587fa fix: clean up socketio dynamic namespaces
While serving many sites it's best to close down namespace when last
connection is closed.

refer https://github.com/socketio/socket.io/pull/4602
2023-07-29 20:35:59 +05:30