Ankush Menat
4a70ac4e4e
chore: Drop some ui tests
...
- Either not important and flaky
- Or badly written using weird selectors and flaky
Not touching things that work.
2023-11-27 16:40:39 +05:30
Ankush Menat
4510471c6d
Merge pull request #23025 from bosue/awesomebar_fix_filter_on_same
...
fix!: Make router always take query parameters into account.
2023-11-27 15:44:18 +05:30
Ankush Menat
a8c943fbdd
Merge pull request #23446 from rmehta/system-settings-tabs
...
refactor: Add tabs to "System Settings"
2023-11-27 15:31:56 +05:30
Ankush Menat
db319700ad
Merge pull request #23443 from ankush/simpler_comparison
...
fix: Simpler oauth token validity checks
2023-11-27 15:30:43 +05:30
Shariq Ansari
c19f426bd5
Merge pull request #23447 from shariquerik/allow-internal-routing-using-url-option
2023-11-27 15:15:46 +05:30
Shariq Ansari
597a53e4c1
fix: allow internal routing using workspace shortcut url option
2023-11-27 14:20:27 +05:30
Rushabh Mehta
2c34c71b43
refactor: Cleanup Login Settings in System Settings
2023-11-27 14:08:45 +05:30
Rushabh Mehta
4a25451f44
refactor: Add tabs to "System Settings"
2023-11-27 13:56:54 +05:30
Ankush Menat
884e980526
fix: Simpler oauth token validity checks
...
The code is currently
1. Getting token expiry time (in system tz)
2. Adding system tz to make it tz aware
3. Converting it to UTC
4. Getting current UTC time and comparing.
We can just get current system tz time and compare directly.
2023-11-27 12:04:29 +05:30
Ankush Menat
1d5d06e924
Merge pull request #23418 from akhilnarang/return-traceback-for-setupwizard-failure
...
fix(setup_wizard): don't suppress original exception
2023-11-27 11:51:40 +05:30
Akhil Narang
d67a6d168e
fix(commands/scheduler): typo ( #23441 )
...
* fix(commands/scheduler): typo
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* chore: Update frappe/commands/scheduler.py
[skip ci]
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-27 11:30:33 +05:30
Ankush Menat
e8fe3b2166
Merge pull request #23414 from ankush/bulk_actions_bg
...
perf: run bulk actions using background jobs
2023-11-24 18:33:38 +05:30
Akhil Narang
db3ffaf658
refactor: check for last response error
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 18:25:31 +05:30
Akhil Narang
d48c3f5f60
refactor: return message in response as well
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 18:25:07 +05:30
mergify[bot]
4ead8e009a
Merge pull request #23424 from vorasmit/after_mapping
...
fix: add `after_mapping` doc method to run custom mapping functions
2023-11-24 12:50:05 +00:00
Nabin Hait
ddac8af434
fix: ignore duplicate contact creation ( #23423 )
2023-11-24 18:16:02 +05:30
Smit Vora
bf50952662
fix: after_mapping hook to run custom mapping functions
2023-11-24 17:45:38 +05:30
Akhil Narang
461f479b45
feat(setup_wizard): store error in error log as well
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 17:43:44 +05:30
Shariq Ansari
5e172eab78
Merge pull request #23378 from shadrak98/no-label-fix
...
fix: show fieldname if field label is not set
2023-11-24 17:38:20 +05:30
Akhil Narang
9aec553b89
fix(setup_wizard): sync password character limit with other places ( #23419 )
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 17:26:34 +05:30
Akhil Narang
838a49ebc2
fix(setup_wizard): don't suppress original exception
...
Raise it so that the user can know what went wrong
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 17:13:34 +05:30
Ankush Menat
6cf168a56f
fix: bulk workflow action in background
2023-11-24 17:04:09 +05:30
Suraj Shetty
a260bd28ce
Merge pull request #23415 from surajshetty3416/fix-font-path
2023-11-24 16:46:25 +05:30
Suraj Shetty
851294a329
fix: Inter css build
2023-11-24 16:44:13 +05:30
Ankush Menat
866a0295e3
fix: bulk submit/cancel/update in background jobs
2023-11-24 16:38:04 +05:30
Ankush Menat
077218156b
fix: always publish progress for bulk action
2023-11-24 16:38:04 +05:30
Suraj Shetty
8ca616e7c0
Merge pull request #23412 from surajshetty3416/font-cleanup
2023-11-24 16:26:37 +05:30
Suraj Shetty
37411f53e3
chore: Remove unused font and redundant code
2023-11-24 16:24:16 +05:30
Ankush Menat
a8a8f8d438
feat: msgprint using socketio ( #23408 )
2023-11-24 10:54:07 +00:00
Rushabh Mehta
8a38976442
Merge pull request #23405 from rmehta/inter-fix
...
fix: Inter V loading issues + Update to Version 4
2023-11-24 15:17:48 +05:30
Ankush Menat
3c83b102ef
fix: tz aware vs naive comparison
2023-11-24 15:03:08 +05:30
Rushabh Mehta
f9f36b6f72
fix: Inter V loading issues
2023-11-24 15:01:45 +05:30
Shariq Ansari
655e646d8b
Merge pull request #23401 from shariquerik/banner-image-name-overlapping
...
fix: webform banner_image name replacing navbar banner_image
2023-11-24 12:43:42 +05:30
Shariq Ansari
01fb455a76
fix: webform banner_image name replacing navbar banner_image
2023-11-24 11:29:29 +05:30
Ankush Menat
62529f3d74
chore(telemetry): track logged errors ( #23390 )
...
Also includes unhandled errors
2023-11-24 04:55:12 +00:00
Ankush Menat
770598df49
Revert "refactor: remove code that manually prevents bulk refresh ( #23138 )"
...
This reverts commit 60d99eb20c
2023-11-24 10:18:29 +05:30
Raffael Meyer
1f6cd8080e
Merge pull request #23392 from barredterra/default-email-group
2023-11-24 01:08:42 +01:00
Raffael Meyer
cc1673a40e
Merge pull request #23394 from barredterra/german-timespan
2023-11-24 01:00:28 +01:00
barredterra
a99bf56160
fix: german translations for timespan
2023-11-24 00:59:22 +01:00
barredterra
06fbe6df20
fix: default Email Group in system language
2023-11-23 16:51:23 +01:00
mergify[bot]
514ea6e259
Merge pull request #23309 from akhilnarang/drop-redundant-bool
...
refactor(treewide): code cleanup
2023-11-23 11:20:55 +00:00
Akhil Narang
d21c7730da
fix(commands/site): the old logic did rely on 0 evaluting to false
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 16:34:28 +05:30
Akhil Narang
23bcb6733e
refactor(website_generator): update variable name to make more sense as per usage
...
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-23 16:06:07 +05:30
Akhil Narang
cc58fd20ca
refactor(oauth): simplify scopes check with the usage of all()
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 16:04:56 +05:30
Akhil Narang
f8c5a61bbd
refactor(report): simplify check further
...
NoneType will evaluate to False here so we don't need this complexity
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-23 15:54:13 +05:30
Akhil Narang
f007f16ce9
fix: handle invalid passwords better ( #23377 )
...
* chore(login): show a message for response code 500 as well
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* refactor: reject passwords > 512 characters
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 15:35:37 +05:30
mergify[bot]
a775d5adb0
Merge pull request #23380 from ruthra-kumar/ignore_dynamic_links_on_virtual_doctypes
...
fix: ignore dynamic links in virtual doctypes
2023-11-23 09:37:28 +00:00
ruthra kumar
1e0920409f
fix: ignore dynamic fields in virtual doctypes
2023-11-23 14:49:28 +05:30
Shadrak Gurupnor
43ffd17559
chore: translation
2023-11-23 14:26:29 +05:30
Akhil Narang
fbc88a4d24
refactor(treewide): code cleanup
...
Drop redundant bool conversion
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 13:57:51 +05:30
