Ankush Menat
f526054ae2
refactor: Remove usage of utcnow ( #23369 )
2023-11-23 13:21:27 +05:30
Ankush Menat
31e3b3f981
fix: social key signup without signup conf ( #23359 )
2023-11-22 11:32:45 +00:00
David Arnold
ec4bc971c5
fix(integration): preserver data json formatting on update
2023-11-07 16:43:13 +01:00
Hussain Nagaria
a46308709b
fix: add params in make_request arguments
2023-11-01 17:30:58 +05:30
Ankush Menat
563639235e
Merge pull request #22300 from ankush/api_v2
...
feat!: API versioning and API v2 (beta)
2023-10-17 11:34:26 +05:30
Corentin Flr
2b542d87e1
fix: Fix scopes for Google Calendar ( #22614 )
...
https://developers.google.com/identity/protocols/oauth2/scopes
2023-10-17 08:07:38 +05:30
Ankush Menat
e96ecab00e
refactor: OAuth flow without breaking routing convention
...
Appending `/connected-app` after method breaks routing.
2023-10-16 18:12:53 +05:30
Ankush Menat
275f16060a
fix: route ambiguitities and / in name
...
v1 and v2:
- Use path convertor to consume entire document which MIGHT contain `/`
- Drop string convertor, as it's the default
- Dont merge slashes - avoid consuming something that's part of name
v2:
- `SI/BLAH/BLAH/submit` is not simple to parse without ambiguitity
- `SI/BLAH/BLAH/method/submit` removes ambiguitity for 99.99% cases.
2023-10-16 18:12:53 +05:30
Sagar Vora
258c175982
perf: defer db query when saving Event
2023-10-16 12:59:30 +05:30
Anand Chitipothu
aff3f66366
fix: work-around to fix issue with syncing Google Contacts ( #22649 )
...
Issue #22648
2023-10-16 12:29:49 +05:30
Ankush Menat
e1f2f4bb54
fix: Let social login key control signups
...
There are cases where certain social login keys
- Should not allow signups at all and only allow logins. E.g. social media login keys.
- Should allow signups even if global sign ups are disabled. e.g. internal SSO like setups.
2023-10-14 12:43:48 +05:30
Sagar Vora
6043909fe6
fix: allow larger URLs in Integration Request
2023-10-09 19:13:10 +05:30
David Arnold
086435c004
feat: add upstream json argument to integrations make_request ( #22462 )
...
* feat: add upstream json argument to integrations make_request
* style: format
[skip ci]
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-20 13:15:22 +05:30
Corentin Flr
8882679357
fix: Ensure Google Calendar scopes is a List ( #22333 )
2023-09-11 18:04:22 +05:30
Ankush Menat
2f4c5c63aa
test: fix ldap test
2023-08-29 12:07:58 +05:30
Ankush Menat
dc8d7b019a
refactor!: Lower roles from All To Desk User
2023-08-29 12:07:57 +05:30
barredterra
88c8baa9ee
refactor: for append to extend, merge list extend
...
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00
barredterra
b553ed98d8
refactor: inline immediately returned variable
...
Inline a variable to a return in the case when the
variable being declared is immediately returned
2023-08-08 18:09:49 +02:00
Shariq Ansari
9902f36812
fix: show full name instead of first/last name
2023-07-27 13:22:38 +05:30
Ankush Menat
927cd647e4
chore: generate type annotations
2023-07-24 15:32:48 +05:30
David Arnold
a926e64ec9
fix: procure db config from single authority ( #21578 )
...
* fix: procure db config from single authority
ensures that configuration is uniformely procured from local.conf
instead of making use of hard to audit multilevel fallback logic
Implementation Note:
- `get_db(host, port, user, password)` was stripped of any optional
argument and therefrom all errors where fixed.
- All occurances of `grep 'frappe.db.db_'` where changed to
`frappe.conf.db_`
* fix: revert unnecessary breaking changes
2023-07-24 10:48:29 +05:30
Shariq Ansari
a34d87d440
Merge pull request #21706 from shariquerik/oauth-confirm-screen
2023-07-20 12:22:07 +05:30
Shariq Ansari
264372a2a3
fix: show list of user details that we are giving access to if scope is openid
2023-07-18 20:53:31 +05:30
Shariq Ansari
cbe9ec26bd
fix: do not show Home primary button
2023-07-17 15:48:30 +05:30
Sagar Vora
4684e72142
fix: use current redirect URIs instead of legacy ones
2023-07-17 14:29:22 +05:30
Ankush Menat
f6751bf415
refactor: use event.status instead of event.event_type
...
Required after https://github.com/frappe/frappe/pull/21471
2023-07-11 19:02:43 +05:30
Shariq Ansari
654e209511
Merge branch 'develop' into log-webhook-error
2023-06-23 16:32:37 +05:30
Shariq Ansari
fe27b8c7e0
fix: removed redundant condition
...
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-06-23 16:31:55 +05:30
Shariq Ansari
3f792a80b1
fix: return if exception occur before executing webhook
2023-06-23 16:29:39 +05:30
Ankush Menat
cbe8a41cff
build: Add responses as developer dependency ( #21440 )
...
Useful for mocking HTTP responses in tests
2023-06-20 19:50:51 +05:30
Shariq Ansari
74cc21013f
fix: validate webhook secret
2023-06-19 13:46:27 +05:30
Shariq Ansari
85ac64ddd9
fix: log errors while getting headers and data
2023-06-19 13:18:25 +05:30
Devin Slauenwhite
62a3a70bf8
feat: webhook timeout ( #21410 )
...
* feat: webhook timeout
* fix: ensure default timeout 5 seconds
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-06-18 20:53:03 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache ( #21282 )
2023-06-08 11:47:17 +05:30
Ankush Menat
e30b823eeb
fix!: Webhook naming should be prompt
2023-06-04 10:46:38 +05:30
Suraj Shetty
e1c23ef4f3
Merge pull request #21064 from frappe/feat-dynamic-webhook-url
2023-06-02 13:02:12 +05:30
Nabin Hait
af7502bba7
refactor: Workspace cleanup ( #21100 )
...
* refactor: Workspace cleanup
* fix: Resolved conflict
2023-05-26 14:42:31 +05:30
Hussain Nagaria
9fa2655bd9
fix: bring back modified field in json file
2023-05-22 23:11:21 +05:30
Mohammad Hussain Nagaria
a45eb9c8b7
Merge branch 'develop' into feat-dynamic-webhook-url
2023-05-22 23:08:10 +05:30
Hussain Nagaria
3f08e80d88
style: lint test file
2023-05-21 16:44:34 +05:30
Hussain Nagaria
8f8c6b51e8
test: tests for dynamic URL
2023-05-21 16:36:08 +05:30
Hussain Nagaria
77e73ccea4
feat: support for dynamic URL in webhook
...
Closes #11921
2023-05-21 16:35:57 +05:30
Hussain Nagaria
c1d90b1d6a
fix(ui): rearrange fields in webhook request log doctype
2023-05-21 15:50:52 +05:30
Hussain Nagaria
d31d07ed23
fix(ux): set language to enable syntax highlighting JSON
2023-05-21 15:44:33 +05:30
Hussain Nagaria
cb1dce5ef5
fix(ux): add description for jinja support
2023-05-21 15:44:03 +05:30
Hussain Nagaria
cf49369d14
feat(minor): add request log to connections
2023-05-21 15:31:37 +05:30
Raffael Meyer
caeaa3bdf0
Merge branch 'develop' into gc-perms
2023-04-14 17:27:11 +02:00
Ankush Menat
3e95c00fd0
fix: dont track webhook request log ( #20663 )
...
logs dont change
[skip ci]
2023-04-12 11:51:24 +05:30
Raffael Meyer
ea6c1f763e
Merge branch 'develop' into gc-perms
2023-04-11 11:31:20 +02:00
Mohammad Hussain Nagaria
a48b0f3cf8
fix: minor oauth doctypes enhancements ( #20613 )
...
* fix: remove extra`/` from description
* fix(ux): show bearer token status in list view
2023-04-07 14:33:41 +05:30