Ankush Menat
4e318a0280
fix: Abort flushing email queue if >50% fail.
...
When email queue batch failes >33% with >10 count, frappe will now abort
sending emails.
We already notify users via system notification so this
assumes that user will notice it and fix it in sometime.
With previous commits we also prioritize fresh emails over retries.
2023-11-04 11:25:09 +05:30
Ankush Menat
050c0b26f8
fix: flush emails from single background jobs
2023-11-04 11:23:44 +05:30
Raffael Meyer
5c1d84101e
Merge pull request #23092 from barredterra/page_on_trash
2023-11-03 22:25:13 +01:00
barredterra
dd5bb0ff46
fix: allow page deletion during migrate
2023-11-03 22:03:27 +01:00
Ankush Menat
be2beeed9e
fix: improve email queue reliability ( #23070 )
...
* feat: control email queue batch size with config
* fix: Give emails who failed once less priority while sending
2023-11-03 15:10:37 +05:30
Suraj Shetty
ff14c52059
fix: Make editor editable in grid ( #23085 )
2023-11-03 14:30:28 +05:30
Ankush Menat
2ab8c2a053
refactor: misc changes ( #23082 )
...
- Fail early for developer mode
- Convert delete content function to method
- do io after db transaction commits
- write a test
2023-11-03 07:27:34 +00:00
Vishnu VS
ae7a893100
feat: granted delete permission and added folder deletion function for pages ( #23077 )
...
* fix: grant delete permission to administrator
* feat: added function to delete folder associated with the page
2023-11-03 12:34:07 +05:30
mergify[bot]
6ad2e762d3
Merge pull request #23064 from frappe/bulk-insert-search-sync
...
perf(GlobalSearch): bulk insert queued items
2023-11-03 05:10:31 +00:00
Ankush Menat
8c74d542d5
perf: don't check len before popping
...
rpop is atomic and yields None when nothing is found. No need to check length.
2023-11-03 10:20:31 +05:30
Ankush Menat
eba499a9ba
refactor: misc changes
...
- make internal function explicit
- dont delete keys which is immediately being replaced.
- deprecate `sync_value`
2023-11-03 10:15:52 +05:30
Raffael Meyer
f0155674a5
refactor!: remove redundant sending of translations ( #22962 )
...
* chore!: remove redundant translation
* refactor!: remove "get_translated_dict" hook
Instead, include the results from
`frappe.geo.country_info.get_translated_dict` in `get_all_translations`.
* test: money_in_words uses translated currency
... and now we have translations.
* Revert "test: money_in_words uses translated currency"
This reverts commit e07d594ac1ce4b120c0fceb5d23377cb981fe820.
* refactor!: stop translating timezone and currency
* refactor: rename `get_translated_dict`
... to `get_translated_countries`
2023-11-02 20:04:14 +05:30
Bernd Oliver Sünderhauf
888fc5fc55
build(deps): Update PyPDF to v3.17.0 ( #23060 )
2023-11-02 19:46:28 +05:30
18alantom
3d7ba41583
fix(sync_values): use EXCLUDED for postgres
...
removing the second arg from `do_update` causes
EXCLUDE to be auto added
2023-11-02 18:57:51 +05:30
18alantom
aa690553cf
refactor: undo use of count in redis pop
...
count param in rpop and lpop was introduced in 6.20
at the time of this commit we are using an older
version that does not include it
2023-11-02 18:22:50 +05:30
Shariq Ansari
c648d3424b
Merge pull request #23072 from bosue/form_builder_switch_icons
...
fix(UX): Switch 'Duplicate' and 'Move' buttons on Form Builder.
2023-11-02 18:20:05 +05:30
Shariq Ansari
309085f02b
Merge pull request #23066 from shariquerik/form-builder-add-field-btn
2023-11-02 17:57:52 +05:30
Bernd Oliver Sünderhauf
ba1544c49d
fix(UX): Switch 'Duplicate' and 'Move' buttons on Form Builder.
2023-11-02 13:26:17 +01:00
Shariq Ansari
ff5b1907a4
test: fixed failing form builder UI test
2023-11-02 17:28:21 +05:30
Ankush Menat
60e6fb005e
fix: Show excat OSError when creating SMTP session ( #23067 )
2023-11-02 17:23:19 +05:30
18alantom
ee3776f38f
refactor: move inner for to function
2023-11-02 17:02:49 +05:30
18alantom
64adf49706
refactor: use rpop count to pop in batches
...
- fix: dedupe items in a batch
- fix: reassign `query` cause it does not hold state
_fkn ORMs man 🙄 _
2023-11-02 16:58:10 +05:30
18alantom
b56136ba66
refactor: add count to cache pop
2023-11-02 15:52:29 +05:30
Shariq Ansari
198ac226c5
fix: add dedeicated add field button at each column
2023-11-02 15:35:29 +05:30
18alantom
2742746ced
perf(GlobalSearch): bulk insert queued items
...
Fixes #14660
2023-11-02 13:30:56 +05:30
Shariq Ansari
bb48cbcf39
Merge pull request #23062 from shariquerik/form-builder-keep-focus-on-autocomplete
2023-11-02 13:04:02 +05:30
Shariq Ansari
cc87e5dd91
fix: do not loose focus if automcomplete is clicked
2023-11-02 12:59:42 +05:30
Ankush Menat
66b825c134
chore: deprecate runserverobj
2023-11-01 21:42:05 +05:30
Ankush Menat
b070f610c2
Merge pull request #23051 from frappe/allow-params
...
fix: allow params in make_request util function
2023-11-01 20:08:05 +05:30
Shariq Ansari
45236a98d7
Merge pull request #22968 from shariquerik/form-builder-ui-refactor
2023-11-01 19:14:56 +05:30
Shariq Ansari
aa0e72deca
fix: was not able to remove unselected tab
2023-11-01 18:40:19 +05:30
Shariq Ansari
a32f34a5d7
test: fixed failing form builder UI test
2023-11-01 18:09:13 +05:30
Ankush Menat
a477109d4b
Merge pull request #23049 from ankush/api_login_auth
...
fix!: Don't silently fail API auth
2023-11-01 18:07:25 +05:30
Ankush Menat
c4815ff987
fix!: Don't silently fail API auth
2023-11-01 17:51:23 +05:30
Ankush Menat
1b58c6274a
Merge pull request #23050 from ankush/dnt
...
fix: Respect "Do Not Track" settings
2023-11-01 17:47:41 +05:30
Hussain Nagaria
a46308709b
fix: add params in make_request arguments
2023-11-01 17:30:58 +05:30
Shariq Ansari
0bfe196d0c
chore: keep fields table in settings tab at last
...
if you need to add multiple fields by copy paste from excel
2023-11-01 16:49:08 +05:30
Ankush Menat
86e4a3a6e1
fix: Respect "Do Not Track" settings
...
Don't offer telemetry as option if DNT is set in browser.
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/doNotTrack
2023-11-01 15:07:27 +05:30
Shariq Ansari
0cf6eacc1c
fix: added delay in draggable for touch devices scrolling will not be affected
2023-11-01 14:20:26 +05:30
Suraj Shetty
b56cbdfff8
perf: Enqueue "removing of index" on web page deletion ( #23044 )
2023-11-01 09:40:51 +05:30
Shariq Ansari
2522d6bfab
fix: added is_tree & virtual doctype checkbox in new doctype dialog
2023-11-01 00:33:04 +05:30
Shariq Ansari
211740315b
fix: do not delete tab/section/colum/field if pressing delete to edit properties or label
2023-11-01 00:13:34 +05:30
Ankush Menat
2375f2ee05
Merge pull request #23031 from ankush/perm_search
...
fix: enforce perms on global search
2023-10-31 21:57:38 +05:30
Ankush Menat
db01c05eb8
fix: enforce perms on global search
2023-10-31 21:37:30 +05:30
Shariq Ansari
afdfc5cddd
fix: delete/backspace to delete tab/section/column if selected
2023-10-31 21:16:06 +05:30
Shariq Ansari
4955a90f55
fix: click on + button to add field and press enter tab will be deleted
2023-10-31 21:05:33 +05:30
Shariq Ansari
ca2152d56c
feat: ctrl+shift+n to add new field & delete/backspace to delete the field when it in on focus
2023-10-31 20:51:41 +05:30
Shariq Ansari
d95b3b6fb0
feat: created autocomplete component to control options with up/down key
2023-10-31 20:28:31 +05:30
mergify[bot]
f2c3978009
Merge pull request #23021 from akhilnarang/drop-ifnull-helparticle
...
refactor(help_article): drop usage of ifnull
2023-10-31 10:35:40 +00:00
Ankush Menat
f41451708a
Merge pull request #23019 from ankush/amended_from_likns
...
perf: Improve link checks during cancellation
2023-10-31 15:55:40 +05:30