vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
45435 commits 1 branch 0 tags 587 MiB
Commit graph

45435 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ankush Menat
4f18daba17
ci: fix ocassional patch test failure (#25001) 
Some files in /env are touched during deletion which causes test to fail.

Hunch: running processes still not killed OR background jobs.
 2024-02-21 14:55:32 +00:00
Jannat Patel
ab485b2f4f
fix: disable internal columns like _comments from report column selec… (#24998) 
* fix: disable internal columns like _comments from report column selection

* fix: only exclude comments from reportview
 2024-02-21 19:45:12 +05:30
Ankush Menat
9d0a24f3de
fix: handle email without content adding links (#24994) 2024-02-21 19:18:21 +05:30
Ankush Menat
dd50cc0cf1
fix: Correct type hint (#24990) 
closes https://github.com/frappe/frappe/issues/24987
 2024-02-21 19:12:21 +05:30
Ankush Menat
99bb5d0303
fix: Cast to string to handle int PK (#24988) 2024-02-21 13:27:38 +00:00
Ankush Menat
2dffcc08ab
fix: allow negative numbers in grid search (#24989) 2024-02-21 13:26:03 +00:00
Ankush Menat
dab06f33b1
fix: add show_dashboard field on custom fields (#24984) 
closes https://github.com/frappe/frappe/issues/23637
 2024-02-21 12:58:34 +00:00
Ankush Menat
f819558f35
chore: typo (#24983) 2024-02-21 17:33:36 +05:30
Shankarv19bcr
437beaa735 fix: typo 2024-02-21 17:19:32 +05:30
Akhil Narang
9b1735bcb3
Merge pull request #24979 from akhilnarang/enable-ruff-rules 
refactor(treewide): enable `RUF` rules
 2024-02-21 16:34:30 +05:30
Akhil Narang
75e8457005
chore: add recent ruff changes to git blame ignore 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-21 16:20:36 +05:30
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-21 16:20:28 +05:30
Ankush Menat
718b5b8bee
fix: Private images in PDFs from background jobs (#24980) 
* refactor: Private images rendering in PDFs

Private images currently render fine if PDF is generated during a
request as we pass the cookiejar to WKHTML.

Background jobs however fail completeley because they can't retrieve
private images without cookiejar.

This PR converts all image types to base64 encoded sources in HTML
itself, so wkhtmltopdf doesn't have to a fire a request.

* test: private images in pdf
 2024-02-21 10:38:02 +00:00
Ankush Menat
3aa7fd77ed
fix: patch QB before setup_module_map (#24981) 
This function if cache isn't available CAN result in a DB query, this
will cause cold starts to fail because QB is not yet patched.
 2024-02-21 09:57:50 +00:00
Akhil Narang
f027a03dcf
Merge pull request #24974 from akhilnarang/redis-pipeline-handle-exception 
fix(redis_wrapper): handle redis not being connected during cache clearing
 2024-02-21 12:48:15 +05:30
Maharshi Patel
339e5a0e57
Merge pull request #24975 from maharshivpatel/fix-bold-class 
fix: added important to bold class.
 2024-02-21 11:38:05 +05:30
Maharshi Patel
18749838b6 fix: added important to bold class. 
it is kind of unintuitive that we are adding semi-bold weight ( 600 ) to bold class :D
it also make sense to have !important to the bold class.
 2024-02-21 11:32:28 +05:30
Akhil Narang
648828c3b5
fix(redis_wrapper): handle redis not being connected during cache clearing 
Ignore the redis connection errors, we can still proceed here

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-21 11:26:57 +05:30
Alan
d2445989e9
Merge pull request #24973 from 18alantom/build-install-deps 
fix: install deps if node_modules not found
 2024-02-21 11:03:21 +05:30
18alantom
c07c86e4fc fix: install deps if node_modules not found 2024-02-21 10:45:16 +05:30
Corentin Flr
bc0da15d20
fix(capture): Add input to DOM before emitting click on it (#24841) 2024-02-20 20:29:39 +05:30
Ankush Menat
64a5ebb112
refactor!: Drop user based workflow action compatibility (#24956) 
* test: run workflow actions in tests

* test: fix workflow action tests

* refactor!: Remove compatibility with `user` based workflow action

* test: cleanup test cleanups

* fix: restore form dict after printing

* test: patch printing during workflow tests
 2024-02-20 14:37:13 +00:00
Ankush Menat
b794f868cc
fix: never apply role profiles to standard user (#24968) 2024-02-20 14:07:50 +00:00
Ankush Menat
8093a1d0a5
Merge pull request #24858 from ankush/socketio_auth_headr 
feat: socketio using authorization headers
 2024-02-20 16:10:11 +05:30
Frappe PR Bot
058d467a48
New translations main.pot (German) (#24960) 2024-02-20 16:09:11 +05:30
Ankush Menat
c37bb58c0c
Merge pull request #24954 from ankush/socketio_perf 
perf: Add optional socketio native packages
 2024-02-20 11:43:20 +05:30
Ankush Menat
692a400632 perf: Add optional socketio native packages 
These are native implementations of some of the things socketio relies
on. Just installing makes few things faster.

These are optional so yarn should ignore failure to install.
 2024-02-20 11:07:47 +05:30
Akhil Narang
08962ac22a
Merge pull request #24952 from frappe/dependabot/github_actions/actions/checkout-4 
chore(deps): bump actions/checkout from 3 to 4
 2024-02-20 10:19:57 +05:30
dependabot[bot]
c5d5fad4cc
chore(deps): bump actions/checkout from 3 to 4 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
 2024-02-19 18:39:36 +00:00
Ankush Menat
e306e01660
Merge pull request #24947 from ankush/chore/remove_patch 
fix: remove patch for hashing existing tokens
 2024-02-19 18:44:39 +05:30
Ankush Menat
9a0fc2e9d9 fix: remove patch for hashing existing tokens 2024-02-19 18:38:21 +05:30
Ankush Menat
41bd0a41cd
Merge pull request #24945 from ankush/perf_cli 
perf: defer imports during CLI
 2024-02-19 18:23:13 +05:30
Ankush Menat
0a886b7ca8 perf: defer imports during CLI 2024-02-19 18:10:07 +05:30
Ankush Menat
3d488cbb09
Merge pull request #24643 from akhilnarang/optimize-redis 
refactor: try to optimize redis calls
 2024-02-19 17:45:15 +05:30
Akhil Narang
59ca074780
fix: only try JSON if content-type says so (#24936) 
Keep NoneType as the fallback

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-19 15:29:22 +05:30
Akhil Narang
ec8500ef09
Merge pull request #24884 from barredterra/timeline-communication-date 
fix: use communication date in timeline
 2024-02-19 14:31:06 +05:30
Ankush Menat
1de72ab07f
Merge pull request #24938 from ankush/handle_cronless_jobs 
fix: handle bad cron expressions
 2024-02-19 14:30:43 +05:30
Akhil Narang
c60e97410d
chore(cache): add in some tests 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-19 14:28:35 +05:30
Akhil Narang
5343bcb756
fix(redis_wrapper/hdel): don't pipeline if we can avoid it 
For a single deletion it doesn't make much sense, so just directly delete and return

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-19 14:28:35 +05:30
Akhil Narang
94365a59bf
chore(utils/caching): drop unnecessary indent 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-19 14:28:35 +05:30
Akhil Narang
7c82115f5b
refactor(redis): DEL -> UNLINK 
This is beneficial since unlink is non blocking, it will run in a different thread if the data passed is large
https://redis.io/commands/unlink/

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-19 14:28:35 +05:30
Akhil Narang
886d4ffc25
refactor(boot): frappe.cache() -> frappe.cache 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-19 14:28:35 +05:30
Akhil Narang
7dddc9e4f1
refactor(twofactor): reduce number of calls to redis 
Pipeline wherever possible, set expiry while saving value

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-19 14:28:35 +05:30
Akhil Narang
762290db9a
chore: don't delete keys that aren't used 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-19 14:28:35 +05:30
Akhil Narang
aa38d9e2f4
refactor: pipeline wherever possible, optimize calls 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-19 14:28:35 +05:30
Ankush Menat
e88c078c9d fix: validate cron format 2024-02-19 13:27:34 +05:30
Ankush Menat
68d1a9ec07 fix: delete cron jobs when switching server script type 2024-02-19 13:11:45 +05:30
Frappe PR Bot
30fcf354e5
feat: new translations from Crowdin (#24901) 
* New translations main.pot (French)

* New translations main.pot (Spanish)

* New translations main.pot (Arabic)

* New translations main.pot (German)

* New translations main.pot (French)

* New translations main.pot (Spanish)

* New translations main.pot (Arabic)

* New translations main.pot (German)

* New translations main.pot (German)

* New translations main.pot (French)

* New translations main.pot (German)

* New translations main.pot (Spanish)

* New translations main.pot (Arabic)
 2024-02-19 07:15:59 +00:00
Ankush Menat
931e1d64a2
ci: fix labeller (#24935) 
* ci: fix labeller

* ci: fix labeller workflow
 2024-02-19 07:04:45 +00:00
Ankush Menat
e6120f230a
Merge pull request #23848 from barredterra/copy-config-to-new-app 
feat: default configuration for new app
 2024-02-19 12:19:07 +05:30