Commit graph

53982 commits

Author SHA1 Message Date
Sagar Vora
51c2e9ec89 perf: set docfields only on doc change 2026-02-19 10:30:49 +05:30
Sagar Vora
9fabfa3054 fix: prevent docfield copy contamination across grid rows on deletion/reorder
set_docfields was passing the row's mutated docfields (with stale
reqd/read_only/hidden from dependency evaluation) as source to
make_docfield_copy_for, poisoning the copy store for whichever doc
landed at that position after deletion/reorder.

- Remove make_docfield_copy_for call from set_docfields (the copy store
  seeds itself lazily from clean originals in get_docfield_copy)
- Always call set_docfields() on refresh so rows pick up correct copies
  when doc identity changes at a position
- Thread grid.docfields through meta.js so new copy-store entries
  include grid-level customizations (set_df_property on child fields)

Closes #36921
2026-02-19 00:48:15 +05:30
Ejaaz Khan
ec2dbdd491
Merge pull request #37202 from iamejaaz/sidebar-menu-position
refactor(ui): reposition menu for improved layout
2026-02-18 20:34:53 +05:30
Hussain Nagaria
8edecdaefc
Merge pull request #37035 from trustedcomputer/fix-attach-print-pdf 2026-02-18 20:28:26 +05:30
Hussain Nagaria
71365066d3
refactor: safer property access 2026-02-18 19:40:47 +05:30
Ejaaz Khan
0254f52834
Merge pull request #37201 from iamejaaz/add-fc-banner-desktop
refactor: remove FC banner from desk
2026-02-18 17:57:14 +05:30
Ejaaz Khan
8cd5ad51b1 refactor(ui): reposition menu for improved layout
Co-authored-by: diptanilsaha <diptanilsaha@users.noreply.github.com>
Co-authored-by: surajshetty3416 <surajshetty3416@users.noreply.github.com>
2026-02-18 17:34:39 +05:30
Ejaaz Khan
6a3357c224 refactor: remove FC banner from desk 2026-02-18 17:25:11 +05:30
Ejaaz Khan
3de8e14754
Merge pull request #37198 from iamejaaz/add-fc-banner-desktop
feat: add FC billing banner on Desktop
2026-02-18 16:25:19 +05:30
Ejaaz Khan
081908540d feat: add FC billing banner on Desktop 2026-02-18 16:08:12 +05:30
Prathamesh Kurunkar
79003d6674
docs(sendmail): clarify behavior of queue_separately and CC/BCC in email_queue (#37113)
* fix(sendmail): enhance queuing of cc and bcc recipients to avoid duplicates

* revert: fix(sendmail): enhance queuing of cc and bcc recipients to avoid duplicates

This reverts commit 66c0c1cfb7c0f46f5687ce5266f945e88dadc1db.

* docs(email_queue): clarify behavior of queue_separately and CC/BCC in email queue
2026-02-18 15:57:20 +05:30
Prathamesh Kurunkar
3e061b026b
fix(email): ensure CC header visibility according to email semantics (#37182)
* fix(email): ensure CC header visibility according to email semantics

* chore(email): fix linting in docs
2026-02-18 15:55:06 +05:30
s-aga-r
13c7a38fce
fix: link received reply of sent email (#37177) 2026-02-18 15:20:48 +05:30
Patel Aasif Khan
9c0acda79a
fix: Fixed Email Header folding issue with Message-ID (#35266)
* fix: Fixed Email Header folding issue with Message-ID

* fix: email header folding with smtp policy refold

* chore: linter

---------

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
2026-02-18 14:33:13 +05:30
Harsh Patadia
849a935e20
fix: List Settings UI Issue (#36903)
* fix: List Settings UI Issue #36861

* fix: removed extra padding from top, made everything vertically aligned

* fix: properly formatted the changes made to the file

* fix: failing linter

* fix: failing linter

* fix: failing linter

* fix: failing linter

* fix: failing linter

* fix: formatting

* refactor: code cleanup

---------

Co-authored-by: priyanshshah2442 <priyanshshah2442@gmail.com>
Co-authored-by: Ejaaz Khan <ejaaz@frappe.io>
2026-02-18 14:14:09 +05:30
Gursheen Kaur Anand
9dcbd870c4
Merge pull request #37156 from GursheenK/open-link-icon-overflow
fix(minor): open link button overflows in grid row
2026-02-18 13:09:37 +05:30
Soham Kulkarni
739eae4a4e
Merge pull request #36983 from KerollesFathy/fix-kb-layout
fix: adjust padding and layout for knowledge base
2026-02-18 12:51:48 +05:30
Suraj Shetty
c0806fabe8
Revert "fix(safe-exec): Allow WITH queries" (#37175) 2026-02-18 07:21:41 +00:00
Soham Kulkarni
44566953aa
Merge pull request #37174 from frappe/allow-with
fix(safe-exec): Allow WITH queries
2026-02-18 12:36:35 +05:30
Balamurali M
87ea953609 fix(safe-exec): Allow WITH queries
ref: https://mariadb.com/docs/server/reference/sql-statements/data-manipulation/selecting-data/common-table-expressions/with
2026-02-18 12:21:50 +05:30
Soham Kulkarni
46d56e1f52
Merge pull request #37157 from sokumon/awesomebar
fix(desktop): call setup once
2026-02-18 11:44:42 +05:30
Sayantan Ghosh
84bfc8aa91
fix: frappe.call for website now handles 417 errors (#32362)
this is to bring parity between the two `frappe.call` methods: one for the website and one for the framework.
2026-02-18 06:00:27 +00:00
Ejaaz Khan
1262479ad3
Merge pull request #37146 from Vibhuti410/fields-table-ui-alignment
fix: resolve text input extra line causing table break and align checkbox
2026-02-18 11:20:26 +05:30
Ejaaz Khan
b1c5977ee4
Merge pull request #37145 from GursheenK/autocomplete-editable-grid
fix: autocomplete field dropdown in editable grid row
2026-02-18 11:13:34 +05:30
Frappe
100e9528da fix: resolve text input extra line causing table break and align checkbox 2026-02-18 10:19:24 +05:30
Akash Tom
bdb6d07ed9
fix: render checkbox state appropriately on changing page (#37148) 2026-02-18 08:27:21 +05:30
Soham Kulkarni
c6ba17e514
fix(grid): styling of focus grid control (#37169) 2026-02-18 08:21:34 +05:30
sokumon
0ebef17256 fix: remove other creation option 2026-02-18 03:37:54 +05:30
Trusted Computer
caf08a8451
Merge branch 'frappe:develop' into fix-attach-print-pdf 2026-02-17 12:18:30 -08:00
sokumon
a0bb44f0f0 fix: close notification pane correctly 2026-02-17 23:40:15 +05:30
Aarol D'Souza
a043c26709
Merge pull request #35318 from AarDG10/add-custom-hook
feat(server script): parse child table list onto server script for customizations
2026-02-17 23:05:32 +05:30
sokumon
481d43e0e5 fix(desktop): call setup once 2026-02-17 22:18:09 +05:30
Akhil Narang
9d5a3c2537
Merge pull request #37144 from akhilnarang/fix-raw-html-check
fix: only allow raw_html if an email template is passed
2026-02-17 22:15:22 +05:30
Gursheen Anand
91091a9098 fix: use inline-flex to vertically center open icon 2026-02-17 21:49:12 +05:30
Gursheen Anand
8bb725d90f fix: remove sleep delay 2026-02-17 21:20:42 +05:30
Soham Kulkarni
2eb1af09cd
Merge pull request #36755 from sokumon/add-to-workspace
fix(ux): create workspace
2026-02-17 21:07:42 +05:30
Aarol D'Souza
9eef4f6dae
fix: force type check in whitelisted methods (#37044)
* fix(contact): force type check in contact whitelisted methods

* fix(google_indexing): force type check in google_indexing whitelisted methods

* fix(assignment_rule): add type checks to assignment_rule whitelisted methods

* refactor: remove unused args

* fix(queue): add type hints to whitelisted methods in queue.py

* fix(auto_email_report): add type hints to whitelisted methods

* fix(dashboard): add type hints to whitelisted methods

* fix(sidebar_item_group): add type hints to whitelisted methods

* fix(weasyprint): add type hints to whitelisted methods

* fix(backups): add type hints to whitelisted methods

* fix(document_naming_settings): add type hints to whitelisted methods

* fix(get_latest_submissions): add type hints to whitelisted methods

* fix(custom_field): add type hints to whitelisted methods

* fix(customize_form): add type hints to whitelisted methods

* fix(personal_data_deletion_request): add type hints to whitelisted functions

* fix(__init__): add type hints to whitelisted methods

* fix(prepared_report): add type hints to whitelisted methods

* fix(session_default_settings): add type hints to whitelisted methods

* fix(document_follow): add type hints to whitelisted methods

* fix(route_history): add type hints to whitelisted methods

* fix(form_tour): add type hints to whitelisted methods

* fix(dashboard_settings): add type hints to whitelisted methods

* fix(address): add type hints to whitelisted methods

* fix(contact): add type hints to whitelisted methods

* fix(discussion_reply): add type hints to whitelisted methods

* fix(auto_repeat): add type hints to whitelisted methods

* fix: add the missing type hints and misc. corrections

* fix(email): add type hints to whitelisted methods

* fix(permitted_documents_for_users): add type hints to whitelisted methods

* fix: correct the type hints

* fix: int PK types

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2026-02-17 15:16:30 +00:00
Safwan
2231252fe8
Merge pull request #37141 from safwansamsudeen/gantt-dark-mode
fix: dark mode in Gantt
2026-02-17 17:09:02 +05:30
Gursheen Anand
e83a80bd6c fix: take available width for dropdowns in grid and limit minWidth 2026-02-17 16:38:40 +05:30
Gursheen Anand
9d4cec10aa fix: handle autocomplete field dropdown similar to link in editable grid 2026-02-17 16:34:00 +05:30
Safwan
7e0de9a902
Merge pull request #37126 from safwansamsudeen/fetch-all-gantt-fields
fix: fetch all required gantt fields
2026-02-17 16:27:48 +05:30
Safwan Samsudeen
f43e2eb6ea chore: bump gantt version 2026-02-17 16:20:23 +05:30
sokumon
96b37742da fix: add back the add to desktop button 2026-02-17 16:13:44 +05:30
sokumon
6750191419 chore: add type hints 2026-02-17 16:10:10 +05:30
sokumon
9c2b2f97aa fix: remove other options for creation 2026-02-17 16:10:10 +05:30
sokumon
4ee7c9a54c fix: create workspaces from the frontend 2026-02-17 16:10:10 +05:30
sokumon
c82e455370 fix: make the default icon color as gray 2026-02-17 16:10:10 +05:30
sokumon
5716365661 fix(ux): show new icon 2026-02-17 16:10:10 +05:30
sokumon
0587320d78 fix: delete icon and sidebar for non exported workspaces 2026-02-17 16:10:10 +05:30
sokumon
4eeeebc657 fix(ux): add to desktop button on workspace 2026-02-17 16:10:10 +05:30