Commit graph

46370 commits

Author SHA1 Message Date
barredterra
553918f36b feat: use autocomplete on "New Address" button 2024-05-09 22:10:47 +02:00
barredterra
ae505b769c feat: implement primary and secondary action for autocomplete dialog 2024-05-09 22:08:56 +02:00
barredterra
388046491e fix: return structured result from provider 2024-05-09 22:08:12 +02:00
barredterra
7a45c76da2 fix(Address Autocomplete Settings): provider and API Key mandatory if enabled 2024-05-09 22:06:55 +02:00
barredterra
9880d9466f Merge branch 'develop' into address-autocomplete 2024-05-09 20:58:07 +02:00
Akhil Narang
26164ca600
Merge pull request #26377 from akhilnarang/add-back-request-raise-for-status
fix(integrations): add back `response.raise_for_status()`
2024-05-08 15:28:13 +05:30
Akhil Narang
19b696acf6
fix(integrations): add back response.raise_for_status()
It got removed in 59ca074780, however it
should still be here, the point of that commit was to fix other
behaviour, don't exactly remember why it was removed.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-08 15:14:41 +05:30
Akhil Narang
a623d1b285
Merge pull request #26372 from akhilnarang/drop-read-only-excel-read
chore(openpyxl): don't set `read_only=True` while reading an excel file
2024-05-08 12:28:00 +05:30
Akhil Narang
af5af9b7a1
chore(openpyxl): don't set read_only=True while reading an excel file
The way openpyxl parses files is very different, and read only seems to break with certain files
It tries to head information about the max rows/columns from the header in the case of read only
which can be wrong sometimes.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-08 11:42:07 +05:30
Ritwik Puri
e6118cca3c
fix: open URL type shortcut in workspace in a new tab (#26367) 2024-05-07 21:27:01 +05:30
Ankush Menat
f07ea138d5
test: check redis calls and overhead (#26356) 2024-05-07 10:05:21 +00:00
Ankush Menat
c17eb87c70
perf: Reuse cached user for get_user_lang (#26350)
Saves ~1% of overhead.

User doc is almost always cached to create session so we can reuse it in
same request without additional redis call.
2024-05-07 12:50:22 +05:30
Ankush Menat
e240c6bdf8
perf: Avoid caching module_app (#26349)
module_app is just reverse of app_module.

This saves ~1.5% of overhead.
2024-05-07 07:06:44 +00:00
Kevin Shenk
cd50b025d5
fix: QB name in error message (#26345)
"Query Engine" wording made the edited error message ambiguous, since the docs all refer to this feature as Query Builder
2024-05-07 11:39:28 +05:30
Ankush Menat
f8abd09ab9
perf: avoid two layer cache of timezone (#26340)
It's same thing, system settings are always fetched, no idea what's point of additional layer of caching on top of it.
2024-05-06 13:12:41 +00:00
Ankush Menat
724d886f88
perf: Reduce 1 redis call while dumping monitor logs (#26337) 2024-05-06 12:53:36 +00:00
Ankush Menat
1defbf5be8
fix: Apply configured perms on address list (#26334) 2024-05-06 12:08:06 +00:00
Akhil Narang
32d6d802fc
Merge pull request #26324 from blaggacao/feat/error-log-link
feat: allow linking of request http errors
2024-05-06 17:16:06 +05:30
David
f9cdcfb7af
feat: allow linking of request http errors 2024-05-06 13:18:33 +02:00
Ankush Menat
aa48d7d84a
test: smtp4dev API changes (#26330) 2024-05-06 16:23:25 +05:30
mahsem
424d5e14bc
fix: Add some strings for translation (#26322) 2024-05-04 20:04:18 +05:30
Frappe PR Bot
4c338d26d6
fix: sync translations from crowdin (#26120)
* fix: Turkish translations

* fix: Persian translations

* fix: Turkish translations

* fix: Persian translations

* fix: Bosnian translations

* fix: Turkish translations

* fix: Persian translations

* fix: Bosnian translations

* fix: Turkish translations

* fix: Spanish translations

* fix: German translations

* fix: Bosnian translations

* fix: Persian translations

* fix: Spanish translations

* fix: Bosnian translations

* fix: Turkish translations

* fix: Persian translations

* fix: Spanish translations

* fix: Turkish translations

* fix: Turkish translations

* fix: Turkish translations
2024-05-04 18:11:26 +05:30
mahsem
076e25658b
style: whitespace in social_login_key.json (#26317) 2024-05-04 17:11:04 +05:30
Ankush Menat
2796f8e002
Merge pull request #26314 from ankush/fix/update_notifications
feat: improved update notifications
2024-05-04 15:22:45 +05:30
Ankush Menat
8ab308838b feat: Keep certain keys persistent in cache 2024-05-04 15:08:35 +05:30
Ankush Menat
45026aed37 feat: give higher priority to minor versions
Major versions will be shown when minor updates are exhausted only.
2024-05-04 15:08:35 +05:30
Ankush Menat
a234e79790 refactor: misc changes
- Move sys setting check to server side
- tomli import handling
2024-05-04 15:08:34 +05:30
Ankush Menat
e0c171b23b feat: show security issues count
chore: conflicts
2024-05-04 15:08:34 +05:30
Ankush Menat
5ca14bb171 feat: FC specific update notifications 2024-05-04 15:08:34 +05:30
Ankush Menat
56233f3182 chore: dead hooks 2024-05-04 15:08:32 +05:30
Ankush Menat
330a1b2044 fix: update notifier never running 2024-05-04 12:28:19 +05:30
Ankush Menat
2b95aa66a7
test: increase threshold for perf test (#26316)
We are >2x faster since the time this test was written 😄
2024-05-04 06:34:16 +00:00
Ankush Menat
7fe9cc4f09
perf: Don't update session in cache after every request (#26308)
It's just reading and writing same information except last_update inside
data which is never read back from this.
2024-05-04 06:10:38 +00:00
Ankush Menat
8e76a94a62
fix: like filter from meta filters (#26311) 2024-05-03 18:46:32 +05:30
RitvikSardana
5e25d2d121
fix: link filter falsy fix (#26282)
* fix: when operator is like, then convert to string

* chore: code cleanup

* chore: code cleanup
2024-05-03 17:43:06 +05:30
Ankush Menat
0929c235c5
fix(UX): multi-tab experience (#26309)
- On booting new session update other sessions in same browser to avoid
  "invalid requests"
- On logging in as diff user - notify user to reload page.

Not going to force reload to avoid potential data loss.
2024-05-03 16:52:45 +05:30
Ankush Menat
65b3c42635
fix: only redirect to same domain (#26304)
This limits post login redirects to same domain to avoid social engineering attempts.
2024-05-02 18:02:18 +05:30
Rohan
4bfcccfd11
fix: ignore unittest.mock objects during typing validations (#26301)
* fix: ignore unittest.mock objects during typing validations

* fix: check against base mock class

---------

Co-authored-by: Rohan Bansal <rohan@agritheory.dev>
2024-05-02 11:00:02 +00:00
Ankush Menat
3e64e60389
chore!: drop sid from boot (#26299) 2024-05-02 10:10:34 +00:00
Akhil Narang
490fae768a
Merge pull request #25900 from akhilnarang/fix-accessing-report-without-roles
fix: allow accessing reports without roles
2024-05-02 14:33:09 +05:30
Akhil Narang
26012aceb5
fix: allow accessing reports without roles
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-02 14:20:12 +05:30
Ankush Menat
1948422b63
Merge pull request #26292 from ankush/scheduler_reliability
fix: changes for scheduler reliability
2024-05-02 13:52:25 +05:30
Ankush Menat
b2ef2cd506 feat: show oldest unscheduled job in health report 2024-05-02 13:39:51 +05:30
Ankush Menat
86b1e9ec31 fix: update last_execution for no-log unconditionally
Cron jobs can now also disable logging.
2024-05-02 13:36:17 +05:30
Ankush Menat
b0aaeb5096 fix: Dont let one invalid cron fail scheduler
Scenario:
- One bad cron job exists
- When it fails nothing after that job is enqueued.

After this fix, that failure is skipped and rest of the jobs are enqueued.
2024-05-02 13:36:14 +05:30
Ankush Menat
8bd40b38e1
fix: reportview average of ints should be float (#26284) 2024-05-02 06:41:15 +00:00
Akhil Narang
3db923995c
Merge pull request #26283 from gparent/canada-dateformat
fix(Geo): change Canadian all numeric dates to ISO 8601 format
2024-05-02 12:04:30 +05:30
gparent
902d48ce86 fix(Geo): change Canadian dates to ISO 8601 format 2024-05-02 02:11:04 +00:00
Raffael Meyer
02ea846cd4
fix: automatic logo width (#26273) 2024-05-01 19:16:26 +05:30
Raffael Meyer
8eb8c64fbd
fix(Navbar Settings): reload page after save (#26274)
* fix(Navbar Settings): reload page after save

* test: file uploader flake

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-05-01 13:20:04 +00:00