Commit graph

40389 commits

Author SHA1 Message Date
Ankush Menat
57c81b2f42
fix: log unknown usernames too for failed attempts (#19199)
[skip ci]
2022-12-08 17:41:47 +05:30
Ritwik Puri
0aa24cc5ef
fix: reload shared dialog upon checking any perm (#19196) 2022-12-08 17:32:34 +05:30
Ankush Menat
7578be8191
fix: only make fetch_from field read only if no input (#19192) 2022-12-08 16:38:27 +05:30
dependabot[bot]
775321b99d
build(deps): bump qs from 6.7.0 to 6.11.0 (#19182)
Bumps [qs](https://github.com/ljharb/qs) from 6.7.0 to 6.11.0.
- [Release notes](https://github.com/ljharb/qs/releases)
- [Changelog](https://github.com/ljharb/qs/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ljharb/qs/compare/v6.7.0...v6.11.0)

---
updated-dependencies:
- dependency-name: qs
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-08 13:30:33 +05:30
Dany Robert
2ab543f4ae
fix: allow changing counter for prefix-less series (#19180) 2022-12-08 13:27:14 +05:30
Ankush Menat
49437f53b4
feat: operation level locking for CLI commands (#19162)
This prevents mistakenly issuing same commands twice which can be
dangerous.

added global lock(s):
- [x] bench build

added site level lock(s):
- [x] bench new-site sitename
- [x] bench --site sitename migrate
- [x] bench install-app appname
- [x] bench build
- [x] bench restore (the code is just meh, needs some cleanup)

closes https://github.com/frappe/frappe/issues/13215
2022-12-08 13:24:43 +05:30
Ritwik Puri
dbc5a790c1
fix(docshare): return None if share_name and value are None (#19187) 2022-12-08 12:49:23 +05:30
Shariq Ansari
0b2bc14816
Merge pull request #19170 from phot0n/fix-shared-with 2022-12-08 12:35:57 +05:30
Shariq Ansari
8b0736d07c
Merge pull request #19098 from resilient-tech/check-parentfield-valid 2022-12-08 12:19:51 +05:30
phot0n
19588b24f7 fix: stabilize shared with dialog 2022-12-08 00:40:32 +05:30
Ankush Menat
b304751639
ci: common server test (#19177) 2022-12-08 00:09:59 +05:30
Shariq Ansari
5f27d24272
Merge pull request #19161 from iamejaaz/workflow-button-icon
Fixes https://github.com/frappe/frappe/issues/19132
2022-12-07 19:52:43 +05:30
Shariq Ansari
7345da5dbf
Merge branch 'develop' into workflow-button-icon 2022-12-07 19:28:43 +05:30
Ankush Menat
e37742f75c
Merge pull request #19171 from resilient-tech/restore-_dict
fix: restore `_dict` in safe exec, override RestrictedPython transformer to add compatibility
2022-12-07 16:38:04 +05:30
Ankush Menat
b11793ab02 fix: set filename explicitly for safe_exec 2022-12-07 16:34:27 +05:30
Mohammad Hussain Nagaria
02601dafd4
perf: remove redundant render template (#19123) 2022-12-07 15:11:46 +05:30
Sagar Vora
d61748446b
fix: validate email template subject and minor refactor (#19102)
* fix: validate email template subject

* chore: remove duplicate call to `json.loads` and minor refactor
2022-12-07 15:09:07 +05:30
Raffael Meyer
dcae57475d
fix: unscrub and translate field names in tooltip explaining fetch from (#19143) 2022-12-07 14:57:07 +05:30
Sagar Vora
5f2cc8ec79 chore: keep previous order for easy backport 2022-12-07 14:09:02 +05:30
Sagar Vora
0c220169da chore: reorder pylint disable 2022-12-07 13:50:59 +05:30
Sagar Vora
aa53779e6b fix: improve condition to init context 2022-12-07 13:46:34 +05:30
Sagar Vora
7d47d10692 fix: override RestrictedPython transformer to allow _dict, revert frappe.as_dict 2022-12-07 13:45:28 +05:30
Sagar Vora
10695d3d49 feat: make context optional when calling render_template 2022-12-07 13:32:38 +05:30
Sagar Vora
f2e1dbe7eb fix: restore _dict, used in Jinja code 2022-12-07 13:13:27 +05:30
Ejaaz Khan
785d534eca
Merge branch 'develop' into workflow-button-icon 2022-12-07 12:12:44 +05:30
Raffael Meyer
6e8820e627
chore: translate doctype in link error (#19164) 2022-12-07 00:31:39 +05:30
Raffael Meyer
7484ebacb5
ci(deps): install mariadb 10.6 (#19166) 2022-12-07 00:23:35 +05:30
Ejaaz Khan
77976293ed
fix: workflow icon not visible in mobile view 2022-12-06 18:31:06 +05:30
Ankush Menat
d389fffbb7
feat: inter-process file locks (#19133) 2022-12-06 16:31:51 +05:30
Ankush Menat
bbcc365a24
fix: use monotonic clock for timing code (#19138)
* fix: use monotonic time for timing code

`time.time()` depends on system clock which can drift away and get corrected
over time. If you're unlucky it will get corrected in your timing code
and give absurd results.

* test: dont check for status

can refresh and give wrong output

[skip ci]
2022-12-06 15:42:37 +05:30
Sagar Vora
23ab8bf3b2
Merge pull request #19128 from resilient-tech/fix-read-receipt-in-email
fix: type conversion for read receipt in communication email
2022-12-06 08:44:12 +00:00
Daizy Modi
d76b5fb719 fix: type conversion for read receipt in communication email 2022-12-06 08:25:11 +00:00
dependabot[bot]
9e91f209b6
build(deps): bump engine.io from 6.2.0 to 6.2.1 (#19127)
Bumps [engine.io](https://github.com/socketio/engine.io) from 6.2.0 to 6.2.1.
- [Release notes](https://github.com/socketio/engine.io/releases)
- [Changelog](https://github.com/socketio/engine.io/blob/main/CHANGELOG.md)
- [Commits](https://github.com/socketio/engine.io/compare/6.2.0...6.2.1)

---
updated-dependencies:
- dependency-name: engine.io
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-06 12:14:26 +05:30
Shariq Ansari
7431a0d5e6
Merge pull request #19124 from shariquerik/ldap-multiple-email
fix: LDAP - check each email in list before creating user
2022-12-06 11:34:55 +05:30
dependabot[bot]
36e857aa00
build(deps): bump dessant/lock-threads from 3 to 4 (#19125)
Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads) from 3 to 4.
- [Release notes](https://github.com/dessant/lock-threads/releases)
- [Changelog](https://github.com/dessant/lock-threads/blob/master/CHANGELOG.md)
- [Commits](https://github.com/dessant/lock-threads/compare/v3...v4)

---
updated-dependencies:
- dependency-name: dessant/lock-threads
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-12-06 10:04:10 +05:30
Shariq Ansari
2201601170
Merge branch 'develop' into ldap-multiple-email 2022-12-05 22:28:51 +05:30
Shariq Ansari
86dc33c1f1 fix: LDAP - check each email in list before creating user 2022-12-05 22:14:51 +05:30
Ankush Menat
4ba72d0f29
fix: give more weight to sequential matches (#19121) 2022-12-05 18:00:15 +05:30
Aradhya Tripathi
68e9fa639e
docs: Added query_builder docs (#19086)
* docs: Added query_builder docs

* docs: Added future works
2022-12-05 16:48:12 +05:30
Sagar Vora
9a3819e608
fix: disable signups by default (#19114)
* fix: disable signups by default

* fix: set `disable_signup` to `0` for tests
2022-12-05 16:40:51 +05:30
Sagar Vora
4ea39d1a68
chore!: drop device support from session (#18729)
* chore!: drop device support from session

* chore: remove `session_expiry_mobile` field

* fix: remove extra `%s`
2022-12-05 16:37:32 +05:30
Ankush Menat
186b88a8cb
build: Bump minimum required MariaDB version (#19116) 2022-12-05 16:24:35 +05:30
Ankush Menat
56b6e3eabd fix: deduplicate currencies manually
on mariadb 10.3 `insert ignore` doesn't work
2022-12-05 16:00:44 +05:30
ruthra kumar
90a4c93bf9
fix: attribute error on export of reports with additional columns (#19105) 2022-12-05 15:03:10 +05:30
Ankush Menat
39faf34ba4
fix: ignore empty/None scripts (#19111) 2022-12-05 13:32:45 +05:30
Ankush Menat
34f3f1469f
Merge pull request #19088 from phot0n/correct-doctype-perm-webform
fix(security): validate web form permissions correctly
2022-12-05 12:46:22 +05:30
Ritwik Puri
6444f66b36
Merge pull request #19093 from resilient-tech/get_permlevel_access
chore(Document): simplify `get_permlevel_access`
2022-12-05 12:41:32 +05:30
Raffael Meyer
f6f2c5ff8a
fix(UX): freeze on delete (#19094) 2022-12-05 12:36:33 +05:30
Maharshi Patel
03afa99e6c
feat(UI): Sticky Tabs Header (#18906)
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
2022-12-05 12:19:58 +05:30
phot0n
d7f4540132 chore: consider docname via data 2022-12-05 12:19:29 +05:30