Commit graph

44037 commits

Author SHA1 Message Date
barredterra
586fee979b fix: conf must be available 2023-11-08 00:07:31 +01:00
barredterra
a3feb08100 fix: integrate upstream changes 2023-11-06 20:40:37 +01:00
barredterra
8a0f921d78 refactor: reuse existing get_user_translations 2023-11-06 20:40:22 +01:00
barredterra
5839963475 fix: integrate upstream changes 2023-11-06 20:39:09 +01:00
barredterra
f00b510828 fix: prefer more specific extractors 2023-11-06 20:37:11 +01:00
barredterra
e16f1632a7 chore: remove unused method 2023-11-06 19:49:47 +01:00
barredterra
67404e0cd0 Merge branch 'develop' into po-translation 2023-11-06 19:40:25 +01:00
Ankush Menat
0aa3b51faa fix: single global search sync
closes https://github.com/frappe/frappe/issues/23106
2023-11-06 20:29:16 +05:30
Ankush Menat
72ca95dec0
fix: Only allow standard print format modification in migrate (#23112)
* fix: Only allow standard print format modification in migrate

AFAIK only valid use case is fixtures and there too it should avoid
"standard".

* chore: typo

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

---------

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2023-11-06 19:28:10 +05:30
Ankush Menat
47c3151662
fix: remove data import legacy leftover fields (#23113)
* fix: clear last message if ignoring DNE

* fix: attempt to delete data import legacy leftover fields
2023-11-06 19:18:39 +05:30
Suraj Shetty
2aa79202f3
Merge pull request #23116 from vishakhdesai/get_open_grid_form-not-a-function-error 2023-11-06 17:50:29 +05:30
Suraj Shetty
a562b30fa3
Merge pull request #22600 from bosue/quick_entry_remove_saving_message 2023-11-06 17:49:14 +05:30
mergify[bot]
9bedb19cf5
fix: ToDo assignment (backport #23056) (#23114)
Co-authored-by: CahyadiSuwindra <149154168+CahyadiSuwindra@users.noreply.github.com>
2023-11-06 17:46:36 +05:30
Vishakh Desai
c06fe30b11 fix: get_open_grid_form function not found 2023-11-06 17:29:44 +05:30
Suraj Shetty
e3d536659e
Merge pull request #22684 from GursheenK/audit-trail-filters 2023-11-06 17:12:45 +05:30
Bernd Oliver Sünderhauf
6378a45146 fix(UX): Remove freeze on QuickEntryForm, slower fade out after save. 2023-11-06 11:43:25 +01:00
Ankush Menat
69857f3c36
fix(UX): Restrict grid upload to CSV files (#23109)
Users end up uploading wrong files and wonder why it's not working.

Only CSV filetype is supported here.

Internal refernce: 5377
2023-11-06 15:26:44 +05:30
Bernd Oliver Sünderhauf
a0d52c9319 refactor(DRY): QuickEntryForm 2023-11-06 10:51:57 +01:00
Bernd Oliver Sünderhauf
5f8b93ee4c fix(UX): Replace 'Saving...' indicator by 'Created new...' success message for Quick Entry saves. 2023-11-06 10:51:34 +01:00
Maharshi Patel
4bba64d8e4
fix(minor): web and timeline styles (#23083) 2023-11-06 11:30:39 +05:30
mergify[bot]
4f81cf32eb
Merge pull request #22862 from SaiFi0102/grid-ui-perf
perf(Grid Table): 60% - 75% faster grid refresh
2023-11-06 05:04:18 +00:00
Bernd Oliver Sünderhauf
0b4bf84e38
fix(I18n): Use normalize to make fuzzy_match recognize diacritics, umlauts etc. (#22828)
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2023-11-06 10:10:23 +05:30
Ankush Menat
fa5a472686
Merge pull request #23094 from frappe/integration_smtp_test
test: smtp integration test using smtp4dev
2023-11-04 15:44:31 +05:30
Ankush Menat
3905e8970a test: smtp integration test using smtp4dev 2023-11-04 15:26:40 +05:30
Ankush Menat
3211a77dc8 fix: handle emails sent from console 2023-11-04 14:30:37 +05:30
Ankush Menat
4255a0ec46
Merge pull request #23075 from ankush/reuse_smtp_sess
perf: reuse SMTP session for email queue
2023-11-04 14:21:43 +05:30
Ankush Menat
089985e53b feat: frappe.job local for reading job info 2023-11-04 14:06:31 +05:30
Ankush Menat
ecca32853e test: ensure that same smtpserver is being reused 2023-11-04 13:53:08 +05:30
Ankush Menat
0362de82bb fix: Mark fake site config emali account with internal attribute 2023-11-04 13:41:18 +05:30
Ankush Menat
a4382fda5a fix: Automatically close SMTP connections on exit 2023-11-04 11:51:42 +05:30
Ankush Menat
d5d0dfb58b perf: Reuse SMTP connection when flushing email queue
This depends on https://github.com/frappe/frappe/pull/23070
2023-11-04 11:32:48 +05:30
Ankush Menat
4e318a0280 fix: Abort flushing email queue if >50% fail.
When email queue batch failes >33% with >10 count, frappe will now abort
sending emails.

We already notify users via system notification so this
assumes that user will notice it and fix it in sometime.

With previous commits we also prioritize fresh emails over retries.
2023-11-04 11:25:09 +05:30
Ankush Menat
050c0b26f8 fix: flush emails from single background jobs 2023-11-04 11:23:44 +05:30
Raffael Meyer
5c1d84101e
Merge pull request #23092 from barredterra/page_on_trash 2023-11-03 22:25:13 +01:00
barredterra
dd5bb0ff46 fix: allow page deletion during migrate 2023-11-03 22:03:27 +01:00
Ankush Menat
be2beeed9e
fix: improve email queue reliability (#23070)
* feat: control email queue batch size with config

* fix: Give emails who failed once less priority while sending
2023-11-03 15:10:37 +05:30
Suraj Shetty
ff14c52059
fix: Make editor editable in grid (#23085) 2023-11-03 14:30:28 +05:30
Ankush Menat
2ab8c2a053
refactor: misc changes (#23082)
- Fail early for developer mode
- Convert delete content function to method
- do io after db transaction commits
- write a test
2023-11-03 07:27:34 +00:00
Vishnu VS
ae7a893100
feat: granted delete permission and added folder deletion function for pages (#23077)
* fix: grant delete permission to administrator

* feat: added function to delete folder associated with the  page
2023-11-03 12:34:07 +05:30
mergify[bot]
6ad2e762d3
Merge pull request #23064 from frappe/bulk-insert-search-sync
perf(GlobalSearch): bulk insert queued items
2023-11-03 05:10:31 +00:00
Ankush Menat
8c74d542d5 perf: don't check len before popping
rpop is atomic and yields None when nothing is found. No need to check length.
2023-11-03 10:20:31 +05:30
Ankush Menat
eba499a9ba refactor: misc changes
- make internal function explicit
- dont delete keys which is immediately being replaced.
- deprecate `sync_value`
2023-11-03 10:15:52 +05:30
Raffael Meyer
f0155674a5
refactor!: remove redundant sending of translations (#22962)
* chore!: remove redundant translation

* refactor!: remove "get_translated_dict" hook

Instead, include the results from
`frappe.geo.country_info.get_translated_dict` in `get_all_translations`.

* test: money_in_words uses translated currency

... and now we have translations.

* Revert "test: money_in_words uses translated currency"

This reverts commit e07d594ac1ce4b120c0fceb5d23377cb981fe820.

* refactor!: stop translating timezone and currency

* refactor: rename `get_translated_dict`

... to `get_translated_countries`
2023-11-02 20:04:14 +05:30
Bernd Oliver Sünderhauf
888fc5fc55
build(deps): Update PyPDF to v3.17.0 (#23060) 2023-11-02 19:46:28 +05:30
18alantom
3d7ba41583 fix(sync_values): use EXCLUDED for postgres
removing the second arg from `do_update` causes
EXCLUDE to be auto added
2023-11-02 18:57:51 +05:30
18alantom
aa690553cf refactor: undo use of count in redis pop
count param in rpop and lpop was introduced in 6.20
at the time of this commit we are using an older
version that does not include it
2023-11-02 18:22:50 +05:30
Shariq Ansari
c648d3424b
Merge pull request #23072 from bosue/form_builder_switch_icons
fix(UX): Switch 'Duplicate' and 'Move' buttons on Form Builder.
2023-11-02 18:20:05 +05:30
Shariq Ansari
309085f02b
Merge pull request #23066 from shariquerik/form-builder-add-field-btn 2023-11-02 17:57:52 +05:30
Bernd Oliver Sünderhauf
ba1544c49d fix(UX): Switch 'Duplicate' and 'Move' buttons on Form Builder. 2023-11-02 13:26:17 +01:00
Shariq Ansari
ff5b1907a4 test: fixed failing form builder UI test 2023-11-02 17:28:21 +05:30