Ankush Menat
59f421cd04
fix: traceback colours ( #25356 )
...
default ipython colours use yellow on white font, which looks horrible
and is practically unreadable on most colourschemes.
2024-03-12 10:22:18 +00:00
Rushabh Mehta
4963a7e2b2
Merge pull request #25357 from rmehta/fix-minor-style
...
fix(minor): fixed style for read-only tables and form comments
2024-03-12 15:45:16 +05:30
Ankush Menat
ee03bf7518
Merge pull request #25348 from ankush/estimate_count
...
perf: cap max count on list views
2024-03-12 15:36:50 +05:30
Rushabh Mehta
6d3af51aab
fix(minor): fixed style for read-only tables and form comments
2024-03-12 15:31:08 +05:30
Ankush Menat
698ef95ca1
refactor: avoid duplicate render_count for report view
...
Only difference is element
2024-03-12 15:07:06 +05:30
Ankush Menat
1fa7cc7816
fix: support child tables in count with limit
2024-03-12 13:17:31 +05:30
Ankush Menat
fdcff2d9e8
fix(UX): let user see actual count on click
2024-03-12 13:17:31 +05:30
Ankush Menat
7e88c53aa4
perf: show estimated count on list view
2024-03-12 13:17:31 +05:30
Ankush Menat
a49fafbf8e
feat: support countig till a limit
...
In InnoDB counting is essentially O(n) operation, it can be pretty fast
on indexes but when filters don't use any index it usually means doing a
full table scan.
Adding a limit will stop the scan as soon as that many records are
matched.
2024-03-12 13:17:28 +05:30
Ritwik Puri
723bdb1e16
fix: check if the route is app sooner ( #25351 )
...
this fixes invalid routing for routes like /app/app
2024-03-12 12:44:53 +05:30
David Arnold
5f9dc1f529
fix: socketio port ( #25347 )
2024-03-12 09:40:26 +05:30
Ankush Menat
ae649aadf0
fix: dont add useless distinct clause
...
confuses query planner in some cases
2024-03-12 09:18:07 +05:30
Ankush Menat
fc7366deef
revert: fetch validations ( #25343 )
2024-03-11 14:59:18 +00:00
Ankush Menat
8bbb69a883
fix: Prevent multiple schedulers from running on same bench ( #25340 )
2024-03-11 14:12:31 +00:00
Akhil Narang
c441c844f9
fix(auto_email_report): check if column (docfield) parent is a child table ( #25335 )
...
This code tried to fetch the child doctype with the parent's ID otherwise
Support ticket 11145
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-03-11 19:34:53 +05:30
Ankush Menat
8a3dd85503
Merge pull request #25295 from ankush/virtual-doctype-dx
...
fix(DX)!: virtual doctype APIs
2024-03-11 18:37:20 +05:30
Ankush Menat
f7c0dd66fd
refactor: migrate virtual doctypes to new API
2024-03-11 18:25:05 +05:30
Shariq Ansari
3fc4203aec
Merge pull request #25331 from Ponnusamy1-V/ponnusamy
...
fix: list view click and drag select rows
2024-03-11 18:23:28 +05:30
Ankush Menat
1f35886995
test: flake from expecting a succesful job
2024-03-11 18:15:34 +05:30
Ankush Menat
4ab2ccd01f
fix!: get_count accepts splatted arguments
2024-03-11 18:15:27 +05:30
Ankush Menat
b8c4eff68a
fix: Skip child table management for children of virt doctypes
2024-03-11 18:15:25 +05:30
Ponnusamy1-V
b09833ac1c
fix: list view click and drag select rows
2024-03-11 17:08:40 +05:30
Raffael Meyer
eecb31e8e8
Merge pull request #25285 from barredterra/custom-field-translatable-default
2024-03-11 11:39:50 +01:00
Ankush Menat
a28921750d
fix(DX): Avoid use of args in virtual doctype
2024-03-11 15:20:35 +05:30
Ankush Menat
d6137a805c
fix: better default virtual doctype template
2024-03-11 15:20:35 +05:30
Ankush Menat
acf398f46e
fix: commit regardless of framework's transaction_writes count ( #25322 )
...
- There is code that depends on "commit", everything that happens with `db.after_commit`.
- There are operations that will not write anything to DB but just
enqueue the function, if it's enqueue_after_commit then it will break.
2024-03-11 15:18:38 +05:30
Ankush Menat
b56e94d1af
Merge pull request #25319 from ankush/dashboard_chart_install
...
fix: export dashboard_chart_source only if not programatically save
2024-03-11 14:39:50 +05:30
Ankush Menat
dc531ab769
Merge pull request #25318 from ankush/enq_after_commit
...
fix: Enqueue action after commit
2024-03-11 14:32:05 +05:30
Ankush Menat
bdae769c74
fix: export dashboard_chart_source only if not programatically save
2024-03-11 14:27:24 +05:30
Ankush Menat
68a78d33d3
fix!: Enqueue action after commit
2024-03-11 14:19:59 +05:30
Ankush Menat
bf449e8207
Merge pull request #25315 from ankush/comment_timeline_ts
...
fix: missing timeline timestamp for comments
2024-03-11 12:56:22 +05:30
Ankush Menat
c89eace582
fix: missing timeline timestamp for comments
...
resolves https://github.com/frappe/frappe/pull/24884/files#r1519195726
2024-03-11 11:40:52 +05:30
Akhil Narang
ad530601db
Merge pull request #25314 from barredterra/ruff-typing
...
chore: specify typing models for ruff
2024-03-11 10:59:29 +05:30
barredterra
5558cb0739
fix: linter config in boilerplate
2024-03-10 20:43:39 +01:00
barredterra
031d227542
chore: specify typing models for ruff
...
Resolves #25313
2024-03-10 20:41:05 +01:00
Vishnu VS
f1e8db80d5
feat(Dashboard Chart Source): delete files on trash ( #25173 )
...
Also refactored writing and reading of these files.
Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
2024-03-10 19:45:56 +01:00
Ankush Menat
e96c5755d0
Merge pull request #25311 from barredterra/refactor-in-list
...
refactor: replace `in_list(array, member)` with `array.includes(member)`
2024-03-10 22:28:58 +05:30
Ankush Menat
495273dcf9
fix: faster change of hash prefix
2024-03-10 21:48:56 +05:30
Ankush Menat
71a73054de
Merge pull request #25309 from ankush/mysql_optimized_naming
...
perf: optimize hash naming for MySQL storage
2024-03-10 21:34:59 +05:30
Ankush Menat
665f1fdf79
perf: optimize hash naming for MySQL storage
...
Random names can send rows all over the place, typically documents
created closer in time should live closer on mysql pages too.
2024-03-10 21:22:36 +05:30
barredterra
da1e8750c8
refactor: replace in_list(array, member) with array.includes(member)
2024-03-10 16:09:09 +01:00
Ankush Menat
e57bc17bcb
Merge pull request #25299 from ankush/skip_route_history
...
fix: ignore route history and access log from link check
2024-03-10 13:18:33 +05:30
Ankush Menat
f5bf218f5d
Merge pull request #25267 from akhilnarang/update-invalid-encryption-key-message
...
chore: include a link to FC docs regarding what to do with encryption key for restored sites
2024-03-10 13:10:44 +05:30
Ankush Menat
4f4a387b7e
fix(patch): Remove obviously invalid fetch from expressions ( #25284 )
2024-03-10 07:36:12 +00:00
Ankush Menat
8cf0c53eb7
Merge pull request #25265 from ankush/debug_key
...
fix: Use debug log to log DB queries
2024-03-10 13:01:37 +05:30
Ankush Menat
cfeb1db3f5
fix: ignore route history and access log from link check
2024-03-10 12:59:22 +05:30
mergify[bot]
66d73e6e6d
Merge branch 'develop' into custom-field-translatable-default
2024-03-10 07:23:46 +00:00
Ankush Menat
010de19ac4
Merge branch 'develop' into update-invalid-encryption-key-message
2024-03-10 12:51:22 +05:30
Ankush Menat
77c907a928
ci: add debug gha option
2024-03-10 12:49:19 +05:30
Ankush Menat
448991d74a
fix: avoid linking to ephemeral virtual docs
2024-03-10 12:49:19 +05:30
