Abhishek Saxena
5c8856d66e
refactor: db.sql calls to frappe.qb ( #16107 )
...
# Changes
- Introduces `subqry` class to use in where clause when there is a non-column condition. eg.
> .where(subqry(no_of_roles) == 0)
- Convert SQL queries to frappe.qb
# Testing
Functions with query refactors
- frappe.boot.get_user_pages_or_reports() -> Same output of `get_bootinfo()` as develop
- frappe.boot.get_unseen_notes() -> Forms the same query as develop
```sql
SELECT `name`,`title`,`content`,`notify_on_every_login`
FROM `tabNote` WHERE `notify_on_every_login`=1
AND `expire_notification_on`>'2022-03-30 01:10:53.393874'
AND (SELECT `nsb`.`user` FROM `tabNote Seen By` `nsb` WHERE `nsb`.`parent`=`tabNote`.`name`) NOT IN ('Administrator')
```
- frappe.installer._delete_doctypes() -> installed and uninsalled a dummy app to drop tables
### Not tested
- frappe.make_property_setter()
- frappe.realtime.get_pending_tasks_for_doc() [whitelist method]
- frappe.sessions.Session.start()
- frappe.twofactor.cache_2fa_data()
2022-04-12 05:07:25 +00:00
mergify[bot]
31d87176c1
Merge pull request #16570 from resilient-tech/fix-theme-switcher
...
fix: theme switcher shortcut issue
2022-04-11 11:26:56 +00:00
Shariq Ansari
b51d8379b5
fix: Card link indicator hover color same as link background color ( #16568 )
2022-04-11 16:15:35 +05:30
lapardnemihk1099
5993a8ba57
chore: sider issues fixed
2022-04-11 14:45:13 +05:30
lapardnemihk1099
27d226f295
test: theme switcher dialog shortcut test
2022-04-11 14:32:14 +05:30
mergify[bot]
bb6d682c07
Merge pull request #16507 from phot0n/from-signature
...
feat(minor): use specific email signature via from field
2022-04-11 08:19:05 +00:00
Shariq Ansari
1e63475b2a
style: Added gap between from and to field
2022-04-11 13:07:52 +05:30
Shariq Ansari
0739104d2a
Merge branch 'develop' into from-signature
2022-04-11 12:47:11 +05:30
mergify[bot]
b73580a262
Merge pull request #16478 from ChillarAnand/fmatch
...
feat: Added fuzzy search to awesome bar
2022-04-10 03:19:27 +00:00
Suraj Shetty
908a169626
Merge branch 'develop' into fmatch
2022-04-10 08:24:55 +05:30
mergify[bot]
6dd292c044
Merge pull request #16543 from kamaljohnson/add-after-insert-option-to-server-script
...
feat: add "After Insert" doctype event to server script
2022-04-10 02:44:26 +00:00
mergify[bot]
9910c79596
Merge pull request #16471 from phot0n/use-backticks
...
fix: use backticks for fieldname while preparing filters
2022-04-10 02:34:47 +00:00
Suraj Shetty
2a994a3be4
Merge branch 'develop' into use-backticks
2022-04-10 07:50:53 +05:30
HENRY Florian
cc9613f5c2
fix: update french translation ( #16550 )
2022-04-10 07:48:55 +05:30
Mohammed Redah
60814c4e3f
fix: Export Links in Customize Form ( #16333 )
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2022-04-10 07:46:43 +05:30
Suraj Shetty
5b8d930165
Merge pull request #16554 from netchampfaris/system-console-logs-route-fix
2022-04-10 07:45:24 +05:30
Faris Ansari
9e4182d91f
fix: new route syntax for Logs in System Console
2022-04-09 16:37:59 +05:30
Suraj Shetty
97a610a412
Merge pull request #16553 from frappe/dependabot/npm_and_yarn/moment-2.29.2
2022-04-09 07:33:10 +05:30
dependabot[bot]
42cfcdadf9
chore(deps): bump moment from 2.24.0 to 2.29.2
...
Bumps [moment](https://github.com/moment/moment ) from 2.24.0 to 2.29.2.
- [Release notes](https://github.com/moment/moment/releases )
- [Changelog](https://github.com/moment/moment/blob/develop/CHANGELOG.md )
- [Commits](https://github.com/moment/moment/compare/2.24.0...2.29.2 )
---
updated-dependencies:
- dependency-name: moment
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-04-09 01:08:28 +00:00
Komal-Saraf0609
02286e4e6f
test: Added test script for control type "Attach" ( #16355 )
...
Adding automation test script for control/fieldtype "Attach".
The above test script does the following testing:
1. Creating a new doctype with attach fieldtype.
2. Attaching a new image using the "Link" option from the options which the "Attach" button offers.
3. Checking if the URL of the attached image is getting displayed in the field of the newly created doctype.
4. Checking if the clicking on the "Clear" button clears the text in the field and again displays the "Attach" button.
5. Doing all the above testing by using the "Library" option from the options which the "Attach" button offers.
2022-04-08 13:42:58 +00:00
Rushabh Mehta
a682516f71
fix(style): minor style fixes
2022-04-08 10:38:03 +05:30
Rushabh Mehta
c54f694e7c
fix(style): minor style fixes
2022-04-08 07:56:23 +05:30
Rushabh Mehta
c0d8dfed15
fix(style): minor style fixes
2022-04-08 07:50:07 +05:30
Rushabh Mehta
96a6233953
fix(style): minor style fixes
2022-04-08 07:19:44 +05:30
Rushabh Mehta
4c350f41a2
fix(style): minor style fixes
2022-04-08 06:37:44 +05:30
Rushabh Mehta
63ad1efe3d
fix(style): minor style fixes
2022-04-08 06:12:32 +05:30
Rushabh Mehta
ddd807e818
fix(style): minor style fixes
2022-04-08 05:57:06 +05:30
Rushabh Mehta
7ceb8fd747
fix(style): minor style fixes
2022-04-08 05:35:55 +05:30
mergify[bot]
6410dbead0
Merge pull request #16518 from ChillarAnand/app
...
fix: Use app name for parsing app name
2022-04-07 15:01:13 +00:00
kamaljohnson
428b0bc4b1
feat: add after insert event to server script
...
this option was not available in the events dropdown.
2022-04-07 19:46:53 +05:30
mergify[bot]
096110e14d
Merge pull request #16538 from resilient-tech/fix-read-only
...
fix: Read Only fields visible despite no value
2022-04-07 08:06:26 +00:00
mergify[bot]
ec85c3df73
Merge pull request #16528 from Komal-Saraf0609/control-date2
...
test: Script for "Date" control
2022-04-07 07:41:32 +00:00
Shariq Ansari
7679d5e82c
chore: better variable name
2022-04-07 13:07:04 +05:30
Shariq Ansari
0a1595e94e
fix: added add signature button if multiple sender emails available
2022-04-07 12:57:11 +05:30
Sagar Vora
a096b85b52
fix: Read Only fields visible despite no value
2022-04-07 12:23:41 +05:30
Komal-Saraf0609
27cbcc3e8d
test: Removed first_day_of_week test case
2022-04-07 11:19:08 +05:30
mergify[bot]
81ece0197e
Merge pull request #16513 from alyf-de/default-map-view
...
fix: stabilize leaflet map
2022-04-07 04:52:31 +00:00
Komal-Saraf0609
5483caa8f5
test: Added test script for control type "Date"
2022-04-06 18:56:11 +05:30
Komal-Saraf0609
ae4acd71f2
Merge branch 'develop' into control-date1
2022-04-06 17:41:48 +05:30
Faris Ansari
ff8231da9c
Merge pull request #16523 from netchampfaris/fix-blog-comments
...
fix: strip html from blog comments to prevent spam
2022-04-06 17:34:31 +05:30
Faris Ansari
ae335f5e1c
test: spam links shouldn't render on blog post
2022-04-06 16:29:22 +05:30
Faris Ansari
e13c74b53f
fix: strip html from comment content
2022-04-06 16:28:57 +05:30
Faris Ansari
9943423a1f
fix: strip html from blog comments to prevent spam
2022-04-06 16:10:14 +05:30
ChillarAnand
7c46736654
fix: Use app name for parsing app name
2022-04-06 12:26:26 +05:30
Suraj Shetty
3d1bf21673
Merge branch 'develop' into control-date1
2022-04-06 11:15:02 +05:30
mergify[bot]
698d75193c
Merge pull request #16407 from alyf-de/map-control
...
feat: store reference to leaflet's drawControl
2022-04-06 05:42:49 +00:00
Suraj Shetty
d57302ff74
Merge pull request #16514 from surajshetty3416/misc-fixes-april-2022
2022-04-06 10:05:06 +05:30
Suraj Shetty
253d0cabb4
fix: Move custom-actions under page-actions
...
Change in custom-actions was affecting custom-actions in timeline
the issue was introduced with https://github.com/frappe/frappe/pull/16470
2022-04-06 10:04:33 +05:30
Raffael Meyer
d5627f5994
Merge branch 'develop' into map-control
2022-04-05 23:47:46 +02:00
barredterra
4c901a7074
fix: stabilize leaflet map
...
- disable flyToBounds
- invalidateSize after loading to avoid gray tiles
2022-04-05 20:38:42 +02:00