Commit graph

43487 commits

Author SHA1 Message Date
Ankush Menat
5e6f0daa0f
Merge pull request #22499 from barredterra/render-image-count
fix: render count on image capture
2023-09-25 12:51:15 +05:30
Ankush Menat
139530c858
Merge pull request #22513 from ankush/rename_field
feat: rename custom field's `fieldname`
2023-09-25 12:50:25 +05:30
Ankush Menat
0d5f28d569 feat: rename custom field 2023-09-25 12:25:28 +05:30
Suraj Shetty
64db601b9a
Merge pull request #22488 from gavindsouza/run-ui-tests-electron 2023-09-25 11:47:42 +05:30
Gavin D'souza
b19c569761
fix(run-ui-tests): Set default browser as chrome
Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2023-09-25 11:11:13 +05:30
Ankush Menat
a81fb2a11a
Merge pull request #22509 from netchampfaris/file-backup-path
fix: use relative path in file backup
2023-09-24 10:06:47 +05:30
Raffael Meyer
cd747d1428
Merge pull request #22500 from barredterra/check-write-perms-on-file-upload 2023-09-23 23:34:47 +02:00
Faris Ansari
d53a8832c8 chore: run restore test only on mariadb 2023-09-24 01:17:26 +05:30
Ankush Menat
21881e6652 fix(UX): Add Undo/Redo to toolbar
for better discoverabilty
2023-09-23 19:09:22 +05:30
Ankush Menat
4b89f65bff fix: no label when field isn't set 2023-09-23 18:58:13 +05:30
Ankush Menat
1a88b137fe fix: include standard fields in group by 2023-09-23 18:54:21 +05:30
Gavin D'souza
a5f709b468
ci: Use electron browser over chrome
* Electron is already shipped along with Cypress. Can we use it?
* Pass --record kwarg only if CYPRESS_RECORD_KEY envvar is set
2023-09-23 18:12:48 +05:30
Ankush Menat
224f97cd9c fix: incorrect pending tour computation 2023-09-23 17:50:10 +05:30
Ankush Menat
4122eba784 fix: Add crossorigin for preload
If crossorigin isn't specified browsers don't seem to use it.
2023-09-23 17:34:48 +05:30
Ankush Menat
bf037acb5b chore: deprecate get_js
Pointless function for loading public JS files
2023-09-23 15:30:23 +05:30
Ankush Menat
e9a6c4ab13 fix: user info error when name case mismatches 2023-09-23 15:26:31 +05:30
Ankush Menat
428d78a491 chore: move svg icons to end and correct version 2023-09-23 15:17:05 +05:30
Ankush Menat
8621e196d1
Merge pull request #22113 from gavindsouza/assets-fetch-no-get_js
perf: frappe.require
2023-09-23 15:14:05 +05:30
Ankush Menat
d7a9d0111c
perf: lazy load SVG icons (#22517)
| Metric                             | Before | After | Change    |
| ---                                | ---    | ---   | ---       |
| app.html first response size       | 421kb  | 106kb | -75% (!)  |
| First response duration            | 60ms   | 40ms  | -33%      |

huge thanks to @cogk for doing most of the work for this PR on this issue: https://github.com/frappe/frappe/issues/17449#issuecomment-1728328726

Co-authored-by: Corentin Flr <10946971+cogk@users.noreply.github.com>
2023-09-23 15:13:43 +05:30
Ankush Menat
b5d0169ca7 refactor: fetch logic
- Use _version_number which indicates when assets.json was generated.
  Files are evicted roughly at same time. metadata_version changes with
  other changes too.
- use `includes` instead of index check
- camelCase -> snake_case
- dont force caching. doesn't seem to be required. Caches without this
  header too.
2023-09-23 15:07:35 +05:30
Ankush Menat
1e19a2e4f1 Merge branch 'develop' into assets-fetch-no-get_js 2023-09-23 14:58:06 +05:30
Faris Ansari
18c4f653f4 chore: unskip restore test 2023-09-23 13:01:40 +05:30
Ankush Menat
8635daf425
fix: duplicate icons (#22516) 2023-09-23 12:51:20 +05:30
Ankush Menat
908ddad962
Merge pull request #22515 from ankush/email_rec
fix: handle poorly encoded from emails
2023-09-23 12:13:57 +05:30
Ankush Menat
f974fcabac fix: ignore poorly encoded email parts 2023-09-23 11:53:05 +05:30
Ankush Menat
59d1eefa61 refactor: move unhandled email to log settings 2023-09-23 11:23:53 +05:30
Faris Ansari
fa88f1a628 fix: resolve path instead of absolute path
#22142 made the change to absolute path but it affected file backups.
Resolve path should probably be enough in most cases.
2023-09-23 11:05:49 +05:30
David Arnold
e57dc10631
fix: rss rendering of blog entries (#22511) 2023-09-22 20:31:51 +05:30
Ankush Menat
aa413e8c9f
fix: link notification messages with communication (#22507) 2023-09-22 17:06:47 +05:30
Suraj Shetty
f374771361
Merge pull request #22191 from maharshivpatel/feat-desk-refresh 2023-09-22 12:56:11 +05:30
Maharshi Patel
a4fdc0ff80 fix(minor): change comment box color to control bg 2023-09-21 22:38:25 +05:30
Daizy Modi
3b8aca1a43
feat: provision to set_route for Custom Number Card (#21806) 2023-09-21 18:38:43 +05:30
barredterra
262bda5c91 feat: check write perms on attached to doc(type) 2023-09-21 14:53:45 +02:00
barredterra
ae77f92821 fix: render count on image capture
Immediately render total_count as "No Images", instead of displaying the
name of the HTML field (total_count).
2023-09-21 14:48:17 +02:00
Ankush Menat
4888e85df1
fix: Add more usable fieldtypes to group by (#22497)
- Autocomplete is same as select
- Dynamic link is same as link
- Date is useful too

Possible improvement `group by date(datetime)` (not part of this PR)
2023-09-21 17:49:07 +05:30
Maharshi Patel
73601cbc2a chore: remove form builder not important and flaky ui test. 2023-09-21 16:39:33 +05:30
Maharshi Patel
83c2f6e53a chore: fix linters 2023-09-21 14:56:52 +05:30
Maharshi Patel
32da8cb530 fix(minor): datatable header cell bg color 2023-09-21 13:49:24 +05:30
Maharshi Patel
8837e24d5c fix: sidebar tags as per espresso
changed frappe.ui.Tags to sidebar button to match espresso style.
2023-09-21 13:22:56 +05:30
Maharshi Patel
88329d73c7 fix: datepicker style as per espresso 2023-09-21 12:34:33 +05:30
Maharshi Patel
880030864e fix(minor): form tour driver dark theme background color. 2023-09-21 12:12:08 +05:30
Maharshi Patel
e99f07c8a3 fix(minor): dark mode checkbox disabled state. 2023-09-21 11:30:01 +05:30
Maharshi Patel
37f03069bf
Merge branch 'develop' into feat-desk-refresh 2023-09-20 22:24:33 +05:30
Maharshi Patel
9b6d6267dd fix: awesome_bar & sidebar cypress test as per espresso. 2023-09-20 22:22:44 +05:30
Corentin Flr
41d30e7213
feat: Add custom icons with the app_include_icons hook (#22254)
* feat: Add custom icons with the `app_include_icons` hook

These custom icons are available on the desk only. They can be picked in the `ControlIcon` picker.

Co-authored-by: Abraham Kalungi <85731451+kalungia@users.noreply.github.com>

* fix: skip conf for including icons

* test: Fix test_include_icons

---------

Co-authored-by: Abraham Kalungi <85731451+kalungia@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-09-20 20:23:17 +05:30
HENRY Florian
42ee7f9b2d
feat: bulk update fields select sorted by translated labels (#22318)
* feat: bulk update fields sorted translated alpha sort

* chore: implement review from @barredterra

* chore: fix linter/prettier

* fix: convert to string

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-20 18:52:21 +05:30
Ankush Menat
ff26528ab0 style: format 2023-09-20 18:16:10 +05:30
Psyi Rius
36c182e72c
chore(js): improved cryptic looking sanitise regex with info (#22357) 2023-09-20 17:39:33 +05:30
Gavin D'souza
13e04999d2
fix: Add version tag for non-bundled assets 2023-09-20 17:02:55 +05:30
Anand Baburajan
5004374ecc
chore: handle invalid connections conf for internal links (#22486)
* chore: handle invalid connections conf for internal links

* chore: remove unnecessary None
2023-09-20 11:14:51 +00:00