Commit graph

41620 commits

Author SHA1 Message Date
Shariq Ansari
602120eb8c
Merge branch 'develop' into freeze-modal-z-index 2023-04-14 17:30:30 +05:30
Shariq Ansari
477335eb4a fix: prioritize modal over freeze in grid-form 2023-04-14 17:26:24 +05:30
Wolfram Schmidt
4a7e039b87
fix: allow renaming workflow action master (#20698)
allow to rename work flow action masters will help to consolidate and make sure that typos can be corrected at ease
2023-04-14 14:53:04 +05:30
Ankush Menat
1e9ede40fa
fix: stale frappe.local (#20695)
* fix: stale `frappe.local`

Co-Authored-By: Aditya Hase <aditya@adityahase.com>

* fix: force re-init in request

To ensure that any one bad request can not completely cause recurring
loop of broken requests due to bad locals, we just force-init locals on
every request.

---------

Co-authored-by: Aditya Hase <aditya@adityahase.com>
2023-04-14 14:19:01 +05:30
Ankush Menat
76e576c83e test: fix print view test from lang 2023-04-14 09:07:00 +05:30
Raffael Meyer
652202132d
fix: remove guest permission from language (#20677)
* fix: remove guest permission from language

* fix: allow "All" to select a Language

* fix: allow "All" to read a Language
2023-04-13 18:07:28 +05:30
Anand Baburajan
b62bb8b0ec
fix: allow filter values to be saved in custom report (#20623) 2023-04-13 17:42:21 +05:30
Shariq Ansari
d635467c7e
Merge pull request #20671 from shariquerik/group-btn-overlap 2023-04-13 17:02:33 +05:30
Shariq Ansari
8a11ad3a6f
Merge branch 'develop' into group-btn-overlap 2023-04-13 16:23:57 +05:30
Suraj Shetty
8a0b7e2c79
Merge pull request #20610 from pps190/report-view-dt 2023-04-13 14:56:00 +05:30
Shariq Ansari
a342439494
Merge pull request #20682 from shariquerik/filter-with-captitalized-opearator-fix 2023-04-13 14:48:14 +05:30
Shariq Ansari
4913b679a7
Merge branch 'develop' into filter-with-captitalized-opearator-fix 2023-04-13 14:14:24 +05:30
Shariq Ansari
6b2b161876 fix: filter with capitalized operator was getting bypassed 2023-04-13 14:11:52 +05:30
Ankush Menat
cbb7c4a91c test: fix imghdr test 2023-04-13 12:47:37 +05:30
Ritwik Puri
ac351166b2
fix: pull from email account every 10 mins instead of 4 mins (by default) (#20675) 2023-04-13 12:36:14 +05:30
Ankush Menat
0cab0b830d
refactor: replace imghdr with filetype (#20680)
* refactor: replace `imaghdr` with `filetype`

```
11:52:06 worker.1      | /home/ankush/benches/develop/apps/frappe/frappe/core/doctype/file/utils.py:2: DeprecationWarning: 'imghdr' is deprecated and slated for removal in Python 3.13
```

* feat: improved extension guessing using filecontent
2023-04-13 12:19:08 +05:30
Shariq Ansari
398fe0d84f fix: group buttons are overlapping 2023-04-12 17:07:23 +05:30
Mohammad Hussain Nagaria
f46d1aefa9
refactor: use urljoin to build picture url (#20664) 2023-04-12 13:38:23 +05:30
Suraj Shetty
188b6a6fdd
Merge pull request #20665 from phot0n/log-err-email-server 2023-04-12 13:24:38 +05:30
phot0n
c7632d0e51 fix: use frappe.log_error in EmailServer exception handling 2023-04-12 13:20:32 +05:30
Ankush Menat
3e95c00fd0
fix: dont track webhook request log (#20663)
logs dont change

[skip ci]
2023-04-12 11:51:24 +05:30
Ankush Menat
c5f36a4979
fix(UX): workspace breadcrumbs based on history (#20529)
* fix(UX): Resolve breadcrumb conflicts from history

Same report can be part of 2 workspace, in which case use breadcrumbs
from last workspace.

* fix: make sure last workspace belongs to same module at least
2023-04-12 10:56:05 +05:30
Shariq Ansari
2623391e8f
Merge pull request #20658 from shariquerik/update-docfield-property-fix 2023-04-12 10:55:35 +05:30
Shariq Ansari
66df0e9abc fix: update property if field exist 2023-04-12 10:53:34 +05:30
Ankush Menat
e42c072d4a
Merge pull request #20656 from barredterra/format_timedelta
refactor: pretty_date
2023-04-12 09:52:02 +05:30
Ritwik Puri
a1396349fe
chore: translate successful redirection message in web_form 2023-04-12 00:00:53 +05:30
barredterra
44bb745035 fix: change pretty date expectations in test 2023-04-11 15:56:05 +02:00
barredterra
fcb705b41d chore: docstring for pretty_date 2023-04-11 15:50:17 +02:00
barredterra
9f1feaab02 refactor: pretty_date 2023-04-11 15:44:03 +02:00
Ankush Menat
d7b474f4ac
Merge pull request #20648 from ankush/translations_hooks_order
fix(translations)!: load translation in installed app order
2023-04-11 18:29:01 +05:30
Ankush Menat
d5a9f198ec
refactor: set docfield options without method (#20653) 2023-04-11 18:08:19 +05:30
Ritwik Puri
82ec29702e
fix: consider user email if send me a copy is checked (#20627)
* fix: consider user email if send me a copy is checked

* test(communication): test cc with include sender
2023-04-11 16:24:47 +05:30
Andrew McLeod
b898029894
fix(workflow): add whitelisted functions permissions checks (#20575)
Add permissions checks to workflow.py whitelisted functions.
2023-04-11 14:45:35 +05:30
Ankush Menat
75b32f90ab
fix: track workspace changes (#20649) 2023-04-11 14:35:48 +05:30
Ankush Menat
6fa732e2f7 test: flake in redis caching test
[skip ci]
2023-04-11 12:29:59 +05:30
Ankush Menat
0b8b829483 perf: dont cache intermediate translation files
Just caching final files for each language is enough, duplicating
doesn't help much.
2023-04-11 12:10:49 +05:30
Ankush Menat
361e44de1d fix(translations)!: load translation in installed order
- translations are loaded in apps.txt order this doesnt make much sense.
- translations are loaded from apps which aren't even installed, again
  doesn't make sense.

Breaking but necessary change.
2023-04-11 12:10:45 +05:30
Smit Vora
08732e50db
fix: better permission error for query_report (#20643) 2023-04-11 11:42:18 +05:30
Ankush Menat
c36dabbc63 chore: add removed message
Not sure why this was removed
2023-04-11 11:26:47 +05:30
Saurabh
26e73208d5
fix: validate if doctype exists before syncing customisations (#20598)
* fix: validate if doctype exists before syncing customisations

* refactor: rename and add default

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-04-11 11:24:03 +05:30
Bread Genie
6248d8f062
fix(pretty-date): plural form when the value is 1 (#20619) 2023-04-11 10:56:52 +05:30
Ankush Menat
a3a9e40aa4
fix: log requests even if no response (#20638) 2023-04-11 07:29:14 +05:30
Suraj Shetty
822fd4e37e
Merge pull request #20375 from deepeshgarg007/user_defaults 2023-04-10 14:34:29 +05:30
Deepesh Garg
c0ae00168d chore: Only run on mariadb 2023-04-10 13:58:06 +05:30
Shariq Ansari
c297924401
Merge pull request #20470 from AHasanin/fix-update-docfield-property-function 2023-04-10 13:55:01 +05:30
Patrick.St
7962505779
fix(ListView): Evaluate sort_field sort_order within listviews based on DocTypes Definition (#20482) 2023-04-10 13:49:48 +05:30
Shariq Ansari
6aa2dfbe85
Merge branch 'develop' into fix-update-docfield-property-function 2023-04-10 12:42:41 +05:30
Shariq Ansari
e5cb90bce1
Merge pull request #20541 from Jainysh/fix/20538-UI-freeze 2023-04-10 12:06:31 +05:30
Shariq Ansari
75ba9b40d8 fix: child row form should be above freeze screen
sidebar overlay was also getting affected
2023-04-10 11:42:06 +05:30
Shariq Ansari
93dafbf5ed
Merge branch 'develop' into fix/20538-UI-freeze 2023-04-10 11:14:24 +05:30