Gursheen Anand
61807dda71
fix: allow creation of workspace based on desk role perms
2024-05-30 17:35:48 +05:30
Corentin Flr
847012e415
fix(checkbox): Fix checkbox size on small screens ( #26596 )
2024-05-30 13:44:17 +05:30
Rutwik Hiwalkar
d09ef5431f
fix: kanban filters fixes ( #26605 )
...
* fix(kanban): don't concat old cards after filter
- this was messing up rendering filtered cards
* fix: refresh not working without standard fields
2024-05-30 12:38:22 +05:30
Raffael Meyer
0c01da43e9
fix: toggle full width for more than 4 columns ( #26607 )
...
Resolves https://github.com/frappe/frappe/pull/26538#issuecomment-2137092812
2024-05-30 12:37:44 +05:30
Ankush Menat
80a3bf33cf
perf: rearrange some frequent jobs ( #26591 )
...
* perf: lower frequency of not so useful jobs
* fix: 4x deferred insert frequency
2024-05-29 17:41:06 +05:30
Akhil Narang
b866ee3ef6
Merge pull request #26600 from akhilnarang/fix-number-card-formatting
...
fix(number_card): ensure value is returned
2024-05-29 16:37:48 +05:30
Akhil Narang
7695a0d2ec
fix(number_card): ensure value is returned
...
In the case of a number card based on a query report, an integer with
a very basic DF is passed, leading to the "formatted" value being just
the integer as a string, which becomes an empty string after $().text()
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-29 16:22:20 +05:30
Ankush Menat
dce308bc65
perf: memory leak on kanban refresh ( #26597 )
2024-05-29 16:05:44 +05:30
Ankush Menat
5d753251ac
Merge pull request #26592 from ankush/todo_conc
...
fix: Avoid concurrent TODO updates
2024-05-29 11:32:02 +05:30
Ankush Menat
e43205eb25
fix: Avoid concurrent TODO updates
2024-05-28 19:52:06 +05:30
Akhil Narang
aa5febfe43
Merge pull request #26570 from akhilnarang/fix-address-query-respect-custom-title
...
fix(address_query): use title field if set
2024-05-28 15:34:44 +05:30
Raffael Meyer
d5f3bb5d2a
Merge pull request #26563 from barredterra/letter-head-link
2024-05-27 17:23:18 +02:00
Marica
135713a8c0
Merge pull request #26535 from frappe/dialog-grid-add-row
...
feat: Add `on_add_row` event for grid in Dialog
2024-05-27 20:38:43 +05:30
Ankush Menat
d14e544172
fix: Don't enable submit on quick entry with workflow ( #26579 )
2024-05-27 14:44:14 +00:00
gavin
a71df1839f
fix: Drop file_manager.download_file ( #26575 )
...
Closes https://github.com/frappe/frappe/issues/26424
2024-05-27 19:30:48 +05:30
Ankush Menat
148b3f771d
build: bump RQ to latest ( #26576 )
...
* build: Bump RQ
Latest version simplifies workerpool extension a bit
* fix: Disable RQ's scheduler
It's now enabled by default with no easy way to disable it except
upstream change or overriding the run_worker method. So better to
disable it with custom worker class.
2024-05-27 13:54:34 +00:00
RitvikSardana
394227a90f
fix: text editor fields exports HTML tags ( #26571 )
...
* fix: text editor fields exports HTML tags
* fix: use html2text to preserve text structure
2024-05-27 18:26:00 +05:30
Ankush Menat
c05bc8292f
Merge pull request #26574 from ankush/broken_scheduler_sync
...
fix: Broken scheduled job type sync
2024-05-27 18:25:17 +05:30
Ankush Menat
0dfff8375c
fix: Broken scheduled job type sync
...
Jobs weren't gettng deleted if they were moved around in sections.
I feel we should just drop support for same job in multiple blocks. It's
trivial to get around this limitation by adding a separate function.
2024-05-27 17:26:11 +05:30
Akhil Narang
b0a7d62a9e
fix(address_query): use title field if set
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-27 13:56:12 +05:30
Ankush Menat
4893beee51
Merge pull request #26567 from frappe/pot_develop_2024-05-26
...
chore: update POT file
2024-05-27 13:01:00 +05:30
Ankush Menat
852dbd427f
Merge pull request #26562 from barredterra/migration-info
...
feat: increase verbosity of post_schema_updates
2024-05-27 13:00:42 +05:30
Ankush Menat
7a37c7fad7
Merge pull request #26566 from ankush/sched_merge
...
perf: Merge `worker-pool` and `scheduler`
2024-05-27 12:42:39 +05:30
Ankush Menat
d13178755b
refactor: keep scheduler+worker behaviour to workerpool
...
- Single worker adds some extra costs to each worker (importing scheduler)
- Workerpool can import it all once and share
- This way we need not have many different
2024-05-27 12:29:41 +05:30
Ankush Menat
59bbbd7b56
perf: optimize scheduling
...
- Randomize scheduling order
- Cache dormant status for 1 hour (this gets checked every second, too much work)
2024-05-27 12:21:11 +05:30
Ankush Menat
433e7281f7
feat: make running scheduler with worker optional
2024-05-27 12:14:15 +05:30
frappe-pr-bot
d6d3a511b9
chore: update POT file
2024-05-26 09:33:22 +00:00
Ankush Menat
f7ff829ea7
perf: Merge worker and scheduler
2024-05-26 12:44:00 +05:30
Ankush Menat
43c8ae0049
fix: Duplicate scheduled jobs run forever ( #26565 )
...
If same method is added in multiple places our code just finds 1 random
scheduled job type and updates it as "ran", in some unlucky situations
this behaviour won't be random and always run one and update another so
the job never gets marked as "ran" and keeps running on every tick.
2024-05-26 06:49:20 +00:00
Raffael Meyer
d18f743d39
Merge pull request #26327 from frappe/l10n_develop
...
fix: sync translations from crowdin
2024-05-25 18:37:39 +02:00
Frappe PR Bot
b725d7bc73
fix: Turkish translations
2024-05-25 06:42:39 +05:30
barredterra
bb7e1eb4ec
fix: apply user permissions on letter head
2024-05-24 16:03:15 +02:00
barredterra
223ad14c15
fix: use link field for letter head
2024-05-24 16:01:49 +02:00
barredterra
e041603aca
feat: increase verbosity of post_schema_updates
2024-05-24 15:48:00 +02:00
marination
985199913e
fix: Appropriate variable name, avoid redefining parameter
2024-05-24 13:37:58 +02:00
KlausH09
6b0d9e4bb2
fix: child table field wildcard in API ( #26543 )
2024-05-24 10:31:05 +00:00
Raffael Meyer
4a7de16019
fix: don't automatically add system manager ( #26540 )
...
* fix: don't automatically add system manager
* feat: remove User.a_system_manager_should_exist
* feat: remove User.add_system_manager_role
* feat: remove User.is_system_manager_disabled
* feat: remove User.get_other_system_managers
* feat: add "System Manager" role to User created by setup wizard
2024-05-24 08:29:30 +00:00
Rutwik Hiwalkar
7e18910dbd
fix: append download button to body and cleanup after click ( #26544 )
2024-05-24 08:24:08 +00:00
Raffael Meyer
551a520052
feat: kanban style ( #26538 )
...
* fix(Kanban): hide sidebar toggle
* fix(Kanban): toggle full-width if more than five columns are visible
* fix(Kanban): show correct cursor on column header
* fix(Kanban): increase column height, add margin
* fix(Kanban): increase card padding
* feat(Kanban): set column background based on indicator
* fix(Kanban): add-button background color
* feat(Kanban): grow columns if there's leftover space
* fix(Kanban): space between columns
2024-05-24 13:32:56 +05:30
Rutwik Hiwalkar
3e8765d5d1
fix(ui_test): reload page after login instead of redirecting to /app ( #26551 )
...
- navigating to /app does an absolute navigation in cypress and doesn't
forward url args
2024-05-24 13:08:31 +05:30
Ankush Menat
750b70b075
refactor: Wrap meta in v2 ( #26548 )
2024-05-24 06:05:09 +00:00
Frappe PR Bot
82aca3fde4
fix: Turkish translations
2024-05-24 06:15:56 +05:30
Frappe PR Bot
72acee102a
fix: Turkish translations
2024-05-23 06:09:44 +05:30
Rutwik Hiwalkar
75412ba872
Merge pull request #26514 from rutwikhdev/fix-download-redirect
...
fix: download file instead of open in new window
2024-05-22 19:04:21 +05:30
Rutwik Hiwalkar
5cdad43d23
Merge pull request #26515 from rutwikhdev/fix-imageview
...
fix: misc fixes in image view
2024-05-22 19:04:00 +05:30
Rutwik Hiwalkar
f95d7ace1e
fix(style): remove bg-color override for datatable ( #26497 )
2024-05-22 19:03:31 +05:30
Ankush Menat
9e9e72bce5
fix: reload before saving on reconnect ( #26534 )
...
The doc we have might be "in future".
2024-05-22 16:31:07 +05:30
marination
6f6e429ab2
feat: Add on_add_row event for grid in Dialog
...
- This can be used to manipulate data and add presets to the grid dynamically
2024-05-22 12:48:39 +02:00
gavin
ea6a47df94
fix: Redirect to Login Page if not signed In ( #26506 )
...
Redirect to Login page if User is not logged in already. Upon successful login, redirect to the page they intended to see.
This is a common pattern for opening tabs to previous sessions where Users get logged out and are shown the "Log in to access this page." message instead.
2024-05-22 15:49:59 +05:30
Ankush Menat
005e74b20d
perf: Avoid coalesce for between filters ( #26531 )
...
- Avoid on `between` + date
- Avoid on timestamp fields
- Avoid on `>` and `>=` comparisons
2024-05-22 09:32:59 +00:00
