Commit graph

43073 commits

Author SHA1 Message Date
barredterra
62e4df8a1f feat(File Uploader): open file details from search 2023-08-18 14:06:05 +02:00
mergify[bot]
06ba61ff97
Merge pull request #22064 from barredterra/assignment-rule-on-change
fix(Assignment Rule): also run `on_cancel` and `on_update_after_submit`
2023-08-17 14:44:23 +00:00
Ankush Menat
c7847395da
fix: remove thread-unsafe class attributes (#22097)
The problem is same as mutable defaults. Container type class attributes
are mutable and shared between all objects.

```python
class CLS:
    attr = {}
    ...

a = CLS()
b = CLS()

a.attr is b.attr  # => True
```
2023-08-17 20:11:20 +05:30
barredterra
68d984dbb2 fix(Assignment Rule): run on additional events
- on_cancel
- on_update_after_submit
2023-08-17 13:10:03 +02:00
Ankush Menat
7af8f6a8ff
refactor: replace usage of mktemp (#22093) 2023-08-17 11:03:02 +00:00
barredterra
63aded91f9 Revert "fix: run assignment rule on change"
This reverts commit 88cbba5f21.
2023-08-17 13:02:41 +02:00
Shariq Ansari
f796ed04ef
Merge pull request #22089 from maharshivpatel/fix-grid-last-row-css
fix(minor): grid row layout on small viewport
2023-08-17 13:53:00 +05:30
Maharshi Patel
fb62a22cd9 fix: hide "Edit" text on md viewport
hide text on md viewport and add min-width of 0 instead of 50px
2023-08-17 13:48:42 +05:30
Maharshi Patel
4d88daac66 fix(minor): grid row layout on small viewport
on small viewports header and body rows were not aligned due to "Edit" text.
2023-08-17 12:43:08 +05:30
Ankush Menat
48f72655ad
feat(dx): Run gunicorn in development setup (#22088)
This lets developer run gunicorn in development setup while still being
able to use statics/assets.

While this is not "first class" support, it's usable for me. I don't see
need for more right now. Making this default in developer mode isn't
ideal IMO as it's quite heavy compared to werkzeug (and no debugger or
decent request logging)

To use in development mode swap `bench serve` with gunicorn command,
refer gunicorn config docs for more info.

```diff
- web: bench serve --port 8000
+ unicorn: gunicorn -b 127.0.0.1:8000 -w 1 --chdir /home/user/benches/develop/sites 'frappe.app:application_with_statics()' --preload
```

`no-docs`
2023-08-17 11:34:45 +05:30
Ankush Menat
79392260d4
fix: autoincr caching and clear site cache after restore (#22079)
* fix: remove hazardous cache for autoincr

* fix: move cache to redis

* fix: clear all redis cache after restoring a site
2023-08-17 11:11:27 +05:30
Ankush Menat
4649c8dacf
build(deps): Bump gunicorn to latest version (#22086) 2023-08-17 11:11:01 +05:30
bVisible
88c2e64899
fix: translation of buttons in the Form tour (#22055) 2023-08-17 10:51:27 +05:30
Suraj Shetty
4dad5428cf
Merge pull request #22084 from surajshetty3416/dynamic-routes-hook 2023-08-17 09:51:45 +05:30
Suraj Shetty
77e5ad26fe
Merge pull request #21819 from marination/attachments-access 2023-08-17 09:46:30 +05:30
Suraj Shetty
5d85341984 feat: Hook to add dynamic routes for other web view doctypes 2023-08-17 09:30:24 +05:30
Deepesh Garg
112836dcd7
chore: Provision to ignore prepared report via route options (#22077) 2023-08-16 20:18:57 +05:30
Corentin Flr
274ffe8d68
fix(link_selector): Fix page_length value (#22076)
cbe4da6437/frappe/desk/search.py (L60)
2023-08-16 20:18:06 +05:30
Shariq Ansari
1c72218eba
Merge pull request #21913 from barredterra/close-assignment-from-sidebar 2023-08-16 18:17:15 +05:30
barredterra
f6ca94705e fix: don't show closed assignments in list view 2023-08-16 11:56:01 +02:00
Raffael Meyer
cd56c6aaec
fix: faster transition and improved button style
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2023-08-16 11:46:04 +02:00
Shariq Ansari
cbe4da6437
Merge pull request #22073 from shariquerik/remove-unused-fields 2023-08-16 13:49:12 +05:30
Shariq Ansari
ac775c0e68 fix: removed duplicate doctype_properties from customize form 2023-08-16 13:46:52 +05:30
Shariq Ansari
8e3ebc5948
Merge pull request #22006 from HarryPaulo/fix-button-more 2023-08-16 11:46:38 +05:30
Ankush Menat
06b86206ef
ci: make auto-merge work with skipped tests (#22070) 2023-08-16 05:55:55 +00:00
Ankush Menat
3094d7d145
Merge pull request #22067 from barredterra/rfq-button-styling
fix: button link styling in quill
2023-08-16 11:12:15 +05:30
barredterra
3b0fdd8104 fix: button styling in quill 2023-08-15 20:35:43 +02:00
barredterra
7c38dac8ee Merge remote-tracking branch 'upstream/develop' into close-assignment-from-sidebar 2023-08-15 18:45:17 +02:00
Raffael Meyer
1331fa6f72
Merge pull request #22053 from barredterra/hide-doctype-sections 2023-08-15 16:04:04 +02:00
barredterra
c1901dbf72 test: assignment rule on_submit / cancel 2023-08-15 15:17:15 +02:00
barredterra
88cbba5f21 fix: run assignment rule on change 2023-08-15 14:01:40 +02:00
barredterra
2ad4b2ad53 fix(DX): hide irrelevant sections in DocType
If the DocType is a child table, hide sections "Form Settings",
"View Settings", "Web View", "Actions", "Linked Documents",
"Email Settings" and "Document States".
2023-08-14 17:36:32 +02:00
Shariq Ansari
a7afb5170e
Merge pull request #22049 from shariquerik/restrict-creation-fix 2023-08-14 18:27:05 +05:30
Shariq Ansari
f6aafb68cd fix: do not allow to create dashbaord chart, number card if doesn't have access 2023-08-14 16:37:50 +05:30
Ankush Menat
379690fb10 fix: skip notification log in read only mode 2023-08-14 16:11:53 +05:30
David Arnold
1a061d4590
fix: rely on pyenv to collect bench commands, however that may be set up (#21975) 2023-08-14 15:02:32 +05:30
Shariq Ansari
3796a530d0
Merge pull request #22044 from shariquerik/multiple-total-in-print 2023-08-14 14:39:57 +05:30
Shariq Ansari
6e8fdb9e2c fix: tree report has 2 total rows while printing it 2023-08-14 14:01:41 +05:30
Raffael Meyer
bd7072f9ff
refactor: get_system_users (#21992) 2023-08-14 13:58:55 +05:30
Raffael Meyer
d6dfe6f0fe
fix(Web Form): redirect countdown (#22032) 2023-08-14 13:57:12 +05:30
gavin
943b09dde3
fix: Don't show online/offline alerts when tab not active (#22039)
[skip ci]
2023-08-14 12:30:12 +05:30
Shariq Ansari
0a5db95b41
Merge pull request #21993 from barredterra/use-existing-fullname 2023-08-14 11:29:56 +05:30
Ankush Menat
8d5d371ba8 chore: off by one error in site age 2023-08-14 10:25:11 +05:30
Jannat Patel
cd2f2df303
fix: controls loading for discussions (#22037) 2023-08-14 10:21:09 +05:30
Ankush Menat
a3c7358f66 fix: check permission on autorepeat 2023-08-13 18:27:34 +05:30
Ankush Menat
4d5a945861
refactor: reduce duplication in unsafe attr checks (#22033) 2023-08-13 18:23:41 +05:30
Ankush Menat
74d78dafce chore: dont render query as reqd/bold
[skip ci]
2023-08-13 17:20:58 +05:30
Ankush Menat
ce1355dab8
fix: block format attributes (#22028) 2023-08-12 22:12:30 +05:30
Ankush Menat
16aa414fda fix: flush telemetry before ending background job 2023-08-12 12:13:59 +05:30
Ankush Menat
19d33a9a88
fix: fair-er scheduling for multitenant deploys (#22022) 2023-08-12 10:55:35 +05:30