Commit graph

38513 commits

Author SHA1 Message Date
Ankush Menat
69b7c72be8 fix: kanban board from shared links
- Apply filter from URL
- Update URL in browser when filters change
2022-06-17 19:45:34 +05:30
Ankush Menat
b3b3829912 fix: don't forget 'like' filters
Currently like filters get reset if field is part of standard filters
2022-06-17 19:43:26 +05:30
Ankush Menat
f4e8dee669 fix: double urlencoding of values
This was breaking URLs for complex filters
2022-06-17 19:43:26 +05:30
Ankush Menat
813793a700 fix: view routing from URL query paramters 2022-06-17 19:43:21 +05:30
Ankush Menat
e0e0c6f219 fix: remove query params from existing URL 2022-06-17 19:29:40 +05:30
Ankush Menat
23bd9749f6 feat(UX): refresh URL when updating filters 2022-06-17 19:29:40 +05:30
Suraj Shetty
bd2f2bcae9
Merge pull request #17233 from surajshetty3416/fix-first-tab
fix(tabs): Set first visible tab as active
2022-06-17 19:26:07 +05:30
Suraj Shetty
ee7cb22cd6 fix: Remember active tab for a document in a browsing session 2022-06-17 18:17:54 +05:30
Suraj Shetty
3f2901d837 fix: Check if visible tab exists 2022-06-17 16:56:11 +05:30
Suraj Shetty
05ea37c779 fix: Set first visible tab as active 2022-06-17 16:16:58 +05:30
Ankush Menat
8c6d266fad fix: can't select dynamic link on address doctype 2022-06-17 14:43:02 +05:30
Himanshu
6d6a67e9e3
feat: set image as footer in letter head (#17119)
* feat: set image as footer in letter head

* fix: do not hide footer section

* fix: hide footer source

* style: black

* fix: reduce code for setting image as html

* fix: Force system admin role only if active

* fix(ui): tab refresh was not implemented

* fix(minor): Onboarding: add option to view list view in create action

* fix(minor): js lint

* fix: allow All to select a User

* test: user permissions affecting User

* refactor: filter_dynamic_link_doctypes API

* Added typing, better variable naming
* Remove unnecessary re-iterations
* Optimize queries and membership processing

* perf: Check query type via is_query_type

* chore: Drop duplicate get_frontmatter definition

* perf: Login Page

Improves performance 3x - from 0.047s to 0.017s

* Use frappe.get_*_settings to query table once
* Use cached LDAP Settings' document via get_ldap_client_settings
* Use single get_all to query all Social Login providers and related
  data
* Skip provider if client_secret doesn't exist

* perf: About Us Settings

Use cached document for building /about page

* perf: App Page

Reduced time taken for get_context to execute from 0.035s to 0.02s (75%
reduction)

* perf: Patch qb only once - not on every init

* perf: Fetch and cache entire settings' dicts

* refactor!: frappe.db.get_singles_dict

* Cast single's values as their fieldtypes before returning
* Support previously dead debug parameter
* Consider single with no meta as non-existent; skip query

Decided to go ahead with the breaking change given the nature of the
existing usages of get_singles_dict :crie:

* ci: Run tests bypassing roulette with labels "Run UI Tests", "Run Server Tests"

* test: Scheduler tests cleanup

* chore: linter changes

* chore: linter changes

* chore: linter changes

* fix: set HTML as default

to keep existing formats working

* refactor: no **kwargs

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Rushabh Mehta <rmehta@gmail.com>
Co-authored-by: Gavin D'souza <gavin18d@gmail.com>
2022-06-17 12:07:07 +05:30
Suraj Shetty
9ebe3e70ea
Merge pull request #17212 from surajshetty3416/add-more-instance-for-UI 2022-06-17 10:24:30 +05:30
Suraj Shetty
7b328e85c9
Merge branch 'develop' into add-more-instance-for-UI 2022-06-17 09:21:15 +05:30
Ritwik Puri
335edc14f3
fix: number card ui inconsistencies (#17160) 2022-06-16 20:25:01 +05:30
Shariq Ansari
5ca7d6fab9
Merge branch 'develop' into add-more-instance-for-UI 2022-06-16 17:45:35 +05:30
Suraj Shetty
5db7716df2
Merge pull request #17223 from frappe/rpm_typo 2022-06-16 16:20:27 +05:30
Michelle Alva
86f9465432
chore: typo 2022-06-16 16:16:00 +05:30
Suraj Shetty
24324dbced
Merge pull request #17221 from frappe/dependabot/github_actions/bruceadams/get-release-1.2.3
build(deps): bump bruceadams/get-release from 1.2.0 to 1.2.3
2022-06-16 15:59:48 +05:30
dependabot[bot]
27b0b3669d
build(deps): bump bruceadams/get-release from 1.2.0 to 1.2.3
Bumps [bruceadams/get-release](https://github.com/bruceadams/get-release) from 1.2.0 to 1.2.3.
- [Release notes](https://github.com/bruceadams/get-release/releases)
- [Commits](https://github.com/bruceadams/get-release/compare/v1.2.0...v1.2.3)

---
updated-dependencies:
- dependency-name: bruceadams/get-release
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-06-16 10:24:59 +00:00
Suraj Shetty
717ad9e2ec
Merge pull request #17120 from turrisxyz/Dependabot-GitHub-Actions 2022-06-16 15:54:22 +05:30
Suraj Shetty
faf085a420
Merge pull request #17211 from shariquerik/daterange-fix 2022-06-16 15:34:06 +05:30
Suraj Shetty
40e7d9b824
Merge pull request #17217 from phot0n/fix-integration-req-patch 2022-06-16 15:24:59 +05:30
Suraj Shetty
6c36b7251c
Merge branch 'develop' into add-more-instance-for-UI 2022-06-16 15:22:28 +05:30
phot0n
782fb801ec fix: ignore if integration_type column doesn't exist (for direct v14 installations) for integration request patch 2022-06-16 14:43:32 +05:30
Shariq Ansari
590d511618
Merge branch 'develop' into daterange-fix 2022-06-16 14:35:32 +05:30
Suraj Shetty
bb0a9bc3a9
Merge pull request #17177 from ruchamahabal/fix-event-streaming 2022-06-16 14:21:35 +05:30
Ankush Menat
a7f9c2a672 chore: remove migrate 2022-06-16 14:10:01 +05:30
Ankush Menat
1c385826ef test: make sure all patches are in patch.txt 2022-06-16 14:10:01 +05:30
Ankush Menat
214be6a7e8 chore: discard stale patches, add relevant ones to patches.txt 2022-06-16 14:10:01 +05:30
Shariq Ansari
d9e848ef88 test: added UI test for date range control 2022-06-16 13:00:34 +05:30
Suraj Shetty
b0503fc839
Merge branch 'develop' into add-more-instance-for-UI 2022-06-16 12:25:09 +05:30
Suraj Shetty
6cebacaf6f ci: Update mergify.yml 2022-06-16 12:07:55 +05:30
Suraj Shetty
1298b39bb3 ci: Add one more instance for faster UI tests execution 2022-06-16 12:07:19 +05:30
Shariq Ansari
42f3013699 fix: daterange value not updating 2022-06-16 11:35:58 +05:30
Ankush Menat
f7e00633b9 chore: useless flake8 warnings 2022-06-15 17:27:04 +05:30
Suraj Shetty
c7e89267cc
Merge pull request #17151 from phot0n/fix-format-date-dashboard-charts 2022-06-15 16:26:20 +05:30
gavin
dc7100757c
Merge pull request #17200 from gavindsouza/fix-qb-patched
fix: Patch qb for different schemas in same process
2022-06-15 16:15:37 +05:30
Suraj Shetty
444c2db1c4
Merge pull request #17124 from s-aga-r/fix/user-type 2022-06-15 16:13:31 +05:30
Suraj Shetty
77a6c103ec test: Fix dashboard chart test cases 2022-06-15 16:11:55 +05:30
Ankush Menat
8436acbecb
Merge pull request #17174 from gavindsouza/pyproject-filt
build!: Declarative builds via pyproject.toml
2022-06-15 16:10:41 +05:30
Suraj Shetty
2568e8a1ac
Merge branch 'develop' into fix-format-date-dashboard-charts 2022-06-15 16:03:02 +05:30
Gavin D'souza
36fa2122a3 fix: Patch qb for different schemas in same process
You would want to switch schemas in the same process. Eversince the
change
64e5273764
we stopped patching on every frappe.init call which meant, if a MariaDB
site was initialized first, frappe._qb_patched would be set to True and
if a Postgres site was initialized after, _qb_patched would be lying as
the PG engine isn't patched yet. Sooooo we need a Dict instead to
maintain this record of patching. This issue caused weird errors lol -

Traceback:

  File "/home/frappe/Desktop/frappe-bench-dev/env/lib/python3.10/site-packages/click/decorators.py", line 21, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/commands/__init__.py", line 29, in _func
    ret = f(frappe._dict(ctx.obj), *args, **kwargs)
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/commands/site.py", line 524, in migrate
    SiteMigration(
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/migrate.py", line 169, in run
    self.setUp()
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/migrate.py", line 73, in setUp
    clear_global_cache()
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/cache_manager.py", line 102, in clear_global_cache
    clear_website_cache()
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/website/utils.py", line 374, in clear_website_cache
    clear_cache(path)
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/website/utils.py", line 369, in clear_cache
    for method in frappe.get_hooks("website_clear_cache"):
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/__init__.py", line 1440, in get_hooks
    hooks = _dict(_load_app_hooks())
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/utils/caching.py", line 57, in wrapper
    return_val = func(*args, **kwargs)
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/__init__.py", line 1407, in _load_app_hooks
    apps = [app_name] if app_name else get_installed_apps(sort=True)
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/utils/caching.py", line 57, in wrapper
    return_val = func(*args, **kwargs)
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/__init__.py", line 1374, in get_installed_apps
    installed = json.loads(db.get_global("installed_apps") or "[]")
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/database/database.py", line 917, in get_global
    return self.get_default(key, user)
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/database/database.py", line 921, in get_default
    d = self.get_defaults(key, parent)
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/database/database.py", line 938, in get_defaults
    defaults = frappe.defaults.get_defaults(parent)
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/defaults.py", line 88, in get_defaults
    globald = get_defaults_for()
  File "/home/frappe/Desktop/frappe-bench-dev/apps/frappe/frappe/defaults.py", line 218, in get_defaults_for
    frappe.qb.from_(table)
TypeError: 'Field' object is not callable
2022-06-15 15:55:43 +05:30
Suraj Shetty
675e72506c
Merge pull request #17132 from nabinhait/minor-fixes 2022-06-15 15:42:56 +05:30
gavin
6c8b22a5d5
Merge branch 'develop' into pyproject-filt 2022-06-15 15:25:55 +05:30
Gavin D'souza
21bad02b72 ci: Remove dependency on requirements.txt for builds 2022-06-15 15:25:26 +05:30
Gavin D'souza
59ab6531c9 ci: Invalidate GHA pip cache on pyproject or setup changes
- Cache invalidated if any of the files change: *requirements.txt,
pyproject.toml, setup.py or setup.cfg
- Updated boilerplate for new apps too
2022-06-15 15:05:37 +05:30
Ankush Menat
5affa2248d
fix: pass parent doctype on client.get_value (#17196) 2022-06-15 14:59:25 +05:30
Suraj Shetty
b638291b5d
Merge pull request #17189 from frappe/mergify/copy/develop/pr-17116
fix: no add/change image-field if user is not allowed (copy #17116)
2022-06-15 14:14:52 +05:30
Ankush Menat
b36bf64261
chore: revert naming to default (#17194) 2022-06-15 13:35:21 +05:30