Suraj Shetty
6bbd8fcb32
fix: Filter notes with notify_on_login and not notify_on_every_login
2022-07-20 13:16:51 +05:30
Suraj Shetty
d5bf9b60e0
fix: Query for unseen notification
2022-07-20 10:36:40 +05:30
Ankush Menat
066d5a4245
Merge pull request #17528 from phot0n/mis-fixes-goauth
...
fix: misc fixes (google oauth)
2022-07-19 15:55:24 +05:30
Shariq Ansari
a50e0ffa08
refactor: Webform ( #17232 )
2022-07-19 15:52:15 +05:30
gavin
cf7cb387f3
Merge pull request #17439 from gavindsouza/ldap-user_type
...
feat: Allow setting "User Type" for LDAP user creation
2022-07-19 15:40:49 +05:30
Raffael Meyer
2bf14bb29f
fix: translate page numbers ( #17492 )
2022-07-19 15:38:17 +05:30
Nabin Hait
31ef1c7355
perf: option to skip realtime notify update after insert ( #17543 )
...
While doing optimization for the period closing voucher, found that `notify_update` takes a significant amount of time to execute (200 seconds in this case), even though it was not required at all in this specific case (insert of GL Entry). That's why made the function optional by using a flag.
Related PR: https://github.com/frappe/erpnext/pull/31626
2022-07-19 09:53:04 +00:00
gavin
50a8cc8068
Merge branch 'develop' into ldap-user_type
2022-07-19 15:01:59 +05:30
Gavin D'souza
c55bb98482
test: LDAP test for website user creation
2022-07-19 15:01:16 +05:30
Gavin D'souza
c7726d6394
fix: Pick default_role for Sytem User type only
2022-07-19 15:00:23 +05:30
Ankush Menat
21a7291d00
ci: Stripped down config for Semantic checks ( #17542 )
...
* ci: Stripped down config for Semantic checks
Conventional commit enforces too many pointless rules, all we care about
is type and subject.
* ci: auto merge on commit pass
2022-07-19 14:32:34 +05:30
Ankush Menat
4eb1fe74a5
chore: dont fetch full repo
...
In most cases we need 10-50 previous commits. Checking out full repo is
time consuming and not required.
2022-07-19 12:03:18 +05:30
Ankush Menat
8ac7e32214
ci: check commit messages with commitlint ( #17541 )
2022-07-19 11:50:48 +05:30
mergify[bot]
6f8be47ff9
Merge pull request #17300 from resilient-tech/encrypt-otp-secrets
...
feat: encrypt 2FA secrets
2022-07-19 05:08:26 +00:00
mergify[bot]
7a7693e60f
Merge pull request #17466 from resilient-tech/remove-client.set_default
...
fix!: allow system managers to toggle email queue
2022-07-19 02:17:48 +00:00
Sagar Vora
4b0a9da400
refactor: rename hold_queue to suspend_email_queue
2022-07-18 22:32:12 +05:30
Sagar Vora
9a7f92ca1d
fix!: allow system managers to toggle email queue
2022-07-18 16:53:49 +00:00
Sagar Vora
d6f3e2935f
Merge branch 'develop' into encrypt-otp-secrets
2022-07-18 16:47:11 +00:00
Sagar Vora
a822092211
fix: remove redundant condition
2022-07-18 22:16:25 +05:30
Shariq Ansari
04f4fd8cfc
fix: Redirect to comment in the doc comment section ( #17538 )
2022-07-18 22:00:54 +05:30
mergify[bot]
f4a82e4b85
Merge pull request #17527 from kid1194/develop
...
Updating the Arabic part of the datepicker_i18n.js file
2022-07-18 14:22:59 +00:00
Shariq Ansari
330fef15ab
Merge branch 'develop' into develop
2022-07-18 19:27:56 +05:30
Ankush Menat
afba6a4815
Merge pull request #17520 from ankush/country_specific_short_numbers
...
feat: country specific number shortening in charts
2022-07-18 19:06:20 +05:30
Vladislav
dcbf320b8b
fix: update ru translation ( #17512 )
2022-07-18 18:44:35 +05:30
Ankush Menat
44630f5f62
feat: country specific number shortening in charts
2022-07-18 18:43:50 +05:30
Ankush Menat
3304e1c222
chore: bump frappe-charts to latest
2022-07-18 18:39:41 +05:30
Ankush Menat
66c77f30dd
fix: chart wrapper padding
...
This is close to the card boundary and looks ugly when numbers on Y axis
start colliding with it.
2022-07-18 18:39:24 +05:30
gavin
ee36942b76
Merge branch 'develop' into ldap-user_type
2022-07-18 18:22:46 +05:30
Gavin D'souza
26f4654b31
test: Check user role & type updated via LDAP
2022-07-18 18:22:12 +05:30
Ritwik Puri
0414d05ece
Merge pull request #17522 from phot0n/fix-page-not-created
...
fix: add default system manager role when changing from child to non-child table doctype
2022-07-18 18:17:03 +05:30
phot0n
943334a90c
chore: fix docstrings
2022-07-18 17:47:57 +05:30
Gavin D'souza
a588879094
refactor(minor): LDAP Settings Test Suite
...
* Re-write blocks for better readability
* De-indent everything
* Add typing, etc
2022-07-18 17:30:04 +05:30
Ankush Menat
59fff76cb3
fix(dx): word wrap in script diffview
...
Helpful for devs who write >120 character long code. 💩
[skip ci]
2022-07-18 16:48:30 +05:30
Ankush Menat
a98e47150f
feat(tiny): frappe.log -> frappe.log for server scripts
...
This it already whitelisted but in global scope.
[skip ci]
2022-07-18 16:27:28 +05:30
gavin
155a7c2343
Merge branch 'develop' into ldap-user_type
2022-07-18 15:41:10 +05:30
Ankush Menat
1a7a21bbe5
fix(UX)!: respect no filters set by user
...
Currently if user resets a filter and comes back to same view default
filters get populated. This is annoying behaviour especially since this
is already saved in user setting.
Fix: Always respect user's preference, if their last choice was no
filters then load view without filters.
2022-07-18 15:31:29 +05:30
Ankush Menat
b73899e99d
feat: frappe.utils.debug.watch_property to debug JS
...
This util adds a watcher on any JS object for purpose of debugging,
whenever the property changes a console trace is generated. A custom
callback function can also be passed if required.
Usage:
```javascript
filters = {}
frappe.utils.debug.watch_property(filters, "company");
// any changes to company key on filters object from now on will print a
console trace
```
only for debugging, make sure to not commit it in codebase! :)
debug
2022-07-18 15:31:29 +05:30
Ankush Menat
29c855b028
fix: db.get_value -> db.get_single_value ( #17531 )
...
db.get_value for singles returns string type always, this is confusing
behaviour, db.get_single_value should be used instead.
semgrep rule: https://github.com/frappe/semgrep-rules/pull/16
2022-07-18 15:10:49 +05:30
Ritwik Puri
de31c9f7a9
Merge branch 'develop' into fix-page-not-created
2022-07-18 12:01:39 +05:30
phot0n
1fd47f1c10
chore: remove unused no_remaining field from email account doctype
2022-07-18 10:53:27 +05:30
phot0n
404e9ab4e6
minor: add auto fetch for updating used_oauth field in User Email doctype
...
(when added a user email manually)
2022-07-18 10:53:27 +05:30
mergify[bot]
a344d89459
Merge pull request #17530 from frappe/ankush-patch-1
...
perf(DX): add watchdog as developer dependency
2022-07-18 04:16:33 +00:00
phot0n
f679dc3fdd
fix(security): restrict the god google callback
...
the common google callback can be used to trigger any method in the whole codebase
restrict it by only allowing domain specific callback method and raise
an error if the domain is not found
2022-07-17 21:37:21 +05:30
phot0n
8edae2ce09
fix: encrypt access_token when setting in db after refreshing access_token
2022-07-17 21:35:06 +05:30
Ankush Menat
55fb8acafa
perf(DX): add watchdog as developer dependency
...
Werkzeug reloader is right now using an inefficient `stat` based reloader which is horrible on large codebases with low-powered devices.
Difference:
- `stat` based reloader basically checks each and every file if they have changed or not.
- watchdog subscribes to platform specific change events on kernel (like kqueue, fsevents or inotify )
2022-07-17 20:07:05 +05:30
Amin Ahmed
454766c263
Update datepicker_i18n.js
2022-07-15 21:17:34 +03:00
phot0n
5738676b46
fix: use on_update hook instead of after_save and after_insert
...
after_save hook doesn;t exist so using that triggers nothing
2022-07-15 19:24:56 +05:30
phot0n
ddbbc0ef8d
fix: add default system manager role when changing from child to non-child table doctype
2022-07-15 19:16:14 +05:30
Ankush Menat
c200f5b3ae
ci: check build requirement before setting up python
...
[skip ci]
2022-07-15 12:03:47 +05:30
Ankush Menat
1f0e019e89
fix(UX): correct message for empty prepared report ( #17517 )
2022-07-14 19:02:19 +05:30
