Ankush Menat
6ce7444669
refactor: generic callback manager
2023-06-03 18:44:19 +05:30
Ankush Menat
680cf73cba
fix: link_count
...
This didn't work correctly, if link_count is present in cache it would
just read and dump it back in.
This has practically never worked correctly.
2023-06-03 18:44:19 +05:30
Ankush Menat
3f1c66de10
refactor: move flush_local_link_count to hook
2023-06-03 18:44:19 +05:30
Ankush Menat
ccc107b41f
test: use db.before_commit
2023-06-03 18:44:19 +05:30
Ankush Menat
6519651002
refactor: change implementation of enqueue_after_commit
...
if enqueue_after_commit then pass partial function after commit instead
of storing it in flags. SLIGHTLY less efficient, but uses consistent API.
2023-06-03 18:44:19 +05:30
Ankush Menat
b3d370a0b1
refactor!: remove rollback_observers
...
use `frappe.db.after_rollback.add` instead
2023-06-03 18:44:19 +05:30
Ankush Menat
7e9ef00bea
refactor!: Remove frappe.db.add_before_commit
...
Not used anywhere, use `frappe.db.before_commit.add()` instead.
2023-06-03 18:44:19 +05:30
Ankush Menat
235e4855c2
feat: DBHooks to run things before/after commit/rollback
...
This is a common pattern which is implemented in inconsistent and undocumented ways using these:
- `frappe.local.rollback_observers`
- `frappe.flags.enqueue_after_commit`
- `frappe.local.realtime_log`
- `frappe.local.before_commit`
- `flush_local_link_count`
Instead new simple api:
- Simple function call `frappe.db.after_commit.run(function)`
- If you need args just pass partial function `frappe.db.after_commit.run(lambda: frappe.clear_cache(doctype, name)`
2023-06-03 18:44:19 +05:30
Shariq Ansari
a049b7f9cf
Merge pull request #21220 from shariquerik/multiple-webform-for-same-doctype
2023-06-03 17:50:37 +05:30
Shariq Ansari
38513ccac5
Merge branch 'develop' into multiple-webform-for-same-doctype
2023-06-03 17:27:01 +05:30
Shariq Ansari
042595ca92
fix: handle multiple webform for same doctype
2023-06-03 16:52:51 +05:30
Ankush Menat
5185374f72
refactor!: Remove dynamic addition of _comments ( #21217 )
...
This isn't required anymore, was added to handle old sites.
2023-06-02 21:57:58 +05:30
Ankush Menat
cb885a86ae
feat: allow clearing view logs
...
These dont need to exist for eternity. Let site admins decide when to
drop them.
2023-06-02 17:32:33 +05:30
Ankush Menat
f12773487a
Merge pull request #21206 from resilient-tech/attach-formatter
...
feat: formatter for `Attach` and `Attach Image` fields
2023-06-02 16:57:01 +05:30
Ankush Menat
691cbd6da7
chore: remove select from ddl prefix
2023-06-02 16:39:58 +05:30
Shariq Ansari
1d0078038d
Merge pull request #21209 from shariquerik/workspace-minor-fix
2023-06-02 16:19:59 +05:30
Shariq Ansari
ac95b7496b
fix: do not render custom cards if workspace does not contain content
2023-06-02 16:16:39 +05:30
Sagar Vora
cad6f938c1
feat: formatter for Attach and Attach Image fields
2023-06-02 14:28:48 +05:30
Sagar Vora
f65198fba3
chore: ignore formatting commit
...
[skip ci]
2023-06-02 14:28:04 +05:30
Sagar Vora
f223bc0249
chore: fix formatting in user.py
2023-06-02 14:26:50 +05:30
Suraj Shetty
e2403cc12b
Merge pull request #21204 from JeansReal/develop
2023-06-02 13:02:38 +05:30
Suraj Shetty
e1c23ef4f3
Merge pull request #21064 from frappe/feat-dynamic-webhook-url
2023-06-02 13:02:12 +05:30
Suraj Shetty
66d08ba365
Merge branch 'develop' into develop
2023-06-02 12:45:59 +05:30
Suraj Shetty
69927ce12f
Merge pull request #21110 from yjane99/customise-welcome-password-reset-emails
2023-06-02 12:41:49 +05:30
Ankush Menat
a09e29cfa0
Merge pull request #21173 from resilient-tech/safe-filters
...
fix!: improved filter validation in `Engine.get_query`
2023-06-02 11:45:06 +05:30
Maharshi Patel
6fd9c44391
fix: ui tour popover when outside viewport ( #21164 )
...
* fix: ui tour always popover inside viewport
There are times when popover will go outside viewport this updates the style on highlight to make sure it doesn't.
* fix: don't run form ui tours on small screens.
* Revert "fix: don't run form ui tours on small screens."
This reverts commit b11aaf8d182fa07369f17b914e8a0cb3e7327a18.
[skip ci]
2023-06-02 10:53:05 +05:30
Jeans K. Real
f8edb3dc3d
Closing span tags on form_links.html and list_view status field indicator. Also Removed extra calls from multicheck.js
2023-06-01 19:10:29 -06:00
Dhia' Alhaq Shalabi
efff6ebba7
fix: doctype name localization ( #21197 )
...
[skip ci]
2023-06-01 12:09:25 +05:30
Ankush Menat
83e3a20901
feat: allow clearing web page views
2023-05-31 17:50:10 +05:30
Ankush Menat
3bbe4498a0
feat: allow re-running patches in developer mode
...
Simpler debugging.
2023-05-31 16:39:29 +05:30
Ankush Menat
4104e7d733
feat: show db table utilization on doctype ( #21193 )
...
* feat: show db table utilization on doctype
* fix: nicer error message with docs
2023-05-31 16:28:44 +05:30
Ankush Menat
950277a88d
chore: increase logging level
2023-05-31 16:04:56 +05:30
Ankush Menat
48539dc0a3
feat: log all DDL queries ( #21107 )
2023-05-31 16:00:59 +05:30
Suraj Shetty
8750d39141
Merge pull request #21183 from surajshetty3416/print-letterhead-warning
2023-05-31 15:46:38 +05:30
Suraj Shetty
eda8be74ca
fix: Hide font-size from print format
...
- Since it is only used in new print format builder
and it can be set via new print format builder's interface
2023-05-31 15:44:05 +05:30
Suraj Shetty
1fd84f6b09
fix: Remove field_id from URL
...
- scroll to field is not yet supported
2023-05-31 15:42:50 +05:30
Sagar Vora
1b2d1dd567
chore: move statement to set validate_filters property
2023-05-31 14:20:26 +05:30
Sagar Vora
81d5160ac1
test: ensure stricter filters when validate_filters is passed
2023-05-31 14:16:52 +05:30
Sagar Vora
9f5a994f70
fix!: improved filter validation in Engine.get_query
2023-05-31 14:16:52 +05:30
Ankush Menat
fd232805fe
chore: capture frappe version in heartbeat
2023-05-31 12:44:41 +05:30
Ankush Menat
4a81d9f8e3
feat!: populate fields from kwargs in frappe.new_doc ( #21190 )
...
This makes it similar to `get_doc` API BUT still signifies intent that
it's a "NEW" document.
Minor Breaking Change: positional arguments are now forcefully keyword
arguments. Only seems to be used internally from what I can tell.
https://sourcegraph.com/search?q=context:global+repo:%5Egithub%5C.com/frappe/.*+/frappe.new_doc%5C%28.*%3F%2C.*%3F%5C%29/+lang:python+&patternType=regexp&case=yes&sm=0&groupBy=repo
2023-05-31 12:29:31 +05:30
Saurabh
aabaab0fd2
feat: used cached version of document in mapper ( #21186 )
...
* fix: in get_mapped_doc return cached version if available
* feat: specify explicitly cached version of doc in doc_mapper
[skip ci]
2023-05-31 11:15:33 +05:30
Suraj Shetty
6321e2ac0b
Merge pull request #21187 from surajshetty3416/duplicate-signature-in-communication-box
2023-05-31 10:12:12 +05:30
Suraj Shetty
abb479f89f
fix: Check if signature already exist
2023-05-31 09:55:39 +05:30
Suraj Shetty
55455cef4e
fix: Update label
...
"in PDF" is not required as it is already under PDF settings.
2023-05-31 09:03:07 +05:30
Suraj Shetty
a13592a66a
fix: Warn users if "Repeat Header and Footer" is disabled
...
- and if the user still sets Letterhead
Also, add label to the print options
2023-05-31 08:55:59 +05:30
Ankush Menat
ca85524f91
fix: skip form tours on mobile ( #21180 )
...
[skip ci]
2023-05-30 16:33:08 +05:30
Ankush Menat
77db84a2be
fix: reset tour
...
[skip ci]
2023-05-30 15:39:14 +05:30
Ankush Menat
1e0daa6edc
fix: correct abbreviation for lakh (L)
...
[skip ci]
2023-05-30 15:21:55 +05:30
Shariq Ansari
ea45d27de0
Merge pull request #21172 from shariquerik/css-for-web-form-mobile
2023-05-30 15:02:22 +05:30