Commit graph

48160 commits

Author SHA1 Message Date
Sumit Bhanushali
6d034bb92b
Merge pull request #28740 from frappe/quick_filters_fix
fix: in case of owner, always include owner in count data
2024-12-12 01:21:30 +05:30
Akhil Narang
264155635a
Merge pull request #28745 from akhilnarang/set-webform-sysdefaults-currency
fix: set `currency` system setting in webform `frappe.boot.sysdefaults`
2024-12-11 18:15:48 +05:30
Akhil Narang
a63cd10387
fix: set currency system setting in webform frappe.boot.sysdefaults
Otherwise this resulted in the fallback `USD` showing for some currency fields in webforms

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-12-11 17:59:13 +05:30
Sumit Bhanushali
602e05a5f8 fix: in case of owner, always include owner in count data 2024-12-11 17:49:09 +05:30
Ankush Menat
2295d3108d
chore: make bench_helper executable (#28742)
I need a real entry point that isn't wrapped by bench CLI.
2024-12-11 10:52:58 +00:00
Akhil Narang
c59933fe70
Merge pull request #28734 from barredterra/validate_from_to_dates
fix: clarify error message for child tables
2024-12-11 11:07:54 +05:30
barredterra
beab110ce9 fix: clarify error message for child tables 2024-12-10 17:06:55 +01:00
Akhil Narang
e92d10a0b0
Merge pull request #28729 from akhilnarang/fixup-28093
fix(convert_utc_to_timezone): set UTC if tzinfo undefined
2024-12-10 16:28:38 +05:30
Akhil Narang
4cf18d37bd
fix(convert_utc_to_timezone): set UTC if tzinfo undefined
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-12-10 16:12:01 +05:30
Rushabh Mehta
c4792204df
Merge pull request #28720 from netchampfaris/remove-justify
fix: remove text align justify from newsletter
2024-12-09 18:19:04 +05:30
Faris Ansari
4eafaea3e7 fix: remove text align justify from newsletter 2024-12-09 16:59:33 +05:30
Ankush Menat
1b1126c1c8
perf: index document name (#28718)
Moved index from doctype to docname. Docname always has higher
cardinality. Even if you filter by both it shouldn't matter as
cross-doctype name conflicts are rather rare.

Perf impact of this change should be net 0 but it does addresses problem
of indeterministic load times based on how many errors exist in db.

closes https://github.com/frappe/frappe/issues/28713
2024-12-09 09:08:59 +00:00
Ankush Menat
60bc472ab6
revert: restore JSON files (#28717)
* Revert: bring back JSON files

* chore: re-apply changes to new files

* chore: remove old TOML files

* chore: delete empty files
2024-12-09 08:41:56 +00:00
Sumit Bhanushali
fcd79d7075
Merge pull request #28715 from frappe/mergify/bp/develop/pr-28663
fix: check at doc level when if owner role permission is checked during export (backport #28663)
2024-12-09 13:06:52 +05:30
Sumit Bhanushali
9a331d30c6 chore: fix for failing test
(cherry picked from commit 0f3dad71e69e829171ac7c48de065f797a1357bd)
2024-12-09 07:22:33 +00:00
Sumit Bhanushali
1bb26f68d3 fix: check at doc level when if owner role permission is checked during export from list view
(cherry picked from commit 1ed45ceb97868c9b517dd3066f0b4ea2cd5358f5)
2024-12-09 07:22:32 +00:00
Sumit Bhanushali
5d22ee7b2b fix: check at doc level when if owner role permission is checked during export from report view
(cherry picked from commit c7ad3296c9664f5d6b2946f46082f57b91c1bac8)
2024-12-09 07:22:32 +00:00
Sumit Bhanushali
f8df660854
Merge pull request #28714 from frappe/patch-expr
fix(Patch): only insert expression key if not exists
2024-12-09 12:52:16 +05:30
Sumit Bhanushali
5b8bde97bb fix(Patch): only insert expression key if not exists 2024-12-09 12:36:11 +05:30
Rushabh Mehta
839477e422
Merge pull request #28446 from rmehta/fix-reply-icon
fix(minor): fix reply icon, group buttons
2024-12-09 12:29:59 +05:30
Rushabh Mehta
eb15de4873 fix(minor): fix reply icon, group buttons 2024-12-09 12:15:10 +05:30
Sumit Bhanushali
91d553c9cf
Merge pull request #28363 from frappe/expr-series
fix(NamingExpression): series should be separate for different format expressions instead of global
2024-12-09 12:13:28 +05:30
Sumit Bhanushali
c32703549f chore: added patch to create missing keys and update counter 2024-12-09 11:32:50 +05:30
David Arnold
d17136cd04
fix: redirect cssutils logger to file (#28692) 2024-12-08 13:42:18 +05:30
Sumit Bhanushali
4bb972e0b9
Merge pull request #28690 from iamejaaz/select-all-column-child-table
feat: add select all button to select all column in child table
2024-12-08 10:14:11 +05:30
Sumit Bhanushali
8233c2ffce fix: naming tests should consider pattern for generating series 2024-12-08 10:04:50 +05:30
David Arnold
1e6208a774
fix: pending deprecations with unspecified graduation (#28704) 2024-12-08 02:19:19 +00:00
David Arnold
0ff4c73e18
fix: bencher scoping (#28703)
* fix(bench_interface): sites loading

* feat(bench_interface): guard against naive scoping back to all sites

* refactor(bench_interface): remove 'scope' methods for (newer) site_name
2024-12-08 01:37:42 +00:00
David Arnold
8c7f3fac6c
ci: fix type check for manual trigger 2 (#28702) 2024-12-08 00:36:14 +00:00
David Arnold
0fbac0927b
ci: fix type check for manual trigger (#28701) 2024-12-08 01:15:47 +01:00
David Arnold
cc4cbfa826
refactor: simplify bench_interface class hierarchy and path resolution (#28697)
closes: #28696
2024-12-07 15:59:42 +00:00
David Arnold
c8a972a039
feat: add local deprecation descriptor (in reserve; not used) (#28695)
* feat: add local deprecation descriptor (in reserve; not used)
2024-12-07 14:33:06 +00:00
David Arnold
fef569e284
refactor: simplify bencher (#28694)
* chore: flatten bencher class layout

* chore: rename bencher to clarify

* docs: add file level docstrings
2024-12-07 14:10:03 +00:00
David Arnold
c5b7910ded
fix: improve bencher (#28693) 2024-12-07 12:53:17 +00:00
Ejaaz Khan
dbc8a60000 feat: add select all button to select all column in child table 2024-12-07 01:39:34 +05:30
David Arnold
3d71f594d8
refactor: bench class inauguration (#28158)
* feat: Add bench layout classes and configuration handler

Bench layout: (`frappe.bench`)

- Layout by env variable, e.g. FRAPPE_BENCH_PATH, FRAPPE_SITES_PATH, etc
- Detecting modules and apps by the presence of a sentinel .frappe file
- Site is scoped by frappe.local.site_name (thread safe)

Config handler: (`frappe.bench.sites{,.site}.config`)

- Optional config registry for better discovery; warning if not specced
- Env variable overload with `FRAPPE_` prefix

* chore: type frappe.config

* chore: type frappe.bencher

* chore: py310 compat
2024-12-06 19:07:34 +01:00
Sumit Bhanushali
bebc75e635
Merge pull request #28686 from aerele/insert-below-button
fix: hide insert below button in submitted document
2024-12-06 23:35:47 +05:30
vimalraj27
5a3f4c34cc chore: add indent 2024-12-06 18:24:12 +05:30
vimalraj27
7833911b6f fix: hide insert below button in submitted document 2024-12-06 17:16:18 +05:30
Smit Vora
6b02484f1c
feat: bulk update docs using case when queries (#28483) 2024-12-06 11:34:25 +00:00
Akhil Narang
14510ea96f
Merge pull request #28093 from gavindsouza/perf-datetime-utils
refactor: Replace pytz to std lib zoneinfo & datetime
2024-12-06 16:29:24 +05:30
Akhil Narang
94fe90de66
refactor: pytz -> ZoneInfo
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-12-06 16:14:05 +05:30
Akhil Narang
ad1ed62652
fix: handle ZoneInfoNotFoundError
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-12-06 16:01:43 +05:30
Akhil Narang
401f6dedbd
chore(deps): add back pytz
Too many apps depend on it for now
Will drop the actual dependency later

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-12-06 15:44:51 +05:30
Gavin D'souza
d521ac124d
style: Sort imports & move whitespaces to please ruff 2024-12-06 15:43:33 +05:30
Gavin D'souza
00163f5bf4
fix: Re-define utils to match previous behaviour 2024-12-06 15:43:33 +05:30
Gavin D'souza
7e2e5f80b9
fix: Usage of tzinfo replace when no tz is specified 2024-12-06 15:43:33 +05:30
Gavin D'souza
c6580b5880
refactor: Replace pytz to std lib zoneinfo & datetime
Signed-off-by: Gavin D'souza <gavin.dsouza@switchup.de>
2024-12-06 15:43:33 +05:30
Sumit Bhanushali
aaefd066f0 fix: validate "format:" expression to only contain one set of {#} pattern 2024-12-06 13:03:27 +05:30
Rushabh Mehta
fd1357cd3d
Merge pull request #28536 from iamejaaz/scrollable-child-table
feat: make child table scrollable
2024-12-06 12:55:43 +05:30