Commit graph

44355 commits

Author SHA1 Message Date
Shariq Ansari
75c3b7d1d7
test: skip permissions.js UI test
To check if it is the reason for test are failing frequently
2023-12-01 20:38:40 +05:30
Shariq Ansari
da385ccefe
Merge pull request #23537 from shariquerik/flaky-ui-test 2023-12-01 20:21:20 +05:30
Shariq Ansari
33f729ebd3 chore: linter fix 2023-12-01 20:03:18 +05:30
Shariq Ansari
856beca884
Merge pull request #23520 from niraj2477/feat/subject-in-timeline-mail 2023-12-01 20:01:30 +05:30
Shariq Ansari
78e63be26d
chore: linter fix 2023-12-01 19:37:55 +05:30
Shariq Ansari
a703bf398d
chore: linter fix 2023-12-01 19:37:09 +05:30
14987
77da425169
fix(UI): Display timestamp beside name 2023-12-01 19:22:44 +05:30
Bernd Oliver Sünderhauf
3bf0d08dc7
fix: Preserve title case in String.prototype.plural. (#23465) 2023-12-01 19:18:21 +05:30
14987
44a0bef8c9
fix: Update the css 2023-12-01 18:51:13 +05:30
14987
f027034404
fix: Update subject display location 2023-12-01 17:14:39 +05:30
Ankush Menat
1e20820846
refactor: Indicate that weak hash functions are not usedforsecurity (#23540)
[skip ci]
2023-12-01 16:04:37 +05:30
mergify[bot]
e2c168a6e0
Merge pull request #23442 from ruthra-kumar/webhooks_refactor
refactor: execute last instance of webhook trigger on documents
2023-12-01 10:02:04 +00:00
ruthra kumar
0a7c0593da refactor: execute the last instance of a webhook in a request 2023-12-01 15:15:43 +05:30
Shariq Ansari
8c2ef311bb test: flaky multi_select_dialog 2023-12-01 15:02:06 +05:30
Shariq Ansari
b2f8c11330 test: flaky control_link 2023-12-01 15:01:54 +05:30
Ankush Menat
ddedfd1d9e
build: pin editor js (#23534) 2023-12-01 13:18:33 +05:30
dependabot[bot]
821b469ff3
build(deps): bump @adobe/css-tools from 4.3.1 to 4.3.2 (#23532)
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.3.1 to 4.3.2.
- [Changelog](https://github.com/adobe/css-tools/blob/main/History.md)
- [Commits](https://github.com/adobe/css-tools/commits)

---
updated-dependencies:
- dependency-name: "@adobe/css-tools"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-12-01 12:12:12 +05:30
Ankush Menat
71e31a4200 chore: version bump 2023-12-01 10:36:49 +05:30
tonspar
fae3685b03
feat: Patch and Delete Request to integration utils (#23525)
* Update utils.py

Adding the patch and delete request

* Update safe_exec.py

Adding the patch and delete request from integration utils.
2023-12-01 10:25:43 +05:30
Ankush Menat
7b46223b76
Merge pull request #23521 from frappe/fix-readonly-edit
fix: prevent edit of readonly popup fields
2023-11-30 19:45:39 +05:30
Ankush Menat
c24a1d1b43
Merge pull request #23483 from akhilnarang/sentry
feat: Sentry support to automatically catch and report errors (opt-in)
2023-11-30 19:28:26 +05:30
18alantom
4a0562af3e fix: prevent edit of readonly popup fields 2023-11-30 19:17:27 +05:30
Ankush Menat
0e8b4de96f fix: tweak sentry config
- disable session tracking - This causes sentry to phone home on every load, we don't need this (yet)
- disable automatic integrtaions (like redis)
- disable all default integration and cherry-pick what's required
2023-11-30 19:01:19 +05:30
Ankush Menat
52686f79cb refactor: code cleanup
- better boot config name
- send sentry after - because frappe namespce doesn't exist if it starts
  first
- remove import in app.py because __init__ is always imported so no
  need.
- leave telemetry JS always present, this is used even when telemetry is
  not enabled.
2023-11-30 17:40:53 +05:30
14987
10823a6c96
feat(UI): Add subject in timeline communication 2023-11-30 17:36:49 +05:30
Ankush Menat
4cc1392697 ci: report all errors to sentry
This can be useful.
2023-11-30 17:34:15 +05:30
Akhil Narang
2bab0ab309 fix(js): use the correct field for sentry DSN
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-30 17:13:41 +05:30
Akhil Narang
9a0a5468c5 feat: setup sentry integration
Inspired primarily from sentry's generic WSGI integration

Environment variable `FRAPPE_SENTRY_DSN` needs to be enabled as well
as explicit opt-in from the user's side in system sid telemetry
settings

Conditionally include telemetry JS bundles

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-30 17:13:41 +05:30
Ankush Menat
a7137bdeaa feat: client side error reporting + sentry
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-30 17:13:41 +05:30
Ankush Menat
cccb95387c build(deps): add sentry/browser dependency 2023-11-30 17:13:41 +05:30
Ankush Menat
ebbd3cd137
fix: skip overriden doctypes during orphan check (#23518)
These are prone to breakage and shouldn't be deleted automatically.

This mostly works fine but there can be cases where it doesn't. So best to leave them untouched.
2023-11-30 11:33:42 +00:00
Ankush Menat
286e0a7b96
fix: Always evaluate Virtual Fields (#23515)
Related: https://github.com/frappe/frappe/issues/23475
Likely caused by: https://github.com/frappe/frappe/pull/22110

Because run_doc_method passes doc from client to server side, we end up
setting values for what is a "virtual field", this is why it finds some
value and not re-evaluate it.

IMO there are only mild breaking ways of fixing this:
1. Virtual fields should always be computed.
2. Virtual fields should not be set when init-ing the arguement. (e.g. from doc.set APIs )
2023-11-30 16:22:22 +05:30
Raffael Meyer
8c9275ba4e
fix: add blank line after auto-generated types (#23430) 2023-11-30 13:22:28 +05:30
Ankush Menat
c23771475c
refactor: Use hooks to specify default log clearing (#23507) 2023-11-30 13:06:29 +05:30
Abdo Hamoud
ba1d597e73
fix: image cropper in RTL mode (#23492) 2023-11-30 11:13:11 +05:30
Lucas Z
92684ab029
Update de.csv (#23478) 2023-11-30 00:21:31 +05:30
Raffael Meyer
7e08f003b3
fix: translate customize form (german) (#23497)
* fix: show translated doctype names

* fix: german translations for customize form
2023-11-30 00:18:52 +05:30
Thomas Fojan
043c004c01
fix!: switch google drive picker to gis (#23096)
* fix: switch google drive picker to gis

* fix: switch google drive picker to gis (linting)

* fix: switch google drive picker to gis (prettier)

* fix: remove restrictions on file types

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>

* fix: show navigator

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>

* fix: no multiselect for files

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>

* refactor: get rid of jquery

* fix: don't add script twice

* refactor: remove unused properties

* refactor: store access token in one place only

* refactor: make tokenClient a local constant

* fix: set locale

* refactor: async calls

* fix: don't store access token

It's one-time use anyway.

* fix: scope for allowing file upload

* reafctor: rename libsLoaded() to autthenticate()

---------

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2023-11-29 23:39:43 +05:30
Ankush Menat
f01937c788
fix(DX): return email queue doc (#23495) 2023-11-29 17:34:42 +00:00
Ankush Menat
15384f88e0 chore: dead code/comment 2023-11-29 22:11:37 +05:30
Ankush Menat
74a3e24653
Merge pull request #23490 from ankush/preload_headers
fix: Only preload icons for desk
2023-11-29 22:07:09 +05:30
Ankush Menat
957293bd54 fix: Only preload icons for desk 2023-11-29 21:50:18 +05:30
mergify[bot]
44ef719685
Merge pull request #23491 from cogk/fix-knowledge-base-cache
fix(kb): Fix cache not being cleared
2023-11-29 15:50:41 +00:00
Corentin Flr
932ef76da3
chore(kb): Drop unused parameter path 2023-11-29 16:12:01 +01:00
Corentin Flr
5781a913c7
refactor(kb): Rename clear_website_cache to clear_knowledge_base_cache 2023-11-29 16:09:04 +01:00
Corentin Flr
d432ff7a08
refactor(kb): Don't call website.utils.clear_cache again
Indeed, `website.utils.clear_cache` is already called by `WebsiteGenerator.clear_cache` the parent class of Help Article/Category.
2023-11-29 16:09:04 +01:00
Corentin Flr
4b3ddf30f3
fix(kb): Fix cache clearing not being triggered 2023-11-29 16:09:04 +01:00
Ankush Menat
ddb40e6a36
Merge pull request #23488 from frappe/unit
refactor: Avoid alias for dashboard chart
2023-11-29 16:45:47 +05:30
Ankush Menat
b2dafe5acd refactor: Avoid alias for dashboard chart 2023-11-29 13:12:53 +05:30
Alan
049f3c9323
Merge pull request #23485 from frappe/fix-sidebar-override
fix: set `sidebar_items` only if not present
2023-11-28 22:56:49 -08:00