Commit graph

251 commits

Author SHA1 Message Date
Suraj Shetty
eda8be74ca fix: Hide font-size from print format
- Since it is only used in new print format builder
and it can be set via new print format builder's interface
2023-05-31 15:44:05 +05:30
Suraj Shetty
1fd84f6b09 fix: Remove field_id from URL
- scroll to field is not yet supported
2023-05-31 15:42:50 +05:30
Suraj Shetty
55455cef4e fix: Update label
"in PDF" is not required as it is already under PDF settings.
2023-05-31 09:03:07 +05:30
Suraj Shetty
a13592a66a fix: Warn users if "Repeat Header and Footer" is disabled
- and if the user still sets Letterhead

Also, add label to the print options
2023-05-31 08:55:59 +05:30
Suraj Shetty
e429101370 fix(print): Language set in document should have higher precedence 2023-03-14 15:13:35 +05:30
Devin Slauenwhite
2223f97f88
fix: print preview when no letterhead is selected (#20286) 2023-03-10 12:10:22 +05:30
Ankush Menat
8446875257
refactor!: Remove "Set user permission" permtype (#20090)
This has never worked and setting user permission requires system
manager role always (because of permissions on list view)
2023-02-20 16:07:49 +05:30
Shariq Ansari
efd82c464e fix: checkbox is getting squeezed if label is long 2023-02-14 15:57:11 +05:30
Ankush Menat
c69c040186 chore: typo 2023-02-13 18:26:09 +05:30
Ankush Menat
b8ba7dcdb3
fix: Setting default print format (#19862)
- Remove check for developer mode, it's not even valid as we dont allow
  setting default print format like this
- Set in custom doctype if custom doctype else prop setter.
- query meta instead of doctype.

[skip ci]
2023-01-31 17:52:35 +05:30
Samuel Danieli
4d08f50a03
fix: PermissionError (#19856)
* fix: PermissionError

* fix: check perm on customize form

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-01-31 16:04:40 +05:30
barredterra
0d87870ca3 refactor: better, consistent names 2022-12-08 17:01:35 +01:00
barredterra
6069cde624 fix: remove seemingly useless code 2022-12-08 17:00:46 +01:00
barredterra
c8a196f768 fix: use standard format if none is selected 2022-12-08 16:59:29 +01:00
barredterra
0c3c4bf197 fix: add missing translations (de) 2022-12-08 16:57:32 +01:00
Ankush Menat
08aa17e5a3
Merge branch 'develop' into select-print-language 2022-11-24 13:04:27 +05:30
Ankush Menat
e594c35a3a fix: show fields without labels in print format builder (#18939)
* fix: show fields without labels in print format builder

* refactor: dont hardcode layout fields

[skip ci]

Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>

Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-11-21 14:52:31 +05:30
barredterra
5843aae5f6 fix: set default print format 2022-11-13 23:28:05 +01:00
barredterra
42608ac0c1 fix: set default letterhead 2022-11-13 22:57:26 +01:00
barredterra
aefba91139 refactor: use link for Letter Head 2022-11-09 18:06:50 +01:00
barredterra
75299abec8 fix: add placeholder for language 2022-11-09 18:06:26 +01:00
barredterra
9782f937fd refactor: use link for print format 2022-11-09 18:05:44 +01:00
barredterra
354279d690 fix: use link field to select print language 2022-11-09 15:06:28 +01:00
Ankush Menat
2eec621e95 chore: db.get_all -> get_all
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
Ankush Menat
3e2d2a703a test: Use FrappeTestCase everywhere 2022-08-17 16:39:42 +05:30
Gavin D'souza
598359c684 test: Reset requirements for export_doc 2022-08-09 15:57:26 +05:30
Gavin D'souza
208e33afa6 test: Add cleanup for generated files 2022-08-08 15:09:21 +05:30
Gavin D'souza
624c308659 Merge branch 'develop' of github.com:frappe/frappe into modules-refactor 2022-08-08 12:27:11 +05:30
Ankush Menat
40f27f908a style: format JS files with prettier 2022-08-04 14:51:01 +05:30
Gavin D'souza
85e3ee9403 chore: Minified DocType JSON notation from old verbose notation 2022-08-03 12:22:03 +05:30
Shariq Ansari
3216529deb
fix: Letter head image not working (#17608) 2022-07-25 17:46:27 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Gavin D'souza
a15411d1e1 fix: Skip invalid field in get_print_settings_to_show 2022-06-29 12:53:49 +05:30
Samuel Danieli
19a1393152 feat: make field label translatable 2022-06-27 23:32:55 +02:00
Suraj Shetty
64cc07227e refactor: Replace usage of deprecated attribute 2022-06-21 08:00:49 +05:30
Himanshu
6d6a67e9e3
feat: set image as footer in letter head (#17119)
* feat: set image as footer in letter head

* fix: do not hide footer section

* fix: hide footer source

* style: black

* fix: reduce code for setting image as html

* fix: Force system admin role only if active

* fix(ui): tab refresh was not implemented

* fix(minor): Onboarding: add option to view list view in create action

* fix(minor): js lint

* fix: allow All to select a User

* test: user permissions affecting User

* refactor: filter_dynamic_link_doctypes API

* Added typing, better variable naming
* Remove unnecessary re-iterations
* Optimize queries and membership processing

* perf: Check query type via is_query_type

* chore: Drop duplicate get_frontmatter definition

* perf: Login Page

Improves performance 3x - from 0.047s to 0.017s

* Use frappe.get_*_settings to query table once
* Use cached LDAP Settings' document via get_ldap_client_settings
* Use single get_all to query all Social Login providers and related
  data
* Skip provider if client_secret doesn't exist

* perf: About Us Settings

Use cached document for building /about page

* perf: App Page

Reduced time taken for get_context to execute from 0.035s to 0.02s (75%
reduction)

* perf: Patch qb only once - not on every init

* perf: Fetch and cache entire settings' dicts

* refactor!: frappe.db.get_singles_dict

* Cast single's values as their fieldtypes before returning
* Support previously dead debug parameter
* Consider single with no meta as non-existent; skip query

Decided to go ahead with the breaking change given the nature of the
existing usages of get_singles_dict :crie:

* ci: Run tests bypassing roulette with labels "Run UI Tests", "Run Server Tests"

* test: Scheduler tests cleanup

* chore: linter changes

* chore: linter changes

* chore: linter changes

* fix: set HTML as default

to keep existing formats working

* refactor: no **kwargs

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Rushabh Mehta <rmehta@gmail.com>
Co-authored-by: Gavin D'souza <gavin18d@gmail.com>
2022-06-17 12:07:07 +05:30
Vishal Dhayagude
b04af618f2
fix: fix ux for print preview page (#17087)
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
2022-06-08 14:58:06 +05:30
Maharshi Patel
a79a572f65
fix: print & breadcrumbs for forward slash (#17095) 2022-06-08 13:59:52 +05:30
Gavin D'souza
5ec2690160 Merge branch 'develop' into refactor-file 2022-06-01 15:47:55 +05:30
HENRY Florian
1826c9e9af
fix: translation context for print format align values (#17026) 2022-05-31 14:15:21 +05:30
Gavin D'souza
7e51f51f11 test: Added test for PrintFormat.export_doc
Other Changes
* Added return value for export_doc method
2022-04-14 09:58:35 +05:30
Gavin D'souza
97e911e069 Merge branch 'develop' of github.com:frappe/frappe into refactor-file 2022-04-13 10:49:26 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
ChillarAnand
5ca48ae3f6 fix: Fetch only active letter heads 2022-04-04 16:57:25 +05:30
HENRY Florian
7eb5274283
fix: bad closure on double quote print js (#16420) 2022-03-28 17:39:05 +05:30
Gavin D'souza
c6bad81f24 fix: Use new direct import paths
The old paths worked too, but it's just better to use the new paths and
not go in circles ;)
2022-03-15 19:39:47 +05:30
gavin
e1ec5ec964
Merge pull request #15458 from gavindsouza/print-format-rename
fix: Rename Property Setter on Print Format Rename
2021-12-27 15:48:05 +05:30
Gavin D'souza
7a68d797e9 fix: Rename Property Setter on Print Format Rename
This fixes the default print format set when Custom Print Formats are
renamed
2021-12-27 15:02:52 +05:30
karthikeyan5
a1c9282368 fix: update refresh lable in print view 2021-12-24 20:35:17 +05:30
karthikeyan5
dd731903bd fix(print page): addtional menu in mobile view 2021-12-24 10:04:42 +05:30