Gavin D'souza
76ec9e44e4
refactor: Rename guess_language as get_language
...
Guess suggests there's some AI involvement. The get_language function
has a defined priority. It is deterministic, hence teh name change.
2021-07-14 12:21:12 +05:30
Gavin D'souza
c47cbfd2ef
refactor: Set Language in HTTPHeader
...
Order of priority for setting language:
1. Form Dict => _lang
2. Cookie => preferred_language
3. Request Header => Accept-Language
4. User document => language
5. System Settings => language
Cookie is placed at #2 since the language picker in the navbar depends
on it. And the Accept-Language header sends values based on the client's locales.
---
Form Dict _lang now accepts language codes too. Previously, language
names were used...for whatever reason.
2021-07-14 12:21:12 +05:30
Gavin D'souza
caafd9e2b5
refactor: Simplify HTTPRequest class
...
* For the sake of Readability and ease of understanding
* Style updates
2021-07-14 12:21:12 +05:30
Fahim Ali Zain
f5bd21cf46
fix: preferred_language cookie support for all users
2021-07-14 12:21:12 +05:30
Gavin D'souza
f96ebb1f66
perf: Skip guess_language if _lang is provided
2021-07-14 12:21:12 +05:30
Fahim Ali Zain
9d9d76efe6
fix: frappe.local.lang resolution
2021-07-14 12:21:11 +05:30
Leela vadlamudi
ee1b27587d
Merge pull request #13698 from leela/fix-email-attachments
...
fix: sending document as an attachment through mail
2021-07-14 10:47:28 +05:30
leela
f2267bec25
fix: sending document as an attachment through mail
...
Currently sending document as an attachment is failing and the fix is to
make it work by fixing the bug introduced in latest refactoring.
2021-07-14 10:28:10 +05:30
mergify[bot]
6128123eed
Merge pull request #13687 from bhavesh95863/patch-6
...
fix: Duplicate if condition removed
2021-07-13 15:22:34 +00:00
gavin
59f4b4d754
Merge pull request #13554 from gavindsouza/drop-data-import-legacy
...
chore: Drop Data Import Legacy
2021-07-13 20:39:00 +05:30
mergify[bot]
e528c959e8
Merge pull request #13692 from resilient-tech/fix-boilerplate
...
fix: escape quotes before declaring variables when making a new app
2021-07-13 14:21:24 +00:00
Pruthvi Patel
bed64ef0ad
test: change app description to test if quotes are being escaped
2021-07-13 18:49:26 +05:30
mergify[bot]
2ca636be31
Merge pull request #13640 from alyf-de/bench_version_branch_commit
...
feat: different output formats for `bench version`
2021-07-13 12:59:36 +00:00
barredterra
199990decc
Merge branch 'develop' into bench_version_branch_commit
2021-07-13 14:30:56 +02:00
Sagar Vora
b23dd71116
fix: escape quotes before declaring variables when making a new app
2021-07-13 17:56:47 +05:30
Suraj Shetty
e2bee9b46d
Merge pull request #13689 from surajshetty3416/fix-customize-form
2021-07-13 17:26:53 +05:30
Suraj Shetty
cf67dbce5a
fix: Add missing fieldtypes in for custom fields
2021-07-13 16:56:49 +05:30
barredterra
fc2c887635
test: fix return code
2021-07-13 13:23:25 +02:00
gavin
9c0acea286
Merge pull request #13630 from frappe/dependabot/npm_and_yarn/minimist-1.2.5
...
chore(deps): [security] bump minimist from 1.2.0 to 1.2.5
2021-07-13 16:42:30 +05:30
barredterra
04094110f5
fix: handle detached head
...
Workaround for https://github.com/gitpython-developers/GitPython/issues/633
2021-07-13 13:11:15 +02:00
dependabot-preview[bot]
8bc498c18c
chore(deps): [security] bump minimist from 1.2.0 to 1.2.5
...
Bumps [minimist](https://github.com/substack/minimist ) from 1.2.0 to 1.2.5. **This update includes security fixes.**
- [Release notes](https://github.com/substack/minimist/releases )
- [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.5 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2021-07-13 10:42:00 +00:00
Bhavesh Maheshwari
68930a022a
fix: Duplicate if condition remove
2021-07-13 15:55:24 +05:30
gavin
a837a4d69c
Merge pull request #13680 from frappe/mergify/bp/develop/pr-13667
...
fix: custom script to duplicate row not working in v13 (backport #13667 )
2021-07-13 13:21:55 +05:30
Gavin D'souza
8dcb7a1eaa
style: Remove redundant comments
2021-07-13 12:04:50 +05:30
Gavin D'souza
2aa2586a0c
fix: Drop deprecated validate_csv_import_file def
2021-07-13 12:04:18 +05:30
Gavin D'souza
baea532c3d
fix: Move depr module module utils in exporter
2021-07-13 11:27:58 +05:30
Gavin D'souza
0d0e527416
chore: Show deprecation warning in command help
2021-07-13 11:21:21 +05:30
Gavin D'souza
dc50b77179
chore: Drop Data Import Legacy
2021-07-13 11:21:21 +05:30
mergify[bot]
df9386208a
Merge pull request #13655 from MitulDavid/patch-1
...
fix: Accurately cast fieldtype in frappe.db.get_single_value()
2021-07-13 05:50:12 +00:00
Rushabh Mehta
372447846e
fix(minor): website_builder.scss removed border for cards
2021-07-13 10:14:43 +05:30
Rushabh Mehta
959a5549d1
fix(minor): website_builder.scss padding and line-height for cards
2021-07-13 09:51:40 +05:30
Mitul David
42585579e6
refactor: Replace str.format() with f-strings
2021-07-12 19:13:29 +05:30
rohitwaghchaure
10fde05950
fix: custom script to duplicate row not working in v13 ( #13667 )
...
(cherry picked from commit 1615baf69a476a4c8361cd8af19e2edada6b4784)
2021-07-12 12:15:28 +00:00
mergify[bot]
d8c4ad379c
Merge pull request #13488 from shariquerik/custom-report-link-fix
...
fix: Invalid Custom Report link on Workspace
2021-07-12 12:10:08 +00:00
Mitul David
934fc17a3b
refactor: Improve readability, consistency
2021-07-12 15:52:57 +05:30
Leela vadlamudi
1753cc1ac6
Merge pull request #13670 from frappe/send-me-a-copy-not-working
...
fix: send me a copy not working
2021-07-12 11:45:00 +05:30
Suraj Shetty
e66c76c971
Merge pull request #13674 from surajshetty3416/fix-scrollbars
2021-07-12 09:15:19 +05:30
Suraj Shetty
d54bc4fc70
fix: Make scrollbar thumb rounded
2021-07-11 21:00:03 +05:30
Mitul David
95550861a7
refactor(minor): Fix indentation
2021-07-09 18:48:12 +05:30
Mitul David
1e839f0ab1
test: Add test for frappe.db.get_single_value
2021-07-09 18:36:06 +05:30
Mohammad Hasnain Mohsin Rajan
6fd762da96
fix: send me a copy not working
2021-07-09 18:02:19 +05:30
mergify[bot]
c192f6972b
Merge pull request #12715 from alyf-de/google_drive_picker
...
feat: Google Drive Picker
2021-07-09 06:01:16 +00:00
Suraj Shetty
ef5c486b0a
Merge pull request #13664 from surajshetty3416/fix-dashboard-open-count
2021-07-07 23:11:55 +05:30
Suraj Shetty
ee75cea4fe
fix: Enable set_open_count
...
perf: move set_open_count to after_refresh to avoid unnecessary calls
2021-07-07 22:39:12 +05:30
Suraj Shetty
67736f9199
Merge pull request #13662 from surajshetty3416/fix-file-folder-routing-issue
2021-07-07 19:39:15 +05:30
Suraj Shetty
121ae7e36b
fix: Allow to open folders that are nested inside 2 folders
2021-07-07 17:58:45 +05:30
Mohammad Hasnain Mohsin Rajan
d25252b1e1
perf: Index workflow action fields ( #13622 )
...
* feat: add number format parameter in doc.get_formatted
* fix: add test cases
* fix: test_document test
* fix: test_document test fix
* fix: readding test for test_formatter
* perf: add indexes in workflow action
* chore: commit auto created file
* Revert "feat: add number format parameter in doc.get_formatted"
This reverts commit 6bdcae12014bafae6e383336915daef5e40141af
2021-07-07 15:52:19 +05:30
Mitul David
64840aac6b
refactor(minor): Delete redundant imports
2021-07-06 14:13:27 +05:30
Mitul David
a1e84d2341
fix: Accurately cast fieldtype in frappe.db.get_single_value()
2021-07-06 13:28:18 +05:30
mergify[bot]
9fdde15841
Merge pull request #13651 from resilient-tech/fix-cannot-read-property
...
fix: cannot read property `0` of undefined
2021-07-06 05:18:30 +00:00
