Commit graph

40975 commits

Author SHA1 Message Date
Shariq Ansari
7d2d276d3c
Merge pull request #19743 from shariquerik/grid-in-3-column-ux
Fixes https://github.com/frappe/frappe/issues/19275
2023-01-24 13:07:09 +05:30
Shariq Ansari
aabe357ebf
Merge branch 'develop' into grid-in-3-column-ux 2023-01-24 12:36:29 +05:30
Shariq Ansari
1d97023b34 fix(UX): Grid in 3 column layout is broken 2023-01-24 12:34:31 +05:30
dependabot[bot]
788d512a69
chore(deps): bump cookiejar from 2.1.2 to 2.1.4 (#19737)
Bumps [cookiejar](https://github.com/bmeck/node-cookiejar) from 2.1.2 to 2.1.4.
- [Release notes](https://github.com/bmeck/node-cookiejar/releases)
- [Commits](https://github.com/bmeck/node-cookiejar/commits)

---
updated-dependencies:
- dependency-name: cookiejar
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-01-24 11:33:00 +05:30
Shariq Ansari
af671fc22b
Merge pull request #19710 from shariquerik/pass-strength-progress-bar 2023-01-24 11:31:26 +05:30
Shariq Ansari
56c822b274
Merge pull request #19740 from shariquerik/ldap-fix
Fixes https://github.com/frappe/frappe/issues/19702
2023-01-24 11:25:43 +05:30
Shariq Ansari
229ca404ae fix: LDAP - default user role mandatory logic broken 2023-01-24 11:22:05 +05:30
Shariq Ansari
4afd96baae
Merge pull request #19731 from shariquerik/child-table-fields-in-dialog-readonly-fix
fix: child table readonly field in dialog is not readonly
2023-01-24 09:55:25 +05:30
Sagar Vora
71420eb4e6
refactor: simplified get_controller (#19684)
* refactor: simplified `get_controller`

* chore: more refactor, better error if not subclass

* chore: more correct condition

* refactor: `class_` > `_class`

* chore: use `Meta` instead of DB calls

* chore: `_get_controller` => `import_controller`

* style: remove else block
2023-01-24 01:27:26 +05:30
Ankush Menat
30e9fc4cb6 chore: remove unnessary todo comment 2023-01-23 20:05:28 +05:30
Shariq Ansari
3d280a2d3f fix: child table readonly field in dialog is not readonly 2023-01-23 18:17:21 +05:30
Ankush Menat
3821167f66
Merge pull request #19725 from ankush/migration_fixes_moar
fix: misc migration issues
2023-01-23 16:44:19 +05:30
Ankush Menat
391edba10a fix(UX): better error message for dead link fields
Link fields referring to non-existing doctypes are possible when

- Removing customizations.
- Removing app which added a custom field but didn't clean up after
  itself.

[skip ci]
2023-01-23 16:43:57 +05:30
Shariq Ansari
bbcdd3102e
Merge branch 'develop' into pass-strength-progress-bar 2023-01-23 16:29:47 +05:30
Shariq Ansari
6c1624d41e feat: toggle password icon 2023-01-23 16:23:44 +05:30
Ankush Menat
224ab37924 fix: Dont apply non-standard perms in migrate
ref: agent-job/b8bca95f25
2023-01-23 15:07:13 +05:30
Ankush Menat
87561940a4
feat: Interactively add a new patch (#19722) 2023-01-23 15:04:43 +05:30
Anand Baburajan
6554919f1e
fix: improve invalid naming series message (#19711)
* fix: show the invalid naming series in special chars error msg

* chore: translations

[skip ci]
2023-01-23 15:00:04 +05:30
Richard Case
0e6e2609b5 fix: unhelpful error message (#19666) 2023-01-23 14:48:27 +05:30
Ritwik Puri
65a76cc0f3
Merge pull request #19083 from Aradhya-Tripathi/refactor-bg-submissions
fix: misc fixes (background submission)
2023-01-23 13:18:18 +05:30
phot0n
4144c45b2a fix: make job_id link field and allow all (if owner) to read their submission queues 2023-01-23 13:13:27 +05:30
phot0n
230d36e789 chore: revert things related to workflow 2023-01-23 12:59:18 +05:30
phot0n
99fbe969e8 Revert "fix: workflow mechanics for submission queue (start)"
This reverts commit bb8b0d415e.
2023-01-23 12:57:20 +05:30
phot0n
af093dd598 fix: traceback with context for submission queue 2023-01-23 12:57:20 +05:30
phot0n
bb8b0d415e fix: workflow mechanics for submission queue (start) 2023-01-23 12:45:22 +05:30
phot0n
08c8ab0229 chore: better notification message
Co-authored-by: Aradhya-Tripathi
2023-01-23 12:45:22 +05:30
phot0n
64cb507fae chore: verbose confimation dialog message 2023-01-23 12:45:22 +05:30
Shariq Ansari
bd3ee0d4c0 fix: Password Strength Progress Bar 2023-01-20 22:03:21 +05:30
Suraj Shetty
eb086268b0
Merge pull request #19681 from surajshetty3416/fix-indicator-colors 2023-01-20 20:01:31 +05:30
Suraj Shetty
ee3a6fab7d fix: Add cyan and pink indicator color for dark theme
- fix gray indicator colors on dark... make them lighter to make it more consistent and visible
2023-01-20 19:24:21 +05:30
Suraj Shetty
e2b3dd60c2 fix: Indicator contrast to make it more readable 2023-01-20 19:12:21 +05:30
Ankush Menat
e1ed1e9899
fix: rate limit newsletter subscriptions (#19690) 2023-01-20 19:05:51 +05:30
Ankush Menat
e8209b5dce
fix: invalid "empty form" message (#19696) 2023-01-20 19:03:56 +05:30
Shariq Ansari
f81dc3fce8
Merge pull request #19695 from frappe/fix-comment-email-title 2023-01-20 18:47:59 +05:30
Hussain Nagaria
0411328101 fix: use document title instead of name in subject 2023-01-20 18:30:27 +05:30
Richard Case
457114521f
fix: prevent web form button resubmit and add freeze (#19670)
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2023-01-20 17:22:37 +05:30
Richard Case
b66f93bdf5
feat: allow 'content' attribute for website structured data schema (#19667) 2023-01-20 14:37:18 +05:30
Sagar Vora
e208db7104
perf: only clear controller cache from current site (#19661)
* perf: only clear controller from current site

* chore: only pop current site controllers if doctype isnt specified
2023-01-20 14:36:42 +05:30
Suraj Shetty
dcbc9e54ca fix: Indicator dot colors in dark mode 2023-01-20 14:16:04 +05:30
Ritwik Puri
98191c5a94
Merge pull request #19677 from phot0n/commentcountui
fix(minor): show 0 as comment count if _comment_count doesnt exist
2023-01-20 13:52:39 +05:30
Ankush Menat
0449f851c7
fix: correct exit code on missing app failure (#19676) 2023-01-20 13:51:00 +05:30
phot0n
586555a1c4 fix(minor): show 0 as comment count if _comment_count doesnt exist 2023-01-20 13:48:47 +05:30
Richard Case
e80c8ac862
fix: improved installed app fail feedback (#19668) 2023-01-20 13:02:09 +05:30
Shariq Ansari
07df794ea4
Merge pull request #19646 from shariquerik/form-builder-fixes-2 2023-01-20 12:43:12 +05:30
Shariq Ansari
cba7c638ae
Merge branch 'develop' into form-builder-fixes-2 2023-01-20 11:52:15 +05:30
Ankush Menat
2971fcf657
fix: misc migration related fixes (#19623)
* fix: Dont check for hidden-mandatory during migration

This is being added programatically and can be addressed later. No need
to fail migrations for this.

* refactor: Convert patch log naming to hash

Naming series isn't required and can cause collision if patches were
incorrectly executed or reattempted.
2023-01-20 11:43:21 +05:30
Ankush Menat
945a2b34fe
fix(UX): drag handles on app resolution order table (#19672)
[skip ci]

Co-Authored-By: Suraj Shetty <surajshetty3416@gmail.com>

Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2023-01-20 11:35:15 +05:30
Ankush Menat
40d0c8aaaf
Merge pull request #19657 from ankush/invalid_filters
fix(UX): invalid filters, incorrect std fieldtypes
2023-01-19 22:07:50 +05:30
Ankush Menat
b483f27ae8
fix: only generate fieldname for inconsequential fields (#19663)
Creating columns that are altered in DB on save automatically is kinda
bad and will leave unnecessary columns in DB if user makes a mistake or
forgets to add a fieldname explicitly.

The default generated names are meaningless like "float_asdx", there is
no use case for this.

[skip ci]
2023-01-19 21:55:31 +05:30
Ankush Menat
9588455515
Merge branch 'develop' into invalid_filters 2023-01-19 21:39:58 +05:30