gavin
7eb7ec2663
Merge branch 'develop' into cleanup
2022-07-22 15:10:34 +05:30
Gavin D'souza
9dba593a6e
refactor: Add typing + comprehensions for readability
2022-07-22 15:09:39 +05:30
Gavin D'souza
ad90923801
test(communication): Add test for handling duplicate email signatures
2022-07-22 14:59:47 +05:30
gavin
b52fdbba45
Merge pull request #16961 from gavindsouza/mariadb-client-refactor
...
refactor!: Database
2022-07-22 14:19:38 +05:30
gavin
f40214bca8
fix(get_last_doc): Allow for_update as kwarg only
...
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-07-22 13:34:04 +05:30
Gavin D'souza
d1fbab1c45
test(db): Add tests for untested db methods
2022-07-22 13:30:47 +05:30
Gavin D'souza
2bef29bb46
chore: Deprecate backup script + minor refactors
2022-07-22 13:21:29 +05:30
Gavin D'souza
1dbc0b4d3c
fix(db*): Use common fallback Datetime str
...
There existed inconsistencies between db_query & db's fallback for min
datetime in str format - missing decimal seconds places. Now, we're
storing the default string once and re-using it to reduce
inconsistencies or room for human errors.
2022-07-22 13:19:25 +05:30
Gavin D'souza
bcfa8c276e
fix: Set default port attribute for Database classes
...
db.default_port wil be available as a class attribute to hold defaults
for DB types.
Usage: frappe.conf.db_port or frappe.db.default_port
Why: I couldn't run the mariadb command because the defaults aren't set
for my system. server is remote / containerized. Setting port in
equivalent mysql command fixes this.
2022-07-22 13:16:26 +05:30
gavin
d285ce910f
Merge branch 'develop' into mariadb-client-refactor
2022-07-22 12:11:54 +05:30
Gavin D'souza
1a610e135d
fix(db): Use sentinel object for default values paramters
2022-07-22 12:11:01 +05:30
Gavin D'souza
e411132c6e
fix(db): Revert breaking change of wrapping NoneType in sequence
2022-07-22 12:11:01 +05:30
Gavin D'souza
63e618c709
test: More resilient tests for sequences
2022-07-22 12:11:01 +05:30
Gavin D'souza
006ebcbede
refactor: Use pymysql over mariadb client
...
This is supposed to be a temporary switch to make the parent PR easier
to digest. MariaDB client has some issues with release, and system
dependencies.
This commit may be reverted to enable mariadb client again.
2022-07-22 12:10:54 +05:30
Shariq Ansari
b1e9bc8d12
fix: error while genarating date for blog post google search preview ( #17581 )
2022-07-21 20:46:03 +05:30
Suraj Shetty
623650ab3b
Merge branch 'develop' of https://github.com/frappe/frappe into develop
2022-07-21 17:03:58 +05:30
Suraj Shetty
9e87598dda
refactor: Use FrappeTestCase as it rolls back test data
2022-07-21 17:03:52 +05:30
Ankush Menat
d2177d16a1
ci: bump node version to node16 ( #17564 )
...
* ci: bump node version to node16
* chore: remove `node-sass` - no longer used
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2022-07-21 16:54:41 +05:30
Sagar Vora
85a3837b14
fix: ensure 2FA patch sets parent only for 2FA keys ( #17575 )
...
* fix: ensure 2FA patch sets parent only for 2FA keys
* fix: try to rebuild defaults
* fix: set other app defaults as well
* fix: set POS profile defaults
* fix: exists params
* chore: remove unnecessary change
* fix: handle case where POS Profile doesnt exist
* chore: move erpnext code to erpnext
2022-07-21 13:04:47 +05:30
Ankush Menat
b42e3b7a6b
Merge pull request #17491 from ankush/undo_stack
...
feat: Undo/Redo changes on FormView
2022-07-20 22:51:04 +05:30
Ankush Menat
5ea96ced3a
test: undo/redo, jump to field UI tests
2022-07-20 21:44:48 +05:30
Ankush Menat
e73f4aa8ab
fix: avoid nonsensical change triggers
...
if both values are same then logging it doesn't make much sense.
2022-07-20 21:44:48 +05:30
Ankush Menat
129152c1c5
feat: highlight changed fields when doing undo/redo
2022-07-20 21:44:48 +05:30
Ankush Menat
a1ca1e2cc6
feat: undo/redo on child table fields
2022-07-20 21:44:48 +05:30
Ankush Menat
715299fc08
fix: erase undo/redo history on doc change/refresh
2022-07-20 21:44:48 +05:30
Ankush Menat
836ce67d85
feat: undo/redo on form view
...
This commit implements basic undo/redo on form view fields
2022-07-20 21:44:48 +05:30
Ankush Menat
e7082d611f
fix: broken realtime doc change updates ( #17567 )
2022-07-20 21:05:23 +05:30
Ankush Menat
8a8f0a1c79
fix: replace incorrect validation on doctype links ( #17561 )
2022-07-20 17:51:45 +05:30
Suraj Shetty
302b01267c
Merge pull request #17551 from surajshetty3416/fix-note-notification
...
fix: Query for unseen notification
2022-07-20 13:44:30 +05:30
Suraj Shetty
67350e9ac3
test: Add a test case to validate get_unseen_notes
2022-07-20 13:23:49 +05:30
Suraj Shetty
6bbd8fcb32
fix: Filter notes with notify_on_login and not notify_on_every_login
2022-07-20 13:16:51 +05:30
gavin
486f26a1ff
Merge branch 'develop' into mariadb-client-refactor
2022-07-20 12:41:46 +05:30
Ankush Menat
b840b6dd2e
Merge pull request #17549 from resilient-tech/use-decorator
...
style: use `middleware` decorator to keep function definition intact
2022-07-20 12:28:17 +05:30
Suraj Shetty
6294e13e64
Merge pull request #17554 from surajshetty3416/fix-client-query
2022-07-20 12:27:38 +05:30
mergify[bot]
23e6df4cb3
Merge pull request #17550 from surajshetty3416/fix-file-upload-permission
...
fix: No need to check for permission again while attaching a file
2022-07-20 06:40:52 +00:00
Suraj Shetty
99c6990761
fix: Allow fields to have "*" without array
2022-07-20 11:30:57 +05:30
Suraj Shetty
d5bf9b60e0
fix: Query for unseen notification
2022-07-20 10:36:40 +05:30
Suraj Shetty
8f48c4d943
fix: No need to check for permssion again while attaching a file
2022-07-20 08:24:49 +05:30
Sagar Vora
eea2616aac
style: use middleware decorator to keep function definition intact
2022-07-19 22:28:14 +05:30
Gavin D'souza
1ccdad811a
Merge branch 'develop' of github.com:frappe/frappe into mariadb-client-refactor
2022-07-19 16:23:24 +05:30
Ankush Menat
066d5a4245
Merge pull request #17528 from phot0n/mis-fixes-goauth
...
fix: misc fixes (google oauth)
2022-07-19 15:55:24 +05:30
Shariq Ansari
a50e0ffa08
refactor: Webform ( #17232 )
2022-07-19 15:52:15 +05:30
gavin
cf7cb387f3
Merge pull request #17439 from gavindsouza/ldap-user_type
...
feat: Allow setting "User Type" for LDAP user creation
2022-07-19 15:40:49 +05:30
Raffael Meyer
2bf14bb29f
fix: translate page numbers ( #17492 )
2022-07-19 15:38:17 +05:30
Nabin Hait
31ef1c7355
perf: option to skip realtime notify update after insert ( #17543 )
...
While doing optimization for the period closing voucher, found that `notify_update` takes a significant amount of time to execute (200 seconds in this case), even though it was not required at all in this specific case (insert of GL Entry). That's why made the function optional by using a flag.
Related PR: https://github.com/frappe/erpnext/pull/31626
2022-07-19 09:53:04 +00:00
gavin
50a8cc8068
Merge branch 'develop' into ldap-user_type
2022-07-19 15:01:59 +05:30
Gavin D'souza
c55bb98482
test: LDAP test for website user creation
2022-07-19 15:01:16 +05:30
Gavin D'souza
c7726d6394
fix: Pick default_role for Sytem User type only
2022-07-19 15:00:23 +05:30
Ankush Menat
21a7291d00
ci: Stripped down config for Semantic checks ( #17542 )
...
* ci: Stripped down config for Semantic checks
Conventional commit enforces too many pointless rules, all we care about
is type and subject.
* ci: auto merge on commit pass
2022-07-19 14:32:34 +05:30
Ankush Menat
4eb1fe74a5
chore: dont fetch full repo
...
In most cases we need 10-50 previous commits. Checking out full repo is
time consuming and not required.
2022-07-19 12:03:18 +05:30
