Commit graph

40246 commits

Author SHA1 Message Date
Ankush Menat
7ec120d2ba refactor: support generators in db.bulk_insert
When you want to insert a huge amount of docs in DB, using bulk insert
currently requries creating a huge number of objects, this is
ineffecient from memory perspective and also delays failures if any till
last step in execution.
2022-11-28 15:29:59 +05:30
Mohammad Hussain Nagaria
a534e7a66a
fix: Pass *args and **kwargs in db_insert boilerplate for Virtual DocType (#19018)
[skip ci]
2022-11-28 11:14:24 +05:30
Sabu Siyad
406f894141
feat: default value options: sort (#19019)
[skip ci]

Signed-off-by: Sabu Siyad <hello@ssiyad.com>
2022-11-28 11:09:15 +05:30
Ankush Menat
263055e247
fix: site creation using non-root users (#19014) 2022-11-26 12:45:57 +05:30
Marica
a4db4550e9
fix: Avoid update_order twice on Kanban load (#19011)
* fix: Avoid `update_order` twice on kanban load

- The older logic called `kanban.update()` on a refresh (not on load) and returned from `render()`
- Due to a recent PR, it calls `kanban.update()` AND builds a new board on load, which invokes `update_order` twice consecutively and causes a timestamp error to be thrown

* chore: Remove redundant condition

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-11-25 20:55:16 +05:30
Sagar Vora
a14367f1d9
chore: replace use of cur_frm with this.frm (#19005) 2022-11-25 14:38:30 +05:30
Ankush Menat
763bdb5d3c
Merge pull request #18996 from gavindsouza/spaces-db_query
fix(db_query): Space resilient sanitization
2022-11-25 13:12:20 +05:30
Ankush Menat
d00b98f460 chore: typo 2022-11-25 13:10:43 +05:30
Ankush Menat
4661083247
Merge pull request #18995 from ankush/multi_queue_workers
feat(workers): many small RQ worker features
2022-11-25 12:47:47 +05:30
gavin
35827af172
fix: Strip white spaces on lower cased field value
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-11-25 12:39:11 +05:30
Ankush Menat
ed28626021 refactor: simpler deque strat selection
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-11-25 12:14:37 +05:30
Ankush Menat
a8bf86ef75 feat: support dequeuing strategies for worker 2022-11-25 12:14:37 +05:30
Ankush Menat
aece93fbc5 feat: burst mode in workers
https://python-rq.org/docs/workers/#burst-mode
2022-11-25 12:14:33 +05:30
Ankush Menat
0ebd3945ff refactor: consider multi-queue consumption 2022-11-25 12:03:34 +05:30
Ankush Menat
40b2929c0d feat(workers): allow consuming multiple queues 2022-11-25 12:03:34 +05:30
Ankush Menat
b7cef3ae71 fix: prioritize short queue when using all queues 2022-11-25 12:03:34 +05:30
Sagar Vora
b1703117fc
chore: remove unused whitelisting from API (#19000) 2022-11-25 11:59:04 +05:30
Gavin D'souza
1a5e5f546b fix: Move function check inside subquery 2022-11-24 16:27:54 +05:30
Himanshu Shivhare
c7461a05c6
chore: Typo correction (#18997)
[skip ci]
2022-11-24 16:25:11 +05:30
Gavin D'souza
1f913248aa test: Add more tests for illegal subquery and fn usage 2022-11-24 15:36:31 +05:30
Gavin D'souza
575d32ec35 fix(db_query): Space resilient matching 2022-11-24 15:36:28 +05:30
Raffael Meyer
73f0256aa8
feat: add param letterhead to frappe.get_print (#18989)
* feat: add param letterhead to frappe.get_print
2022-11-24 13:15:24 +05:30
Raffael Meyer
920606f10e
fix: handle "No Letterhead" in new print format builder (#18990)
[skip ci]
2022-11-24 10:54:46 +05:30
Sagar Vora
8486109f2f
Merge pull request #18985 from resilient-tech/fix-key-check
fix: only accept string values for `key`
2022-11-23 17:49:53 +00:00
Sagar Vora
8cc504709b fix: only accept string values for key 2022-11-23 23:00:48 +05:30
Shariq Ansari
526a00884e
Merge pull request #18973 from shariquerik/rtl-horizontal-scroll-fix
fix: horizontal scroll in rtl language
2022-11-23 12:37:32 +05:30
Shariq Ansari
5c45106971 fix: horizontal scroll in rtl language 2022-11-22 19:30:23 +05:30
Raffael Meyer
eae918d545
feat: contact full name (#18596)
* feat: contact full name

* patch: autocommit and don't update modified

* patch: print progress while updating contacts

* patch: don't overwrite existing full_name
2022-11-22 18:57:41 +05:30
Shariq Ansari
4cd1d3c669
Merge pull request #18965 from netchampfaris/attach-field-in-table
fix(file): set fieldname to table fieldname
2022-11-22 13:14:01 +05:30
Faris Ansari
45230cf938
fix: succinct version
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-11-22 00:00:37 +05:30
Faris Ansari
6479163899 fix(file): set fieldname to table fieldname
because files are always attached to parent
2022-11-21 19:28:54 +05:30
Shariq Ansari
f47755480d
Merge pull request #18962 from shariquerik/phone-field-in-web-form 2022-11-21 18:51:41 +05:30
Shariq Ansari
941949e0a1
Merge branch 'develop' into phone-field-in-web-form 2022-11-21 18:26:57 +05:30
mergify[bot]
d1d30e6451
Merge pull request #18877 from marination/get_role_permissions-js-consistency
fix: Correctness in `get_role_permissions` and `has_perm` JS APIs
2022-11-21 12:56:30 +00:00
Shariq Ansari
58a35d12bf
Merge branch 'develop' into phone-field-in-web-form 2022-11-21 18:26:11 +05:30
Shariq Ansari
cf4d55855d fix: added phone field in webform 2022-11-21 18:16:44 +05:30
Sagar Vora
b8e7deea40 chore: revert to doctype_perm cache for now 2022-11-21 18:07:40 +05:30
Shariq Ansari
5605e9dbcb
Merge pull request #18960 from shariquerik/web-form-get-fields-fix 2022-11-21 17:36:46 +05:30
Shariq Ansari
962d96c1a6 fix: only get fields which is not already in webform fields table 2022-11-21 17:33:39 +05:30
Sagar Vora
e10a3d0b8d chore: move cheaper condition first 2022-11-21 17:30:32 +05:30
Sagar Vora
6e896aa412 fix: decorator usage 2022-11-21 17:17:18 +05:30
Sagar Vora
8003b907c1 chore: cache role_perms instead 2022-11-21 17:11:34 +05:30
marination
4cd80bd279 fix: Avoid caching unsaved documents and secure whitelist decorator
- Avoid caching documents like 'new-item-1', default to doctype perms instead
- Use secure `whitelist_for_tests` decorator instead
2022-11-21 16:41:37 +05:30
marination
0937c962a7 chore: web_form.py format via pre-commit 2022-11-21 16:18:58 +05:30
Marica
209ecd02fb
Merge branch 'develop' into get_role_permissions-js-consistency 2022-11-21 15:38:33 +05:30
marination
d529b2a64e chore: Cache Document level perms as well in has_perm
- Cache documet level output of `get_perm` in `has_perm` as well
2022-11-21 15:32:39 +05:30
Shariq Ansari
c56c71b1e0
Merge pull request #18945 from theopen-institute/oi-webform-error 2022-11-21 15:25:58 +05:30
PeterG
4ec7d2dbba
feat(minor): redirect after login from NotPermittedPage (#18946)
* redirect after login from NotPermittedPage
2022-11-21 14:56:18 +05:30
Ankush Menat
e594c35a3a fix: show fields without labels in print format builder (#18939)
* fix: show fields without labels in print format builder

* refactor: dont hardcode layout fields

[skip ci]

Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>

Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-11-21 14:52:31 +05:30
PeterG
cfa9ed4fa0
Update frappe/website/doctype/web_form/web_form.py
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-11-21 15:06:17 +05:45