Ankush Menat
8088bd3891
chore: Drop empty UnitTestCases ( #32867 )
...
Next to zero adoption after introduction, just noise in codebase.
I don't see any point in arguing about purity of test cases when
existence and quality of test cases is usually the bigger problem.
Dropped using semgrep
2025-06-10 05:28:53 +00:00
Ankush Menat
e4bc7f361b
Revert: DocRef ( #32866 )
...
- Hardly used anywhere
- Too many hardcoded `__value__` calls without which it's not usable.
- Another type to worry about
2025-06-10 05:20:56 +00:00
Ankush Menat
49a11a0112
Merge pull request #32865 from ankush/check_link_value
...
fix: Assert type of link field values
2025-06-10 10:22:00 +05:30
Ankush Menat
9de31d8516
ci: Don't run CI with PYTHONOPTIMIZE flag
...
🤦
2025-06-10 10:10:54 +05:30
Ankush Menat
22827056ce
fix: Assert type of link field values
2025-06-10 10:10:51 +05:30
Sagar Vora
72f3d7a754
Merge pull request #32861 from sagarvora/fix-perm-check
2025-06-10 04:33:44 +00:00
Aayush Dalal
ca5b4cea0b
fix: throw permission error ( #32860 )
2025-06-10 08:47:49 +05:30
Sagar Vora
7c4b6b3dc1
fix: check permissions as per specified user
2025-06-09 23:31:50 +05:30
Sagar Vora
db3354f111
Merge pull request #32859 from sagarvora/try-fin
...
fix: always restore old user
2025-06-09 16:11:52 +00:00
Sagar Vora
7afe6dbbda
Merge pull request #32858 from sagarvora/add-test-comments
...
chore: add comments for test code
2025-06-09 16:04:18 +00:00
Sagar Vora
1d5aa7a4a5
fix: always restore old user
2025-06-09 21:30:21 +05:30
Sagar Vora
a822b2840d
chore: add comments for test code
2025-06-09 21:22:59 +05:30
Soham Kulkarni
eb7d597e34
chore: bump sentry-sdk ( #32856 )
2025-06-09 20:15:21 +05:30
Ankush Menat
292646a5a7
Revert "Revert "perf: Make get_query query mutable ( #32849 )" ( #32855 )" ( #32857 )
...
This reverts commit 85dc9e6981
2025-06-09 14:43:27 +00:00
Ankush Menat
85dc9e6981
Revert "perf: Make get_query query mutable ( #32849 )" ( #32855 )
...
This reverts commit dda62ff784
2025-06-09 13:17:16 +00:00
Soham Kulkarni
5d194fdbd3
Merge pull request #32814 from sokumon/communication-query-perm
...
fix: show communication based on recipient and sender
2025-06-09 16:32:12 +05:30
Ankush Menat
15dda50365
Revert "fix: Pin web workers by default ( #31739 )" ( #32852 )
...
This reverts commit 4533f92582
2025-06-09 09:52:23 +00:00
sokumon
d727b16a2b
fix: show communication based on recipient and sender
2025-06-09 15:05:28 +05:30
Ankush Menat
dda62ff784
perf: Make get_query query mutable ( #32849 )
...
pypika internally keeps copying query builder object because everything
is supposed to be immutable in pypika design, this however is terribly
slow. Often query generation takes more time than query execution.
This PR makes query builder mutable inside `get_query` function to avoid
copying while applying fields, filters, limit, order etc.
It's marked as immutable again when sending it back to users of the API.
2025-06-09 13:46:40 +05:30
Ankush Menat
8c1ee68ce6
perf: Skip order_by in link validation ( #32848 )
...
~10% faster because no QB overhead
2025-06-09 07:35:00 +00:00
Ankush Menat
f9ff807e4c
refactor: Rename get_settings -> get_single_value ( #32840 )
...
Not all single doctypes are settings, so this is better. Implicit
caching is fine, same is done for `db` APIs on singles. We *should* aim
for 100% correctness of caching implementation, especially for singles.
Thanks to @netchampfaris for the suggestion.
2025-06-09 04:20:29 +00:00
Soham Kulkarni
7bcac9d419
Merge pull request #32833 from sokumon/toolbar-issue
...
fix: add check if toolbar exists
2025-06-07 16:07:33 +05:30
sokumon
8811e6118b
fix: add check if toolbar exists
2025-06-07 15:08:48 +05:30
MochaMind
e83a79a501
fix: sync translations from crowdin ( #32703 )
2025-06-06 22:14:16 +02:00
Soham Kulkarni
0848426642
Merge pull request #32633 from sokumon/handle-imap-abort
...
fix: handle imap abort in email server
2025-06-07 00:39:37 +05:30
Sagar Vora
226c68846a
Merge pull request #32829 from sagarvora/allow-zero-default
...
fix: allow `0` to be a default value for dialog fields
2025-06-06 17:39:25 +00:00
Sagar Vora
8df7df8897
fix: allow 0 to be a default value for dialog fields
2025-06-06 22:46:11 +05:30
Sagar Vora
b50131c9b8
Merge pull request #32827 from frappe/revert-32822-allow-zero-default
...
Revert "fix: allow `0` to be a default value for dialog fields"
2025-06-06 17:15:22 +00:00
Sagar Vora
e88f834c70
Revert "fix: allow 0 to be a default value for dialog fields"
2025-06-06 21:22:38 +05:30
Sagar Vora
695f561bbb
Merge pull request #32822 from sagarvora/allow-zero-default
2025-06-06 14:02:41 +00:00
Sagar Vora
0d603f6f4f
fix: allow 0 to be a default value for dialog fields
2025-06-06 19:12:39 +05:30
Ankush Menat
caf415f13e
feat: get_settings ( #32821 )
...
* feat: get_settings
get_cached_value doesn't work well with singles because you either need
to pass `None` or repeat doctype name... both are awekward and easy to
shoot yourself in foot with.
* refactor: Use cached settings
2025-06-06 18:34:17 +05:30
Akhil Narang
1a3602f715
feat: add in a doctype to optionally track API Requests ( #32622 )
2025-06-06 13:22:25 +05:30
Ocheretovich
d5518fde79
chore: update license link in readme ( #32815 )
2025-06-06 12:56:51 +05:30
Soham Kulkarni
1f01571bb1
Merge pull request #32805 from sokumon/allow-bulk-delete
...
fix: allow bulk delete for docs with workflow
2025-06-05 23:08:00 +05:30
Ankush Menat
90a410d05e
Merge pull request #32781 from ankush/cruft_invalidations
...
perf!: Speedup link validations, fetch, docstatus
2025-06-05 22:08:16 +05:30
Ankush Menat
a278ff2356
chore: remove invalid return type
2025-06-05 21:38:14 +05:30
Ankush Menat
515d9006a4
refactor: simplify link field checks
...
Also: perf: only fetch docstatus if required
This will let us do index-only scans.
2025-06-05 21:38:12 +05:30
ruthra kumar
3a2840518b
Merge pull request #32806 from ruthra-kumar/return_code_for_light_runner
...
refactor: return code for light test runner
2025-06-05 20:25:50 +05:30
ruthra kumar
7b811d0490
refactor: return code for light test runner
2025-06-05 20:10:24 +05:30
sokumon
c710cbcdad
fix: allow deleteion of docs despite workflow
2025-06-05 17:47:32 +05:30
Soham Kulkarni
3c0678efac
fix(mobile): broken UI/ UX issues ( #32577 )
...
* fix: add a way to go back to list view from form
* fix: show the correct logo while routing
* fix(mobile): make report view look decent
* fix: only show the back button if no previous route
* fix(mobile): broken timeline view
* fix(mobile): broken timeline actions
* fix(mobile): fix timeline content
* fix: minify duration in mobile view
* fix(mobile): align timeline dot
* fix(mobile): toggle visiblity of standard filters in list view
* fix: dont translate template string
* fix(minor): dont wrap the list count
2025-06-05 17:37:24 +05:30
Ejaaz Khan
1444dbfbbf
Merge pull request #32676 from zaqoutabed/export-chart-data-patch-1
...
feat: enable user to export chart data
2025-06-05 15:30:18 +05:30
Ankush Menat
4dd21f175e
perf: Avoid seprately fetching docstatus
2025-06-05 15:24:29 +05:30
Ankush Menat
c434f4ca14
Revert "Revert "perf: cache fetch from value too ( #32700 )" ( #32708 )"
...
This reverts commit 8a3f65338c
2025-06-05 15:24:29 +05:30
Ankush Menat
27e8561197
Merge pull request #32800 from ankush/db_cache_refactor
...
refactor!: Change db.value_cache data structure
2025-06-05 15:23:35 +05:30
Soham Kulkarni
441a6a646f
Merge pull request #32796 from sokumon/bump-datatable
...
chore: bump datatable
2025-06-05 15:23:09 +05:30
Ankush Menat
f1a03200ab
fix: clear db.value_cache when clearing doctype cache
2025-06-05 14:46:03 +05:30
Ankush Menat
47a47a9b5d
refactor!: Change internal datastructure of db.value_cache
...
It's now a defaultdictionary of `[doctype][name/filters][fieldname]`
This allows us to implement granular clearing and improve usage of this cache.
2025-06-05 14:46:03 +05:30
Ankush Menat
a3d5b4af77
Revert "perf: cache docstatus check for invalid links" ( #32799 )
...
This reverts commit be5c96acf22f208c4ec8fbcde92a721b0e84d561.
2025-06-05 08:52:57 +00:00
