Suraj Shetty
826ee3e73d
Merge pull request #21405 from adityahase/fix-esbuild-failure-node-14
2023-06-16 12:57:46 +05:30
gavin
6303e53eda
fix(desk): Allow setting filters_description via df API ( #21382 )
2023-06-16 12:54:05 +05:30
Aditya Hase
5b52350ae0
fix(build): Exit build process instead of throwing an exception
2023-06-16 12:27:30 +05:30
Suraj Shetty
1283ece760
Merge pull request #21396 from cogk/feat-icon-arrow-down-right-for-number-card
2023-06-16 09:14:02 +05:30
Corentin Flr
e586a1e5cf
perf(icons): Remove uneeded code on some arrow icons
2023-06-16 00:50:11 +02:00
Corentin Flr
7710dbb8bb
feat(icons): Add new icon arrow-down-right for Number Card
2023-06-16 00:28:34 +02:00
Ritwik Puri
71bfafc6b2
Merge pull request #21365 from treasuryesc/develop
...
fix: "Remember Last Selected Value" not working (frappe#21364)
2023-06-15 20:48:31 +05:30
Ritwik Puri
c999508cbf
Merge pull request #21392 from ankush/perf_share
...
perf: faster docshare queries
2023-06-15 20:37:07 +05:30
Ritwik Puri
62dbdddb56
Merge branch 'develop' into perf_share
2023-06-15 20:23:26 +05:30
Ankush Menat
e9645b759f
perf: Dont order_by while fetching shares
...
Unnecessary confusion to query planner
2023-06-15 18:07:06 +05:30
Ankush Menat
85cef317f2
perf: Index everyone in DocShare
...
A typical share query looks like this.
select `share_name` from `tabDocShare` where `tabDocShare`.`read` = 1.0 and
`tabDocShare`.`share_doctype` = 'Pick List' and (`tabDocShare`.`user` = 'username'
or `tabDocShare`.`everyone` = 1.0) order by `tabDocShare`.`modified` DESC;
None of existing indexes provide `everyone` values quickly, so `OR`
clause effectively clauses full table scan ALL THE TIME.
2023-06-15 18:04:58 +05:30
gavin
09501da12f
fix(meta): Revert to using conf over _dev_server for cache ( #21391 )
2023-06-15 17:45:10 +05:30
Ankush Menat
fcce713b14
perf: index for_user in Notification log ( #21379 )
...
Missed out before somehow: 3a5a45d8af
2023-06-14 21:24:54 +05:30
Ankush Menat
8155371162
fix: ignore DOCTYPES_FOR_DOCTYPE in issingle check ( #21375 )
2023-06-14 18:21:55 +05:30
Ankush Menat
3f3ee12338
Revert: keep supporting set_value for singles
...
w/ explicit check for singles
This shouldn't have any performance impact as last function call only
happens if we THINK it's single doctype. use set_single_value to avoid
that extra function call.
2023-06-14 17:30:32 +05:30
Ankush Menat
8b187b395c
chore: remove translation tool related APIs
...
This was removed a while ago, this function seems like leftover code
Not used anywhere else.
2023-06-14 17:14:54 +05:30
Ankush Menat
99ab17754b
fix: removing website theme breaks website ( #21373 )
2023-06-14 12:38:10 +05:30
Ankush Menat
c2a562b82e
ci: debug patch workflow failure ( #21369 )
2023-06-14 11:45:03 +05:30
Ankush Menat
039be73af4
refactor: Consider singles for dynamic set_value usage ( #21367 )
...
Found all usage using this semgrep rule:
```yaml
- pattern: frappe.db.set_value($DOCTYPE, ...)
- pattern-not: frappe.db.set_value("$STR", ...)
```
2023-06-14 10:46:25 +05:30
David Arnold
5d074f3237
ci: fix patch workflow ( #21363 )
2023-06-14 08:56:09 +05:30
Marco Fonseca
b0e8a75ee6
fix: "Remember Last Selected Value" not working (frappe#21364)
2023-06-13 22:59:40 -03:00
David Arnold
23dd8e9248
refactor: normalize redis invocation and unblock unix domain socket conn ( #21309 )
...
Prior to this change, given tat a unix domain socket string was passed
ad `frappe.conf.redis_queue`, then the url split would have failed.
With this change, the upstream API for `from_url` is invoked
transparently.
passing none values for username and password is inocuous; [proof](d95d8a24ed/redis/connection.py (L604) ) and
[proof](d95d8a24ed/redis/connection.py (L594) )
The [entrypoint](d95d8a24ed/redis/client.py (L868) ) passes these parameters on transparently.
2023-06-13 21:06:06 +05:30
Shariq Ansari
52b09e80f1
Merge pull request #21255 from pps190/fix-col-input-focus
...
fix: multiple input element's in a single control
2023-06-13 20:46:13 +05:30
Devin Slauenwhite
eed61e6485
fix: text to lowercase
...
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2023-06-13 11:14:35 -04:00
Shariq Ansari
e267f33534
Merge pull request #21359 from shariquerik/load-more-communication
2023-06-13 19:38:42 +05:30
Ankush Menat
63a1a32594
chore: remove unused argument
2023-06-13 19:03:52 +05:30
Shariq Ansari
610ef83270
Merge branch 'develop' into load-more-communication
2023-06-13 16:52:59 +05:30
Sagar Vora
97a7900da7
style: use for..of in frappe.model.clear_table()
2023-06-13 16:52:54 +05:30
Shariq Ansari
b9487498d1
Merge pull request #21306 from shariquerik/date-field-fix
2023-06-13 16:51:01 +05:30
Shariq Ansari
113a8004b2
Merge branch 'develop' into load-more-communication
2023-06-13 16:32:31 +05:30
Shariq Ansari
b3ab63e697
feat: load more communications button in timeline
2023-06-13 16:24:58 +05:30
Shariq Ansari
9e0ed9d2a2
fix: convert string to int
2023-06-13 16:23:39 +05:30
Shariq Ansari
82464a4149
fix: add timestamp attr on timeline-item
2023-06-13 16:22:22 +05:30
Shariq Ansari
0e962078fe
revert: temp fix to load communications
2023-06-13 16:20:07 +05:30
Ankush Menat
3d0888a5d5
refactor: set_value usage
2023-06-13 16:00:43 +05:30
Ankush Menat
4bf1139427
chore: remove get_shade usage
...
This function doesn't do anything
2023-06-13 16:00:43 +05:30
Ankush Menat
3005e66e45
refactor!: Drop previously deprecated code
2023-06-13 16:00:43 +05:30
Ankush Menat
bd60c60d4e
refactor!: remove legacy password hashing
...
It's been 5+ years, no need to add this compatibility layer anymore.
2023-06-13 16:00:43 +05:30
Sagar Vora
455103248d
fix: workspace blank after login ( #21356 )
2023-06-13 15:51:27 +05:30
Shariq Ansari
fe607f6e44
Merge branch 'develop' into date-field-fix
2023-06-13 15:49:22 +05:30
Ankush Menat
cfdbad6653
refactor!: Remove custom script import
2023-06-13 13:13:23 +05:30
Ankush Menat
74cbdbf07f
refactor: Deprecate importing of fixturs/custom_scripts
2023-06-13 13:13:23 +05:30
Ankush Menat
22149b5bff
chore: increase communication limit
...
This needs better fix, added temporarily
2023-06-13 12:12:21 +05:30
Vishal Kumar
9d20509492
fix: no role assigned message when role profile is passed ( #21342 )
...
* Fix: no role assigned message when role profile is passed
* refactor: rename misleading method
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-06-13 11:10:47 +05:30
Suraj Shetty
db358aafd5
Merge pull request #21341 from ruchamahabal/fix-fixture-sync
...
fix: handle fixtures & custom script syncing for missing doctypes
2023-06-13 10:50:02 +05:30
Sagar Vora
fb438f342d
fix: clean insert_after setters when resetting layout ( #21346 )
2023-06-13 10:42:57 +05:30
Shariq Ansari
42a6ba63a9
Merge branch 'develop' into date-field-fix
2023-06-13 10:34:07 +05:30
Shariq Ansari
ec39a9d612
Merge pull request #21347 from resilient-tech/customize-form-actions
...
chore(UX): reorder customize form actions (+ one rename)
2023-06-13 09:04:29 +05:30
Sagar Vora
113d271af7
chore(UX): reorder customize form actions (+ one rename)
2023-06-13 02:12:48 +05:30
Sagar Vora
0c72130ae6
fix: set confirm_action instead of reject_action for Reset Layout button ( #21345 )
2023-06-13 01:52:02 +05:30