Commit graph

43594 commits

Author SHA1 Message Date
Maharshi Patel
8550e7bded chore: deprecated get_filter_as_json
Instead of removing get_filter_as_json add console warn.
2023-10-10 21:18:20 +05:30
Maharshi Patel
27e4901e0b fix: workspace don't strip filter info on save.
currently on save of filter ( get_filter_as_json ) is used
to convert it to object with following structure:

```
{
   priority: (2) ['=', 'Medium'],
   status: (2) ['=', 'Open']
}
```

Doing this we lose information of parent doctype.
Missing parent doctype causes field not permitted error.

To fix this, I saved filter as it is and converted it to object when required.
2023-10-08 16:42:17 +05:30
Suraj Shetty
0c9db5060b
Merge pull request #22602 from resilient-tech/fix-long-title 2023-10-08 06:37:33 +05:30
Suraj Shetty
ecca2fcc7a
Merge pull request #22562 from FHenry/dev_translation_context_for_edit_grid_row_button 2023-10-08 06:27:35 +05:30
Florian HENRY
d05e0b8d4c Merge branch 'develop' of https://github.com/frappe/frappe into dev_translation_context_for_edit_grid_row_button 2023-10-07 16:30:52 +02:00
mergify[bot]
eee418a4c6
Merge pull request #22330 from blaggacao/feat/improve-openid-connect-devx
feat: improve openid connect devx
2023-10-07 13:43:36 +00:00
barredterra
ed2290d1d6 Merge branch 'develop' into feat/improve-openid-connect-devx 2023-10-07 15:22:59 +02:00
DaizyModi
1cd51644a2 fix: set css for max width 412px 2023-10-06 15:10:58 +05:30
Maharshi Patel
d83b6758dd
Merge pull request #22626 from maharshivpatel/fix-workspace-style
fix: workspace style
2023-10-05 10:28:24 +05:30
Maharshi Patel
60b3f34691
Merge pull request #22628 from maharshivpatel/fix-kanban-memory-issue
fix: kanban remove unnecessary get_docfield
2023-10-05 00:45:14 +05:30
Maharshi Patel
6c5856f6fc
Merge pull request #22627 from maharshivpatel/hide-sidebar-on-new-doc
fix(minor): hide side section on new doc form.
2023-10-05 00:43:29 +05:30
Maharshi Patel
84adb3f68e
Merge pull request #22617 from maharshivpatel/fix-sidebar-and-multiselect
fix: sidebar, multi-select, body tag letter spacing
2023-10-05 00:24:38 +05:30
Maharshi Patel
68221f4d9e fix: kanban remove unnecessary get_docfield
*  Label will be same for all documents so there is no need to call get_docfield.
*  As it internally calls docfield_copy and makes "deep copy" for each document.
   which causes massive memory usage as number of document increases.
*  Instead get meta from docfield_map and use it.
2023-10-04 23:36:53 +05:30
Maharshi Patel
658f58d1e0 fix(minor): hide side section on new doc.
* on new doc, hide sidebar is hidden. however, layout-side-section is still visible.
* added hide-sidebar class to layout-side-section when doc is new.
2023-10-04 23:30:48 +05:30
Maharshi Patel
a46739688e fix: workspace style
* removed divider, changed arrow location for shortcut-widget-box

* removed indicator from quick_list_widget   also changed link items style to shortcut links with arrow

* added border for workspace and removed border for onboarding and quick_list_widget
2023-10-04 23:26:23 +05:30
Maharshi Patel
aaf40dc583 fix: sidebar redesign
* replaced all full width pill buttons with the labels and plus icons
* added a click listener to avatars for opening share dialog.
* made attachments label a link where user can click and open all of the files
  as there isn't enough space for explore buttons in new design
2023-10-04 23:05:24 +05:30
Ankush Menat
95882f5b69
Merge pull request #22624 from bosue/switch_add_multiple_button
fix(UX) Switch 'Add Multiple' and 'Add Row' button for consistency
2023-10-04 22:13:55 +05:30
Bernd Oliver Sünderhauf
3531686840 fix(UX) Switch 'Add Multiple' and 'Add Row' button for consistency 2023-10-04 17:37:20 +02:00
DaizyModi
ef7766af8a fix: set back get_textstyle for mobile devices 2023-10-04 12:29:45 +05:30
DaizyModi
2b3ff029ed fix: remove redundant rule 2023-10-04 12:13:51 +05:30
DaizyModi
a9de6ae05c fix: replace px with vw 2023-10-04 11:48:16 +05:30
Maharshi Patel
8718b60bfc fix: sidebar, multiselect, body tag letterspacing
* fixed space between multiselect pills
* fixed sidebar spacing and alignment
* added letterspacing of 0.02em in the body tag as this is the new base spacing.
2023-10-04 10:18:46 +05:30
Sambasiva Suda
53c795f4b8
fix: Workflow Builder not updating diagram with added states/transitions in table (#22429)
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
2023-10-03 17:13:51 +05:30
Suraj Shetty
c519239ff2
Merge pull request #22604 from deepeshgarg007/address_contact_perm 2023-10-02 23:06:16 +05:30
Deepesh Garg
99bec229fb chore: remove unintentional json updated 2023-10-02 16:51:09 +05:30
Deepesh Garg
89fa201d9b chore: remove unintentional json updated 2023-10-02 16:49:36 +05:30
Deepesh Garg
ca726a82b4 fix: Give All role permission to read/create own address and contact 2023-10-02 16:12:41 +05:30
Ankush Menat
4b0326ac39
Merge pull request #22603 from ankush/fix_button_groups
fix(UX): remove clutter from buttons on query report
2023-10-02 15:42:34 +05:30
Ankush Menat
19394ca353 fix(UX): remove clutter from buttons on query report 2023-10-02 15:37:08 +05:30
DaizyModi
dc2fbdca82 style: fix title for mobile screen 2023-10-02 12:49:23 +05:30
DaizyModi
6d398bdc64 style: prevent title overriden by buttons in small screen 2023-10-02 11:32:22 +05:30
Shariq Ansari
3761de260f
Merge pull request #22335 from bosue/vertical_checkbox_columns 2023-10-01 13:11:58 +05:30
Bernd Oliver Sünderhauf
42575d9951 fix(UX): Bring responsive multi-column design to module and role editors 2023-09-30 14:46:44 +02:00
Bernd Oliver Sünderhauf
7baab4490b fix(UX): Responsive, column-major design for multicheck elements. 2023-09-30 14:46:19 +02:00
Shariq Ansari
a7e03a9095
Merge pull request #22589 from cogk/fix-breakpoints-css 2023-09-29 21:32:22 +05:30
Corentin Forler
b9e16f5fed
fix: Fix breakpoints CSS variables using map-get
“Sass parses custom property declarations differently than other property declarations. All tokens are passed through to CSS as-is.”
https://sass-lang.com/documentation/style-rules/declarations/#custom-properties
2023-09-29 16:23:50 +02:00
Shariq Ansari
a0783fa8cc
Merge pull request #22587 from shariquerik/workspace-plus-icon-missing 2023-09-29 17:12:48 +05:30
Shariq Ansari
910b8e1b96 fix: plus icon missing in workspace 2023-09-29 17:10:34 +05:30
Ankush Menat
08f8019903
Merge pull request #22586 from ankush/make_default_private
fix: set default to private for InteractionComposer
2023-09-29 16:01:33 +05:30
Ankush Menat
4f3c9bc91a fix: set default to private for InteractionComposer
Most common use case for event/task is private so that's what should be
set here.
2023-09-29 15:59:45 +05:30
Ankush Menat
f02521bfc5
Merge pull request #22583 from ankush/filene_error
fix: no perm if doc doesn't exist
2023-09-29 13:27:29 +05:30
Ankush Menat
8242d75bc6 fix: no perm if doc doesn't exist
Right now "doc doesn't exist is thrown, instead we can assume that user
doesn't have permission to this file. User might have access to other
file still.
2023-09-29 13:11:02 +05:30
Florian HENRY
d1ade6ac62 Merge branch 'develop' of https://github.com/frappe/frappe into dev_translation_context_for_edit_grid_row_button 2023-09-29 09:20:27 +02:00
HENRY Florian
f04dd717c9
refactor: apply review
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-09-29 09:19:50 +02:00
HENRY Florian
dfe1990bf7
refactor: apply review
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-09-29 09:19:41 +02:00
Sagar Vora
e3b012b76d
Merge pull request #22578 from resilient-tech/double-translate 2023-09-29 12:20:48 +05:30
Sagar Vora
78240d8f0d
Merge pull request #22574 from resilient-tech/address-contact 2023-09-29 12:11:51 +05:30
Sagar Vora
20178bd3eb fix: improved validation for address and contact 2023-09-29 12:04:38 +05:30
Suraj Shetty
1b80bd45dd style: Fix linter warnings 2023-09-29 11:08:16 +05:30
Suraj Shetty
e5bce72d5c test: Fix flaky theme switcher UI test 2023-09-29 10:49:49 +05:30