Commit graph

39894 commits

Author SHA1 Message Date
barredterra
87298f5d76 test: export query report as CSV 2022-11-03 12:02:16 +01:00
barredterra
62d68a8be6 refactor: reuse functions from reportview 2022-10-29 18:07:51 +02:00
barredterra
a232e7f0c1 fix: don't parse CSV params for Excel 2022-10-29 18:05:52 +02:00
barredterra
685eb419eb refactor: utility function get_export_dialog 2022-10-29 17:17:05 +02:00
barredterra
40593ac1be feat: CSV params for query report 2022-10-28 19:54:33 +02:00
barredterra
26534118e4 feat: CSV params for report view 2022-10-28 19:54:03 +02:00
Faris Ansari
aa8957e785
fix(insert_many): list instead of set to maintain order (#18641) 2022-10-28 14:37:17 +05:30
Sagar Vora
d35aa6c545
fix: use is_file_path_valid instead of is_safe_path (#18316)
* fix: use `validate_file_path` instead of `is_safe_path`

* test: specify `is_private` for file with private URL
2022-10-28 13:56:24 +05:30
Ankush Menat
1c613179bb
fix: correct stacklevel for warnings (#18633)
Stacklevel=2 just points to frame that called warning and not frame
where it originated. This frame is useless in most cases as you can just
`grep` for it instead of looking at log.

stacklevel=3 gives frame which is calling the code with warnings.

[skip ci]
2022-10-28 12:22:24 +05:30
Shariq Ansari
ae23fd971c
Merge pull request #18590 from NagariaHussain/fix-link-routing
fix(router-js): handle case when link is not of same host
2022-10-27 18:52:38 +05:30
Shariq Ansari
ce7096ff66
Merge branch 'develop' into fix-link-routing 2022-10-27 16:35:02 +05:30
Hussain Nagaria
ccbd6ffab3 fix(formatting): use snake case for variable names 2022-10-27 16:30:28 +05:30
Ankush Menat
3ddac5fe92
refactor: accurate translation caching (#18595)
* refactor: rename poorly named functions

* refactor: getting translation from apps

- use generator
- use sane name for cache key
- avoid manual handling of frappe.local state just use cache() interface
2022-10-27 16:28:02 +05:30
Sagar Vora
cf02106683
Merge pull request #18593 from resilient-tech/recorder-fix
fix: use `async...await` when parsing route
2022-10-27 08:53:05 +00:00
Sagar Vora
22990ff343 fix: use async...await when parsing route 2022-10-27 13:59:08 +05:30
Hussain Nagaria
8cdda2e721 fix(router-js): handle case when link is not of same host 2022-10-27 13:48:16 +05:30
Ankush Menat
c5c91bdbd3
fix(UX): warn about Etc/* timezones behaviour (#18587) 2022-10-27 11:52:47 +05:30
Faris Ansari
5c2b917f52
refactor(minor): Tab layout in Website Theme form (#18570) 2022-10-26 00:15:47 +05:30
Wolfram Schmidt
66fbd14c3a
chore: fix DE translations
added missing translation

[skip ci]
2022-10-25 12:06:49 +05:30
dependabot[bot]
ce9570de56
build(deps): bump bruceadams/get-release from 1.2.3 to 1.3.1 (#18535)
Bumps [bruceadams/get-release](https://github.com/bruceadams/get-release) from 1.2.3 to 1.3.1.
- [Release notes](https://github.com/bruceadams/get-release/releases)
- [Commits](https://github.com/bruceadams/get-release/compare/v1.2.3...v1.3.1)

---
updated-dependencies:
- dependency-name: bruceadams/get-release
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[skip ci]
2022-10-25 11:30:08 +05:30
Andrew McLeod
01fe2da368
fix(email): generate random filename when attachment filenames are same upon inbound email (#18483)
Fix issue when an email has multiple inline images with the same filename. Currently the cid_map is overwritten; instead, attach the files with different names. Emails where every inline image has the filename 'image.png', only one of the images ends up correctly linked.
2022-10-24 00:37:49 +05:30
Ankush Menat
8222a60546
chore: bump pillow (#18496)
security fixes: https://pillow.readthedocs.io/en/stable/releasenotes/9.2.0.html
2022-10-23 15:56:23 +05:30
Ankush Menat
3491d0dcb0
refactor: dynamically load web form module (#18486) 2022-10-23 11:20:17 +05:30
Ritwik Puri
dad080842a
fix: don't print multiple print statements when database settings dont match with expected settings (#18492)
Also, fetch mariadb variables only once when checking mariadb variables
2022-10-22 21:55:12 +05:30
Komal-Saraf0609
8fd497a594
fix: map view doesnt open (#18487)
Co-authored-by: Komal Saraf <komal@frappe.io>
2022-10-21 15:01:06 +05:30
Ernesto Ruiz
745d956678
fix: Improve Translation on To Do list view (#18484) 2022-10-21 10:02:10 +05:30
Dany Robert
f383669107
feat: meaningful report pdf name (#18422)
* feat: meaningful report pdf name

* feat: limited filename length

* chore: uncomment line
2022-10-20 17:00:06 +05:30
Daizy Modi
fce9ccedaa
fix: only execute generator if value is not found in redis cache (#18472)
* fix: use of generator in

* fix: improve docstring

* fix: improve docstring

* fix: directly assign value to flags

Co-authored-by: Daizy <DaizyModi>
2022-10-20 16:48:03 +05:30
Ritwik Puri
1bf384f81d
fix: consider reference docname when reference doctype is Contact when setting participant emails in event doctype (#18463) 2022-10-20 03:02:05 +05:30
Wolfram Schmidt
1e2370ffd3
chore: update de translation (#18476)
Make Attachments Public by Default, Anhänge im Standard als öffentlich markieren,
2022-10-20 02:47:48 +05:30
Ankush Menat
20593f155d
fix: delete custom tables when doctype is deleted (#18433)
* fix: delete custom tables when doctype is deleted
2022-10-19 16:45:56 +05:30
Ankush Menat
abaa830bbc
feat: db storage usage report (#18464)
Basic report to check storage usage by each table.

Note: This is not 100% accurate and will never be 100% accurate but gives rough indication of which table is consuming how much storage.

`no-docs`

[skip ci]
2022-10-19 15:23:00 +05:30
Ritwik Puri
59387d1a74
Merge pull request #18431 from phot0n/fix-bulk-edit-datetime
fix: consider now datetime if the default value is now for datetime field
2022-10-19 13:07:38 +05:30
phot0n
71bb5e835d fix(minor): consider lowercase value for comparision in set_formatted_input for datetime field 2022-10-19 12:01:44 +05:30
Ankush Menat
061a9aa2ab test: db_set does not query for new doc
[skip ci]
2022-10-19 10:58:29 +05:30
PeterG
3676188083
fix: google calendar sync times (system tz) (#18458)
* fix: google calendar sync times (system tz)

* added line breaks to excessively long bit

* (chore) linter appeasement

* chore: linting

[skip ci]
2022-10-19 10:39:43 +05:30
Ritwik Puri
dc92248378
Merge branch 'develop' into fix-bulk-edit-datetime 2022-10-19 02:17:20 +05:30
Ankush Menat
d0715dd574
Merge pull request #18453 from ankush/db_set_null
fix: dont `db_set` on unsaved document
2022-10-18 22:01:45 +05:30
Rushabh Mehta
83c310b779
Merge pull request #18452 from rmehta/blog-category-fix
fix(ux): add better home for blog category, cleanup forms
2022-10-18 21:50:22 +05:30
Anoop
c44e278fed
feat: add video conferencing option (Google Meet) to Google Calendar integration (#17851)
* feat: add video conferencing (via google meet) for events syncing with google calendar

* fix: unset add_video_conferencing if sync_with_google_calendar not enabled

* fix: remove conference data if add_video_conferencing disabled during update

* fix: restrict add conferencing if event_category in Event, Meeting and Other

* fix: save meet link while pulling from calendar
updated response API Response comment with conference details
show google calendar section if pulled from google calendar

* feat: show link to join video conference with google meet

* fix(style): linter errors

* fix(style): linter errors

* fix: set conferenceDataVersion 1 only if google meet conferencing enabled
remove google meet link from event needs both conferenceData as null and conferenceDataVersion 1

* Update frappe/desk/doctype/event/event.py

show add_video_conferencing for events of all categories

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>

* Update frappe/desk/doctype/event/event.json

show add_video_conferencing for events of all categories

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>

* fix: handle empty ends_on, use starts_on

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>

* fix: do not update Event modified time on db set meet link

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>

* fix: add email field event participants table
set email from linked contact
google calendar event to use event participant email as attendees

* fix: attendees not cleared from google calendar event

* fix(style): linter suggestions

* fix: make email field non-read only, called set_participants_email from before_save hook

* test: update new no of fields in event doctype in test_fetch_to_customize

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-10-18 19:07:48 +05:30
Ankush Menat
1bd61d5c25 fix: dont db_set on unsaved document 2022-10-18 17:38:03 +05:30
Rushabh Mehta
2a50d6c593 fix(ux): add better home for blog category, cleanup forms 2022-10-18 17:28:47 +05:30
Ankush Menat
6e020f333e
Merge pull request #18443 from netchampfaris/client-delete-child-doctype
fix(frappe.client): delete child doc via parent
2022-10-18 17:00:13 +05:30
Shariq Ansari
5c2dfcb9a0
Merge pull request #18425 from maharshivpatel/fix-ui-mobile-grid 2022-10-18 14:50:36 +05:30
Faris Ansari
2b859990d2 test(client.delete): test for child doc delete 2022-10-18 14:15:37 +05:30
Faris Ansari
8acbc38670 fix: raise error if child doc not found 2022-10-18 13:46:57 +05:30
Maharshi Patel
6b1c825741 fix(UI): consider 2px border at grid end 2022-10-18 13:02:42 +05:30
Ankush Menat
c2f43c4b26
fix: validate website settings (#18446) 2022-10-18 12:41:36 +05:30
Shariq Ansari
98e1813de1 fix(UI): lesser margin if cell is focused 2022-10-18 11:37:37 +05:30
dependabot[bot]
ab259343c2
build(deps): bump actions/checkout from 2 to 3 (#18442)
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/checkout/compare/v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-10-18 10:07:56 +05:30