Commit graph

32942 commits

Author SHA1 Message Date
Gavin D'souza
88ef41bc58 fix(typo): Let's try executing bound method instead 2021-05-26 19:49:22 +05:30
Gavin D'souza
295d44cee5 chore: Drop future from requirements.txt 2021-05-26 19:31:17 +05:30
Gavin D'souza
f6b215938a fix: Use raw string to avoid invalid sequence errors
Escaped when proven easier
2021-05-26 19:30:08 +05:30
Gavin D'souza
131cfaee8b fix: Close file after read
This fixes the ResourceWarning errors due to unclosed files while
utilizing the website router
2021-05-26 17:07:23 +05:30
Gavin D'souza
3adb84eb8d chore: Drop watchdog dependency
Watchdog isn't used by Frappe, and there wasn't any mechanism to access
it directly either. By default, bench serve (or start) uses
Werkzeug's watchdogreloader
2021-05-26 17:04:28 +05:30
Gavin D'souza
bd6fcddd04 chore: Drop unreachable code 2021-05-26 16:41:32 +05:30
Gavin D'souza
feea2f3c44 fix: Use raw string to avoid invalid escape sequence errors 2021-05-26 16:32:41 +05:30
Gavin D'souza
1e9b0cf386 fix: Use dict.items instead of six.iteritems 2021-05-26 16:02:27 +05:30
Gavin D'souza
1acb2ddd2f fix: Use context managers to stream data
While executing git commands in the shell via Frappe processes, use
context managers to ensure files get closed after usage. This fixes the
ResourceWarning errors due to unclosed files.
2021-05-26 15:54:36 +05:30
Gavin D'souza
d236a93169 chore: Replacing and updating bleach source list
* The library bleach-whitelist was deprecated and renamed to
bleach-allowlist.
* Updated the usages and requirements for the same.
2021-05-26 15:45:34 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Gavin D'souza
e8cf96d1d3 fix: Replace cmp with different logic
cmp was being used from past.builtins library since it was deprecated in
PY2. It's hard to understand behaviour of their usages, so this is an
attempt to replicate behaviour with simpler logic, making this more
readable.

Also, removed usages of iteritems and string_types, compatibility
imports
2021-05-26 13:25:01 +05:30
Akshay Kumar Tripathi
b0f1bbc378
fix: corrected the function get_url (#13330)
* Removed /Form from the function get_url

As per issue #12820, I think /Form was causing a problem so I removed it. Now the get_url returns URL in the format: "app/doctype/name".

* fix: Change to f-strings

* Implement slug on get_url

* Removed slug for names
2021-05-26 05:07:50 +00:00
mergify[bot]
8ebc251394
Merge pull request #13065 from gavindsouza/api-updates
fix: Evaluate boolean values better via /api/resource/<doctype>
2021-05-26 04:41:55 +00:00
Suraj Shetty
8764134309
ci: Run mariadb tests after PR merge for coverage badge 2021-05-26 10:02:12 +05:30
Gavin D'souza
b215921a97 fix: Convert only as_dict and debug values to bool
Given the scope of its usage at this point, this becomes a problem when you'd have a field named y,n, true, false and order_by that field, or have the same values for a document name that parent parameter would accept out of all those that Frappe REST allows.
2021-05-25 21:44:54 +05:30
mergify[bot]
21473aced7
Merge pull request #13338 from resilient-tech/fix-cb-grid
fix: double checkboxes in editable grid
2021-05-25 15:47:38 +00:00
Sagar Vora
e79ce22d4d fix: double checkboxes showing in editable grid 2021-05-25 19:41:03 +05:30
Suraj Shetty
878ac658b2
Merge pull request #13333 from surajshetty3416/fix-breakpoint
feat: Add grid breakpoint css_variables
2021-05-25 16:08:22 +05:30
mergify[bot]
1c5747bf71
Merge pull request #13286 from gavindsouza/router-fix
fix: Don't strip 'app' from doctype route names
2021-05-25 10:31:12 +00:00
Suraj Shetty
ad8b844942 feat: Add grid breakpoint css_variables
So that other apps does not have to be dependant on 'variables' file to get grid sizes
2021-05-25 15:51:59 +05:30
mergify[bot]
b7312545f2
Merge pull request #13296 from resilient-tech/fix-col-heading
fix: set title attribute for grid header columns
2021-05-25 09:52:32 +00:00
mergify[bot]
b726f4bff7
Merge pull request #13325 from frappe/dependabot/npm_and_yarn/browserslist-4.16.6
chore(deps): bump browserslist from 4.4.2 to 4.16.6
2021-05-25 05:39:45 +00:00
gavin
6fb979b81c
Merge pull request #13206 from ankush/slack_disable_link
feat(minor): option to disable button in slack message
2021-05-25 11:05:34 +05:30
dependabot[bot]
62015292da
chore(deps): bump browserslist from 4.4.2 to 4.16.6
Bumps [browserslist](https://github.com/browserslist/browserslist) from 4.4.2 to 4.16.6.
- [Release notes](https://github.com/browserslist/browserslist/releases)
- [Changelog](https://github.com/browserslist/browserslist/blob/main/CHANGELOG.md)
- [Commits](https://github.com/browserslist/browserslist/compare/4.4.2...4.16.6)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-25 00:44:04 +00:00
mergify[bot]
19d905a2e8
Merge pull request #13295 from resilient-tech/fix-report-link
fix(Workspace): broken links for reports created with Report Builder
2021-05-24 17:10:53 +00:00
Ankush Menat
ba1c11008f
feat: option to disable button in slack message
Add a checkbox that lets user disable button which has link to the
document.
2021-05-24 22:01:45 +05:30
Kenneth Sequeira
6632b5876a
feat(minor): add number format parameter in fmt_money (#13255)
* feat: add number format parameter in fmt_money

* review fix: move new parameter at the end

Co-authored-by: Kenneth Sequeira <kenneth@Kenneths-MacBook-Air.local>
2021-05-24 16:14:56 +00:00
mergify[bot]
1ac27efa7a
Merge pull request #13309 from gavindsouza/exempt-button-customize
fix(DocType): Skip field name conflict validation for No value fields
2021-05-24 08:46:09 +00:00
Gavin D'souza
ee8f349344 fix: Skip field name conflict validation for No value fields 2021-05-24 12:57:18 +05:30
Gavin D'souza
c90cea89cb feat(minor): Nudge for method exists for button fieldtype
This doesn't throw an exception, rather a msgprint in case the
developer isn't ready for that yet. This serves as a nudge rather than a
validation
2021-05-24 12:30:02 +05:30
Gavin D'souza
8d590eabca fix: Don't throw error for fieldtype Button conflicts 2021-05-24 11:59:55 +05:30
mergify[bot]
36b3d415e7
Merge pull request #13303 from chromonav/user-profile-not-loading
fix: user profile not loading
2021-05-24 06:25:16 +00:00
Rushabh Mehta
03efb18571
Merge pull request #13044 from alyf-de/fix_number_format_de
fix: default number format for germany
2021-05-24 09:41:02 +05:30
Suraj Shetty
d6f8fc7429
Merge pull request #13306 from surajshetty3416/fix-script-manager
fix: Use extend_cscript in make to properly extend functions of class
2021-05-24 09:07:19 +05:30
Suraj Shetty
4410813502 fix: Use extend_cscript in make to properly extend functions of class 2021-05-24 09:05:00 +05:30
Chinmay Kulkarni
3e44744a37
fix: user profile not loading
fix issue caused during implementation of esbuild system
2021-05-23 23:30:01 +05:30
Suraj Shetty
b5b8810945
Merge pull request #13300 from surajshetty3416/fix-extend-cscript 2021-05-23 13:38:38 +05:30
Suraj Shetty
dcf2ef223c
Merge pull request #13284 from surajshetty3416/fix-email-tracker 2021-05-22 23:54:23 +05:30
Suraj Shetty
52a0a905a7 test: Fix email tracker test case 2021-05-22 20:44:48 +05:30
mergify[bot]
109c1882c5
Merge pull request #13293 from anandology/sendmail-issue-13292
fix: issue with sending emails
2021-05-22 12:11:18 +00:00
Sagar Vora
3756461926 fix: set title attribute for grid header columns 2021-05-22 14:14:10 +05:30
Sagar Vora
8513fdd34a fix: missing semicolon 2021-05-22 13:39:19 +05:30
Sagar Vora
1edd2f68d4 fix: condition for is_query_report 2021-05-22 13:31:12 +05:30
Sagar Vora
c1e0930e16 fix(Workspace): broken links for reports created with Report Builder 2021-05-22 13:22:10 +05:30
Anand Chitipothu
114bdb5721 fix: issue with sending emails
The sendmail functionality got broken in recent refactoring to the email
module. The call to sendmail was passing from_addr and to_addrs in the
wrong order. This has been fixed.

Issue #13292
2021-05-22 11:05:39 +05:30
Gavin D'souza
ba7785eaa0 fix: Don't strip 'app' from doctype route names
After creation of a new document and going back would break routes for doctypes that start with 'App'. In observed instance, it would clips the “app” portion in the appraisal and appraisal-template.
2021-05-21 18:53:44 +05:30
Suraj Shetty
b38a15aad7 fix: Check 2021-05-21 17:35:02 +05:30
Suraj Shetty
925f1273d5 fix: Use email_account_doc to get track_email_status value 2021-05-21 17:11:14 +05:30
Suraj Shetty
07cdab3902 fix: Add a command to properly extend class methods 2021-05-21 17:01:28 +05:30