Commit graph

40292 commits

Author SHA1 Message Date
phot0n
917dfdae78 refactor(minor): use virtual docfield for report_start_time - and renamed it to queued_at
* chore: rename Report End Time label to Finished At
2022-11-29 13:46:11 +05:30
phot0n
08bae70908 perf: use modified for fetching old logs for clearing 2022-11-29 13:46:11 +05:30
phot0n
433615beed chore: add queued_by virual docfield in prepared report 2022-11-29 13:46:11 +05:30
phot0n
18d48ddeb8 refactor: cleanup peprared result render and old logs cleanup
* directly fetch columns from result file rather than storing it in db
* remove prepared report settings from system settings
* remove disable_prepared_report from report doctype
2022-11-29 13:46:11 +05:30
phot0n
6218a99301 refactor(minor): dry-er code in generate_report 2022-11-29 13:46:11 +05:30
phot0n
cd468c3229 fix(ux): don't show report_name field on prepared report doc 2022-11-29 13:46:11 +05:30
phot0n
ecbafb5a23 feat(minor): add job_id column to prepared report
* chore: make report_name mandatory
2022-11-29 13:46:11 +05:30
phot0n
4fe8eadf5e refactor: remove unnecessary fields from prepared report
* removed ref_report_doctype
* changed title_field from ref_report_doctype to report_name (both are same)
* changed report_name field to link type
* changed autonaming to hash based
* added status in list view via document states
2022-11-29 13:46:11 +05:30
phot0n
9bfc43c148 fix: use after_insert hook for enqueuing report generation
this removes the need of additionally calling enqueue_report method

* enqueue report in long queue
* reduce the timeout from 100 mins to 30 mins
2022-11-29 13:46:11 +05:30
Ankush Menat
442060a96a
Merge pull request #17150 from ankush/bulk_object_inserts
feat: bulk insert simple Docs and iterator support for db.bulk_insert
2022-11-29 13:33:25 +05:30
Ankush Menat
7a3faf23e1
Merge pull request #18664 from barredterra/csv-params
feat: configurable CSV delimiter and quoting
2022-11-29 13:27:24 +05:30
Ankush Menat
465b3f6968 test: use _dict in tests
form_dict is usually _dict, otherwise some unrelated tests will fail.
2022-11-29 11:53:52 +05:30
HarryPaulo
f25358ad63
fix: "_dict" is an invalid attribute name because it starts with "_" (#19010)
* fix: "_dict" is an invalid attribute name because it starts with "_"

* chore: move to frappe namespace
2022-11-29 11:43:23 +05:30
Ankush Menat
c89cdb4f0c test: handle multi-queue consumers 2022-11-29 11:30:12 +05:30
Ankush Menat
6dda853278
fix: broken link for email tracking pixels (#19030) 2022-11-28 20:46:51 +05:30
Shariq Ansari
abb9055be4
fix(UX): Make fetch_from read_only if fetch_is_empty is not set (#19025)
* fix(UX): Make fetch_from read_only if fetch_is_empty is not set

* Update frappe/public/js/frappe/form/controls/base_input.js

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-11-28 16:53:34 +05:30
barredterra
b1f6152f38 fix: pop from form_params 2022-11-28 12:19:14 +01:00
barredterra
2c0827dda9 fix: test reportview 2022-11-28 12:16:18 +01:00
barredterra
ee18984e1f refactor: export_query 2022-11-28 12:15:57 +01:00
barredterra
5008bc0b09 fix: fieldname referenced before assignment 2022-11-28 12:15:30 +01:00
Ankush Menat
a6af1ed542 feat: bulk insert simple Document objects 2022-11-28 15:32:20 +05:30
Ankush Menat
7ec120d2ba refactor: support generators in db.bulk_insert
When you want to insert a huge amount of docs in DB, using bulk insert
currently requries creating a huge number of objects, this is
ineffecient from memory perspective and also delays failures if any till
last step in execution.
2022-11-28 15:29:59 +05:30
Shariq Ansari
321dbfa6c7
Merge pull request #19012 from resilient-tech/fix-grid-issues 2022-11-28 15:20:12 +05:30
gavin
6062d812a1
fix(db_query): Disallow usage of certain functions in *_by (#18981)
* fix(db_query): Disallow blacklisted functions in (order|group)_by

Changes:
- allow only functions that are not blacklisted in *_by clause:
  currently just sleep
- perf improvemnts: lower, in, split, strip & other low hanging  micro optimizations

Handle the following use cases:
- upper/lower case function usages
- spaces between function name and brackets

* test(db_query): Add tests for *_by checks
2022-11-28 12:42:29 +05:30
mergify[bot]
e35c7a2a3e
Merge pull request #19024 from ankush/sess_commit
refactor: request DB transaction
2022-11-28 06:46:13 +00:00
Ankush Menat
4f162da728 fix: rollback if not commiting 2022-11-28 11:43:41 +05:30
Ankush Menat
4cc367f6c1 fix: apply rollback to all HTTP methods that can write 2022-11-28 11:34:46 +05:30
Ankush Menat
7504c1bc73 refactor: simpler commit after_request 2022-11-28 11:31:24 +05:30
Mohammad Hussain Nagaria
a534e7a66a
fix: Pass *args and **kwargs in db_insert boilerplate for Virtual DocType (#19018)
[skip ci]
2022-11-28 11:14:24 +05:30
Sabu Siyad
406f894141
feat: default value options: sort (#19019)
[skip ci]

Signed-off-by: Sabu Siyad <hello@ssiyad.com>
2022-11-28 11:09:15 +05:30
barredterra
b8b6db541a feat: german translations for export dialog 2022-11-27 17:13:22 +01:00
barredterra
1d25437121 fix: duplicate translation of field labels 2022-11-27 17:10:53 +01:00
barredterra
d7139af6cc feat: hide csv settings in collapsible section 2022-11-27 17:02:25 +01:00
Raffael Meyer
83e2f524e2
Merge branch 'develop' into csv-params 2022-11-26 20:10:51 +01:00
barredterra
433b285b92 refactor: use provide_binary_file 2022-11-26 20:08:50 +01:00
barredterra
839de22d95 feat: add test for exporting reportview as CSV 2022-11-26 20:01:48 +01:00
barredterra
d70e5e73e2 refactor: extract common methods 2022-11-26 20:00:58 +01:00
Ankush Menat
263055e247
fix: site creation using non-root users (#19014) 2022-11-26 12:45:57 +05:30
Marica
a4db4550e9
fix: Avoid update_order twice on Kanban load (#19011)
* fix: Avoid `update_order` twice on kanban load

- The older logic called `kanban.update()` on a refresh (not on load) and returned from `render()`
- Due to a recent PR, it calls `kanban.update()` AND builds a new board on load, which invokes `update_order` twice consecutively and causes a timestamp error to be thrown

* chore: Remove redundant condition

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-11-25 20:55:16 +05:30
Sagar Vora
a14367f1d9
chore: replace use of cur_frm with this.frm (#19005) 2022-11-25 14:38:30 +05:30
Sagar Vora
375de8647a fix: discovery and styling issues in grid buttons 2022-11-25 14:13:05 +05:30
Ankush Menat
763bdb5d3c
Merge pull request #18996 from gavindsouza/spaces-db_query
fix(db_query): Space resilient sanitization
2022-11-25 13:12:20 +05:30
Ankush Menat
d00b98f460 chore: typo 2022-11-25 13:10:43 +05:30
Ankush Menat
4661083247
Merge pull request #18995 from ankush/multi_queue_workers
feat(workers): many small RQ worker features
2022-11-25 12:47:47 +05:30
gavin
35827af172
fix: Strip white spaces on lower cased field value
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-11-25 12:39:11 +05:30
Ankush Menat
ed28626021 refactor: simpler deque strat selection
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-11-25 12:14:37 +05:30
Ankush Menat
a8bf86ef75 feat: support dequeuing strategies for worker 2022-11-25 12:14:37 +05:30
Ankush Menat
aece93fbc5 feat: burst mode in workers
https://python-rq.org/docs/workers/#burst-mode
2022-11-25 12:14:33 +05:30
Ankush Menat
0ebd3945ff refactor: consider multi-queue consumption 2022-11-25 12:03:34 +05:30
Ankush Menat
40b2929c0d feat(workers): allow consuming multiple queues 2022-11-25 12:03:34 +05:30