mergify[bot]
91f446ef04
Merge pull request #14356 from shariquerik/primary-navbar-css-fix
...
fix: Fixed css for Primary Navbar template
2021-11-03 05:57:57 +00:00
mergify[bot]
92ad320917
Merge pull request #14489 from shariquerik/custom-report-dependency-fix
...
fix: Multi level custom report fix
2021-11-02 14:15:51 +00:00
Shariq Ansari
bf0fb0de5c
test: Added UI test for multi level query report
2021-11-02 17:39:14 +05:30
Faris Ansari
2f8a6491f7
Merge pull request #14854 from netchampfaris/bench-browse-login-as-user
...
fix: login as user with browse command
2021-11-02 17:12:18 +05:30
Faris Ansari
c75f15e25a
fix: print url only when user is Administrator
2021-11-02 13:52:09 +05:30
Faris Ansari
ce695b8706
fix: Restrict user logins to developer_mode
...
- Allow Administrator user login in production
- Print login url
2021-11-02 13:38:33 +05:30
mergify[bot]
53a2539c5a
feat(minor): Implement __getitem__ in Base Document ( #14855 ) ( #14866 )
...
* feat(minor): Implement __getitem__ in Base Document
This addition allows for syntactic sugars like writing doc["name"] to
access document name. This addition is solely for the sake of code
simplicity. Since dictionaries in Python follow this standard, we can
write code that works for both Vanilla Dicts, Frappe Dicts & all
Document objects
* fix: Use getattr over get in getitem
For the sake of consistency and some level of sanity in the universe.
Co-authored-by: Ankush Menat <ankush@frappe.io>
* fix: Raise KeyError instead of AttributeError
why: shit breaks down. Specifically stuff in Jinja templates, attributes
that are conditional. Either this is acceptable or subscripting objects
cannot and probably should not be possible along with our pre-condiitons
* chore: Use hasattr instead of get default
Couldn't decide between a style commit or a chore
Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 583a7ef23923d362c85beeabe57703c2d5b12a65)
Co-authored-by: gavin <gavin18d@gmail.com>
2021-11-02 13:24:36 +05:30
Shariq Ansari
04a145c40c
Merge branch 'frappe:develop' into primary-navbar-css-fix
2021-11-01 21:02:39 +05:30
mergify[bot]
95dc3875bb
Merge pull request #14859 from ankush/flaky_side_bar_test
...
test: flaky sidebar test due to msgprint
2021-11-01 11:28:05 +00:00
Ankush Menat
4be43092a3
test: flaky sidebar test due to msgprint
2021-11-01 16:10:36 +05:30
Lev
98fb2ac787
fix(UI): Translate preview popover data ( #14842 )
2021-11-01 16:09:08 +05:30
Ankush Menat
a03378e29d
Merge pull request #14558 from ankush/perf/remove_track_changes
...
perf: remove "track changes" from log-like doctypes
2021-11-01 14:27:00 +05:30
mergify[bot]
462ba256aa
Merge pull request #14845 from resilient-tech/fix-reportview-join
...
fix: clean `join` param when executing `reportview.get`
2021-11-01 08:45:32 +00:00
Faris Ansari
c5512d4c66
fix: login as user with browse command
...
`bench --site site.local browse --user Administrator`
2021-11-01 12:34:24 +05:30
mergify[bot]
16217838f9
Merge pull request #14834 from ankush/fix/global_search_link
...
fix: old style links in global search
2021-11-01 05:50:54 +00:00
mergify[bot]
c09b84da1e
Merge pull request #14843 from ankush/reload_doctype
...
fix: patch failure due to new field in doctype
2021-11-01 05:48:24 +00:00
mergify[bot]
9e85da4465
Merge pull request #14846 from sumaiya2908/ql-issue
...
fix(minor): add classes for rtl for proper layout
2021-11-01 05:29:36 +00:00
Summayya Hashmani
b3ca6b4068
refactor: space in code
2021-10-31 20:09:06 +05:30
Summayya
6e57e8b40d
fix(minor): add classes for rtl
2021-10-31 19:41:31 +05:30
Sagar Vora
2e48c0a85e
fix: clean join param when executing reportview.get
2021-10-31 19:20:51 +05:30
Ankush Menat
78705f3a4c
fix: patch failure due to new field in doctype
2021-10-31 18:32:14 +05:30
Faris Ansari
2ac2426c20
Merge pull request #14802 from netchampfaris/jinja-get_dom_id
...
fix: generate dom id helper for jinja
2021-10-31 13:39:30 +05:30
Ankush Menat
66568e7365
fix: old style links in global search
2021-10-29 21:35:21 +05:30
Faris Ansari
96ea14003d
fix: generate dom id helper for jinja
2021-10-29 16:26:45 +05:30
mergify[bot]
5477429aa8
Merge pull request #14801 from ankush/test/restore_scheduler
...
test: restore scheduler state after running tests
2021-10-29 10:24:04 +00:00
mergify[bot]
b27a24dc53
Merge pull request #14501 from hasnain2808/between-formatting
...
fix: format between for creation/ modified
2021-10-29 10:19:35 +00:00
Ankush Menat
4755f416db
test: restore scheduler state after running tests
2021-10-29 15:16:29 +05:30
gavin
92f6c4ac65
Merge pull request #14800 from gavindsouza/browserslist-update
...
chore: Bump browserlist dependency
2021-10-29 14:59:20 +05:30
Gavin D'souza
ebf93fe19b
chore: Bump browserlist dependency
2021-10-29 14:25:40 +05:30
Gavin D'souza
ccb53c0f5b
fix: If column comparision is done, dont check for ifnull/coalesce
2021-10-29 14:19:28 +05:30
mergify[bot]
9a933734eb
Merge pull request #14798 from ankush/test/enable-scheduler
...
test: enable scheduler back after running the test
2021-10-29 08:25:08 +00:00
Gavin D'souza
9bf043eddf
fix(db_query): Change fallback to min datetime
2021-10-29 13:24:28 +05:30
Gavin D'souza
9be8a0895d
Merge branch 'develop' into between-formatting
2021-10-29 13:13:55 +05:30
Ankush Menat
13a2c3403c
test: enable scheduler back after running the test
2021-10-29 13:10:28 +05:30
Ankush Menat
7b747a68f9
fix: disable "track changes" by default
2021-10-29 12:23:03 +05:30
Ankush Menat
7aa8688a09
perf: remove "track changes" from log-like doctypes
...
Removed "Track Changes" from:
- Activity Log
- Error Log
- Error Snapshot
- Scheduled Job Log
- View Log
- Notification Log
- Route History
- Energy Point Log
- Web Page View
These documents dont change and even if they did it's useless to keep
track of it IMO. Removing this speeds up insertion and saves storage.
2021-10-29 12:20:13 +05:30
rohitwaghchaure
6ae352a05f
fix: ignore filename with dotted path ( #14617 )
...
* fix: ignore dotted path in file name
* fix: condition for checking file
* Update data.py
* fix: only allow pdf files
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2021-10-28 19:23:57 +00:00
Aditya Hase
43a722d3bb
fix(minor): Don't allow frappe.cache() methods in server scripts ( #14609 )
2021-10-28 15:54:32 +05:30
mergify[bot]
80345e4206
Merge pull request #14526 from surajshetty3416/fix-has-permission-for-child-doc
...
fix: Check parent permission while doing `has_permission` for child
2021-10-28 10:08:50 +00:00
Suraj Shetty
4e6ea8fdbd
fix: Docstring of has_permission & made error title translatable
...
- doctype -> DocType
- fixed other typo
2021-10-28 15:25:45 +05:30
Suraj Shetty
57df0bad82
fix: Check permission for address and contact list
2021-10-28 15:14:53 +05:30
Suraj Shetty
bf34de1d04
fix: Assume that child doc will have parent references
2021-10-28 15:06:38 +05:30
Ankush Menat
af4ce8156d
fix: remove mutable defaults ( #14597 )
...
* fix: mutable defaults
* fix: missing defaults
2021-10-28 09:36:31 +00:00
mergify[bot]
cf13436ac5
Merge pull request #14604 from adityahase/fix-hooks
...
fix(minor): Don't allow changes to global hooks from server scripts
2021-10-28 09:26:47 +00:00
Suraj Shetty
7670c0430a
fix: Simplify code and fix typo
2021-10-28 14:49:52 +05:30
Aditya Hase
787364b166
fix(minor): Don't allow changes to global hooks from server scripts
2021-10-28 14:40:16 +05:30
Suraj Shetty
cb76118268
refactor: Check parent validity using parent meta
2021-10-28 13:41:12 +05:30
Suraj Shetty
95258bf9f2
fix: Do not allow child table access via "get_list_data"
2021-10-28 13:38:54 +05:30
rohitwaghchaure
2c77d938f2
Merge pull request #14602 from rohitwaghchaure/pdf-to-base-64
...
feat: pdf to base64 convert
2021-10-28 13:04:13 +05:30
Rohit Waghchaure
5ef72dd290
feat: pdf to base64 convert
2021-10-28 12:41:27 +05:30
