Commit graph

38222 commits

Author SHA1 Message Date
Ankush Menat
94920ab4ae
Merge pull request #16727 from ankush/pg_transaction_management
fix: explicitly start a new transaction
2022-06-07 12:46:23 +05:30
Anoop
747198cf17
fix: failing package import (#17075)
* local variable files initialized with get_doc_files return list
* removed for_sync argument not supported anymore by import_file_by_path
2022-06-07 11:51:51 +05:30
Ankush Menat
df3601b67b
Merge pull request #17084 from phot0n/fix-assigned-to-count-order
fix: use desc ordering when fetching Assigned To data
2022-06-06 23:13:29 +05:30
phot0n
d018da1819 fix: use desc ordering when fetching Assigned To data 2022-06-06 22:40:58 +05:30
Ernesto Ruiz
e925600b70
fix: link to Google Settings in Website Settings (#17083) 2022-06-06 20:13:48 +05:30
Faris Ansari
3d07a51442
fix: check read permission on link sub-fields (#17082) 2022-06-06 19:54:54 +05:30
Ankush Menat
09dc131c4a
Merge pull request #17061 from ankush/reduce_caching
perf!: improve document caching
2022-06-06 19:06:04 +05:30
gavin
11d00e72f8
Merge pull request #17005 from gavindsouza/filters_config-fixes
fix: filters_config
2022-06-06 16:34:39 +05:30
Ankush Menat
111df3a8d7 perf: improve document caching
As per current implementation whenever `get_doc` is called, document is
cached. However, this cache is only ever used by `get_cached_doc`. Going
through the codebase of both FF/ERPNext you'll find that `get_doc` is
used a lot more than `get_cached_doc`. So in many places, all this
caching overhead is unnecessary.

This change removes implicit caching from get_doc and replaces it with
cache-replacement instead. i.e. cache is only updated if it exists but
not created from get_doc.

Pros:
- faster `get_doc`
- lower memory usage on Redis
- Reduces chances of OOM by blowing up worker's memory as old docs can't
  be GCed until
- Correctness i.e. caching only what gets used from cache.

Con:
- After this change. First call to `get_cached_doc` will always be a cache miss. DUH.
2022-06-06 16:18:23 +05:30
Ankush Menat
d3b366f147 feat: cache_locally to limit caching in local.cache 2022-06-06 16:18:23 +05:30
Gavin D'souza
50b0eb8cca perf: Initialize Query engine only if used 2022-06-06 15:42:59 +05:30
Gavin D'souza
cc16342bb8 fix(filter): Fetch correct filter values 2022-06-06 15:31:47 +05:30
Ankush Menat
dd62749948
Merge pull request #17071 from ankush/quick_awesomebar
feat(workspace): start searching on alphabetic keypress
2022-06-06 15:21:53 +05:30
gavin
c8207768db
Merge branch 'develop' into filters_config-fixes 2022-06-06 15:03:06 +05:30
Ankush Menat
c7b0351d0e
Merge branch 'develop' into pg_transaction_management 2022-06-06 14:37:29 +05:30
gavin
27ddfae59b
Merge pull request #17074 from frappe/revert-16978-mention-permissions
Revert "fix: mention only users that can be read"
2022-06-06 13:57:08 +05:30
gavin
be6183d408
Merge pull request #17066 from gavindsouza/allow-relative-restore-paths
fix(restore): Remove incorrect validation that doesn't allow relative paths
2022-06-06 13:42:01 +05:30
Ritwik Puri
d9900d4742 Revert "fix: mention only users that can be read (#16978)"
This reverts commit 576af52ec6.
2022-06-06 13:14:09 +05:30
HENRY Florian
e0c25d2b2c
fix: update fr translation (#17070) 2022-06-05 22:38:52 +05:30
Ankush Menat
3272852b12 fix(UX): blur awesomebar after selecting result 2022-06-05 20:15:39 +05:30
Ankush Menat
0890046349 fix: dont show KB shortcut with no description 2022-06-05 20:15:39 +05:30
Ankush Menat
a65940e1c1 feat(UX): start typing on workspace to launch awesomebar 2022-06-05 20:15:36 +05:30
Ankush Menat
359c7768f5 fix: multiple postgres transaction abort issues
- wrap setup fixtures in savepoint
- wrap scheduled_job_type in savepoint
- ignore duplicates where it's ignored by exc
- dont attempt to delete from deleted table
- delete custom field and commit - stale meta causes future inserts to
  insert unknown field.
2022-06-05 00:26:15 +05:30
Ankush Menat
8861752675 fix: restart transaction after commit 2022-06-05 00:26:12 +05:30
Ankush Menat
654ded1a05 chore: print full stack on postgres DB errors 2022-06-04 22:42:03 +05:30
Gavin D'souza
e13df5ba49 fix(restore): Remove incorrect validation that doesn't allow relative paths 2022-06-04 18:20:44 +05:30
Ankush Menat
9137a597eb
ci: update apt cache (#17057) 2022-06-02 14:40:14 +05:30
Deepesh Garg
ce45bafb6e
Merge pull request #17054 from deepeshgarg007/v14-beta-release-fix
chore: fix semantic release config
2022-06-02 12:07:30 +05:30
Deepesh Garg
ebd2bd791c chore: fix semantic release config 2022-06-02 12:06:37 +05:30
Suraj Shetty
830ace2c36
Merge pull request #17021 from surajshetty3416/fix-document-signature-2 2022-06-01 20:31:15 +05:30
Suraj Shetty
2c95434114 style: Fix linter warnings 2022-06-01 19:57:28 +05:30
Suraj Shetty
a4d7cfdd24 fix: Update exception message 2022-06-01 19:53:57 +05:30
Suraj Shetty
121fb49fb5 refactor: Remove unnecessary code 2022-06-01 18:10:30 +05:30
Suraj Shetty
0cd41fbf0c
Merge branch 'develop' into fix-document-signature-2 2022-06-01 18:01:12 +05:30
Suraj Shetty
58d0bcd736
Merge pull request #17046 from surajshetty3416/fix-error-page
fix: Catch any exception and show proper error page
2022-06-01 18:00:46 +05:30
Suraj Shetty
105b398c68 fix: Randomize key length to make it harder to brute force 2022-06-01 17:59:44 +05:30
Suraj Shetty
59c7fb9e0d fix: Add "Document Share Key" to doctypes_to_skip in delete_doc.py
- To avoid error while deleting linked document.
2022-06-01 17:59:32 +05:30
Suraj Shetty
8f7d8bf1ff refactor: Update exception names 2022-06-01 17:59:19 +05:30
Suraj Shetty
f7db085db5 perf: Simplify code to avoid unnecessary DB calls 2022-06-01 17:56:46 +05:30
Suraj Shetty
af287a04a9 refactor: Remove unnecessary exception handling 2022-06-01 17:50:07 +05:30
Suraj Shetty
8b22f9757e revert: page_content class name refactor
Since it would have been a breaking change
2022-06-01 17:12:30 +05:30
Deepesh Garg
be3aaf715c
Merge pull request #17051 from deepeshgarg007/sematic_release_v14_beta
chore: Semantic releases for version-14 beta
2022-06-01 15:48:28 +05:30
Suraj Shetty
b7026a06ae
Merge branch 'develop' into fix-error-page 2022-06-01 15:41:11 +05:30
Deepesh Garg
77e01ddb63 chore: Semantic releases for version-14 beta 2022-06-01 14:33:27 +05:30
Suraj Shetty
4c74160184
Merge pull request #16981 from alyf-de/delete-user-permissions 2022-06-01 14:11:39 +05:30
Suraj Shetty
dc7ffe2916
Merge pull request #16976 from shariquerik/prioritize-custom-roles 2022-06-01 13:53:54 +05:30
Vladislav
c1c3eb0b7c
fix: update russian translation (#17041) 2022-06-01 13:39:48 +05:30
Suraj Shetty
3199be44cd test: Assert status_code according to the exception 2022-06-01 12:49:47 +05:30
HarryPaulo
900f829d83
fix: translate email body for 2FA (#17045) 2022-06-01 12:02:23 +05:30
Suraj Shetty
c299ebe779 fix: Page card style 2022-06-01 08:40:14 +05:30