Commit graph

38666 commits

Author SHA1 Message Date
Gavin D'souza
96b3ee4dc3 fix(webhook): Unbound 'r' through request timeout
Errors like `requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='httpbin.org', port=443): Read timed out. (read timeout=5)`

ref: https://github.com/frappe/frappe/runs/7126891200?check_suite_focus=true
2022-06-30 13:36:08 +05:30
gavin
abfbe3daa4
build: Use toml defined dev dependencies over txt file (#17356)
* build: Use toml defined dev dependencies over txt file

* chore: Remove redundant ==

* ref: https://github.com/frappe/bench/releases/tag/v5.12.1
* Linter's style updates

* chore(deps): Bump coverage from 5.5 to ~=6.4.1
2022-06-30 12:21:28 +05:30
gavin
e814a29fc7
Merge pull request #17348 from gavindsouza/translate-public
fix(translation): Translate strings in public folders
2022-06-30 12:08:17 +05:30
Ankush Menat
ef67052c68
Merge pull request #17358 from frappe/revert-17131-get-all-mod
Revert "feat: Adding support to Query engine"
2022-06-30 10:10:29 +05:30
Ankush Menat
813dcc1848
Revert "feat: Adding support to Query engine" 2022-06-29 23:30:23 +05:30
mergify[bot]
a905a3d755
Merge pull request #17265 from deepeshgarg007/migration_failures
fix: Migration failures for version-13 to develop
2022-06-29 10:28:09 +00:00
Ankush Menat
3ec6f7f470 refactor: merge two workspace2.0 patches 2022-06-29 15:37:44 +05:30
Ankush Menat
61c958c9bb Merge branch 'develop' into migration_failures 2022-06-29 15:33:20 +05:30
Ankush Menat
e1f3c48607
Merge branch 'develop' into translate-public 2022-06-29 14:35:05 +05:30
Ritwik Puri
683e9a380e
fix: escape comma from brazilian portuguese translation (#17349) 2022-06-29 14:29:39 +05:30
Gavin D'souza
a15411d1e1 fix: Skip invalid field in get_print_settings_to_show 2022-06-29 12:53:49 +05:30
mergify[bot]
b189cf4bc8
Merge pull request #17305 from treasuryesc/develop
fix: correct Brazilian portuguese translations
2022-06-29 06:57:06 +00:00
Gavin D'souza
5f0555d982 fix: Translate strings in public folders too 2022-06-29 11:58:53 +05:30
Ankush Menat
181833848f
Merge pull request #17337 from ankush/lint_cleanup
fix: remove bare exception catching
2022-06-29 11:39:05 +05:30
gavin
d89c1e1666
Merge pull request #17346 from gavindsouza/ci-min-PY38
ci: Match CI with minimum Python version requirement
2022-06-29 11:33:15 +05:30
mergify[bot]
3e69b562f1
Merge pull request #17131 from Aradhya-Tripathi/get-all-mod
feat: Adding support to Query engine
2022-06-29 05:36:33 +00:00
Gavin D'souza
6862c10403 ci: PY38 compatible roulette 2022-06-29 11:04:01 +05:30
Ankush Menat
069b0ec650 chore: py38 safe typehint 2022-06-29 11:01:55 +05:30
Gavin D'souza
091debb14f chore: Stringify incompatible typing hints 2022-06-29 10:56:05 +05:30
Gavin D'souza
bd3d7bf3ed ci: Run test builds on min requirement PY38
Since version pinned in pyproject.toml is 38 & we've been running on 39,
we've pushed a few incompatible changes since :crie:
2022-06-29 10:44:55 +05:30
Gavin D'souza
ee18694b1b test(fix): Import Max for test_functions_fields 2022-06-29 10:40:21 +05:30
gavin
91e76ff874
Merge branch 'develop' into get-all-mod 2022-06-28 19:47:20 +05:30
Aradhya
303d94494d refactor: atomic functions & removed complicated checks
Co-authored-by: gavin <gavin18d@gmail.com>
2022-06-28 19:44:03 +05:30
Aradhya
6db6be1f3c refactor: frappe.qb.engine
* Small fixes in set_fields and clean code
* Optimize casefolds
* Fixed functions passed in List
* get_sql => get_query - more expressive, less confusion
* Updated tests
2022-06-28 19:43:57 +05:30
Aradhya
4af2e1e886 refactor: replaced frappe.db.query with frappe.qb.engine 2022-06-28 19:43:50 +05:30
Aradhya
7732accded feat: Attached Engine object to qb & added dynamic type hints 2022-06-28 19:43:23 +05:30
Aradhya
960952cfc3 feat(qb-engine): Added Aggregation function support
* Added Min, Max
* Added tests
2022-06-28 19:41:39 +05:30
Aradhya
fca026927e refactor: moved all query logic to query class 2022-06-28 19:41:32 +05:30
Aradhya
d0680941ad refactor: frappe.qb.engine
* feat: supporting empty iterables for Contains objects
* fix: explicitly setting empty iterables as tuples to support more operators
* feat: Added locate to frappe.qb Functions
* feat: Added support for functions passed as strings in fields
* feat: Included Criterion objects as fields
* fix: picking up only function intended fields to pass to get_function_objects
* feat: Added iterable for available functions, added support for Field objects
* fix: fixed * passed in fields in lists
2022-06-28 19:41:23 +05:30
Aradhya
d1f5c49b02 refactor(qb-engine): frappe.db.query
* feat: Added support for True as filter and pluck in the query engine

* feat: Added join support

* fix: return if filters are None

* feat: Added support for sets as filters and additional conditions

* fix: fixed IS operator in query builder

* feat: Added support for 'as' in query engine

* fix: fixed 'as' for criterion objects passed directly

* fix: fixed frappe.db.count

* fix: fixed functions in fieldname

* feat: Added support for multiple fields passed as a single string :) fixed None fields in a list

* feat: Added support for "as" in single string fields

* fix: fixed queries with invalid syntax
2022-06-28 19:40:34 +05:30
mergify[bot]
948b5acb3c
Merge pull request #17323 from scdanieli/enable-further-translations
fix: enable further translations
2022-06-28 13:34:08 +00:00
Ankush Menat
8463b0e2b9
Merge pull request #17338 from frappe/revert-17126-export-report-with-extra-column
Revert "fix: extra column in excel after exporting report with group by"
2022-06-28 18:40:44 +05:30
Ankush Menat
c8ac3f922e Revert "fix: extra column in excel after exporting report with group by (#17126)"
This reverts commit 971b8160a3.
2022-06-28 18:40:27 +05:30
gavin
4036a5704f
Merge pull request #17331 from gavindsouza/email-unsubscribe
refactor(minor): get_unsubscribe_message
2022-06-28 18:09:22 +05:30
Ankush Menat
d35d7ffbe2 fix: remove bare exception catching
A bare except catches lots of things (like generator iteration end) and should never be used.
2022-06-28 18:05:00 +05:30
Shariq Ansari
6a3e43789b
Merge branch 'develop' into enable-further-translations 2022-06-28 17:43:06 +05:30
Samuel Danieli
d58f2ed8e7
fix: german translations (#17324) 2022-06-28 17:28:27 +05:30
mergify[bot]
996cd58279
Merge pull request #17290 from resilient-tech/fix-expense-svg
fix: improve SVG for expenses icon
2022-06-28 11:48:19 +00:00
Shariq Ansari
4dff0d25a3
feat: add email retry limit in system settings (#17259)
**MAX_RETRY_COUNT** for email was hard coded as 3. Added **Email Retry Limit** field in **Email** section in **System Settings** 

<img width="754" alt="image" src="https://user-images.githubusercontent.com/30859809/174769592-97c27a5b-9fea-471f-b596-593de4c5f91f.png">

>no-docs
2022-06-28 10:47:26 +00:00
Shariq Ansari
971b8160a3
fix: extra column in excel after exporting report with group by (#17126)
Co-authored-by: gavin <gavin18d@gmail.com>
2022-06-28 12:39:45 +05:30
Ankush Menat
9e1d7742eb
Merge pull request #17329 from ankush/next_execution
fix(UX): show next execution time on scheduled job
2022-06-28 12:34:41 +05:30
Ankush Menat
6001864888 fix(UX): show next execution time on scheduled job 2022-06-28 12:27:11 +05:30
Ankush Menat
4bf7cd8210 fix: ignore virtual docfield property conflicts 2022-06-28 12:27:11 +05:30
Gavin D'souza
07d7b34fd9 refactor: get_unsubscribe_message
* Add fallback label "Unsubscribe" instead of printing None in the email
* Add typing hints, f-stringify & make code DRY-er for better readability
2022-06-28 12:08:00 +05:30
Ankush Menat
9bd753551b
ci: temp fix for semgrep (#17228)
* ci: respekt my authoritah

* ci: use pip semgrep
2022-06-28 12:07:34 +05:30
Shariq Ansari
c6fa8ab090
fix: email not sent if contain file with current site url (#17250) 2022-06-28 11:50:57 +05:30
mergify[bot]
f7761c7d43
Merge pull request #17322 from resilient-tech/pass-shared
fix(redis): pass shared param when setting value based on generator
2022-06-28 05:01:58 +00:00
Samuel Danieli
19a1393152 feat: make field label translatable 2022-06-27 23:32:55 +02:00
Samuel Danieli
3263bf8324 style: indent 2022-06-27 22:19:05 +02:00
Samuel Danieli
5604b090c0 feat: enable further translations 2022-06-27 22:15:23 +02:00