vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
41255 commits 1 branch 0 tags 587 MiB
Commit graph

41255 commits

This branch
This branch
All branches
Author SHA1 Message Date
Raffael Meyer
97dde45067
Merge branch 'develop' into fix-note-2 2023-02-17 11:04:26 +01:00
Ankush Menat
d6d67bce64
Merge pull request #19971 from gavindsouza/request-job-hooks 
feat: Request, Job Hooks {Before/After}
 2023-02-17 14:24:30 +05:30
Shariq Ansari
0c3ab52320
Merge pull request #20066 from frappe/publish-custom-button-blog-post 2023-02-17 12:05:14 +05:30
Gavin D'souza
985e0913a5 Merge branch 'develop' into request-job-hooks 2023-02-17 11:40:13 +05:30
Hussain Nagaria
24d7637538 fix: hide published checkbox 2023-02-17 11:31:53 +05:30
Gavin D'souza
5d0bd512e1 fix(after_hook): Don't pass exception object to hook 
* it can fetch most relevant details via response object
* Exceptions not supported by Frappe's WSGI (unsupported HTTP methods) may not be accessible to the after_request hooks - but the lack of active response may be an indicator / and peeking in the request
 2023-02-17 11:24:01 +05:30
Hussain Nagaria
110204e2df feat: publish button in blog post form 2023-02-16 20:05:36 +05:30
Zhixuan Lai
2d416098c2
fix: link validation fetch from virtual doc (#20055) 
Problem: 
document.save() throws "Object is not scriptable exception" when fetching values from virtual doc.

Root cause:
```python
        # ....
        if frappe.get_meta(doctype).get("is_virtual"):
	    values = frappe.get_doc(doctype, docname) <--- Document is not scriptable.
.as_dict()
        # ....

	def set_fetch_from_value(self, doctype, df, values):
		fetch_from_fieldname = df.fetch_from.split(".")[-1]
		value = values[fetch_from_fieldname] <--- Tries to access value by key and throws "Object is not scriptable" exception
```

Solution:
```python
        if frappe.get_meta(doctype).get("is_virtual"):
	    values = frappe.get_doc(doctype, docname).as_dict() <--- Makes the document scriptable.
```
 2023-02-16 18:15:40 +05:30
Shariq Ansari
7a3dfaae8a
Merge pull request #20060 from shariquerik/doc-link-ui-fix 2023-02-16 15:57:21 +05:30
Shariq Ansari
6bf326996e fix: do not show help-icon in report view (datatable) 2023-02-16 14:57:27 +05:30
Shariq Ansari
8b3bd5adc3 fix: help-icon taking space if doc url is not set 2023-02-16 14:19:19 +05:30
Ejaaz Khan
ce6e86b484
fix: unable to upload image in responsive mode (#19963) 
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
 2023-02-16 12:32:37 +05:30
Ankush Menat
cd4d601ed4 fix: traceback sanitizer got extra positional args 2023-02-15 17:51:21 +05:30
Gavin D'souza
fe26c542b7 refactor: Move before/after tasks as hooks 
Moved before/after tasks in Requests as hooks for:
- monitor
- rate_limiter
- recorder

Moved before/after tasks in Jobs as hooks for:
- monitor
- releasing document locks
 2023-02-15 15:30:02 +05:30
Raffael Meyer
9f73b94a74
build(deps): bump cryptography to 39.0.1 (#20042) 
Security fix: https://cryptography.io/en/latest/changelog/#v39-0-1
 2023-02-15 14:59:36 +05:30
Ankush Menat
3235b7a77e
fix: Notification JS relied on leaked locals (#20048) 
this breaks after https://github.com/frappe/frappe/pull/19882

[skip ci]
 2023-02-15 14:56:11 +05:30
Gavin D'souza
6d70b5e934 fix(app): Move after_request hook inside finally block 
Also, rename after_request fn to sync_database to better match functionality
 2023-02-15 14:52:08 +05:30
Ankush Menat
99513db062
feat: fetch from with fields in Customize form (#20046) 
extends https://github.com/frappe/frappe/pull/13760/
 2023-02-15 13:08:35 +05:30
Gavin D'souza
825f1d32f1 Merge branch 'develop' into request-job-hooks 2023-02-15 12:57:14 +05:30
Raffael Meyer
d8101cdf69
ci: print any vulnerabilities found (#20044) 
[skip ci]
 2023-02-15 11:41:50 +05:30
Ankush Menat
1d4ea95105
Merge pull request #20043 from barredterra/bump-ipython 
build(deps): bump ipython to 8.10.0
 2023-02-15 11:41:12 +05:30
barredterra
3f528dac75 build(deps): bump ipython to 8.10.0 
Minor security fix: https://ipython.readthedocs.io/en/stable/whatsnew/version8.html#ipython-8-10
 2023-02-15 00:44:37 +01:00
Samuel Danieli
0bd74bfa5c
chore: do not copy data import status (#20034) 
status is used by other fields and may corrupt view if copied
 2023-02-14 22:43:31 +05:30
Shariq Ansari
84e20bfb17
Merge pull request #20027 from shariquerik/checkbox-squeezing-fix 2023-02-14 18:37:01 +05:30
Ankush Menat
c7e1bec0bd
Merge pull request #19972 from gavindsouza/cli-scheduler-status 
refactor(cli): Scheduler
 2023-02-14 18:09:21 +05:30
Ankush Menat
013f023255
fix: restrict DocType layout permissions (#20028) 
Guest -> All.

This doctype doesn't have anything that's useful for guest users.

[skip ci]
 2023-02-14 17:55:12 +05:30
gavin
c3fa753ed2
Merge branch 'develop' into cli-scheduler-status 2023-02-14 16:13:56 +05:30
Shariq Ansari
91d371e21b
Merge branch 'develop' into checkbox-squeezing-fix 2023-02-14 16:05:55 +05:30
Shariq Ansari
efd82c464e fix: checkbox is getting squeezed if label is long 2023-02-14 15:57:11 +05:30
Suraj Shetty
8864bb023e
Merge pull request #20024 from surajshetty3416/fix-avatar-in-listview 2023-02-14 15:02:02 +05:30
Suraj Shetty
044eec35a6 fix: Do not filter columns like "_assign" & "_user_tags" 2023-02-14 14:00:42 +05:30
Raffael Meyer
69a08ccd43
feat: actually redirect to login (#20018) 2023-02-14 12:42:55 +05:30
Sagar Vora
1c00972940
fix: eval client scripts with immediately invoked Function() constructor (#19882) 2023-02-14 12:31:53 +05:30
Ankush Menat
1cc51e6bb0
fix: Wait for user creation before creating contact (#20022) 
closes https://github.com/frappe/frappe/issues/19995
 2023-02-14 12:24:31 +05:30
Rutwik Hiwalkar
e9c57ee76e
revert: subscription management (#19998) 
* chore: add namespaced subscription conf to boot info

* revert: https://github.com/frappe/frappe/pull/18263

* clean: remove daily hook for creating manage subscription btn
 2023-02-14 12:04:28 +05:30
Ankush Menat
163b9290e3
Merge pull request #19916 from gavindsouza/distinct-get_count 
fix(db_query): apply_fieldlevel_read_permissions
 2023-02-14 11:56:22 +05:30
Suraj Shetty
73a0ca1ee6
Merge pull request #19947 from unibravo/patch-1 2023-02-13 20:51:25 +05:30
Suraj Shetty
075338b628
Merge pull request #20003 from gavindsouza/maintain-listview-checks-after-bulk-update 2023-02-13 20:39:25 +05:30
Ankush Menat
c69c040186 chore: typo 2023-02-13 18:26:09 +05:30
Ankush Menat
91e0d1a439
fix: Migrate color fields to color doctype (#20011) 2023-02-13 16:17:34 +05:30
Ankush Menat
29be4a544e
ci: broken patch tests (#20010) 
* Revert "chore: hard pin patch python versions"

This reverts commit aae3bac0b1.

* Revert "chore(deps): bump gabrielfalcao/pyenv-action from 10 to 13 (#19940)"

This reverts commit c525268084.
 2023-02-13 16:17:18 +05:30
Gavin D'souza
2c348af4f7 test: Add tests for scheduler cli 2023-02-13 15:13:43 +05:30
Jannat Patel
7bfd20ce87
fix: event date exception (#19955) 2023-02-13 14:57:56 +05:30
Gavin D'souza
c337e532d8 test: Add test for db-console pass extra params to client 
Added test for https://github.com/frappe/frappe/pull/19809
 2023-02-13 14:55:23 +05:30
Raffael Meyer
8130153ce6
fix: quote provider name (#19604) 
* fix: quote provider name

* fix: escape icon in get_icon_html
 2023-02-13 14:34:35 +05:30
Raffael Meyer
8180f926e1
fix: ignore permission for marking Note as seen (#19939) 2023-02-13 14:27:23 +05:30
Gavin D'souza
01cc586e20 fix: Use yarn to figure out bin path instead of npm 
Npm v9 doesn't have bin anymore. This causes run-ui-tests to fail

refs:
- https://docs.npmjs.com/cli/v8/commands/npm-bin
- https://yarnpkg.com/cli/bin
 2023-02-13 13:42:59 +05:30
Gavin D'souza
c3e526b475 fix: Maintain checkbox selection on Bulk Edit List Views 2023-02-13 13:37:05 +05:30
Ankush Menat
f1b087df24
Merge pull request #19926 from ankush/report_perm_queries 
fix: Apply permissions on Report sidebar
 2023-02-13 11:51:27 +05:30
Ankush Menat
aae3bac0b1 chore: hard pin patch python versions 
[skip ci]
 2023-02-13 11:34:20 +05:30