Commit graph

42856 commits

Author SHA1 Message Date
Sagar Vora
97eefdaa44
perf: dont reload doc when already saving (#21869) 2023-07-31 11:48:54 +05:30
niraj gautam
d08ee0284d
fix: Delete module folder on Module Def deletion (#21857)
* fix: Delete module folder on Module Def deletion

* fix: Check if folder exists before removal

* fix: Make use of frappe function to delete folder

* fix: Indentation

* fix: Update linting
2023-07-31 11:39:04 +05:30
mergify[bot]
74899f510a
Merge pull request #21378 from dvdl16/feature/force-web-capture-setting
feat: setting for force web capture mode for camera uploads
2023-07-31 05:41:48 +00:00
Dirk van der Laarse
6645589cdf chore: linting fixes 2023-07-30 15:48:03 +00:00
Dirk van der Laarse
c66d744824 fix: field order and change label to title case 2023-07-30 15:36:55 +00:00
Ankush Menat
84188587fa fix: clean up socketio dynamic namespaces
While serving many sites it's best to close down namespace when last
connection is closed.

refer https://github.com/socketio/socket.io/pull/4602
2023-07-29 20:35:59 +05:30
HarryPaulo
ec5f8fcfa1
fix: Parameter {function} get translated and format doesn't work (#21859) 2023-07-29 18:10:42 +05:30
Ankush Menat
657ec80e3a chore: skip console test on postgres
[skip ci]
2023-07-29 18:07:27 +05:30
Ankush Menat
a2167d4f94 perf: index email queue table 2023-07-29 13:47:44 +05:30
Shariq Ansari
dc1a23d497
Merge pull request #21853 from shariquerik/workspace-welcome-page 2023-07-29 12:07:18 +05:30
Shariq Ansari
6876c70147
Merge pull request #21858 from cogk/fix-webform-allow-extending-buttons 2023-07-29 02:25:30 +05:30
Shariq Ansari
f5a2eef755 test: fixed failing date control UI test 2023-07-28 23:20:17 +05:30
Shariq Ansari
120b987661 fix: send public with title in frappe.workspaces 2023-07-28 23:04:05 +05:30
Corentin Forler
d7aea1773f fix(web_form): Allow Jinja extension of header buttons 2023-07-28 18:12:45 +02:00
Shariq Ansari
8a8716f21c chore: updated the welcome message 2023-07-28 20:16:29 +05:30
Shariq Ansari
150d0c1a22
Merge branch 'frappe:develop' into workspace-welcome-page 2023-07-28 20:01:29 +05:30
Shariq Ansari
e4c45dd719 fix: after creating workspace and reloading it gives error
also if workspace does not exist it gives proper error and redirect to last opened workspaces
2023-07-28 19:59:58 +05:30
Shariq Ansari
a227944cfc fix: default page logic in workspace 2023-07-28 19:01:54 +05:30
Shariq Ansari
24a5b38634 fix: better redirect logic for default workspace after login 2023-07-28 19:01:36 +05:30
Shariq Ansari
90f6b44f48 fix: added welcome workspace if user has desk acces but does not have module access
basically if user doesn't have access to any public workspaces

also made welcome workspace hidden if he/she has even one workspace
2023-07-28 19:01:11 +05:30
Maharshi Patel
6b7f815a75
fix: guess_country backward timezone issue for india. (#21849)
* fix: guess_country backward timezone issue for india.

In some cases ( mac ) where Asia/Calcutta is used as timezone. guessing didn't work.

* refactor: make tz backward compatbility extensible

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-07-28 18:13:22 +05:30
Ankush Menat
7ee85758b1
fix(console): dont commit when exception is raised and unconditionally check query (#21850)
* fix(console): unconditionally check query type

* fix(console): don't commit when exception occurs
2023-07-28 18:07:08 +05:30
mergify[bot]
1c5f5a38e9
feat: added specific kanban board as quick link in workspace (backport #21721) (#21842)
* feat: added specific kanban board as quick link in workspace (#21721)

(cherry picked from commit 986b6024241036e68cfa4103d015e46a4c433b7b)

* fix: updated TYPE for workspace_shortcut

* chore: linter fix

---------

Co-authored-by: Vanessa Bualat <40702858+kkulloters@users.noreply.github.com>
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2023-07-28 14:41:34 +05:30
Ankush Menat
e31038d7f9
feat(sec): log IP addresses of login/logout activities (#21844) 2023-07-28 13:59:52 +05:30
Ankush Menat
ef51dde052
perf: set lower priority for background processes (#21841) 2023-07-28 13:01:46 +05:30
Suraj Shetty
df4cc5cf2f
Merge pull request #21734 from barredterra/refactor-geolocation 2023-07-28 12:37:28 +05:30
Suraj Shetty
e3e50acd66
Merge pull request #21794 from barredterra/fix-email-contact 2023-07-28 12:36:52 +05:30
Shariq Ansari
e1c1e256ef
Merge pull request #21798 from pps190/frappe/fix/ambigus-table-join 2023-07-28 12:28:04 +05:30
Ankush Menat
22a3a56d44 chore: remove conflict-marker look-alike
This is annoying when trying to find git conflicts

[skip ci]
2023-07-28 11:45:56 +05:30
Ankush Menat
6e94cd2eb9
fix: Guess most likely exception source (#21827) 2023-07-27 17:30:04 +05:30
Abdo
35c929afdb
refactor(money in words): translatable currency Name (#21672) 2023-07-27 17:21:57 +05:30
Ankush Menat
c40faddac7
perf: skip reset_seen for new doc (#21832)
The query is fired but document doesn't exist yet, so it does nothing really.

[skip ci]
2023-07-27 16:07:22 +05:30
Suraj Shetty
b887fa62f4
Merge pull request #21828 from shariquerik/oauth-confirm-screen-fix 2023-07-27 15:11:25 +05:30
Shariq Ansari
2771c37716
Merge pull request #21795 from cogk/fix-form-builder-issues 2023-07-27 13:53:15 +05:30
Shariq Ansari
d7c3e48819 style: hide p if it is empty 2023-07-27 13:23:49 +05:30
Shariq Ansari
99a4116725 fix: only render message with p tag if message exist 2023-07-27 13:23:24 +05:30
Shariq Ansari
9902f36812 fix: show full name instead of first/last name 2023-07-27 13:22:38 +05:30
Ankush Menat
8930d4b5e1
perf: drop ifnull from IS SET filter (#21822)
- Kinda confuses query planner (idk why it's not smart enough to
  understand but there are probably edge cases where it can't be done)
- `null != null` and `'' != null` both yield `null` which is falsy and
  won't be shown in results.

Alternate fix to https://github.com/frappe/frappe/pull/21817
2023-07-27 10:58:20 +05:30
Sagar Vora
b4629d8c02
chore: strictly pin responses to 0.23.1 to avoid pip conflicts (#21816) 2023-07-27 10:41:20 +05:30
gavin
6cb51a536e
fix: re module cache settings - purge & cache size (#21808)
* fix: Remove re cache internals manipulation

* fix: Purge re cache after module loads

Empty cache would work better as we already got our pre-compiled
patterns at the top level of every module. This leaves the cache open
for dynamically generated patterns which are in better need of it. Over
time, workers would converge to this anyway. This change only reduces
the cache hit and eviction effort.

I'd improve this by executing `re.purge` on every module import but
complexity tradeoff lol. I'd prefer if re didn't cache patterns
generated by `re.compile` but I dont see this behaviour or any escape
hatches so this will have to do for now.
2023-07-27 10:40:50 +05:30
Smit Vora
89b9b64a55
fix: installation error, cannot import name 'DEFAULT_CIPHERS' from 'urllib3.util.ssl_' (#21810)
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-07-26 15:00:04 +05:30
Ankush Menat
5f46f98699
ci: remove mysql (#21811) 2023-07-26 14:31:03 +05:30
Ankush Menat
c45fbce2fa fix: ignore no args to email read url
Some client can strip this and it will cause error.
2023-07-26 09:23:06 +05:30
Corentin Flr
c87a6e8ff0 fix(Form Builder): Handle sort_options in Select 2023-07-25 14:58:43 +02:00
Corentin Flr
766e0b056b fix(Form Builder): Fix label text font size 2023-07-25 14:58:43 +02:00
Suraj Shetty
6c509f6dd1
Merge pull request #21782 from blaggacao/bump-bleach 2023-07-25 18:21:31 +05:30
Suraj Shetty
dff950a56d fix: Remove unused resolve in code
fixes: https://github.com/frappe/frappe/actions/runs/5655856445/job/15321775151?pr=21782
2023-07-25 18:20:00 +05:30
Suraj Shetty
c0d472e95c refactor: Remove unnecessary code 2023-07-25 16:21:59 +05:30
David Arnold
7780670ae4
build(deps): update node redis client to v4 (#21797)
* build(deps): update redis client to v4 in legacy mode

* fix: node17+ - prefer ipv4

* chore: use redis client v4 api (async) and adapt error handling

* fix: timeout by exiting if not in watch mode

* fix: parse message before republishing

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-07-25 14:07:46 +05:30
Ankush Menat
f775c014e4
chore: simple codeowners
[skip ci]
2023-07-25 13:06:49 +05:30