Gavin D'souza
9b6a048bcd
refactor(minor): Use db.db_type instead of conf.db_type
2022-06-17 12:49:12 +05:30
Gavin D'souza
3af8d5caea
fix: Add fallbacks for values
...
Psycopg seems to like None over () and MariaDB - PyMySQL can't seem to
agree on anything - so this seems to keep everyone happy...a very
delicate balance :crie:
2022-06-17 12:47:44 +05:30
gavin
2a1a2deebf
Merge branch 'develop' into mariadb-client-refactor
2022-06-17 12:11:41 +05:30
Gavin D'souza
90c716bce0
fix(sequence): Setup & use SequenceGeneratorLimitExceeded error
2022-06-17 12:10:43 +05:30
Himanshu
6d6a67e9e3
feat: set image as footer in letter head ( #17119 )
...
* feat: set image as footer in letter head
* fix: do not hide footer section
* fix: hide footer source
* style: black
* fix: reduce code for setting image as html
* fix: Force system admin role only if active
* fix(ui): tab refresh was not implemented
* fix(minor): Onboarding: add option to view list view in create action
* fix(minor): js lint
* fix: allow All to select a User
* test: user permissions affecting User
* refactor: filter_dynamic_link_doctypes API
* Added typing, better variable naming
* Remove unnecessary re-iterations
* Optimize queries and membership processing
* perf: Check query type via is_query_type
* chore: Drop duplicate get_frontmatter definition
* perf: Login Page
Improves performance 3x - from 0.047s to 0.017s
* Use frappe.get_*_settings to query table once
* Use cached LDAP Settings' document via get_ldap_client_settings
* Use single get_all to query all Social Login providers and related
data
* Skip provider if client_secret doesn't exist
* perf: About Us Settings
Use cached document for building /about page
* perf: App Page
Reduced time taken for get_context to execute from 0.035s to 0.02s (75%
reduction)
* perf: Patch qb only once - not on every init
* perf: Fetch and cache entire settings' dicts
* refactor!: frappe.db.get_singles_dict
* Cast single's values as their fieldtypes before returning
* Support previously dead debug parameter
* Consider single with no meta as non-existent; skip query
Decided to go ahead with the breaking change given the nature of the
existing usages of get_singles_dict :crie:
* ci: Run tests bypassing roulette with labels "Run UI Tests", "Run Server Tests"
* test: Scheduler tests cleanup
* chore: linter changes
* chore: linter changes
* chore: linter changes
* fix: set HTML as default
to keep existing formats working
* refactor: no **kwargs
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
Co-authored-by: Rushabh Mehta <rmehta@gmail.com>
Co-authored-by: Gavin D'souza <gavin18d@gmail.com>
2022-06-17 12:07:07 +05:30
Gavin D'souza
ca0016a996
test(sequence): Use mariadb client's exception handling
2022-06-17 11:33:32 +05:30
Gavin D'souza
a03bf6b0bb
fix(db): Transform values only if not None
2022-06-17 11:31:55 +05:30
Suraj Shetty
9ebe3e70ea
Merge pull request #17212 from surajshetty3416/add-more-instance-for-UI
2022-06-17 10:24:30 +05:30
Suraj Shetty
7b328e85c9
Merge branch 'develop' into add-more-instance-for-UI
2022-06-17 09:21:15 +05:30
Ritwik Puri
335edc14f3
fix: number card ui inconsistencies ( #17160 )
2022-06-16 20:25:01 +05:30
Shariq Ansari
5ca7d6fab9
Merge branch 'develop' into add-more-instance-for-UI
2022-06-16 17:45:35 +05:30
Gavin D'souza
71ed8417d3
test: frappe.db.describe returns List[Tuple] through mariadb
2022-06-16 16:23:27 +05:30
Gavin D'souza
355e997045
test: Get rid of magical forgiving behaviour of pymysql
...
("test",) would be interpretted as ("test") which would be just "test".
MariaDB client doesn't handle errenous inputs like this that PyMySQL
tolerated
2022-06-16 16:21:32 +05:30
Suraj Shetty
5db7716df2
Merge pull request #17223 from frappe/rpm_typo
2022-06-16 16:20:27 +05:30
Michelle Alva
86f9465432
chore: typo
2022-06-16 16:16:00 +05:30
Gavin D'souza
1a772e304c
fix(db): Store result of last executed query under frappe.db.last_result
2022-06-16 16:01:38 +05:30
Suraj Shetty
24324dbced
Merge pull request #17221 from frappe/dependabot/github_actions/bruceadams/get-release-1.2.3
...
build(deps): bump bruceadams/get-release from 1.2.0 to 1.2.3
2022-06-16 15:59:48 +05:30
dependabot[bot]
27b0b3669d
build(deps): bump bruceadams/get-release from 1.2.0 to 1.2.3
...
Bumps [bruceadams/get-release](https://github.com/bruceadams/get-release ) from 1.2.0 to 1.2.3.
- [Release notes](https://github.com/bruceadams/get-release/releases )
- [Commits](https://github.com/bruceadams/get-release/compare/v1.2.0...v1.2.3 )
---
updated-dependencies:
- dependency-name: bruceadams/get-release
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-06-16 10:24:59 +00:00
Suraj Shetty
717ad9e2ec
Merge pull request #17120 from turrisxyz/Dependabot-GitHub-Actions
2022-06-16 15:54:22 +05:30
Suraj Shetty
faf085a420
Merge pull request #17211 from shariquerik/daterange-fix
2022-06-16 15:34:06 +05:30
Suraj Shetty
40e7d9b824
Merge pull request #17217 from phot0n/fix-integration-req-patch
2022-06-16 15:24:59 +05:30
Suraj Shetty
6c36b7251c
Merge branch 'develop' into add-more-instance-for-UI
2022-06-16 15:22:28 +05:30
Gavin D'souza
25b87a9d49
chore: NoneType alias for < PY310
2022-06-16 15:04:35 +05:30
phot0n
782fb801ec
fix: ignore if integration_type column doesn't exist (for direct v14 installations) for integration request patch
2022-06-16 14:43:32 +05:30
Shariq Ansari
590d511618
Merge branch 'develop' into daterange-fix
2022-06-16 14:35:32 +05:30
gavin
870866df09
Merge branch 'develop' into mariadb-client-refactor
2022-06-16 14:27:08 +05:30
Gavin D'souza
bc3780560e
perf: Use lazy mogrified query for logging
...
For parameterized queries, there's an improvement of ~30% in query
execution via frappe.db.sql - from 58.6 µs ± 2.37 µs to 44.6 µs ± 1.56 µs
2022-06-16 14:26:34 +05:30
Suraj Shetty
bb0a9bc3a9
Merge pull request #17177 from ruchamahabal/fix-event-streaming
2022-06-16 14:21:35 +05:30
Ankush Menat
a7f9c2a672
chore: remove migrate
2022-06-16 14:10:01 +05:30
Ankush Menat
1c385826ef
test: make sure all patches are in patch.txt
2022-06-16 14:10:01 +05:30
Ankush Menat
214be6a7e8
chore: discard stale patches, add relevant ones to patches.txt
2022-06-16 14:10:01 +05:30
Gavin D'souza
154d794c6c
fix: Recorder to use frappe.db.last_query to pick out last executed stmt
2022-06-16 13:29:35 +05:30
Gavin D'souza
effa942f4c
refactor: frappe.db.log_query
...
* Mogrify queries and set them as frappe.db.last_query instead of
directly interfacing with the clients
* This is required for now as the MariaDB client uses binary protocol to
talk to the server and doesn't build the queries itself
* Add typing hints
* Imported Query object as FilterEngine - Query is too ambiguous lol
ref: https://jira.mariadb.org/browse/CONPY-208?focusedCommentId=226873&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-226873
2022-06-16 13:28:54 +05:30
Shariq Ansari
d9e848ef88
test: added UI test for date range control
2022-06-16 13:00:34 +05:30
Gavin D'souza
889ced3035
refactor: frappe.db.sql
...
* Move everything except _cursor.execute outside try-except block - This
caused multiple traceback printing (by recursion of db.sql)
* Include values mogrifying & executing via client alone in execution
time for query
* Reduce indentations lol
2022-06-16 12:39:30 +05:30
Gavin D'souza
0adf5e127a
fix(db): Track query engine under db._filter_engine
2022-06-16 12:31:14 +05:30
Suraj Shetty
b0503fc839
Merge branch 'develop' into add-more-instance-for-UI
2022-06-16 12:25:09 +05:30
Suraj Shetty
6cebacaf6f
ci: Update mergify.yml
2022-06-16 12:07:55 +05:30
Suraj Shetty
1298b39bb3
ci: Add one more instance for faster UI tests execution
2022-06-16 12:07:19 +05:30
Shariq Ansari
42f3013699
fix: daterange value not updating
2022-06-16 11:35:58 +05:30
Gavin D'souza
bfd51aa43a
fix(qb): Use fallback og table if not found in schema mapper
2022-06-15 17:44:29 +05:30
Gavin D'souza
ded55fd98e
fix(db): Skip transformation of query if no named params found
2022-06-15 17:43:44 +05:30
Gavin D'souza
5a29177e6b
fix(db): Log queried tables through generated query
2022-06-15 17:42:52 +05:30
Ankush Menat
f7e00633b9
chore: useless flake8 warnings
2022-06-15 17:27:04 +05:30
Gavin D'souza
b4578dc632
Merge branch 'develop' of github.com:frappe/frappe into mariadb-client-refactor
2022-06-15 16:40:29 +05:30
Suraj Shetty
c7e89267cc
Merge pull request #17151 from phot0n/fix-format-date-dashboard-charts
2022-06-15 16:26:20 +05:30
gavin
dc7100757c
Merge pull request #17200 from gavindsouza/fix-qb-patched
...
fix: Patch qb for different schemas in same process
2022-06-15 16:15:37 +05:30
Suraj Shetty
444c2db1c4
Merge pull request #17124 from s-aga-r/fix/user-type
2022-06-15 16:13:31 +05:30
Suraj Shetty
77a6c103ec
test: Fix dashboard chart test cases
2022-06-15 16:11:55 +05:30
Ankush Menat
8436acbecb
Merge pull request #17174 from gavindsouza/pyproject-filt
...
build!: Declarative builds via pyproject.toml
2022-06-15 16:10:41 +05:30