Ankush Menat
9c4c5d647f
chore: early return in read only mode
2023-07-04 10:34:23 +05:30
Ankush Menat
00e5dabef1
fix: defer access log inserts in read only mod
2023-07-03 13:41:17 +05:30
Sagar Vora
8e329a92a3
Merge pull request #21567 from resilient-tech/fix-package-import
2023-07-03 13:25:31 +05:30
Sagar Vora
d9167985b1
fix: ensure correct file path when importing package
2023-07-03 12:53:20 +05:30
Suraj Shetty
8daf25bec6
Merge pull request #21565 from frappe/mergify/bp/develop/pr-21462
2023-07-03 10:34:23 +05:30
Anh Le
8fc518baff
fix: repeat title value in description of link field.
...
(cherry picked from commit 5957cbcf0908261339e64bf6536e5c18af511ea1)
2023-07-03 05:03:54 +00:00
Suraj Shetty
369b185c50
Merge pull request #21478 from blaggacao/fix-link-list-table-multiselect-no-break-word
2023-07-03 10:11:17 +05:30
Suraj Shetty
b7afc65032
style: Fix linter warning
2023-07-03 10:08:27 +05:30
Suraj Shetty
9b6b09c450
refactor: Simplify code
2023-07-03 09:54:27 +05:30
Suraj Shetty
15d6cfa8b4
Merge pull request #21543 from anandbaburajan/unattached_guest_files
2023-07-03 09:06:05 +05:30
Ankush Menat
d7990368a8
perf: preload more modules ( #21557 )
...
* perf: preload more modules
- bleach is used frequently for sanitization
- File gets imported anytime a private file is viewed. Indirect import
of PIL is costly in each worker.
* test: warm up perf test
2023-07-02 21:47:21 +05:30
David Arnold
f5b93cc2a0
chore: urlparse already does the parsing for us, no need to diy ( #21558 )
...
This is a very minor cleanup. So minor, that it hopefully is a nobrainer
2023-07-02 21:46:53 +05:30
mergify[bot]
721035b313
Merge pull request #21276 from gavindsouza/bump-pydantic-v2
...
build(deps): Bump Pydantic from v1 to v2
2023-07-02 13:38:18 +00:00
Ankush Menat
35039ca382
Revert "test: Bump memory usage treshold post pydantic v2 upgrade"
...
This reverts commit af70328930 .
2023-07-02 18:46:24 +05:30
Ankush Menat
265a28e151
perf: preload pydantic
2023-07-02 16:32:40 +05:30
Ankush Menat
a63398778e
perf: tune gc by default
...
This is running on several prod site without any noticable problems, so
making it default behaviour.
Opt out by setting env variable `FRAPPE_TUNE_GC=False`
2023-07-02 16:29:19 +05:30
Gavin D'souza
af70328930
test: Bump memory usage treshold post pydantic v2 upgrade
2023-07-02 16:19:25 +05:30
Gavin D'souza
883445aefa
perf: Defer pydantic imports until function call
...
Pydantic adds an additional 1-2MB in memory usage. We can defer it in
case an environment doesn't use it at all.
2023-07-02 16:00:50 +05:30
Ankush Menat
1a7cb47826
fix: setup wizard auto completes when clickin on autocomplete fields
...
closes https://github.com/frappe/frappe/issues/15693
2023-07-02 12:50:43 +05:30
Ankush Menat
2aec7ac579
Merge pull request #21550 from batonac/patch-1
...
fix: typo on email queue flush enqueue args
2023-07-02 12:36:49 +05:30
Ankush Menat
dde979389c
Merge pull request #21556 from ankush/fixup_geoip
...
fix(UX): guess country on setup wizrd
2023-07-02 12:33:21 +05:30
Ankush Menat
ee4c66ecf1
feat(UX): Guess country from system_timezone
...
This is accurate enough for vast majority of countries.
Alternate is using GeoIP and making network calls.
2023-07-02 12:31:18 +05:30
Deepesh Garg
02c5b97850
Merge pull request #21554 from frappe/revert-21545-country_update
...
Revert "fix: Update country names"
2023-07-02 12:09:39 +05:30
Deepesh Garg
3a74b38e8c
Revert "fix: Update country names ( #21545 )"
...
This reverts commit e0f35fb85f .
2023-07-02 12:08:43 +05:30
Deepesh Garg
e0f35fb85f
fix: Update country names ( #21545 )
...
* fix: Update country names
* fix: revert name back
2023-07-02 11:25:43 +05:30
Kevin Shenk
70da4ba51d
fix: typo on enqueue args
...
The deduplicate argument was missing the 'l'.
2023-07-01 13:56:50 -04:00
anandbaburajan
2481b7035e
chore: fix permission issues in tests and update docstring of attach_files_to_document
2023-07-01 22:32:34 +05:30
Ankush Menat
ad79c9d180
chore: remove broken call to geoip
...
This has never worked afaik
2023-07-01 20:07:05 +05:30
anandbaburajan
d36765457d
test: add tests for guest files
2023-07-01 19:41:22 +05:30
Ankush Menat
ab42e58dcf
test: flaky test due to list view filters
2023-07-01 19:34:08 +05:30
Ankush Menat
05d0fdcaeb
Merge pull request #21546 from frappe/reliable_prepared_reports
...
refactor: improve prepared report reporting
2023-07-01 18:57:47 +05:30
Ankush Menat
e342f7bd9c
perf: index status and report names
...
Two commonly used fields to filter by
2023-07-01 18:29:38 +05:30
Ankush Menat
2e8ea02028
fix: Expire stalled reports
...
Mark any report that take more than 60 minutes as failed
2023-07-01 18:27:25 +05:30
Ankush Menat
4ece3da47d
test: publish_progress ui test
2023-07-01 18:06:34 +05:30
Ankush Menat
5850176066
fix: Stop running prepared reports when report is deleted
2023-07-01 18:05:30 +05:30
Ankush Menat
f72643781d
feat: "Started" status in prepared reports
2023-07-01 17:44:55 +05:30
Ankush Menat
869f219418
fix: dont export prepared_report and letterhead
2023-07-01 17:17:35 +05:30
Ankush Menat
b81aff3237
test: simplify prepared report tests
2023-07-01 17:11:24 +05:30
Ankush Menat
9137765803
fix: halve prepared report threshold
...
Users can still enable/disable on their own after last refactor.
2023-07-01 16:58:18 +05:30
Ankush Menat
28763aadf8
Merge pull request #21527 from ankush/socketio_refactor
...
refactor!: `frappe.realtime`
2023-07-01 13:15:41 +05:30
Ankush Menat
ab44a9cca8
test: socketio tests
...
- conflict check (moved from form)
- list view updates
- custom event subscribe and recieve
2023-07-01 12:43:53 +05:30
Ankush Menat
be8d2b9de0
perf: lazy websocket connection on website
...
Establishing 1 connection for every website visit is too much.
Only after calling frappe.realtime.on(...) for ANY event, we will
establish a websocket connection.
This is used for handful of things:
- Discussion component
- File upload
Socketio was initially added here: https://github.com/frappe/frappe/pull/6866 this use case no longer exists.
Rarely anywhere website uses realtime.
2023-07-01 12:43:53 +05:30
Ankush Menat
e4ec6e65ee
fix: socketio namespace on website
2023-07-01 12:43:53 +05:30
Ankush Menat
bdaed29ef2
refactor: move handlers to separate file
2023-07-01 12:43:47 +05:30
Ankush Menat
d59e499418
refactor!: Use SocketIO namespaces for multitenancy
2023-07-01 10:53:34 +05:30
Ankush Menat
dad1d57b90
chore: move redis sub setup
2023-07-01 10:53:34 +05:30
Ankush Menat
d13cb116bc
refactor: use existing redis client
2023-07-01 10:53:34 +05:30
Ankush Menat
7320d2d020
refactor: move middleware out
2023-07-01 10:53:34 +05:30
Ankush Menat
164840c32e
refactor: explicitly import socketio
2023-07-01 10:53:34 +05:30
Ankush Menat
5e4e60b509
refactor: Split socketio in multiple logical files
2023-07-01 10:53:34 +05:30