Commit graph

3949 commits

Author SHA1 Message Date
Aarol D'Souza
9eef4f6dae
fix: force type check in whitelisted methods (#37044)
* fix(contact): force type check in contact whitelisted methods

* fix(google_indexing): force type check in google_indexing whitelisted methods

* fix(assignment_rule): add type checks to assignment_rule whitelisted methods

* refactor: remove unused args

* fix(queue): add type hints to whitelisted methods in queue.py

* fix(auto_email_report): add type hints to whitelisted methods

* fix(dashboard): add type hints to whitelisted methods

* fix(sidebar_item_group): add type hints to whitelisted methods

* fix(weasyprint): add type hints to whitelisted methods

* fix(backups): add type hints to whitelisted methods

* fix(document_naming_settings): add type hints to whitelisted methods

* fix(get_latest_submissions): add type hints to whitelisted methods

* fix(custom_field): add type hints to whitelisted methods

* fix(customize_form): add type hints to whitelisted methods

* fix(personal_data_deletion_request): add type hints to whitelisted functions

* fix(__init__): add type hints to whitelisted methods

* fix(prepared_report): add type hints to whitelisted methods

* fix(session_default_settings): add type hints to whitelisted methods

* fix(document_follow): add type hints to whitelisted methods

* fix(route_history): add type hints to whitelisted methods

* fix(form_tour): add type hints to whitelisted methods

* fix(dashboard_settings): add type hints to whitelisted methods

* fix(address): add type hints to whitelisted methods

* fix(contact): add type hints to whitelisted methods

* fix(discussion_reply): add type hints to whitelisted methods

* fix(auto_repeat): add type hints to whitelisted methods

* fix: add the missing type hints and misc. corrections

* fix(email): add type hints to whitelisted methods

* fix(permitted_documents_for_users): add type hints to whitelisted methods

* fix: correct the type hints

* fix: int PK types

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2026-02-17 15:16:30 +00:00
Ankush Menat
69dbd05e87
fix: rebuild tree should process nodes in *some* order (#37116)
Co-authored-by: Shrihari Mahabal <shriharimahabal08@gmail.com>
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
2026-02-17 14:33:40 +05:30
Soham Kulkarni
79a3e181f4
Merge pull request #37101 from sokumon/delete-icons
fix(desktop_icon): use app_name instead of app_title
2026-02-17 11:28:36 +05:30
Raffael Meyer
f00b1b44ba
fix: round negative and positive values the same way (#36242) 2026-02-17 11:23:37 +05:30
sokumon
c6338799e3 fix(desktop_icon): use app_name instead of app_title 2026-02-17 03:25:02 +05:30
Harsh Patadia
af628d70c8
fix: Unpacking of NoneType returned from frappe.get_cached_value() and parenthesized multiple exception syntax (#37008)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2026-02-16 10:19:15 +00:00
Ankush Menat
4d87562641
fix: Allow untyped self/cls (#37053) 2026-02-16 06:57:38 +00:00
Safwan
dd6bb35b1d
Merge pull request #36970 from safwansamsudeen/float-format 2026-02-11 16:20:34 +05:30
Safwan Samsudeen
759ff0e6df fix: do not round whole floats in format 2026-02-11 16:09:37 +05:30
Akhil Narang
e6ea045d06
fix: improve sanitize_column regex
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-02-10 21:35:54 +05:30
Rahul Agrawal
f70e578baf Merge branch 'develop' into fix/email-print-format-render 2026-02-09 18:41:51 +05:30
Ankush Menat
bfba73653f
fix(DX): Boilerplate defaults for type checks and exports (#36871)
Add sane defaults for new apps.
2026-02-09 10:10:02 +00:00
Aarol D'Souza
77af2d53d6
fix(system console): allow read-only queries in system console (#36652)
* fix(system console): allow read-only queries in system console

* fix(security): make transactions strictly read only for console and scripts

* test: remove test to reflect ban on cte's for security

* fix: Only enable read only mode for SQL query

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2026-02-05 11:39:10 +00:00
Ankush Menat
c9cdacb4ce
feat: Optionally force type checking on whitelisted methods (#36744) 2026-02-05 16:20:41 +05:30
Akhil Narang
48e52e152b
fix(report_to_pdf): add some restrictions (#36674)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-02-04 19:33:14 +05:30
Suraj Shetty
666a79fcde
Merge pull request #36549 from vorasmit/notification-templates
feat: create base notification templates (non-overwriting)
2026-02-02 17:30:19 +05:30
sokumon
754aa3b726 fix: hide icons correctly 2026-02-02 16:16:59 +05:30
Smit Vora
bf93eae041 feat: create base notification templates 2026-02-01 16:54:56 +05:30
Aarol D'Souza
c8b95bb350
Merge pull request #36499 from AarDG10/algerian-curr
fix(data): fix currency in words for Algerian compliance
2026-01-30 09:58:22 +05:30
Angel98518
0c59f49ce3
fix: remove redundant isinstance check in encode_dict (#35932)
* fix: remove redundant isinstance check in encode_dict

The encode_dict function was checking isinstance(d[key], str) twice,
which is redundant. Removed the duplicate check to clean up the code.

This is a simple code quality improvement that removes unnecessary
redundancy in the type checking logic.

* fix: correct decode_dict to check for bytes instead of always-false condition

The decode_dict function had a logic error:
'isinstance(d[key], str) and not isinstance(d[key], str)' is always False.
It should check for bytes instead, since decode() is called on bytes objects.

This fixes the decode_dict function to properly decode bytes to strings.

* fix: remove redundant isinstance check in encode_dict

---------

Co-authored-by: Daniel Miner <daniel@gittensor.miner>
2026-01-30 04:09:58 +00:00
AarDG10
2050a127bc fix(data): fix currency in words for Algerian compliance
Co-authored-by: half-ware <contact@half-ware.com>
2026-01-30 09:31:29 +05:30
Nikhil Kothari
c3d06b6456
Merge pull request #36473 from nikkothari22/fix-date-guess-in-import
fix: add support for DD/MMM/YYYY when guessing date format
2026-01-29 16:44:09 +05:30
Nikhil Kothari
6cfb09cef5 fix: add support for DD/MMM/YYYY when guessing date format 2026-01-29 16:07:51 +05:30
Akhil Narang
116e406e8f
feat(sanitize_html): allow the caller to block additional tags
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-01-29 12:10:08 +05:30
Akhil Narang
fb56fbcab8
Merge pull request #34740 from alexleach/bleach-to-nh3
refactor!: Replace bleach HTML sanitiser for nh3
2026-01-27 17:09:53 +05:30
Sagar Vora
6dfabf9912 perf: reduce frappe.as_unicode calls and use str.replace 2026-01-26 13:46:20 +05:30
Ejaaz Khan
046de26230
Merge pull request #35555 from Packeting1/fix/report-letterhead-jinja
fix: render report letterhead jinja on print/pdf
2026-01-23 17:03:04 +05:30
Sagar Vora
5e2c526b9e perf: prefer nh3 to clean script and style tags 2026-01-23 15:18:05 +05:30
Sagar Vora
84359c8d49 chore: improve misleading docstring 2026-01-23 14:48:10 +05:30
ALB.Leach
e4376fc067
Merge branch 'develop' into bleach-to-nh3 2026-01-23 15:29:44 +07:00
Sagar Vora
f4035e0044 fix: explicitly specify inline disposition for PDFs 2026-01-22 17:33:44 +05:30
ljain112
4a9af04f94 fix: update Content-Disposition header for binary as attachment 2026-01-22 17:30:43 +05:30
Satyam-Kolhe
e3ffbf8c6d
refactor: add strict type hints to weekday utility functions (#36057) 2026-01-22 16:04:27 +05:30
Satyam-Kolhe
842fe28e98
refactor: add strict type hints to duration utility functions (#36088) 2026-01-22 10:40:03 +05:30
Packeting
71c85f1f53 fix: render report letterhead jinja on print/pdf 2026-01-22 09:06:37 +08:00
Jannat Patel
90354c68df
fix: capture session user from backend if not found in frontend (#36072) 2026-01-20 13:50:58 +05:30
AarDG10
258741432e revert: keep validation on client side only since permission issue is specific to grid rendering on client side 2026-01-19 19:50:24 +05:30
Aarol D'Souza
ae0a776fab
Merge pull request #35551 from AarDG10/fix-report-print-permission
fix(report_view): enforce print permission for reports
2026-01-18 19:24:23 +05:30
Diptanil Saha
03558f4848
chore(boilerplate): fixed db migration link (#35967) 2026-01-15 07:01:01 +00:00
Rahul Agrawal
45feea5b9a fix: skip standard format 2026-01-15 08:48:40 +05:30
Ejaaz Khan
6a061e461f
Merge pull request #35812 from Rl0007/fix/chrome-pdf-generator-for-standard-format
feat: allow use of chrome pdf generator for standard print format
2026-01-12 14:44:55 +05:30
Akhil Narang
8c5b5ecec3
Merge pull request #35775 from akhilnarang/multisql-wildcard
feat(multisql): support passing a wildcard query
2026-01-12 12:23:31 +05:30
Akhil Narang
c14e9d5d20
fix(response): set content-disposition header correctly again
Broke in ee2c4c20ce

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-01-12 11:49:35 +05:30
Rahul Agrawal
8649c18125 feat: allow use of chrome pdf generator for standard print format 2026-01-10 10:22:00 +05:30
Akhil Narang
5dcb05541f
Merge pull request #35683 from akhilnarang/fix-ipv6-connection-check
fix(connections): try all available interfaces, not just ipv4
2026-01-08 19:38:51 +05:30
Akhil Narang
8657690ef5
refactor: use wildcard to avoid duplicating some queries
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-01-08 18:56:05 +05:30
marcosppca
6ef39f3253
refactor: rejuvenation using match/case in format_value (#34594)
* Refactor: Rejuvenation using match/case in format_value

* refactor(format_value): rejuvenation using match/case (PEP 634) (#34594)

* refactor: if for match

* style: fix code formatting and indentation for consistency

* chore: format

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2026-01-08 12:44:50 +00:00
Akhil Narang
a64834b444
fix(connections): try all available interfaces, not just ipv4
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-01-08 18:10:02 +05:30
Saqib Ansari
727c862208
fix: whitelist is_enabled function (#35721) 2026-01-07 12:10:05 +05:30
sokumon
990329d23b fix(desktop_icon): adapt new schema in auto generation 2026-01-06 17:35:58 +05:30