Sagar Vora
a42ca7d8c1
fix: raise exception if doc before save is not found ( #18796 )
...
* fix: raise exception if doc before save is not found
* test: ensure error is raised when trying to save new doc using `doc.save()`
* chore: add comment explaining condition
* test: clearer name and docstring
2022-11-09 19:45:41 +05:30
Ankush Menat
1dd719b123
fix: decorator ordering
...
statcimethod doesn't return normal function so can't be "chained" the
other way around
[skip ci]
2022-11-09 19:41:02 +05:30
Himanshu Shivhare
a5240824d5
docs: youtube channel in "about" section ( #18810 )
...
* YouTube channel addded in about section.
I have added ERPNext YouTube channel reference in the about section.
#Create an official Handle for YouTube Channel (Like @erpnext or erpnextofficial)
* chore: handle
[skip ci]
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-11-09 18:25:00 +05:30
Ankush Menat
355803e53f
Merge pull request #18814 from ankush/refactor/db
...
refactor: deprecate unused DB methods + misc
2022-11-09 18:09:52 +05:30
Shariq Ansari
4a648d197a
Merge pull request #18779 from Ponnusamy1-V/develop
2022-11-09 17:26:53 +05:30
Ankush Menat
66f5f4dd46
refactor(db): deprecated unused functions
2022-11-09 16:10:09 +05:30
Ankush Menat
ffdd368fe2
perf: faster as_list and as_dict
2022-11-09 15:58:46 +05:30
Ankush Menat
b0cb1adc01
ci: config cleanup and bump coverage
2022-11-09 15:58:46 +05:30
Ankush Menat
b71d93ef9f
test: db timeout computation
2022-11-09 15:55:31 +05:30
Ponnusamy
373292a607
Merge branch 'develop' into develop
2022-11-09 14:17:55 +05:30
Ponnusamy
15cae83c50
Update breadcrumbs.js
2022-11-09 13:13:39 +05:30
Ankush Menat
ad7c0816f8
fix: prevent deleting standard doctypes in prod ( #18803 )
2022-11-08 21:27:41 +05:30
Ankush Menat
3ea75f3559
Merge pull request #18771 from ankush/query_timeout
...
feat: Set default SQL statement timeouts
2022-11-08 15:17:12 +05:30
Ankush Menat
f45656217e
refactor: control statement timeout via flag
2022-11-08 15:01:17 +05:30
Ankush Menat
ce360b6fce
feat: Set default SQL statement timeouts
2022-11-08 14:51:43 +05:30
Ankush Menat
b2860e6f9e
fix(UX): allow clicking on row to open in new tab ( #18789 )
...
- ctrl+click on row is toggling checkbox instead of opening it in new
row
- This only happens on non-mac devices
Root cause: incorrect grouping of predicate
towards fixing https://github.com/frappe/frappe/issues/18788
[skip ci]
2022-11-07 19:01:50 +05:30
Ankush Menat
3a8adfea00
Merge branch 'develop' into develop
2022-11-07 13:18:59 +05:30
Ankush Menat
f04287ae83
fix: dont close static modal with keyboard
...
closes https://github.com/frappe/frappe/issues/11926
[skip ci]
2022-11-06 20:24:34 +05:30
Daizy Modi
62c4a3c020
fix: check permission before print or download document ( #18757 )
2022-11-06 19:59:59 +05:30
Ankush Menat
44a5bdc3f1
fix: ignore internal methods ( #18784 )
2022-11-06 19:18:30 +05:30
Ankush Menat
db1ed206f3
fix: only release db if it exists
...
ref https://github.com/frappe/frappe/pull/18772
[skip ci]
2022-11-06 18:54:18 +05:30
Raffael Meyer
e3a0b007c2
fix: translations ( #18765 )
...
* fix: add missing translations
* fix: capitalize label
* fix: translate label on summary item
2022-11-06 17:36:51 +05:30
Ankush Menat
e02b90cd5b
fix: dont allow reading attributes of unsafe objects ( #18706 )
2022-11-06 17:33:02 +05:30
Raffael Meyer
09d35c74eb
fix: remove redundant translation ( #18775 )
2022-11-06 17:27:02 +05:30
Ponnusamy
9a7e59e811
fix: dashboard view from workspace
2022-11-06 15:00:53 +05:30
Ankush Menat
afe992f1e6
Merge pull request #18773 from ankush/dashboards_not_loading
...
fix: standard dashboards not loading
2022-11-06 11:39:17 +05:30
Ankush Menat
5d1d3564ef
test: Dashboard basic ui test + whitelisting
2022-11-06 10:59:38 +05:30
Sagar Vora
ff0c820c9c
chore(socketio): remove duplicate event handler ( #18770 )
2022-11-05 21:36:07 +05:30
Sagar Vora
cd1bbccdc3
fix: dont release frappe.local twice ( #18772 )
2022-11-05 21:35:37 +05:30
Ankush Menat
313605d328
fix: standard dashboards not loading
2022-11-05 21:13:27 +05:30
Ankush Menat
43ccb40d0e
chore: rollback to 3.10 for vuln checks
...
cython dependency fails
[skip ci]
2022-11-05 18:33:50 +05:30
Ankush Menat
032df946be
test: bg jobs test cleanup ( #18767 )
...
* test: fix flaky RQ job tests
Sometimes stop_job doesn't succeed and causes tests to timeout. Reduced
sleep time to avoid this in tests. We are still testing all the
important features - monitoring.
* build(deps): Bump RQ to latest version
Minor bugfixes that affect us
ref: https://github.com/rq/rq/releases
* test: sanity tests for scheduled job types
* test(test_runner): dont set bench_id globally
* refactor: stop_job shouldn't throw error
The intention of use here is to stop stuck jobs or long running jobs, if
for some reason they were stopped by the time command gets executed,
there's no need to throw error.
2022-11-05 14:08:35 +05:30
Ritwik Puri
ba25e97d4e
Merge pull request #18756 from ankush/qb_simpler
...
refactor: qb builder class identification
2022-11-04 17:26:57 +05:30
Sagar Vora
f20fa69282
fix!: remove relaxations for Cordova ( #18728 )
2022-11-04 17:24:26 +05:30
Ankush Menat
0175fafde3
Merge pull request #18491 from resilient-tech/perf-set-document_naming
...
perf: cache document naming rule to avoid recurring db calls
2022-11-04 17:13:19 +05:30
Ankush Menat
f0197d35d6
refactor: qb builder class identification
2022-11-04 15:42:26 +05:30
Shariq Ansari
a42b7b8e3a
Merge pull request #18754 from maharshivpatel/fix-child-table-mobile-specific-code
2022-11-04 14:20:51 +05:30
Maharshi Patel
9aa5526305
fix: child table don't run mobile specific code
...
on_input_focus & handle_date_picker function has mobile specific code that relies on touch inputs so there is no need to run it on desktop.
2022-11-04 12:07:39 +05:30
Sagar Vora
8b84042037
fix: load doc_before_save in check_if_latest ( #18752 )
2022-11-04 10:44:17 +05:30
Ritwik Puri
58062c296e
Merge pull request #18010 from Aradhya-Tripathi/qb-fixes
...
fix: misc query engine fixes
2022-11-03 21:59:37 +05:30
Ankush Menat
0ed7600604
build: py3.11 support ( #18550 )
...
* chore: bump RestrictedPython
* ci: use py3.11 on development version
* fix: py311 compat changes
* chore: bump to final versions
2022-11-03 20:49:05 +05:30
Aradhya
8b73108270
feat: added PseudoColumnMapper for postgres support
2022-11-03 20:43:24 +05:30
Shariq Ansari
94915b4d6a
Merge pull request #18720 from Ponnusamy1-V/patch-1
2022-11-03 16:38:39 +05:30
Shariq Ansari
cdadff1f4e
Merge branch 'develop' into patch-1
2022-11-03 15:25:09 +05:30
Shariq Ansari
cfc773c648
Merge pull request #18740 from shariquerik/file-cropper-fix
...
fix: file cropper broken in webform
2022-11-03 15:22:33 +05:30
Shariq Ansari
cc3e70b9ac
fix: file cropper broken in webform
2022-11-03 14:04:36 +05:30
phot0n
dfe62f2614
test: use double quotes for postgres query assertions
2022-11-03 12:50:38 +05:30
Aradhya
e1719fd30c
feat: Added support for table_field.fieldname and tests
2022-11-03 03:56:59 +05:30
Ankush Menat
a1a296ac75
fix: ignore global translations ( #18733 )
...
_("string") outside of function/methods don't make any sense cause they
are initialized the moment module is imported. This is already checked
in CI yet people make this mistake.
Ignore and refuse to translate in those cases.
2022-11-03 03:00:03 +05:30
Sagar Vora
5e679bf539
chore: bump cryptography to 38.0.3 ( #18730 )
2022-11-03 01:24:55 +05:30
