Commit graph

2404 commits

Author SHA1 Message Date
Ankush Menat
bb68908fe9
refactor: web form link logic (#25951) 2024-04-15 10:53:38 +00:00
Ankush Menat
535bc10340
fix: make letterhead attachments public by default (#25925)
Also does it for web page.

Note: This is just default config, users can change while uploading.
2024-04-12 05:14:18 +00:00
Ankush Menat
672f3b2258 refactor!: sort by creation for clearing old logs 2024-03-27 13:04:01 +05:30
Ankush Menat
3896296c6f fix: update sort order in doctypes 2024-03-27 11:18:28 +05:30
Suraj Shetty
5bd496d2ee
Merge branch 'develop' into embedable-webform 2024-03-22 20:32:48 +05:30
Suraj Shetty
30082da7af feat: Option to make webform embeddable
- If Web Form is rendered in Iframe all unnecessary elements from the web form view is hidden
2024-03-22 15:06:12 +05:30
Corentin Flr
1b67db7aa1
feat(kb): Add list for help article (#25102) 2024-03-15 16:12:54 +05:30
Corentin Flr
0cf58cac07
chore(weblist): Fix data-txt encoding, remove notxt (#25101) 2024-03-15 15:51:39 +05:30
Ankush Menat
d758af5960 fix: clear routing cache on homepage change 2024-03-13 23:42:59 +05:30
Ankush Menat
d9d29430a9 fix: validate homepage paths 2024-03-13 21:00:51 +05:30
Ankush Menat
b1a8bc9312
fix: Export None as type if select as no options (#25211)
Select options can be dynamic, in that case we should at least the
default value `None` as a value `DF.Literal` otherwise is invalid type
annotation.
2024-03-04 06:42:41 +00:00
Ankush Menat
bab3ee33f0
fix: always show is_standard on web form (#25144)
This causes more confusion when it's hidden.
2024-02-28 12:07:28 +00:00
Ankush Menat
99a6883e5c
fix(UX): correctly disable standard web form form (#25143) 2024-02-28 17:33:46 +05:30
Ankush Menat
dbc2e092f1 fix: escalate print failures
Print failures shouldn't generate PDF with failure message but instead escalate the error.

This prevent all the PDFs that just contain "PermissionError" from being sent.
2024-02-28 16:42:03 +05:30
Ankush Menat
e46ded10c0
fix: keep 3 recent versions of website themes around (#25029)
For whatever unknown reason (https://github.com/frappe/frappe/issues/22205) website theme cache can be invalid or it might fail to generate correctly.

In such cases website becomes unusable, this PR tries to keep it usable.
2024-02-23 10:02:47 +00:00
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-21 16:20:28 +05:30
Akhil Narang
aa38d9e2f4
refactor: pipeline wherever possible, optimize calls
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-19 14:28:35 +05:30
Ankush Menat
72c2207e0f refactor: useless use of dict in frappe.get_doc 2024-02-10 12:52:38 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Suraj Shetty
2243c5ebe3 fix: Resolve conflicts 2024-02-05 15:51:22 +05:30
Suraj Shetty
2bf82e80ba fix: Make sure sitemap respects robot_txt 2024-02-05 15:41:05 +05:30
Corentin Flr
c9c8414562
fix(website): Handle virtual DocTypes webview routing (#24445)
Co-authored-by: Charles-Henri Decultot <chdecultot@dokos.io>
2024-02-05 12:47:09 +05:30
David Arnold
c09f48f5d7
feat: comply trackers with utm and add utm_content for a/b testing (#24521)
* feat: comply trackers with utm and add utm_content for a/b testing

* fix: make all other than source optional

this is plausible.io best practice

* fix: medium is not specified to be lowercase

* fix: ensure proper parameter quoting
2024-02-02 11:33:22 +05:30
Ankush Menat
dd6f20b301
Merge pull request #24644 from ankush/clear_sitemap_cache
fix: clear sitemap cache periodically
2024-01-31 18:41:54 +05:30
Ankush Menat
ffb9c9cf6a fix: clear sitemap cache periodically 2024-01-31 18:25:28 +05:30
Rucha Mahabal
53d6d156ec
chore: cleanup doctype descriptions (#24609) 2024-01-31 12:00:39 +05:30
barredterra
9d6cbd0c15 fix: typos 2024-01-24 02:41:03 +01:00
Maharshi Patel
65af4b8dbf
fix(minor): increase rate limit for web form (#24295)
increased rate limit for web form to 10 requests per minute.
2024-01-12 20:58:34 +05:30
Shariq Ansari
6d40d1c6da
Merge pull request #24170 from shariquerik/precision-in-webform
fix: added precision field in webform field
2024-01-08 14:57:30 +05:30
Suraj Shetty
4b375006bf
Merge pull request #24157 from rmehta/fix-login-footer-visibility 2024-01-08 14:46:34 +05:30
Shariq Ansari
e2bc379b23 fix: get precision data while getting fields 2024-01-08 14:33:31 +05:30
Shariq Ansari
2969b6eff1 fix: added precision field in webform field 2024-01-08 14:24:16 +05:30
Rushabh Mehta
482813e46d
Merge pull request #24155 from rmehta/fix-help-category-unpublish
fix(minor): Unpublish article when category is unpublished #15361
2024-01-08 12:30:34 +05:30
Rushabh Mehta
5275f393c7 fix(minor): drop icon column, unsupported, fixes #23826 2024-01-08 12:07:10 +05:30
Rushabh Mehta
04646024cb fix(minor): show footer on login via Website Settings, fixes #24153 2024-01-08 11:56:51 +05:30
Rushabh Mehta
cb2e803d0c fix(minor): Unpublish article when category is unpublished #15361 2024-01-08 11:39:02 +05:30
Raffael Meyer
3fd26775b3
fix(Web Form): make button label translatable (#24122)
* fix(web Form): make button label translatable

* fix: context in web form translations
2024-01-05 23:32:53 +05:30
Raffael Meyer
bb6911101e
fix: remove Guest permission on Help Article (#24082) 2024-01-02 16:20:20 +05:30
barredterra
cd37bf0337 fix(Blog Post): correct indicator filter 2023-12-30 01:37:53 +01:00
Ankush Menat
8c515a9a5d fix: correct perm check for guests
Allow viewing document page if doctype allows guest to view
2023-12-29 17:59:39 +05:30
Ankush Menat
38314aec59
fix: Check permissions before rendering web view (#24032) 2023-12-29 17:07:17 +05:30
Suraj Shetty
529d0aa5a7
Merge pull request #24018 from surajshetty3416/hook-to-add-custom-route-resolver 2023-12-29 06:53:18 +05:30
Suraj Shetty
a51a150376 feat: Hook to add custom route resolver 2023-12-29 06:33:59 +05:30
Akhil Narang
ff4dca3e16
fix(redirect): make the status codes a select field instead of int
Drop mandatory, assume sane defaults
The current implementation broke old users of redirects like helpdesk app

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-22 12:25:41 +05:30
Ankush Menat
36451b6951
Merge pull request #23765 from akhilnarang/http-307-redirect
feat: allow setting a custom http status code for redirects
2023-12-21 13:53:51 +05:30
Ankush Menat
0fd6f5eed7
Merge pull request #23827 from frappe/api-docs
docs: add Python API missing docstrings / type hints
2023-12-21 12:13:05 +05:30
Akhil Narang
2224d86c94
refactor: cache status code as well
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-20 17:47:16 +05:30
Akhil Narang
6819a38fbe
fix: set correct response code for redirections
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-20 17:36:42 +05:30
Akhil Narang
44667901bf
feat: allow setting a custom http status code for redirects
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-20 17:36:42 +05:30