Commit graph

37822 commits

Author SHA1 Message Date
Suraj Shetty
aac9378beb
test: Disable flaky test
Unable to find the cause of the flakiness of the test. Disabling it for now.

Also, the form_tour test is full of `wait` which is bad anyway.
2022-05-05 18:37:08 +05:30
Ankush Menat
c31eca3ba5
fix: circular imports (#16830)
Circular imports issue when loading modules in background worker. Doesn't happen in web worker or console 🤷
2022-05-04 19:09:53 +05:30
Shariq Ansari
b4e43257c3
fix: bad query if user has ' in the email address (#16796) 2022-05-04 19:07:51 +05:30
Sagar Vora
a33c2e2abe
refactor(BaseDocument)!: improved get, set and extend methods (#16540)
* perf!: 80% faster doc.get for fields with `None` as value

* perf: quicker init child (#3)

* refactor: avoid repitition and improve error message

* test: `doc.extend`

* fix: improve constant naming

* fix: minor improvements and tests

* refactor: improve naming
2022-05-04 18:37:06 +05:30
Ankush Menat
92fcc7c466
Merge pull request #16829 from ankush/deferred_insert_fix
fix: handle dict data in deferred_insert
2022-05-04 16:55:11 +05:30
Ankush Menat
05f9201e07 fix: dont manually commit after flushing deferred_insert
this runs from scheduled job which commits after finishing.
2022-05-04 14:59:19 +05:30
Ankush Menat
ed78a23748 fix: handle dict data in deferred_insert
vanilla dict doesn't have attrs, setattr fails
2022-05-04 14:59:17 +05:30
gavin
65d70e08e1
Merge pull request #16815 from gavindsouza/simplify-setup-wizard
fix: Simplify setup wizard
2022-05-04 12:24:58 +05:30
Gavin D'souza
73c87c0e29 fix: Hide progress bar for less than 2 slides 2022-05-04 11:46:12 +05:30
Ankush Menat
d1938ee271
perf: remove naming series from log-like doctypes (#16823)
- webhook request log
- access log
2022-05-04 10:54:52 +05:30
mergify[bot]
ee40bda491
Merge pull request #16602 from resilient-tech/int-req
refactor: Integration Request
2022-05-02 12:49:27 +00:00
Ankush Menat
4310a2ecca
fix(UX): suggest app-specific password for gmail logins (#16812) 2022-05-02 17:30:21 +05:30
Gavin D'souza
6cb8127e8d fix(setup_wizard): Make language field Autocomplete 2022-05-02 16:56:25 +05:30
Gavin D'souza
a688577a3f fix(setup_wizard): Merge language & country info slides
Minimizing the number of slides required for setting up a new site. In
developer mode, only one slide is visible now titled "Hello" or
selected language equivalent.
2022-05-02 16:19:38 +05:30
gavin
f8a7d04010
Merge pull request #16808 from ruchamahabal/fix-razorpay-error-log
fix: `frappe.log_error` arguments while capturing razorpay payment failures
2022-05-02 10:50:09 +05:30
gavin
30c4425079
Merge pull request #16806 from KrutikaBhatt/sort_by_fix
fix(bug): required meta field is used inplace of mandatory
2022-05-02 10:49:56 +05:30
Rucha Mahabal
693a6a7789 fix: frappe.log_error arguments while capturing razorpay payment failures 2022-05-01 11:34:08 +05:30
KrutikaBhatt
2e4953b8ec
fix(bug): required meta field is used inplace of mandatory 2022-04-30 19:58:52 +05:30
Ritwik Puri
76a6c282b8
fix: use proper validations for number card validation method (#16581) 2022-04-29 16:07:40 +05:30
Ritwik Puri
b41379c78b
fix: misc fixes (integer primary keys) (#16307)
* fix: misc fixes

local.x gets resetted on every request so switched to a simple dict

simplified is_val_used in set_next_val function for sequences

* chore: use multisql for sequence methods

* fix: fields not updating on form

* minor(base_input): removed unnecessary branching in update_input

* chore: remove prints and rename autoincremented_status_map

* chore: added proper type hint + comment + formatting

* fix: added searching in cast_name rather than handling it manually

* fix: share condition query + test_build_match_conditions

* fix: add cast_name to more places

* test: test for sequence

* fix: sequence functions

* fix: inherit frappetestcase

* minor: attach sequence methods to db context local

* chore: update sequence function names in Database

use frappe.db for sequences in naming.py

* fix: convert filename to str (for autoincremented doctypes)

* chore: better regex for modifying values for postgres

* minor: allow changing name column type (if no data is present in the doctype)

* refactor: validate_autoname

converted it to a simple function
enabled changing autoincrement autoname from customize form

* fix: use sql_ddl for change_column_type in postgres

* fix: use not null constraint in postgres when changing name type

* fix(test): updated test_autoincremented_doctype_transition with transitioning when no data is present

* fix(test): updated test_cast_name

probably messed up during rebase

* fix(test): used rollback upon error in transaction for postgres

* chore: use frappe.db.x methods for sequences

* minor: use temporary sequences in test

* minor: use generate_hash for sequence naming in sequence tests

* chore: replace sequence imports with frappe.db.x

* chore: move out casting name fields to a separate method

* refactor: cast_name

more explicit cases for casts and added docstring

* fix: added space in test_cast_name

* chore: fix linter

* chore: better naming for can_change_name_column_type

* chore: add comment for autoincremented_site_status_map

* chore: update/add docstrings
2022-04-29 15:06:03 +05:30
gavin
5bfb55dd21
Merge pull request #16800 from gavindsouza/article-schema-fix
fix: Use BlogPosting schema for Article
2022-04-29 14:46:12 +05:30
Gavin D'souza
6d96f11dd9 fix: Use BlogPosting schema for Article
Fixes https://github.com/frappe/frappe/issues/1730
2022-04-29 14:38:35 +05:30
Rushabh Mehta
a59e5d7aac
Merge pull request #16791 from rmehta/fix-control-test
test: Fixes `control_dynamic_link` test
2022-04-28 16:05:05 +05:30
Rushabh Mehta
4faf6f5704
Merge pull request #16792 from rmehta/fix-email-log
fix(minor): fix email error logging and strip Guest
2022-04-28 15:44:52 +05:30
Rushabh Mehta
dfeb16f58d fix(test): control_dynamic_link.js 2022-04-28 15:20:29 +05:30
Rushabh Mehta
c23cc52948 fix(test): control_dynamic_link.js 2022-04-28 15:17:56 +05:30
gavin
f1cceba81b
Merge pull request #16763 from surajshetty3416/fix-autoname-validation
fix: Validate "autoname" for Customize Form
2022-04-28 15:03:39 +05:30
Suraj Shetty
532e5dd0d6
Merge pull request #16620 from Komal-Saraf0609/control-data 2022-04-28 15:02:50 +05:30
Rushabh Mehta
d3ca83c4d8 fix(minor): fix email error logging and strip Guest 2022-04-28 14:55:39 +05:30
gavin
c0bcae9887
Merge pull request #16793 from gavindsouza/readme-fix
docs: Trimmed whitespace from FC button
2022-04-28 14:54:10 +05:30
Gavin D'souza
760974a050 style(README): Fixed inconsistent whitespaces 2022-04-28 14:52:42 +05:30
Gavin D'souza
b1effcab4b docs: Removed whitespace from Try on FC button 2022-04-28 14:52:29 +05:30
Rushabh Mehta
9847019457 fix(test): control_dynamic_link.js 2022-04-28 14:47:07 +05:30
Rushabh Mehta
efd993cdc3 fix(test): control_dynamic_link.js 2022-04-28 14:45:27 +05:30
Rushabh Mehta
6d266b19af fix(minor): fix email error logging and strip Guest 2022-04-28 14:42:17 +05:30
Rushabh Mehta
ec2c65f0a5 fix(test): control_dynamic_link.js 2022-04-28 14:27:46 +05:30
gavin
b64d10a5ee
docs(README): Add PWD button for Frappe (#16790)
Clicking on the button will take you to Play with Docker site which will
give you a new vanilla Frappe site to test and play around with for 3 hours

PWD File from https://github.com/gavindsouza/install-scripts/blob/main/frappe/pwd.yml
Related ERPNext PR: https://github.com/frappe/erpnext/pull/30817
2022-04-28 14:14:09 +05:30
Ritwik Puri
d1423f1517
test: use data fieldtype instead of int in test_fieldname_starting_with_int (#16771)
* fix(test): use data fieldtype instead of int

postgres doesn't allow using like operator on int/any non-text/varchar column
ref: https://github.com/frappe/frappe/issues/16722

* minor: updated test_fieldname_starting_with_int with child table filters
2022-04-28 13:46:09 +05:30
Rushabh Mehta
926ceb3b25
Merge pull request #16789 from nidhipurohit11/link_field
Modified condition for cypress >> Link field dropdown selection
2022-04-28 12:07:56 +05:30
Komal-Saraf0609
03efa25d03 test: Corrected failed tests 2022-04-28 12:06:45 +05:30
Nidhi Purohit
bc5ab839da Added condition for cypress >> Link dropdown selection 2022-04-28 11:54:36 +05:30
Suraj Shetty
30440026db fix: Do not allow autoname changes to/from autoincrement in customize form 2022-04-28 11:44:33 +05:30
Aditya Hase
672bd8a523
fix: Update links to Frappe Cloud (#16788) 2022-04-28 11:05:50 +05:30
Suraj Shetty
ccc82e2c4c
Merge pull request #15538 from noahjacob/phone_field_control
feat: Phone Control Type
2022-04-28 10:27:52 +05:30
Suraj Shetty
cf49bbe4f8
Merge branch 'develop' into control-data 2022-04-27 17:38:48 +05:30
Suraj Shetty
2bc06a1058 fix: Check if autoname exists 2022-04-27 17:08:42 +05:30
Max Solanki
88992c6686
fix: console error while using TAB shortcut in grid (#16701) 2022-04-27 17:08:26 +05:30
Suraj Shetty
2f2fc0440d test: Init UI test for customize form 2022-04-27 15:56:20 +05:30
Suraj Shetty
a667b00681 refactor: Remove unnecessary switch case 2022-04-27 15:55:29 +05:30
Ankush Menat
9bec3480ed
ci: failfast in case of conflicts (#16777) 2022-04-27 14:25:45 +05:30