Commit graph

43564 commits

Author SHA1 Message Date
Maharshi Patel
aaf40dc583 fix: sidebar redesign
* replaced all full width pill buttons with the labels and plus icons
* added a click listener to avatars for opening share dialog.
* made attachments label a link where user can click and open all of the files
  as there isn't enough space for explore buttons in new design
2023-10-04 23:05:24 +05:30
Maharshi Patel
8718b60bfc fix: sidebar, multiselect, body tag letterspacing
* fixed space between multiselect pills
* fixed sidebar spacing and alignment
* added letterspacing of 0.02em in the body tag as this is the new base spacing.
2023-10-04 10:18:46 +05:30
Sambasiva Suda
53c795f4b8
fix: Workflow Builder not updating diagram with added states/transitions in table (#22429)
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
2023-10-03 17:13:51 +05:30
Suraj Shetty
c519239ff2
Merge pull request #22604 from deepeshgarg007/address_contact_perm 2023-10-02 23:06:16 +05:30
Deepesh Garg
99bec229fb chore: remove unintentional json updated 2023-10-02 16:51:09 +05:30
Deepesh Garg
89fa201d9b chore: remove unintentional json updated 2023-10-02 16:49:36 +05:30
Deepesh Garg
ca726a82b4 fix: Give All role permission to read/create own address and contact 2023-10-02 16:12:41 +05:30
Ankush Menat
4b0326ac39
Merge pull request #22603 from ankush/fix_button_groups
fix(UX): remove clutter from buttons on query report
2023-10-02 15:42:34 +05:30
Ankush Menat
19394ca353 fix(UX): remove clutter from buttons on query report 2023-10-02 15:37:08 +05:30
Shariq Ansari
3761de260f
Merge pull request #22335 from bosue/vertical_checkbox_columns 2023-10-01 13:11:58 +05:30
Bernd Oliver Sünderhauf
42575d9951 fix(UX): Bring responsive multi-column design to module and role editors 2023-09-30 14:46:44 +02:00
Bernd Oliver Sünderhauf
7baab4490b fix(UX): Responsive, column-major design for multicheck elements. 2023-09-30 14:46:19 +02:00
Shariq Ansari
a7e03a9095
Merge pull request #22589 from cogk/fix-breakpoints-css 2023-09-29 21:32:22 +05:30
Corentin Forler
b9e16f5fed
fix: Fix breakpoints CSS variables using map-get
“Sass parses custom property declarations differently than other property declarations. All tokens are passed through to CSS as-is.”
https://sass-lang.com/documentation/style-rules/declarations/#custom-properties
2023-09-29 16:23:50 +02:00
Shariq Ansari
a0783fa8cc
Merge pull request #22587 from shariquerik/workspace-plus-icon-missing 2023-09-29 17:12:48 +05:30
Shariq Ansari
910b8e1b96 fix: plus icon missing in workspace 2023-09-29 17:10:34 +05:30
Ankush Menat
08f8019903
Merge pull request #22586 from ankush/make_default_private
fix: set default to private for InteractionComposer
2023-09-29 16:01:33 +05:30
Ankush Menat
4f3c9bc91a fix: set default to private for InteractionComposer
Most common use case for event/task is private so that's what should be
set here.
2023-09-29 15:59:45 +05:30
Ankush Menat
f02521bfc5
Merge pull request #22583 from ankush/filene_error
fix: no perm if doc doesn't exist
2023-09-29 13:27:29 +05:30
Ankush Menat
8242d75bc6 fix: no perm if doc doesn't exist
Right now "doc doesn't exist is thrown, instead we can assume that user
doesn't have permission to this file. User might have access to other
file still.
2023-09-29 13:11:02 +05:30
Sagar Vora
e3b012b76d
Merge pull request #22578 from resilient-tech/double-translate 2023-09-29 12:20:48 +05:30
Sagar Vora
78240d8f0d
Merge pull request #22574 from resilient-tech/address-contact 2023-09-29 12:11:51 +05:30
Sagar Vora
20178bd3eb fix: improved validation for address and contact 2023-09-29 12:04:38 +05:30
Suraj Shetty
1b80bd45dd style: Fix linter warnings 2023-09-29 11:08:16 +05:30
Suraj Shetty
e5bce72d5c test: Fix flaky theme switcher UI test 2023-09-29 10:49:49 +05:30
Maharshi Patel
bc97d91e3f
Merge pull request #22536 from maharshivpatel/fix-espresso
fix: espresso issues shared in #22508.
2023-09-29 10:30:00 +05:30
Maharshi Patel
407706747e Merge branch 'develop' into fix-espresso 2023-09-29 01:01:17 +05:30
Maharshi Patel
6d111c712a fix(minor): quill toolbar and paging buttons 2023-09-29 00:57:09 +05:30
Maharshi Patel
cb7415338a fix: sidebar UX, sidebar & attach control cypress
* changed "show all" to button
* updated cypress tests for sidebar and attach control
* change "Explore Files" button icon location
2023-09-28 23:35:01 +05:30
Ankush Menat
f2c45577d9 fix: Escape filename in sidebar 2023-09-28 16:59:45 +05:30
Maharshi Patel
2355b9d581 fix: multiselect, page-card border, sidebar image
* changed multiselect feilds background color
* changed page-card border color for error and login page
* moved sidebar image border to image instead of sidebar-image-section
2023-09-28 16:22:52 +05:30
Maharshi Patel
1ff551031b fix(minor): child table inline filter border bottom 2023-09-28 15:07:24 +05:30
Maharshi Patel
d9113bfade fix: workspace number cards
* moved stats to bottom as there isn't enough space on the same row
* updated padding and changed menu top margin
2023-09-28 15:07:09 +05:30
Maharshi Patel
df9afdb649 Merge branch 'develop' into fix-espresso 2023-09-28 15:00:23 +05:30
Maharshi Patel
57a7975405 fix: timeline email style fixes
* dark mode text color
* email left side padding
2023-09-28 14:59:17 +05:30
Sagar Vora
c561369330 fix: avoid double translation 2023-09-28 11:46:44 +05:30
Ankush Menat
f2277b9254
Merge pull request #22539 from ankush/file_backup_exit_code
fix: Correct exit code for failed compressed file backup
2023-09-27 10:14:14 +05:30
Shariq Ansari
9bafe1f558
Merge pull request #22408 from RitvikSardana/develop-ritvik-add-column-fix 2023-09-26 12:30:10 +05:30
RitvikSardana
9368f0aee4 fix: enable server script while testing 2023-09-26 12:02:25 +05:30
Ankush Menat
5d31667157 fix: Correct exit code for failed compressed file backup
addresses https://github.com/frappe/press/issues/1052

Similar to https://github.com/frappe/frappe/pull/18230
2023-09-25 23:15:11 +05:30
Ankush Menat
2056b0a6f0
Merge pull request #22538 from ankush/delete_oauth_data
refactor: delete oauth internal data with db query
2023-09-25 20:01:10 +05:30
Ankush Menat
4fb0f9f98d refactor: delete oauth internal data with db query
This won't trigger DB hooks but
- it's faster.
- doesn't do any validation/hooks
- doesn't store deleted document
2023-09-25 19:38:48 +05:30
Maharshi Patel
fd8cfcc9e7 fix: linters 2023-09-25 18:13:24 +05:30
Maharshi Patel
1041b7b85b fix: espresso issues shared in #22508.
I have fixed the following issues:
    * notification unread indicator
    * workspace sidebar menu icons as per espresso
    * Fallback icon if page is public and no icon is set
    * Removed Borders from grouped buttons
    * added unseen notification icon need to update once timless creates a new icon
    * changed filter button to be more like espresso.
    * changed group by button icon and text.
    * fixed link icon in communications (caused by use of like-icon class)
    * changed sidebar Add Assignee Icon to better reflect use also changed text of Shared with to Share.
2023-09-25 17:51:53 +05:30
Suraj Shetty
36b1a833c0 Merge branch 'develop' of https://github.com/frappe/frappe into develop 2023-09-25 17:12:52 +05:30
Ankush Menat
043f8555b5
Merge pull request #22531 from ankush/allowed_extensions
feat: Global allowlist for file extensions
2023-09-25 17:12:36 +05:30
Suraj Shetty
6bcafb1730 ci: Add codecov_token to fix codecov issue 2023-09-25 17:12:22 +05:30
Ankush Menat
235ae23c3a refactor: Use newline as separator instead of comma 2023-09-25 16:49:26 +05:30
Ankush Menat
68bf9f50c4 fix: Global allowlist for file extensions
This is dumb validation to have and it barely improves security, but
eNterPriSe users keep demanding this nonsense hence we are forced to add
this.

Alternate to https://github.com/frappe/frappe/pull/22528
2023-09-25 16:45:58 +05:30
Ankush Menat
d6c5ba0e16
Merge pull request #22532 from ankush/hook_resolution_methods
fix!: Last overriden method should be considered
2023-09-25 16:35:38 +05:30