Commit graph

43367 commits

Author SHA1 Message Date
Ankush Menat
acd1b9d64e
fix: Don't run query if dn is None (#22475) 2023-09-19 15:11:15 +00:00
Suraj Shetty
be5e05f7a2
Merge pull request #22436 from 0xsirsaif/bench-listapps-refactor 2023-09-19 20:32:55 +05:30
Suraj Shetty
004789b599
Merge pull request #22471 from niraj2477/add-print-shortcut 2023-09-19 16:16:45 +05:30
Suraj Shetty
7905423128
Merge pull request #22446 from surajshetty3416/fix-dashboard-chart-permission 2023-09-19 15:33:25 +05:30
14987
b7e35e558e
feat: Add print shortcut 2023-09-19 15:14:51 +05:30
Shadrak Gurupnor
c4afd035e8
feat: view committed queries in console log (#22466)
* feat: show committed queries in console log

* chore: typo
2023-09-19 14:38:23 +05:30
Corentin Flr
d73a854191
feat(UX): Add autocomplete for User timezone (#22456)
* feat(UX): Add autocomplete for User timezone

* Revert "feat(UX): Add autocomplete for User timezone"

This reverts commit a721b4a1ef8e0e6b656b6795b832324a955b2f7a.

* fix: convert tz to autocomplete

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-18 22:37:32 +05:30
Ankush Menat
e152ebc0a3 chore: typo 2023-09-18 20:16:27 +05:30
Ankush Menat
8779be9b49
fix: propogate correct HTTP status code (#22450) 2023-09-18 10:30:12 +00:00
Ankush Menat
8cb13f922a chore(DX): Annotate all local proxies 2023-09-18 15:36:58 +05:30
Ankush Menat
6a2bfbf61d
fix: Ignore perm while updating module onboarding (#22448)
* fix: Ignore perm while updating module onboarding

* fix: incorrect error message
2023-09-18 09:00:53 +00:00
Ankush Menat
6a2266c641
Merge pull request #22445 from ankush/perm_ux
fix: permission manager if-owner behaviour
2023-09-18 14:05:52 +05:30
Ankush Menat
0381f836d6 fix: update correct role permission rule
Right now if you have if-owner rule on doctype then whatever you change
will only apply to last inserted rule because we don't check if-owner
value

Long term better fix: Identify with perm rule name instead of arbitrary
"primary keys" defined in code.
2023-09-18 13:45:20 +05:30
Suraj Shetty
df30e1c6f0 fix: Only allow user with role set in Dashboard chart
If roles are set is Dashboard Chart, only
user with those roles can access the chart.
If not set, DocType or Report permissions should be used
2023-09-18 13:44:09 +05:30
Ankush Menat
b484c65283 fix: check if owner while deleting permission
If doctype has 2 rules: 1 with if-owner and one without then deleting one deletes both.
2023-09-18 12:33:26 +05:30
Ankush Menat
fb65ab1a4e fix: notify when rule already exists 2023-09-18 12:28:14 +05:30
mergify[bot]
091c6ca49f
Merge pull request #22441 from blaggacao/develop
fix: `flt` with trailing zeros
2023-09-18 06:35:05 +00:00
Ankush Menat
f1ffc3fd39 test: fix bankers rounding test
One more `null` needs to be passed for "not passing precision"
2023-09-18 11:42:21 +05:30
Ankush Menat
7b91df0db6 Merge branch 'develop' into blaggacao/develop 2023-09-18 11:36:38 +05:30
Ankush Menat
808316cc13
Merge pull request #22444 from ankush/perf_docinfo
perf: docinfo
2023-09-18 11:32:04 +05:30
Ankush Menat
d20e436e0f perf: fetch user info in one query 2023-09-18 11:16:20 +05:30
David Arnold
2ddd808b58
test: add more test cases with number & currency formatting 2023-09-17 16:44:13 +02:00
David Arnold
0568795edd
Revert "fix: make flt value idempotent"
This reverts commit 4d0b0d35ef.
2023-09-17 15:39:57 +02:00
David Arnold
9f0c8be183
test: add failing test case for js flt 2023-09-17 15:36:36 +02:00
Ankush Menat
8f34d6fc3e perf: docinfo
- Dont query versions if disabled
2023-09-17 14:16:47 +05:30
saif
8b83e051d0 refactor: Improve list_apps function readability and maintainability.
- Improve variable naming and reduce redundancy.
- Reorganize and simplify code structure.
2023-09-17 11:41:13 +03:00
mergify[bot]
3239636e7d
Merge pull request #22187 from cogk/ux-list-view-sort-columns
feat(list): Sort by column by clicking on col title
2023-09-17 07:19:26 +00:00
Corentin Flr
2f1119bfcc
Merge branch 'frappe:develop' into ux-list-view-sort-columns 2023-09-17 08:57:37 +02:00
Ankush Menat
ea7b080e70 chore: nudge towards properly skipping onboarding
Escape doesn't totally skip
2023-09-15 19:14:24 +05:30
Ankush Menat
4ae3aaf6ac Revert "fix: defer first tour until awesomebar is triggered"
This reverts commit 60615a126c.
2023-09-15 19:04:55 +05:30
Shariq Ansari
4c4b4f61af
Merge pull request #22379 from shariquerik/nested-custom-reports-filter-fix
fix: nested custom reports filter not rendering
2023-09-15 18:51:14 +05:30
Shariq Ansari
6e62baeef9
Merge pull request #22108 from barredterra/open-file-from-picker
feat(File Uploader): open file details from search
2023-09-15 18:45:42 +05:30
Shariq Ansari
6ce30724cb
chore: linter fix 2023-09-15 18:33:18 +05:30
Shariq Ansari
655047c274 fix: stop parent click if external link icon is clicked 2023-09-15 18:23:23 +05:30
Shariq Ansari
a6468cab3a fix: using icon instead of svg 2023-09-15 18:20:02 +05:30
Shariq Ansari
27960cda57
Merge pull request #22422 from ssuda/workflow-builder-fix 2023-09-15 17:25:06 +05:30
Shariq Ansari
920a88e1ac feat: show preview on popover if file is image type 2023-09-15 17:17:22 +05:30
Shariq Ansari
cd5c43d657
Merge pull request #22282 from mterceno/fix-missing-keyboard-shortcut-on-document---Duplicate 2023-09-15 17:13:08 +05:30
Shariq Ansari
865e99929f
Merge pull request #22270 from barredterra/responsive-address-contact-list 2023-09-15 17:05:02 +05:30
Ankush Menat
4f92189a6c
Merge pull request #22399 from niraj2477/remove-stale-data
fix!: Sync deleted doctypes on migration
2023-09-15 16:38:48 +05:30
Ankush Menat
b409a05e8e fix: Ignore all non-import exceptions 2023-09-15 16:22:09 +05:30
Ankush Menat
c189b7e622 revert: syncing of report and pages 2023-09-15 16:22:06 +05:30
Ankush Menat
662b07170c test: orpahned doctype check after patch test 2023-09-15 16:18:25 +05:30
Ankush Menat
b9ee6827b4 refactor: stale object removal
- Do it after migration, post migration might use some old doctype.
- stale -> orpahn
- dont commit changes individually
- Remove table doctype too
2023-09-15 16:18:25 +05:30
Ankush Menat
b6d65fea06 ci: update patch workflow
- start with v13 DB, drop py3.7
- New flow v13DB -> V14 -> V15 (when released) -> PR commit
- Restart bench before final migrate
2023-09-15 16:18:25 +05:30
14987
2937ba38db fix: Update get_doc filter 2023-09-15 16:18:25 +05:30
14987
31a1d37f0a refactor: Fix ambigious var name 2023-09-15 16:18:25 +05:30
14987
b9449a4f13 fix: Delete stale doctypes, reports and pages 2023-09-15 16:18:25 +05:30
Sambasiva Suda
d312cb443c fix: saving workflow in workflow builder 2023-09-15 15:32:48 +05:30
Shariq Ansari
afd323ef23 fix: return report if not custom report 2023-09-15 15:18:23 +05:30