Gavin D'souza
af673f0082
fix: Generate non-conflicting names in File.save_file
...
Other fix:
* Don't set File.file_name (too) different from File.file_url
2022-03-15 19:39:47 +05:30
Gavin D'souza
48c448160d
refactor: Restructure File module
...
* Separate out utils, exceptions & core / maintain import paths [except
API endpoints]
* Add type hints
* Simplify logic
2022-03-15 19:39:47 +05:30
Gavin D'souza
9b54e3d0c0
fix: Disallow sites to have file access beyond site folder
2022-03-15 19:39:47 +05:30
mergify[bot]
2b50525a5e
Merge pull request #16243 from shariquerik/number-card-filter-fix
...
fix: Number Card to support child table doctype for filters
2022-03-15 10:32:30 +00:00
Suraj Shetty
e0def6fdd1
style: Remove unnecessary indentation
2022-03-15 15:51:09 +05:30
Ankush Menat
5f08c9962b
fix(ux)!: when error messages are present supress non-error messages
2022-03-15 15:51:09 +05:30
Suraj Shetty
10b6e1902f
Merge pull request #16283 from nextchamp-saqib/fix-delete-message
2022-03-15 15:38:47 +05:30
Saqib Ansari
da080a4091
Merge pull request #16271 from pateljannat/web-form-link-title-doctype-issue
...
fix: web form link title doctype issue
2022-03-15 15:10:08 +05:30
mergify[bot]
c3e350f2c6
chore: typo mistake ( #16275 ) ( #16285 )
...
(cherry picked from commit e997d82da3d5fa74f90fdd878bb0bd8a80bbbc06)
Co-authored-by: Bhavesh Maheshwari <34086262+bhavesh95863@users.noreply.github.com>
2022-03-15 15:02:44 +05:30
Saqib Ansari
d3464f7c11
chore: improve bulk deletion message
2022-03-15 14:28:54 +05:30
Ankush Menat
b2e115513f
Merge pull request #16280 from ankush/docinfo2x
...
fix: dont return docinfo as `message`
2022-03-15 13:45:21 +05:30
Suraj Shetty
23d7b98317
Merge pull request #16276 from surajshetty3416/fix-build-system
2022-03-15 12:51:08 +05:30
Ankush Menat
db0925d446
fix: dont return docinfo as message
...
The return was added for testability but it also becomes part of
response so response size doubles. :)
2022-03-15 12:46:36 +05:30
Saqib Ansari
82c0b5b1d9
Merge pull request #16238 from nextchamp-saqib/webform-link-title
...
feat: show link titles in web form link fields
2022-03-15 12:20:21 +05:30
Shridhar Patil
89f109a197
fix: postgres support for system console processlist ( #16212 )
...
* fix: postgres support for system console processlist
* fix: removed logs
* fix: handle dbtype from backend
* fix: use frappe.db.multiselect to run database specific query
2022-03-15 11:55:05 +05:30
Suraj Shetty
ccb4475411
build: Pass watchFiles list to auto trigger rebuild process on template change
2022-03-15 09:29:54 +05:30
Suraj Shetty
24f3123552
build: Use @frappe/esbuild-plugin-postcss2 to auto-trigger rebuild on scss file changes
2022-03-15 09:28:30 +05:30
Jannat Patel
55eb8eed1a
fix: calling function directly from boot file
2022-03-15 09:03:37 +05:30
Saqib Ansari
e6f1fbc4f1
refactor: show title only if show_title_field_in_link is enabled
2022-03-14 18:44:38 +05:30
Jannat Patel
825e2d0537
fix: web form link title doctype issue
2022-03-14 18:33:29 +05:30
mergify[bot]
6a45846010
Merge pull request #16199 from resilient-tech/perf-listfactory
...
perf: remove duplicate call to `ListView.show`
2022-03-14 11:01:27 +00:00
Ankush Menat
b16c8efa30
Merge pull request #16256 from ankush/is_async_commit
...
fix!: run synchronous background jobs directly in production
2022-03-14 15:57:17 +05:30
Sagar Vora
be1b503958
fix: create before_show method
2022-03-14 15:49:57 +05:30
Sagar Vora
b3035ac20f
perf: remove duplicate call to ListView.show
2022-03-14 15:49:57 +05:30
Ankush Menat
23b70df784
fix!: deprecate is_async=False usage outside of tests
2022-03-14 14:27:59 +05:30
Ankush Menat
b5cf4a15c0
Merge pull request #16255 from marination/set-column-display-contradiction
...
fix: `set_column_disp` contradicts arguments
2022-03-14 11:39:19 +05:30
Marica
57abf9e06b
Merge branch 'develop' into set-column-display-contradiction
2022-03-11 15:44:04 +05:30
Rushabh Mehta
7ace873c3a
Merge pull request #16211 from nikochiko/notifications-hasrole
...
fix: use parent_doctype=... while fetching users from Has Role table
2022-03-11 15:28:47 +05:30
marination
7723164c05
fix: set_column_display contradicts arguments
...
- `show` should set `hidden` as 0, but does the opposite. This is fixed.
- Use `Array.isArray()` instead of deprecated usage
2022-03-11 14:35:38 +05:30
gavin
a886d793f2
Merge pull request #16254 from gavindsouza/db-api-consistency
...
feat(db): Alias is_missing_table for consistency in APIs
2022-03-11 14:26:03 +05:30
Gavin D'souza
ad1e180666
feat(db): Alias is_missing_table for consistency in APIs
2022-03-11 14:03:21 +05:30
mergify[bot]
41ffb79828
Merge pull request #16250 from resilient-tech/typo-database-py
...
fix: typo in database file for v12 - latest
2022-03-11 08:27:43 +00:00
lapardnemihk1099
f4d3effaf2
fix: typo in database file for v12 - latest
2022-03-11 13:29:01 +05:30
mergify[bot]
878f06dbb8
Merge pull request #16053 from bhavesh95863/patch-1
...
fix: ignore link validation for sort workspace
2022-03-11 05:55:05 +00:00
Shariq Ansari
f5f0176853
Merge branch 'develop' into patch-1
2022-03-10 17:52:13 +05:30
Shariq Ansari
e2a56ee39b
test: Added UI test
2022-03-10 16:46:39 +05:30
Shariq Ansari
3b57e3914b
Merge branch 'develop' into number-card-filter-fix
2022-03-10 16:20:07 +05:30
Shariq Ansari
2c0735d709
fix: Number Card to support child table doctype for filters
2022-03-10 15:58:05 +05:30
Saqib Ansari
82f20b76f7
feat: show link titles in web form link fields
2022-03-10 13:11:05 +05:30
mergify[bot]
9bd1333538
Merge pull request #16188 from resilient-tech/hyphen-dobara
...
feat: allow hyphens in DocType name (again)
2022-03-10 07:09:49 +00:00
Pruthvi Patel
b1d55680a3
fix: Consider title field only if it's value exists ( #16236 )
...
* fix: consider title field only if it's value exists
* chore: make `title` bold
2022-03-10 12:28:23 +05:30
mergify[bot]
a465018088
Merge pull request #16217 from shariquerik/failing-ui-test-fix
...
test: failing report_view UI test fix
2022-03-10 06:55:33 +00:00
mergify[bot]
302f4645e0
Merge pull request #16234 from anandology/show-traceback-as-string
...
fix: show traceback as string instead of bytes
2022-03-10 05:01:35 +00:00
Anand Chitipothu
f811927895
fix: show traceback as string instead of bytes
...
Issue: #16233
2022-03-10 10:15:27 +05:30
Sagar Vora
a6d991272e
fix: sider warning
2022-03-10 09:38:32 +05:30
Sagar Vora
5d93907a19
fix: improve modify_query regex
2022-03-10 09:28:13 +05:30
Kaustubh Maske Patil
4a42488b6d
fix: Use parent_doctype=... syntax while fetching users with a particular role
2022-03-09 21:52:08 +05:30
Sagar Vora
9cd25d72d5
fix: clear filters before setting them ( #16077 )
...
* fix: clear filters before setting them
* fix: dont set dirty state for reports without JSON
* fix: cleaner alternative to clearing filters
* fix: move condition outside loop
* fix: reorder if-else block to avoid hitting else block inadvertently
2022-03-09 18:50:18 +05:30
Ankush Menat
28e57d9d3d
Merge pull request #16222 from ankush/attach_limit
...
fix(ux): remove attachment limits
2022-03-09 14:00:56 +05:30
gavin
7698ac69f3
Merge pull request #16178 from gavindsouza/email-signature-fix
...
fix: Double signature in composed Email
2022-03-09 13:38:38 +05:30