Ejaaz Khan
b0442dc98e
fix: width issue when column are less
2024-11-21 23:10:14 +05:30
Ejaaz Khan
839465a6e1
feat: make child table scrollable
2024-11-21 19:07:39 +05:30
Abdeali Chharchhodawala
5fea212305
fix: Remove typo from get_doc docstring of FrappeClient ( #28515 )
2024-11-20 04:27:13 +00:00
David Arnold
3c1392c8fd
fix: meta signature ( #28526 )
...
* fix: meta
* fix: test case
save is required:
1. Fetch values
```python
def get_invalid_links(self, is_submittable=False):
"""Return list of invalid links and also update fetch values if not set."""
...
```
2. Is triggered by
```python
def _validate_links(self):
if self.flags.ignore_links or self._action == "cancel":
return
...
```
3. Which is triggered by either `_save` or `insert`
----
`reload` does not trigger link fetch
```python
def reload(self) -> "Self":
"""Reload document from database"""
return self.load_from_db()
```
Neither does the new calling path which does not excempt Document
from caching when initializing meta.
It can be proven that this revert would be an alternative fix. But this
seems design by accident and there's no preceivable reason to excempt
Document args from being cached normally.
diff --git a/frappe/model/meta.py b/frappe/model/meta.py
index c4321f0128..87452c812c 100644
--- a/frappe/model/meta.py
+++ b/frappe/model/meta.py
@@ -70,11 +70,10 @@ def get_meta(doctype: str | dict | DocRef, cached=True) -> "_Meta":
Returns:
Meta object for the given doctype.
"""
- if cached and (
- doctype_name := getattr(doctype, "doctype", doctype)
- if not isinstance(doctype, dict)
- else doctype.get("doctype")
- ):
+ if cached and not isinstance(doctype, Document):
+ doctype_name = (
+ getattr(doctype, "doctype", doctype) if not isinstance(doctype, dict) else doctype.get("doctype")
+ )
if meta := frappe.cache.hget("doctype_meta", doctype_name):
return meta
Therefore, we comply the test.
2024-11-20 04:17:38 +00:00
David Arnold
15d122025f
feat: get_meta can derive meta from dict ( #28525 )
2024-11-20 01:36:04 +00:00
David Arnold
f6780a81a7
feat: more fine grained deprecation policies ( #28453 )
...
* feat: more fine grained deprecation policies
* feat: ignore pending warnings by default; they are still far in the future
2024-11-20 01:21:22 +01:00
David Arnold
0727c0de0d
feat: allow to store form tours in custom module ( #28496 )
2024-11-20 00:48:45 +01:00
David Arnold
1613d0abe4
feat: enable dynamic, custom list filter options ( #28497 )
2024-11-20 00:48:17 +01:00
David Arnold
2f559e0fa9
chore: make the type clear ( #28524 )
2024-11-19 22:40:26 +00:00
David Arnold
1467a7f896
ci: polish reusable workflows ( #28521 )
2024-11-19 21:50:32 +00:00
Raffael Meyer
64b2010d21
refactor: readability of translation tests ( #28519 )
2024-11-19 19:05:05 +00:00
Frappe PR Bot
8c8bea7a36
fix: sync translations from crowdin ( #28441 )
...
Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
2024-11-19 19:22:20 +01:00
Sumit Bhanushali
8fb0614f28
Merge pull request #28517 from frappe/mergify/bp/develop/pr-27682
...
fix: total_fields not showing real value (backport #27682 )
2024-11-19 19:27:31 +05:30
Sumit Bhanushali
b7deeb0c1b
fix: default length to available fields when undefined
...
(cherry picked from commit 20c087a93427b64850885b5296dbd00292bfbe43)
2024-11-19 13:44:16 +00:00
Sumit Bhanushali
3831e2f5da
chore: format js
...
(cherry picked from commit 4276ee7317baa5fbf6ad791f8925c3cfd59ff305)
2024-11-19 13:44:16 +00:00
Yamir Haidar
80792067af
fix: total_fields not showing real value
...
(cherry picked from commit 93b3df001ef608a4bcfcf284d077a08408d0b4cf)
2024-11-19 13:44:16 +00:00
David Arnold
4f6e2fbe93
fix: boilerplate test case ( #28514 )
2024-11-19 11:29:34 +00:00
Akhil Narang
d9a1bd5d3d
Merge pull request #28505 from frappe/dependabot/github_actions/codecov/codecov-action-5
...
chore(deps): bump codecov/codecov-action from 4 to 5
2024-11-19 16:01:36 +05:30
Akhil Narang
455edcb7d3
Merge pull request #28478 from akhilnarang/clarify-naming-series-options
...
chore(document_naming_settings): clarify that FY and ABBR require ERPNext being installed
2024-11-19 15:58:01 +05:30
Akhil Narang
605a11a4a1
Merge pull request #28498 from akhilnarang/fix-user-query
...
refactor(user_query): switch to `frappe.get_list()`
2024-11-19 15:56:54 +05:30
Shariq Ansari
16b56ee895
Merge pull request #28459 from shariquerik/billing
...
feat: Billing Page
2024-11-19 11:30:57 +05:30
Shariq Ansari
a1214143b4
chore: updated README
2024-11-19 11:04:09 +05:30
dependabot[bot]
2d7b636c83
chore(deps): bump codecov/codecov-action from 4 to 5
...
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action ) from 4 to 5.
- [Release notes](https://github.com/codecov/codecov-action/releases )
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md )
- [Commits](https://github.com/codecov/codecov-action/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: codecov/codecov-action
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-11-18 18:35:00 +00:00
David Arnold
6f35a554a5
fix: make read only mode thread safe ( #28359 )
...
* fix: Apply read_only_method decorator to Document methods
* fix: update tests for read-only document context manager
* refactor: place mappers into read-only mode
Reapply "refactor: place mappers into read-only mode"
This reverts commit a8208d57069c63f0982bf2881bcad28a4b349f3c.
read-only mode is now thread safe
2024-11-18 15:00:50 +01:00
David Arnold
223640d8a7
feat: render debug timer ( #28501 )
2024-11-18 12:59:23 +00:00
Shariq Ansari
06fed8008c
fix: added some more links in user dropdown
2024-11-18 16:06:15 +05:30
Shariq Ansari
4755b35c91
fix: added support link in sidebar
2024-11-18 16:02:44 +05:30
Shariq Ansari
c161864dd4
refactor: moved currentSiteInfo to App.vue and provide it globally
2024-11-18 16:02:30 +05:30
Shariq Ansari
67decb2323
style: changed upgrade button color
2024-11-18 16:00:26 +05:30
Akhil Narang
b3acb7857b
refactor(user_query): switch to frappe.get_list()
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-11-18 13:04:15 +05:30
Shariq Ansari
14cca922b8
fix: empty state for card listview
2024-11-18 12:44:18 +05:30
Frappe PR Bot
e8808cec17
chore: update POT file ( #28489 )
2024-11-17 16:08:20 +01:00
David Arnold
7065489759
fix: jinja template html errors ( #28490 )
2024-11-17 10:35:09 +00:00
Raffael Meyer
585dae2053
fix: don't try to rename a doctype that doesn't exist ( #28487 )
...
When migrating a database that doesn't contain a table for "Marketing Campaign" yet (because it was added in a later, in-between version), this patch used to fail. Now we attempt to rename the doctype only if it exists.
The patch was introduced in https://github.com/frappe/frappe/pull/27801
2024-11-16 18:27:05 +01:00
Shariq Ansari
b98edf8504
fix: show all apps in apps dropdown
2024-11-16 20:28:27 +05:30
Shariq Ansari
a23307865a
chore: linter fix
2024-11-16 16:49:08 +05:30
Shariq Ansari
5f96b801e2
chore: minor layout fixes
2024-11-16 16:38:54 +05:30
Shariq Ansari
23883096cf
fix: changed upgrade button variant to outline in desk trial banner
2024-11-16 16:13:25 +05:30
Shariq Ansari
9125f173f5
fix: added pay now button in invoices listview
2024-11-16 15:56:08 +05:30
Shariq Ansari
b505cfc97c
fix: pay now will redirect to invoices page if there are multiple unpaid invoices
2024-11-16 15:49:57 +05:30
Shariq Ansari
8fcee6280e
fix: pay now action if payment mode is card
2024-11-16 14:16:34 +05:30
Shariq Ansari
f317e68fc2
fix: added header in each page
2024-11-16 13:44:31 +05:30
Shariq Ansari
85d44755bc
fix: consistent spacing
2024-11-16 13:15:04 +05:30
Shariq Ansari
eece201ea9
fix: changed Billing page name to Overview
2024-11-16 13:11:58 +05:30
Shariq Ansari
78870ba10b
fix: added user dropdown and made sidebar static
2024-11-16 13:07:48 +05:30
s-aga-r
c3a6f750bb
refactor(FrappeMail): merge newsletter and transactional email into a single endpoint ( #28480 )
2024-11-16 04:57:33 +00:00
Shariq Ansari
b77810322d
fix: added billing.py to handle csrf token issue
2024-11-15 20:47:13 +05:30
David Arnold
67f2b056b4
feat: add hook to allow downstream apps to add auto-loading instrumentation for their doctypes ( #28479 )
2024-11-15 13:04:20 +00:00
Shariq Ansari
eb55ff194a
fix: removed TrialBanner component and used css variables instead of hard coded values
2024-11-15 18:24:52 +05:30
Akhil Narang
c06f528037
chore(document_naming_settings): clarify that FY and ABBR require ERPNext being installed
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-11-15 18:04:49 +05:30
