Commit graph

45213 commits

Author SHA1 Message Date
bhavesh95863
b4b4d8f22f fix: hide number counter for new document view shortcut
(cherry picked from commit bb46d23772cfa9ad2e23a24325b16ed17fdfee6c)
2024-02-05 05:57:21 +00:00
bhavesh95863
dc6d71e84b fix: no of rows displayed based on report type
(cherry picked from commit db4d36f527ace8f4a678ebe39daceaa9f9579a73)
2024-02-05 05:57:20 +00:00
Ankush Menat
12bbfd24e6
fix: Show proper error message for prepared report failure (#24733) 2024-02-05 05:49:23 +00:00
Nihantra C. Patel
1783cf7bb9
fix: title link check (#24731)
* fix: listview filter

* chore: use vanilla js

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-02-05 11:16:28 +05:30
Ankush Menat
c02f5d5876
fix: Skip fulltext indexes during sync (#24728)
These are not managed by framework's migration system so we shouldn't
delete them.
2024-02-05 05:30:44 +00:00
mergify[bot]
77b248b180
Merge pull request #24726 from barredterra/respect-null
fix: respect `null` when formatting number values
2024-02-05 05:28:14 +00:00
Raffael Meyer
6c8a08d955
refactor: skip permlevel check if all levels are 0 (#24727)
* refactor: skip permlevel check if all levels are 0

* chore: fix outdated docstring

* chore: equality instead of le
2024-02-05 05:19:09 +00:00
Raffael Meyer
78f20040a5
Merge pull request #24615 from barredterra/widget-translatability 2024-02-04 22:28:54 +01:00
barredterra
a0234355e5 Merge remote-tracking branch 'upstream/develop' into widget-translatability 2024-02-04 22:26:27 +01:00
barredterra
8f44392ea3 fix(widget dialog): translatability 2024-02-04 22:25:51 +01:00
Raffael Meyer
860fe01e18
Merge pull request #24386 from barredterra/google-drive-folders 2024-02-04 22:14:30 +01:00
barredterra
82c68048e0 Merge remote-tracking branch 'upstream/develop' into google-drive-folders 2024-02-04 22:12:39 +01:00
barredterra
8b0c20246c fix: respect null as number value
Null is the intentional absence of a value. It represents a variable that has been explicitly set to have no value.
2024-02-04 18:23:24 +01:00
Shariq Ansari
ea6dbcf217
Merge pull request #24718 from shariquerik/data-import-fix
fix: data import table UI fix
2024-02-03 17:15:43 +05:30
Shariq Ansari
9f08b27991
Merge pull request #24716 from shariquerik/form-builder-fixes-4
fix: redirect and open new doctype dialog if route to /doctype/new
2024-02-03 14:34:42 +05:30
Shariq Ansari
cfd5b91b6e fix: data import table UI fix 2024-02-03 14:32:55 +05:30
Ankush Menat
25692a3c81
fix: Set default for search result limit if empty (#24713) 2024-02-03 07:18:47 +00:00
Indrajith.vs
0314502742
fix(Custom Field): Button Rename Fieldname visible before saving (#24712) 2024-02-03 12:40:50 +05:30
Shariq Ansari
f98af2e67a fix: redirect and open new doctype dialog if route to /doctype/new 2024-02-03 12:35:09 +05:30
mergify[bot]
21d7cbca41
Merge pull request #24570 from Govind-Jangid/feat/auto-email-report-get-first-day
feat: use_first_day_of_period
2024-02-03 06:17:59 +00:00
Govind Jangid
492584db93 fix: date format & pre commit test 2024-02-03 06:36:19 +05:30
Akhil Narang
68238a05da
Merge pull request #24710 from akhilnarang/fix-bench-run-tests
fix(run-tests): don't try to access `frappe.flags` before `frappe.init()`
2024-02-02 22:44:30 +05:30
Akhil Narang
60c1812cc2
fix(run-tests): don't try to access frappe.flags before frappe.init()
Broke in #24432

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-02 22:26:01 +05:30
Ankush Menat
e35d774eda
Merge pull request #24708 from ankush/pw
fix: filter autocomplete doctypes
2024-02-02 19:14:51 +05:30
Ankush Menat
7580125bae fix: Filter auto repeat doctypes 2024-02-02 18:57:47 +05:30
Ankush Menat
7487df22c9 refactor: use frappe.get_system_settings
because it's cached and doesn't hit frappe.db at all.
2024-02-02 18:43:43 +05:30
Ankush Menat
6341ef3ac7
fix: kanban hide "add column" for std fields (#24707)
* fix: build events

* fix(kanban): Don't show custom column option on standard fields
2024-02-02 18:31:03 +05:30
Ankush Menat
dd839e4d50
fix: lower default retention periods (#24697)
These can still be configured to different number. We are just changing
defaults. Why?

- Scheduled job log - errors get logged in error log anyway. Success log
  isn't that useful of 90 days?
- Prepared report - most reports are expired in a day or max a week.
  Rarely last month's report makes any sense today.
2024-02-02 17:33:58 +05:30
Akhil Narang
f19c25ec42
Merge pull request #24432 from blaggacao/chore/cleanup-frappe-connect-2
chore: cleanup frappe connect II/II
2024-02-02 16:53:19 +05:30
Corentin Flr
11baf6e03c
fix(login): Escape translated strings (#24431)
* Use `tojson` instead of `json` Jinja filter
2024-02-02 15:33:55 +05:30
Ankush Menat
380b33d49e
fix: Dashboard view realtime error (#24698)
filter_area doesn't exist on DashboardView, so this inherited function
breaks down.
2024-02-02 09:38:16 +00:00
Ankush Menat
d26c67df75
fix: virtual fields are never writable (#24693) 2024-02-02 13:37:46 +05:30
Akhil Narang
81d8a0b8b9
Merge pull request #24659 from jll-02/patch-7
chore(deps): removes unused cariocffi dependency
2024-02-02 12:37:01 +05:30
David Arnold
c09f48f5d7
feat: comply trackers with utm and add utm_content for a/b testing (#24521)
* feat: comply trackers with utm and add utm_content for a/b testing

* fix: make all other than source optional

this is plausible.io best practice

* fix: medium is not specified to be lowercase

* fix: ensure proper parameter quoting
2024-02-02 11:33:22 +05:30
Ankush Menat
c479a038a8
fix: Avoid enqueueing during install (#24679)
This isn't strictly required but if bench isn't running this can break
installation.
2024-02-01 14:12:54 +00:00
Ankush Menat
aad0c19f3a
fix: lazy translate circular imports (#24672)
* Revert "fix: remove _lt from frappe.model.std_fields (#24662)"

This reverts commit 833d108614.

* fix: circular import
2024-02-01 12:27:25 +00:00
Maharshi Patel
3fb418f28f
Merge pull request #23907 from marination/dynamic-header-footer-develop
feat: Letterhead Scripts & fix disappearing header in pdf
2024-02-01 17:43:12 +05:30
Raffael Meyer
4d63a12ab6
fix(Data Import): scheduler not needed in dev mode (#24667) 2024-02-01 17:11:41 +05:30
Rucha Mahabal
aed3586095
fix: enable syntax highlighting for PythonExpression code fields (#24669) 2024-02-01 17:10:21 +05:30
Ankush Menat
4553de8ba0
fix: never show virtual fields in list view (#24666)
* fix: never render virtual fields in list view

* fix: Hide "in list view" for virtual columns
2024-02-01 16:22:07 +05:30
Raffael Meyer
855202d20a
Merge pull request #24614 from barredterra/data-import-transatability 2024-02-01 11:37:41 +01:00
Raffael Meyer
833d108614
fix: remove _lt from frappe.model.std_fields (#24662) 2024-02-01 16:05:25 +05:30
Raffael Meyer
2de2b59f00
Merge pull request #24663 from barredterra/translate-data-export 2024-02-01 11:10:30 +01:00
barredterra
281c1de639 fix(Data Export): translate multiselect 2024-02-01 10:51:57 +01:00
Raffael Meyer
b5f3873177
Merge pull request #24465 from barredterra/extract-js-microtemplate 2024-02-01 10:32:42 +01:00
Akhil Narang
ea65d86d72
Merge pull request #24625 from blaggacao/fix/shell-escaping
fix: shell escaping on external commands
2024-02-01 12:45:21 +05:30
jll-02
12a246d697
chore(deps): removes unused cariocffi dependency 2024-02-01 08:15:00 +01:00
Ankush Menat
bedf5ba65e
Merge pull request #24656 from ankush/retry_contact
fix: outgoing email account handlng
2024-02-01 11:52:07 +05:30
Ankush Menat
dae99eb53c fix: Fetch SMTP server inside context
Currently if smtp server creation fails email queue is endlessly
retried. It should just fail if there's no outgoing account.
2024-02-01 11:10:57 +05:30
Ankush Menat
78665d98b2 fix: Bail if no SMTP acccount can be found
Currently we give this weird error instead of just saying no outgoing email account is configured.

```
AttributeError: 'NoneType' object has no attribute 'get_smtp_server'
  File "frappe/email/queue.py", line 154, in flush
    email_queue.send()
  File "frappe/email/doctype/email_queue/email_queue.py", line 160, in send
    with SendMailContext(self, smtp_server_instance) as ctx:
  File "frappe/email/doctype/email_queue/email_queue.py", line 236, in __init__
    self.smtp_server: SMTPServer = smtp_server_instance or self.email_account_doc.get_smtp_server()
```
2024-02-01 11:10:57 +05:30