Commit graph

49100 commits

Author SHA1 Message Date
Ankush Menat
ba84768ba8
perf: Use cached redirects (#31698) 2025-03-13 13:50:26 +05:30
Ejaaz Khan
91430efdbb
Merge pull request #31693 from iamejaaz/query-report-translate
fix: report header not translated
2025-03-13 11:37:28 +05:30
Akhil Narang
c77dc8ab5a
Merge pull request #31692 from kalungia/sms
fix: increase length for value field in sms parameter
2025-03-13 11:18:18 +05:30
Ejaaz Khan
f462029178 fix: report header not translated 2025-03-13 11:05:09 +05:30
Ankush Menat
357b6fb11a
perf: don't parse comments just to get comment count (#28921)
This parsing isn't necessary and we are copying all of _comments just to count
how many there are.

Imagine 2500 documents w/ 1-2 auto generated comments each.
2025-03-13 05:00:21 +00:00
Abraham Kalungi
adc54286d9 fix: increase length for value field in sms parameter 2025-03-12 19:45:13 +02:00
Soham Kulkarni
2fb2f7598e
Merge pull request #31691 from sokumon/better-sidebar
fix: small fixes to the sidebar
2025-03-12 22:40:03 +05:30
sokumon
aaf5dd8ca2 fix(minor): move drop icon for better alignment 2025-03-12 22:12:40 +05:30
Sagar Vora
caaf9b09f7
Merge pull request #31690 from sagarvora/more-methods
perf: override more `werkzeug.local` methods
2025-03-12 22:07:26 +05:30
sokumon
f5eab0a179 fix: clear selected app after app is selcted 2025-03-12 22:05:21 +05:30
Sagar Vora
00c12cb029 perf: override more werkzeug.local methods 2025-03-12 21:28:23 +05:30
Sagar Vora
8147f04fb5
Merge pull request #31688 from frappe/revert-31664-faster-_dict-getattr
Revert "perf!: faster frappedict getattr"
2025-03-12 18:35:52 +05:30
Sagar Vora
29c318964b
Revert "perf!: faster frappedict getattr" 2025-03-12 18:35:33 +05:30
Sagar Vora
768202a2d2
Merge pull request #31687 from frappe/revert-31666-add-slots
Revert "fix: add `__slots__` to NamespaceDict"
2025-03-12 18:35:10 +05:30
Sagar Vora
5be83f7df8
Revert "fix: add __slots__ to NamespaceDict" 2025-03-12 18:34:17 +05:30
Ankush Menat
70f9524787
fix(UX): Explain why some doctypes automatically have a filter (#31682) 2025-03-12 12:27:54 +00:00
Tarun Pratap Singh
87d568558a
Merge pull request #31681 from tarunps/fix/conditionally-render-add-total-rows
fix(report): show add_total_row checkbox if report_type is not 'Repor…
2025-03-12 17:40:02 +05:30
Tarun Pratap Singh
41b331d856 fix(report): show add_total_row checkbox if report_type is not 'Report Builder' 2025-03-12 17:10:44 +05:30
Ankush Menat
a2401e735a
fix: option to opt out of automatic filters (#31678) 2025-03-12 11:35:45 +00:00
Ankush Menat
394a5ff9ff
fix: Round of rate limit to seconds (#31674) 2025-03-12 10:52:42 +00:00
Soham Kulkarni
67424caada
Merge pull request #31661 from Abdeali099/fix-sidebar-this-context
fix: handle AppSwitcher `this` context
2025-03-12 15:53:24 +05:30
Akhil Narang
48d3a86144
revert: "fix(UX): Show reason for read only form in headline (#31511)" 2025-03-12 09:27:19 +00:00
Sagar Vora
cc023453e8
Merge pull request #31666 from sagarvora/add-slots
fix: add `__slots__` to NamespaceDict
2025-03-12 14:15:24 +05:30
Sagar Vora
ad33435b33
Merge pull request #31660 from sagarvora/frappelocal
perf: faster local attr lookup
2025-03-12 14:13:46 +05:30
Sagar Vora
26bbb5985e
perf: use client_cache for print_sql (#31663)
* perf: use `client_cache` for `print_sql`

* chore: revert change to conn error handling code

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2025-03-12 08:43:09 +00:00
Sagar Vora
a5dd24ebe9 fix: add __slots__ to NamespaceDict 2025-03-12 14:05:27 +05:30
Sagar Vora
3c8912f6e7 perf: faster local attr lookup 2025-03-12 14:03:36 +05:30
Sagar Vora
45b375ae2c
Merge pull request #31664 from sagarvora/faster-_dict-getattr
perf!: faster frappedict getattr
2025-03-12 13:49:05 +05:30
Sagar Vora
c592f323ff fix: restore dict.__getattribute__ for NamespaceDict 2025-03-12 13:28:12 +05:30
Sagar Vora
20220ef894
fix: avoid one time setup (#31650) 2025-03-12 12:44:19 +05:30
Sagar Vora
04eee35b40 perf: faster frappedict getattr 2025-03-12 12:43:01 +05:30
Abdeali Chharchhoda
a8409e607e fix: handle AppSwitcher this context 2025-03-12 10:15:44 +05:30
Raffael Meyer
2b9aa25520
ci: ignore "skip-release-notes" when generating release notes (#31656) 2025-03-11 16:22:33 +00:00
Raffael Meyer
ddbb987831
Merge pull request #31654 from barredterra/auto-add-label
ci: add label based on PR title
2025-03-11 16:46:52 +01:00
Ejaaz Khan
8e74155534
Merge pull request #31645 from iamejaaz/32254-auto-email-bg
perf: generate auto email reports in background
2025-03-11 19:58:51 +05:30
Ejaaz Khan
dbec126b5e refactor: change queue from default to long 2025-03-11 19:48:59 +05:30
Raffael Meyer
538bad98f6
Merge pull request #31639 from sattamjh/sattamjh-patch-1
fix: prioritize English language selection for Guest user with additional browser language settings
2025-03-11 13:11:14 +01:00
Ejaaz Khan
7d120575db refactor: remove unused import 2025-03-11 15:44:30 +05:30
Ejaaz Khan
d1cc0ee951 perf: generate auto email reports in background 2025-03-11 15:42:00 +05:30
Soham Kulkarni
eb335b9046
Merge pull request #31640 from sokumon/translate-report-data
feat: make translate report data configurable
2025-03-11 14:33:31 +05:30
sokumon
e46ebf4e02 feat: make translate report data configurable 2025-03-11 10:55:01 +05:30
Sattam
a88f2a8fc5
fix: prioritize English language selection for Guest user despite additional browser language settings
Description:
- Resolved an issue where the system incorrectly activated a non-English language for Guest users, even when English was the primary language in the browser settings.
- The bug occurred when additional languages (e.g., Arabic) were configured in the browser and one of those languages was already enabled in Frappe.
- Ensured that English is prioritized as the default language for Guest users when it is present in the browser language list, regardless of other enabled languages.
- Added a fix to explicitly enable English language for Guest users to prevent unintended language switching.

Steps to Reproduce:
- Create a new clean site and add additional languages (e.g., Arabic) in the browser settings.
- Ensure the additional language (e.g., Arabic) is already enabled in the database, which is by default.
- Observe that the system switches to the non-English translation (e.g., Arabic) for Guest users, even if English is the primary language in the browser settings.

Root Cause Analysis:
- Initially suspected `translate.py` was involved in language resolution.
- Checked enabled languages at the console using:
  `frappe.get_all("Language", filters={"enabled": 1}, pluck="name")`
  Result: ['fr', 'fa', 'es', 'de', 'ar']
- Identified that English was not enabled in the system, despite being a default requirement.
- Traced the issue to `languages.csv`, where English was not included among the enabled languages.

Fix:
- Enabled English in `languages.csv` to ensure it is included among the supported languages.
- This ensures English is chosen when included in the browser settings, resolving the issue.
2025-03-11 04:02:40 +03:00
Raffael Meyer
215ebfbd24
Merge pull request #31637 from barredterra/crowdin-file-naming
chore: fix file naming for Crowdin integration
2025-03-11 01:53:44 +01:00
barredterra
885390c1cf chore: fix file naming for Crowdin integration 2025-03-11 01:34:01 +01:00
Ejaaz Khan
721af96f04
Merge pull request #31630 from iamejaaz/31611-link-field-export
fix: custom column export issue in report
2025-03-10 21:35:01 +05:30
Ankush Menat
14006b2c25
refactor: trim __init__.py (#31575)
* refactor: move init.py utils to utils/*

* refactor: split messages.py from init.py
2025-03-10 21:12:19 +05:30
Ankush Menat
6946e3353f refactor: split messages.py from init.py 2025-03-10 21:02:13 +05:30
Ankush Menat
ae4e2ede1a refactor: move init.py utils to utils/* 2025-03-10 21:01:14 +05:30
Ejaaz Khan
ea90228748 fix: custom column export issue in report 2025-03-10 20:46:55 +05:30
Ankush Menat
8d15d28463
fix: check permission on new doc (#31626)
User might only have "only if creator" permission so checking on doctype
will incorrectly flag it.

Not sure if there's any better/simpler way to handle this. This is weird
edge case on how files operate.
2025-03-10 13:30:13 +00:00