Commit graph

3846 commits

Author SHA1 Message Date
Trusted Computer
d870caf6c4
fix: there is no attribute for closed, just handle the exception as the docs suggest (ported from frappe/print_designer #496) (#35098) 2025-12-06 05:05:32 +05:30
Aarol D'Souza
cf69e4bed1
fix(postgres): misc query building fixes + CI (#34831)
* fix(query): check standard field definitions

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* fix(postgres): fix order_by problem in pg

* fix(postgres): fix order_by in get_all for _test_connection_query

* fix: add check to a proper numeric fallback in _get_ifnull_fallback

* test(postgres): fix pg query used in assertion in test_permission_query

* fix(postgres): fix order_by in get_all for possible_link

* fix(postgres): fix order_by in get_all for set_modules

* fix(postgres): fix pg query count *

* fix(postgres): fix order_by in get_all for ask_pass_update

* fix(postgres): fix order_by statement in search_widget

* fix(postgres): fix order_by in get_list for get_stats

* test(postgres): normalize_sql for pg queries in test_arithmetic_operators_in_fields

* test(postgres): normalize_sql for pg queries in test_field_alias_in_group_by

* test(postgres): normalize_sql for pg queries in test_field_alias_permission_check

* test(postgres): fix order_by statement in get_all for test_db_keywords_as_fields

* test(postgres): fix order_by statement in get_all for test_prepare_select_args

* fix(treeview): use 0 instead of false to check since check field is an integer

* fix(postgres): fix order_by in get_all for sync_communication

* fix(postgres): fix order_by in get_all for get_references_across_doctypes_by_dynamic_link_field

* test(postgres): fix order_by in get_all for test_list_summary

* fix(postgres): fix order_by in get_all for email queries

* test(postgres): use order_by none and update assertion for postgres

* fix(postgres): use ILIKE to support case insensitive search in postgres

* test(test_query): update pg specific query assert to use ILIKE

* test(test_query): update test_nested_filters to use ilike instead for PG

* test(postgres): update pg query in assert to test updated qb query

* fix(search): update query to be db-agnostic

* test(postgres): normalize query for pg in test_build_match_conditions

* fix(postgres): suppress ORDER BY when SELECT DISTINCT in query for postgres specific behavior

* fix(postgres): suppress ORDER BY when GROUP BY is explicitly asked for pg specific behavior

* test(postgres): fix test behavior for pg ORDER BY drop when used with GROUP BY

* refactor: reducing noise in code by formatting code

* fix(query): use Star() to handle SQL wildcard character * correctly

* fix(postgres): display warning for ORDER BY fields that will be dropped

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2025-12-05 10:30:49 +05:30
sokumon
34b221d097 fix: delete sidebars when app is deleted 2025-12-02 13:50:29 +05:30
Akhil Narang
e5b340fad4
feat(error_log): add in some request/job metadata (#34937)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-28 15:29:30 +05:30
ALB.Leach
029b1fd3c6
feat: allow tel: protocol hyperlinks (#34699) 2025-11-21 06:05:59 +00:00
Akhil Narang
0ea49a8f1e
fix: make sure limit is an integer
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Soham Kulkarni
518e94ea98
Merge pull request #34769 from sokumon/desktop-fixes
fix: delete desktop icons when app is uninstalled
2025-11-19 16:45:36 +05:30
sokumon
7c93730cfc fix: semgrep issues 2025-11-19 13:21:52 +05:30
sokumon
a0edd3e3f2 fix: delete desktop icons when app is uninstalled 2025-11-19 12:30:15 +05:30
Akhil Narang
1e2d730202
Merge pull request #34670 from trustedcomputer/cogkfix-host-url-when-printing-outside-request
fix: Get host URL when printing outside of request
2025-11-18 17:39:32 +05:30
Saqib Ansari
d4a0181379
Merge pull request #33905 from nextchamp-saqib/custom-perm-types
feat: custom permission types
2025-11-17 16:00:17 +05:30
sokumon
a0caf8e320 refactor: add auto-creation of icons 2025-11-14 23:05:14 +05:30
Akhil Narang
edc4b4bbd5
fix: set multiprocessing start mode to fork instead of forkserver
worker-pool with fork workers seem to not pick up jobs otherwise - the test `test_multi_queue_burst_consumption_worker_pool` just times out.

https://docs.python.org/3/whatsnew/3.14.html#concurrent-futures

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-14 18:36:34 +05:30
Corentin Forler
cb8ac9b14f
fix: Get host URL when printing outside of request
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-14 12:52:29 +05:30
Ankush Menat
f7e594a618 fix: Update value if conflicting 2025-11-14 10:54:38 +05:30
Ankush Menat
e8961aee80 fix: Dont fail silently in tests 2025-11-14 10:52:47 +05:30
Raffael Meyer
0df57b6133
feat(translations): add hook to exclude translatable strings from dependencies (#34544) 2025-11-10 12:50:21 +01:00
Ejaaz Khan
27ce9a3df4
Merge pull request #34624 from khushi8112/get-link-to-report-between-condition
fix: handle between condition properly in get_link_to_report filters
2025-11-06 17:29:02 +05:30
Saqib Ansari
52b88e9518 feat: add test cases 2025-11-06 15:17:45 +05:30
khushi8112
d7106649ee fix: handle between condition properly in get_link_to_report filters 2025-11-06 00:12:01 +05:30
Saqib Ansari
8de26fe3e8 feat: admin can search non-searchable doctypes 2025-11-03 17:49:30 +05:30
Akhil Narang
6dfcc2bf4c
Merge pull request #34027 from sumitbhanushali/expand-link
feat: add support of expand in rest api v1/document_list
2025-10-28 17:02:14 +05:30
Akhil Narang
21fde3a507
Merge pull request #34474 from AMR-Mannesmann/fix(utils)--format_duration-for-negative-values
fix(utils)!: format_duration for negative values
2025-10-28 15:51:10 +05:30
Abdeali Chharchhodawala
fed7b3bb69
feat: utility to generate filtered list URLs and links for doctype (#34503) 2025-10-28 07:33:16 +00:00
Sumit Bhanushali
6f0242db6a chore: added docstring for attach_expanded_links 2025-10-27 15:21:41 +05:30
Sumit Bhanushali
8955f079a1 fix: use get_list to only fetch permitted records 2025-10-27 13:27:13 +05:30
Sumit Bhanushali
f5fed5b4be perf: optimize expand link for table fields 2025-10-27 13:00:43 +05:30
daniel.radl
45a0471f5c fix(utils): added format_duration test 2025-10-25 17:16:15 +00:00
daniel.radl
4908b926c0 fix(utils): format_duration for negative values 2025-10-22 12:38:22 +00:00
Ankush Menat
727775f820
Merge pull request #33088 from ankush/computed_child_table
feat: Computed/virtual child-tables
2025-10-15 18:32:16 +05:30
Ejaaz Khan
a4ba3c1940
Merge pull request #34191 from iamejaaz/chrome-pdf
feat: Chrome PDF generator
2025-10-14 17:31:49 +05:30
Sagar Vora
a93530e221 Merge branch 'develop' into computed_child_table 2025-10-14 12:53:32 +05:30
Sagar Vora
a084f5a2f3 refactor: separate only computed CTs, with new include_computed flag 2025-10-14 12:31:47 +05:30
Akhil Narang
1e5aaac000
fix(oauth): drop keycloak check (#34330)
Not needed anymore

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-10-09 12:10:21 +00:00
Chris Hemmings
fbf07ddf6e
fix: OAuth2 absolute authorize, access token and api urls (#34266)
* fix: OAuth2 absolute authorize, access token and api urls

* fix: add back keycloak check, just use the function instead

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2025-10-09 16:47:38 +05:30
Ejaaz Khan
f74671267d Merge branch 'develop' into chrome-pdf 2025-10-08 15:43:38 +05:30
Ejaaz Khan
4f365bfbf5 refactor: add backwards compatibility styles
Co-authored-by: Maharshiv Patel <maharshivpatel@users.noreply.github.com>
2025-10-07 16:33:59 +05:30
Akhil Narang
835fcbd849
chore: use our copy of protected_inplacevar
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-10-03 00:13:55 +05:30
Akhil Narang
bd60a0a156
chore(inplacevar): lint
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-10-03 00:13:55 +05:30
Hanno Schlichting
c02a3bf5ce
feat: add protected_inplacevar function extracted from AccessControl
Extracted from 17a5ceb0ae/src/AccessControl/ZopeGuards.py
2025-10-03 00:13:51 +05:30
Sagar Vora
2c9c6c0fd5 fix: correct table_fields references 2025-10-01 12:25:00 +05:30
Akhil Narang
e13ccc1226
fix: drop duplicate translator role
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-09-30 19:14:22 +05:30
Ejaaz Khan
5f99434f52 fix: import function/module inside inside fucntion 2025-09-29 23:09:25 +05:30
Ejaaz Khan
510669b64c fix: remove unwanted top padding 2025-09-29 12:19:59 +05:30
Ejaaz Khan
d834727728 fix: add _ in unused variable 2025-09-29 12:16:53 +05:30
Ejaaz Khan
964dd6c034 feat: Chrome PDF generator
Co-authored-by: maharshivpatel <maharshivpatel@users.noreply.github.com>
2025-09-29 12:15:51 +05:30
Ejaaz Khan
516f87e632
Merge pull request #34166 from chdecultot/fix-debug-messages
fix: do not show debug message when traceback is disallowed
2025-09-27 17:33:10 +05:30
Charles-Henri Decultot
7b0555b4ae fix: Do not show debug log also for v2 API 2025-09-26 15:51:27 +02:00
Akhil Narang
355d218f8e
Merge pull request #34162 from akhilnarang/bump-ruff
refactor(treewide): bump ruff
2025-09-26 17:44:11 +05:30
Charles-Henri Decultot
1ae276d441 fix: do not show debug message when traceback is disallowed 2025-09-26 13:15:01 +02:00