Commit graph

38420 commits

Author SHA1 Message Date
Gavin D'souza
bbc90e6578 refactor!: frappe.db.get_singles_dict
* Don't cast values by default - only if cast kwarg is set
* Reverts breaking behaviour added via f74dc5023d
2022-06-15 10:33:06 +05:30
Rushabh Mehta
562499609c
fix(minor): refresh tabs with sections (#17182) 2022-06-14 19:00:01 +05:30
Faris Ansari
ec2aadbf5a
chore: typo 2022-06-14 18:15:48 +05:30
gavin
fb6a092292
Merge pull request #17180 from gavindsouza/sub-query-err
fix(db_query): Remove wanton whitespace split check
2022-06-14 17:43:11 +05:30
Gavin D'souza
9b4db43b84 perf(db_query): Maintain compiled pattern globally 2022-06-14 17:17:22 +05:30
Gavin D'souza
678eebe4fb perf: Limit re internal cache to avoid caching patterns twice 2022-06-14 17:16:34 +05:30
Gavin D'souza
60ec324956 fix: Remove unwanted blacklist over fields
A field like 'count(`tabBOM Update Log`.name) as total_count' split by
whitespace loses it's meaning. Tried splitting it meaningfully but
didn't get the point of this tbh and stopped. I'm not sure what the code
before was trying to do and with what set of inputs.

Imagine the following fields: [count(`tabBOM Update Log`.name) as
total_count, `tabBOM Update Log`.name as update_name, `tabBOM Update
Log`.name, `tabBOM Update as Log`.name, tabBOM.name, name], I couldn't
see what the previous check was trying to protect - hence, didn't add
any equivalent functionality.
2022-06-14 16:40:41 +05:30
gavin
f12a61feab
Merge pull request #17063 from gavindsouza/regex-refactor
perf!: Pages & APIs
2022-06-14 14:24:31 +05:30
Rushabh Mehta
f626464572
Merge pull request #16983 from alyf-de/select-user
fix: allow All to select a User
2022-06-14 14:21:56 +05:30
Rushabh Mehta
71a5f1153a
Merge pull request #17135 from rmehta/tab-refresh
fix(ui): tab refresh was not implemented
2022-06-14 14:17:44 +05:30
Suraj Shetty
1adec8b3e4
Merge pull request #17167 from deepeshgarg007/system_manager_role_restriction 2022-06-14 13:43:45 +05:30
Rushabh Mehta
602d4376ba fix(minor): js lint 2022-06-14 13:07:13 +05:30
Rushabh Mehta
80334698a7 fix(minor): Onboarding: add option to view list view in create action 2022-06-14 12:54:10 +05:30
Gavin D'souza
52359a0ad9 test: Scheduler tests cleanup 2022-06-14 12:22:12 +05:30
Rushabh Mehta
2058b0cbea fix(ui): tab refresh was not implemented 2022-06-14 12:19:37 +05:30
Deepesh Garg
f88ec4de83
Merge branch 'develop' into system_manager_role_restriction 2022-06-14 08:41:27 +05:30
Gavin D'souza
601217a4a2 ci: Run tests bypassing roulette with labels "Run UI Tests", "Run Server Tests" 2022-06-13 19:38:30 +05:30
Gavin D'souza
f74dc5023d refactor!: frappe.db.get_singles_dict
* Cast single's values as their fieldtypes before returning
* Support previously dead debug parameter
* Consider single with no meta as non-existent; skip query

Decided to go ahead with the breaking change given the nature of the
existing usages of get_singles_dict :crie:
2022-06-13 18:39:56 +05:30
Gavin D'souza
e681233e98 perf: Fetch and cache entire settings' dicts 2022-06-13 18:39:56 +05:30
Gavin D'souza
64e5273764 perf: Patch qb only once - not on every init 2022-06-13 18:39:56 +05:30
Gavin D'souza
3871fe6cd0 perf: App Page
Reduced time taken for get_context to execute from 0.035s to 0.02s (75%
reduction)
2022-06-13 18:39:56 +05:30
Gavin D'souza
ce38587a4e perf: About Us Settings
Use cached document for building /about page
2022-06-13 18:39:56 +05:30
Gavin D'souza
7e25cc4568 perf: Login Page
Improves performance 3x - from 0.047s to 0.017s

* Use frappe.get_*_settings to query table once
* Use cached LDAP Settings' document via get_ldap_client_settings
* Use single get_all to query all Social Login providers and related
  data
* Skip provider if client_secret doesn't exist
2022-06-13 18:39:56 +05:30
Gavin D'souza
a1691784a8 chore: Drop duplicate get_frontmatter definition 2022-06-13 18:39:56 +05:30
Gavin D'souza
13cf4964a6 perf: Check query type via is_query_type 2022-06-13 18:39:56 +05:30
Gavin D'souza
963648667d refactor: filter_dynamic_link_doctypes API
* Added typing, better variable naming
* Remove unnecessary re-iterations
* Optimize queries and membership processing
2022-06-13 18:39:56 +05:30
Ankush Menat
6dfbf7b19e fix: show doctype and fieldname filters 2022-06-13 16:42:37 +05:30
Ankush Menat
cc0672537e fix: make error/patch log read only 2022-06-13 16:42:37 +05:30
Ankush Menat
9b7b32e604 fix(ux): report and status filter for prepared_report 2022-06-13 16:42:37 +05:30
Ankush Menat
77d03d2393 fix: add list view filters for prepared report 2022-06-13 16:42:37 +05:30
Ankush Menat
ec860cacea fix(ux): list view filters for server script 2022-06-13 16:42:37 +05:30
Ankush Menat
37086c035c fix: show user and docname filter on access log 2022-06-13 16:42:37 +05:30
Ankush Menat
149594448e fix(ux): make deleted doctype read only
- also add filter for doctype in list view
2022-06-13 16:42:37 +05:30
Ankush Menat
1de9c6ac68 fix(ux): add user as filter on route history 2022-06-13 16:42:37 +05:30
Ankush Menat
3730e20618 fix(ux): better layout on error log
- plus show button to see relevant error logs
2022-06-13 16:42:37 +05:30
Ankush Menat
602e8d0a78 fix(ux): show title field on scheduled job log 2022-06-13 16:42:37 +05:30
Ankush Menat
cfc4d966c7 fix(ux): patch title field and make patch read only 2022-06-13 16:42:37 +05:30
Abhirup Pal
8c8249894b
fix: Update label for editing in full page and add custom logic for rendering it. (#17149) 2022-06-13 16:41:43 +05:30
Deepesh Garg
792c1451e7 fix: Force system admin role only if active 2022-06-13 16:39:15 +05:30
Faris Ansari
eea5cc52da
refactor!: Remove Data Migration Tool (#17134)
* refactor: Remove Data Migration Tool

* chore: unnecessary imports
2022-06-13 16:24:00 +05:30
Suraj Shetty
63a5db94cf
chore: Add mergify[bot] to exception list
https://user-images.githubusercontent.com/13928957/173293263-4987c494-4524-46dd-996c-36f1ca760c68.png
According to this mergify's login id is `mergify[bot]` so am guessing this should work.
2022-06-13 12:03:39 +05:30
Suraj Shetty
b1e97c1ff4
Merge pull request #17163 from frappe/mergify/bp/develop/pr-17161
fix: Handle case where document title can be NONE (backport #17161)
2022-06-13 11:47:27 +05:30
Suraj Shetty
53a079f101 fix: doc.get_title should return empty string if title is not set
(cherry picked from commit b244c9148192362de43aa483b328709745f3be82)
2022-06-13 06:16:57 +00:00
Suraj Shetty
a4f2912fdf fix: Handle case where document title can be NONE
(cherry picked from commit 9b67fc24bc290789158f37a8f2ce10b505878792)
2022-06-13 06:16:56 +00:00
Suraj Shetty
66deca1530
Merge pull request #17153 from ankush/disable_first_version
perf: disable creating version for new docs
2022-06-13 09:36:02 +05:30
Suraj Shetty
06d1483b16
Merge pull request #17144 from ankush/details_defaul_tab 2022-06-13 08:51:47 +05:30
Suraj Shetty
53260f0b7c
Merge pull request #17136 from netchampfaris/bulk-edit-empty-values 2022-06-13 08:51:33 +05:30
Suraj Shetty
4dc8d0fb44
Merge pull request #17152 from FHenry/dev_fix_quote_in_button_name
fix: JS error in page.js when the is a quote in button translation
2022-06-13 08:07:41 +05:30
Ankush Menat
21442f5cba perf: disable creating version for new docs
Each new doc inserts a version, this contains nothing but creator and
creation time.. which is already immutable information on the original
document.

This was added for cases like data import to track from where document
got created, ref: b7dfe7969d

Fix: only add a version on creation IF creation info is present on flags
2022-06-12 18:07:55 +05:30
Ankush Menat
03f48580ef test: button with single quote in label 2022-06-12 16:24:39 +05:30